| === chihchun_afk is now known as chihchun | ||
| === JanC_ is now known as JanC | ||
| alan_g | anpok_: I just looked at lp:mir-android-platform - it doesn't seem to be picking up Mir package configs, linking against gtest, etc. Is there a branch I should checkout? Or am I looking too soon? | 09:23 |
|---|---|---|
| anpok_ | I tested that with install lp:mir into an alternative destination directory.. | 09:25 |
| anpok_ | then setting the pkg config path to pull from there | 09:25 |
| anpok_ | or $there/lib/pkgconfig/ | 09:25 |
| anpok_ | I had no problems with gtest | 09:25 |
| alan_g | Weird. I have Mir in /usr/local. The first thing I hit was gtest: | 09:29 |
| alan_g | $ git diff | 09:29 |
| alan_g | diff --git a/tests/unit-tests/platforms/android/CMakeLists.txt b/tests/unit-tests/platforms/android/CMakeLists.txt | 09:29 |
| alan_g | index 78ef6e6..a8cabda 100644 | 09:29 |
| alan_g | --- a/tests/unit-tests/platforms/android/CMakeLists.txt | 09:29 |
| alan_g | +++ b/tests/unit-tests/platforms/android/CMakeLists.txt | 09:29 |
| alan_g | @@ -35,6 +35,9 @@ target_link_libraries( | 09:29 |
| alan_g | 09:29 | |
| alan_g | client_platform_common | 09:29 |
| alan_g | server_platform_common | 09:29 |
| alan_g | + ${GTEST_BOTH_LIBRARIES} | 09:29 |
| alan_g | + ${GMOCK_LIBRARY} | 09:29 |
| alan_g | + ${GMOCK_MAIN_LIBRARY} | 09:29 |
| alan_g | dl | 09:29 |
| alan_g | ) | 09:29 |
| alan_g | Then I found that it was picking up the wrong libmirserver.so | 09:29 |
| alan_g | so I asked | 09:30 |
| alan_g | But I see things like "mirserver" mentioned, not ${MIRSERVER_LDFLAGS} which is what I'd expect | 09:31 |
| anpok_ | ok there is something wrong | 09:35 |
| anpok_ | I just cleared by cmake cache | 09:35 |
| anpok_ | and it fails to find gmock | 09:36 |
| anpok_ | and gtest | 09:36 |
| alan_g | Your cmake cache came from a copy of lp:mir? | 09:44 |
| anpok_ | alan_g: I dont think that would have been possible - but I did iterate untill it worked, and did not make a clear run after that. | 10:14 |
| anpok_ | Can you try again? | 10:14 |
| anpok_ | should be fine now.. | 10:14 |
| alan_g | anpok_: better but still seeing it pick the wrong libmirserver.so: | 10:17 |
| alan_g | /usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libmirserver.so: undefined reference to `mir::protobuf::RaiseRequest::RaiseRequest()@MIR_PROTOBUF_3' | 10:17 |
| alan_g | I can investigate a bit later, just needed to know if it's worthwhile | 10:18 |
| alan_g | Actually, why would it be linking to libmirserver.so at all?! | 10:20 |
| anpok_ | there are diagnostic utils that would.. but those are disabled at the moment | 10:22 |
| anpok_ | test assist? | 10:23 |
| alan_g | That would be it | 10:24 |
| anpok_ | ah and the wrapper need to changed | 10:25 |
| anpok_ | or actually I should not need that.. | 10:27 |
| === popey_ is now known as popey | ||
| anpok_ | alan_g: ok I think I found something.. | 10:45 |
| alan_g | There are a number of things: MIRSERVER_LDFLAGS, MIRCOMMON_LDFLAGS etc are used but never set | 10:47 |
| alan_g | MIRSERVER_LDFLAGS in particular shouldn't ever be needed | 10:48 |
| alan_g | Something somewhere is searching for libmirserver.so without going through a Mir .pc file. | 10:57 |
| === chihchun is now known as chihchun_afk | ||
| alan_g | anpok_: Here's a fix - https://paste.ubuntu.com/24581832/ | 16:29 |
| === JanC_ is now known as JanC | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!