=== chihchun_afk is now known as chihchun === JanC_ is now known as JanC [09:23] anpok_: I just looked at lp:mir-android-platform - it doesn't seem to be picking up Mir package configs, linking against gtest, etc. Is there a branch I should checkout? Or am I looking too soon? [09:25] I tested that with install lp:mir into an alternative destination directory.. [09:25] then setting the pkg config path to pull from there [09:25] or $there/lib/pkgconfig/ [09:25] I had no problems with gtest [09:29] Weird. I have Mir in /usr/local. The first thing I hit was gtest: [09:29] $ git diff [09:29] diff --git a/tests/unit-tests/platforms/android/CMakeLists.txt b/tests/unit-tests/platforms/android/CMakeLists.txt [09:29] index 78ef6e6..a8cabda 100644 [09:29] --- a/tests/unit-tests/platforms/android/CMakeLists.txt [09:29] +++ b/tests/unit-tests/platforms/android/CMakeLists.txt [09:29] @@ -35,6 +35,9 @@ target_link_libraries( [09:29] [09:29] client_platform_common [09:29] server_platform_common [09:29] + ${GTEST_BOTH_LIBRARIES} [09:29] + ${GMOCK_LIBRARY} [09:29] + ${GMOCK_MAIN_LIBRARY} [09:29] dl [09:29] ) [09:29] Then I found that it was picking up the wrong libmirserver.so [09:30] so I asked [09:31] But I see things like "mirserver" mentioned, not ${MIRSERVER_LDFLAGS} which is what I'd expect [09:35] ok there is something wrong [09:35] I just cleared by cmake cache [09:36] and it fails to find gmock [09:36] and gtest [09:44] Your cmake cache came from a copy of lp:mir? [10:14] alan_g: I dont think that would have been possible - but I did iterate untill it worked, and did not make a clear run after that. [10:14] Can you try again? [10:14] should be fine now.. [10:17] anpok_: better but still seeing it pick the wrong libmirserver.so: [10:17] /usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/libmirserver.so: undefined reference to `mir::protobuf::RaiseRequest::RaiseRequest()@MIR_PROTOBUF_3' [10:18] I can investigate a bit later, just needed to know if it's worthwhile [10:20] Actually, why would it be linking to libmirserver.so at all?! [10:22] there are diagnostic utils that would.. but those are disabled at the moment [10:23] test assist? [10:24] That would be it [10:25] ah and the wrapper need to changed [10:27] or actually I should not need that.. === popey_ is now known as popey [10:45] alan_g: ok I think I found something.. [10:47] There are a number of things: MIRSERVER_LDFLAGS, MIRCOMMON_LDFLAGS etc are used but never set [10:48] MIRSERVER_LDFLAGS in particular shouldn't ever be needed [10:57] Something somewhere is searching for libmirserver.so without going through a Mir .pc file. === chihchun is now known as chihchun_afk [16:29] anpok_: Here's a fix - https://paste.ubuntu.com/24581832/ === JanC_ is now known as JanC