[00:57] axw: no, we use the normal provider [02:22] axw: I don't suppose you know how to configure log forwarding? [02:23] thumper: you need to set logforward-enabled=true, syslog-host=, syslog-ca-cert=, syslog-client-cert=, syslog-client-key= [02:24] so easy ;) [02:24] in the model config? [02:24] thumper: yep [02:24] thumper: in the controller model config [02:24] thumper: not to be confused with controller config... [02:24] hazaah [02:24] axw: I was thinking... we could make this change for log forwarding completely transparent... [02:25] by just making the worker model dependent and not one for the controller [02:25] and still have the tailer just deal with a single model [02:26] thumper: yes we could. we'd just need to use model config defaults to ensure all models get the same syslog-foo config [02:26] or... transparently have that worker just get the config from the controller [02:26] and don't worry at this stage about getting it from the model config for *that* model [02:27] it is a bit ick, but not terrible [02:29] thumper: what I want eventually is for different models to log to the relevant cloud log sink. so a GCE model should go into the stackdriver logging for that model's project. should be able to do something similar for Azure (though I can't quite figure out the API) [02:29] * thumper nods [02:29] thumper: that would allow JAAS users to get their model logs [02:29] without going through debug-l;og [02:29] sounds very useful [02:30] thumper: it would be useful to have controller-wide config too though. so maybe a hierarchy. [02:30] * thumper nods [02:30] sounds like we should start a spec outlining the work [02:31] should also run it by IS and JAAS, I'm sure they'll have some things they'd want [02:31] yeah [02:31] for the future work for sure [02:31] for the "let's not screw jaas" [02:31] I'm all for minimal exposure to the way it works now [02:31] yup [02:33] * thumper may have found the next piece of work for babbageclunk [02:33] babbageclunk: call when you are around? [03:10] wallyworld: have you snapped juju recently? it wants to use golang-go, which is go-1.6... [03:12] hmm maybe it doesn't matter [03:32] thumper: back, sorry, went for a run [03:32] gee, wouldn't want to run here today [03:32] it is wet and cold [03:32] getting very cold [03:32] like 5° cold [03:32] babbageclunk: hangout? [03:33] beautiful day for a run here, cold and sunny and windy [03:33] babbageclunk: more stuff https://hangouts.google.com/hangouts/_/canonical.com/stuff [05:38] wallyworld: can a relation change from being container-scoped to global-scoped? Maybe if there's charm upgrade? Trying to decide whether it's safe to cache decisions. [06:23] babbageclunk: i don't think so, no [06:52] axw: saw my name mentioned earlier - did my recent changes break anything? [06:52] rogpeppe: not sure, wallyworld said something about some cert related failures [06:52] rogpeppe: i sent an email [06:53] wallyworld: ah, thanks [06:53] it appears it may have [06:53] not 100% sure [06:54] wallyworld: are those errors happening every time? [06:55] not sure, there had only been one or two test runs post the landing that i had checked this morning [06:58] wallyworld: hmm, it definitely isn't happening every time. weird. [06:58] wallyworld: it's definitely the kind of area that *could* have been affected by my change [06:58] wallyworld: but i'd expect it to be deterministic [06:58] yeah. it's plausible the pR and failures are related but not certain [06:59] i looked at the test runs just prior to the landing and couldn't see the failures there [06:59] but hard to draw a conclusion when it is intermittent [06:59] wallyworld: yeah [07:00] i was thinking something may jump out at you [07:00] it's not an area i have expert knowledge in [07:06] wallyworld: nothing's jumping out so far [07:06] joy [07:16] wallyworld: we'll have to see if more of those kind of errors happen [07:17] yeah, need a few runs to gauge the depth of the issue [07:17] wallyworld: in http://juju-ci.vapour.ws/job/github-check-merge-juju/1087/artifact/artifacts/grant.log there's at least one suspicious-looking error after the cert error [07:17] 22:53:50 ERROR juju.tools.lxdclient client_instance.go:267 while removing instance "juju-85ed71-0": Failed to destroy ZFS filesystem: cannot open 'lxd-pool/containers/juju-85ed71-0': dataset does not exist [07:17] wallyworld: so perhaps the cert error is usual [07:19] maybe, could be a timing issue === frankban|afk is now known as frankban === MmikeM is now known as Mmike [08:42] axw: a small PR, quick review? https://github.com/juju/juju/pull/7365 [08:43] wallyworld: sure, just a minute [08:50] wallyworld: swap you https://github.com/juju/juju/pull/7366 ? [08:50] ok [08:51] axw: those pyc files were supposed to be removed already! [08:52] wallyworld: I think they were removed in one directory but not the other [08:52] anyway, added to gitignore so they won't sneak back in [08:52] 2 files is better than 108 :-) [08:54] axw: lgtm, will be good to see those tests passing again [08:59] wallyworld: to save a roundtrip, my reply to your Q: "Why? ssh.Client.Command documents the argument as taking the syntax [user@]host. It shouldn't be needed." [09:01] axw: ok, no worries, i just thought it made it more obvious to the reader in the restore code. but i'm totally +-0 , ie no care factor either way [09:02] wallyworld: if someone gets surprised they can add it back in :) [09:07] axw: i called it "cloudProviders" becuase it returns both addable and non-addable ones in 2 separate slices [09:08] wallyworld: but the result is "providers", and "unsupported" [09:08] wallyworld: cloudProviders+providers+unsupported doesn't tell me what it does [09:08] yeah, i just reused the previous var names, i can change to supported and unsupported [09:09] no biggie, just not a super useful name when you're out of context [09:09] yeah, i'll come up with something [09:10] there's also a test isolation issue too from what was there already :-/ [09:10] in the credential related suites somewhere. need to fix that too [09:32] Q: is it OK to remove API that's used only internally, by worker? [09:37] wpk: I think the problem is that the controller might be running a more recent version of jujud than the agents, so they might still try to talk to the removed API/ [09:38] wpk: Oh, hang on - is it used by a worker in the unit or machine agents, or only in the model agent? [09:41] wpk: I think in the latter case it's fine. [09:48] only in model agent [09:48] (discoverspaces worker) [12:13] anyone know if the old juju reviews are still online? e.g. http://reviews.vapour.ws/r/1609 [12:34] rogpeppe: no, I think they turned them off a few weeks ago [12:34] babbageclunk: oh [12:34] babbageclunk: i think that's a really bad idea [12:35] babbageclunk: they're actually a crucial part of the history of the project [12:35] rogpeppe: I know - just after it happened I wanted to find something that I remember discussing in a review. [12:35] babbageclunk: commit messages are often cursory at best [12:35] babbageclunk: can we try getting them turned back on again? [12:36] rogpeppe: yeah, I'll mention it to Tim [12:36] babbageclunk: thanks [12:36] (I mean, I assume they've kept the data!) [12:36] :o [12:38] babbageclunk: if they haven't, i'll be very unhappy [12:38] I'll pass that on too [12:40] babbageclunk: :) === frankban is now known as frankban|afk [19:00] hml, can I get a review of https://github.com/juju/juju/pull/7362? [19:00] balloons: looking [19:02] balloons: ha - i hate assuming anything… but… that’s a lot of files. :-) [19:03] hml, :p It's akin to the PR I mention.. It's more or less dumping in the code from the old repos into juju [19:03] hml, there's one more for packaging, once I complete it :-) [19:04] balloons: figured… i’ll go with assume this time if that’s okay with you? or do you want a sanity check? [19:04] hml, i don't just want to blind push things, hence the PR. So yes, a quick sanity check is most appreciated [19:04] balloons: sanity checking now [19:05] I had to tweak the history on this import, so make sure it's clean for you [19:08] balloons: where is the origin repro - haven’t mastered finding them in launchpad yet [19:10] hml, ahh, right. https://code.launchpad.net/~juju-qa/juju-ci-tools/repository [19:10] balloons: ty