| === rangerpb is now known as rangerpbzzzz | ||
| askb | where can I get the latest srpm for 0.7.9 ? | 07:44 |
|---|---|---|
| === sambetts_ is now known as sambetts | ||
| === rangerpbzzzz is now known as rangerpb | ||
| === smatzek_ is now known as smatzek | ||
| powersj | https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324490 | 15:48 |
| powersj | smoser: ^ | 15:48 |
| smoser | powersj, i know i ran tox before pusing yesterday | 15:56 |
| powersj | default tox run doesn't include pycodestyle | 15:56 |
| powersj | (I can't remember why we did it that way) | 15:56 |
| powersj | I believe because we run the tip version and not tied to a specific release | 15:57 |
| smoser | yeah. ok. right. it doesnt run tip things for style | 15:58 |
| smoser | powersj, the change isnt new or is iot? | 16:00 |
| smoser | #startmeeting ubuntu-server-team | 16:01 |
| smoser | bah | 16:01 |
| powersj | that area of the code wasn't touched since Jan | 16:01 |
| blackboxsw | smoser: rharper who or what delivers /etc/cloud/templates/ on a system | 16:28 |
| blackboxsw | part of the cloud-init deb right? | 16:29 |
| blackboxsw | do any vendors overwrite this content? | 16:29 |
| blackboxsw | just wanted to confirm they are fully under out control (in the ./templates dir of cloudinit) | 16:32 |
| === mariusv is now known as lunarlamp | ||
| smoser | blackboxsw, yes. under cloud-init control outside of someone having a patched cloud-init | 16:49 |
| smoser | powersj, https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324490 | 16:50 |
| smoser | wait. | 16:50 |
| smoser | thinking | 16:50 |
| powersj | Wanna update tox too? | 16:50 |
| powersj | Or at least run pycodestyle of a specific version now that we have cleaned things up | 16:51 |
| smoser | powersj, yeah, that was the thought. i'mlooking at doing that. its really flake8 that we'd move. | 17:19 |
| smoser | powersj, https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497 | 17:21 |
| powersj | smoser: ok let me play with that and I'll ack in a bit | 17:23 |
| rharper | blackboxsw: there is a built in template; there is precedence for overriding a template (aka the apt-configure module where user-data can define the template, but I don't think we added support for that in the ntp module at this time) | 17:30 |
| larsks | smoser: I just added a note to https://code.launchpad.net/~akaris/cloud-init/+git/cloud-init/+merge/324196 with result of testing on rhel6. Let me know if that is sufficient. | 17:32 |
| smoser | larsks thank you! | 17:43 |
| powersj | smoser: acked the flake8 upgrade, I'll pull my merge | 18:00 |
| blackboxsw | smoser: thanks for the review. I've responded to comments and I'm adding unit test for the real template render file. will ping when done | 18:00 |
| smoser | blackboxsw, ... | 18:02 |
| smoser | is_ec2_explicit_datasource | 18:02 |
| smoser | makes me have a 80 char line | 18:02 |
| blackboxsw | hahaha | 18:02 |
| blackboxsw | rejected :) | 18:02 |
| blackboxsw | +1 | 18:02 |
| smoser | good enough. | 18:03 |
| larsks | smoser: do you think that +merge/324196 is ready at this point? | 18:50 |
| smoser | larsks, yes. i want to pull that. | 18:58 |
| larsks | smoser: thanks, just wanted to confirm. I have some internal pressure to get a build out but want to make sure the patch was in good shape. | 18:59 |
| powersj | smoser: when you are bored ;) thoughts on https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/324430 | 19:10 |
| smoser | powersj, i guess thats fine . | 19:14 |
| powersj | smoser: thx | 19:24 |
| powersj | that pulls 2 more out of the review lane \o/ | 19:24 |
| smoser | harlowja, https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497 | 19:55 |
| smoser | help ? | 19:55 |
| smoser | powersj, see that. interesting. | 19:55 |
| powersj | smoser: you ran pip check on your system though right? not the tox venv? | 19:57 |
| smoser | well, no. i ran it in 'tox-venv flake8 pip check' | 19:57 |
| smoser | but yes, that wasnt clear | 19:57 |
| powersj | so hacking pulls in pep8 it looks like; are you concerned about the requirement version mismatches? | 20:01 |
| harlowja | hey hey | 20:02 |
| smoser | harlowja, is that safe ? | 20:04 |
| smoser | why is hacking needing those old versions. it seems to work with newer. | 20:04 |
| harlowja | the asssertEqual -> assertIsNone should be fine | 20:04 |
| harlowja | unsure about why hacking needing old version | 20:05 |
| smoser | yeah, thats the question i have. | 20:06 |
| smoser | my tox works, but i didn't think i'd have pep8 | 20:06 |
| smoser | and then went looking as to why (as it should be replaced by pycodestyle) | 20:07 |
| smoser | and hacking is what pulled it in | 20:07 |
| smoser | as hacking has specific versions | 20:07 |
| harlowja | got me :-/ | 20:08 |
| harlowja | throw email to openstack-dev ? | 20:08 |
| === sambetts is now known as sambetts|afk | ||
| smoser | https://bugs.launchpad.net/hacking/+bug/1607942 | 20:09 |
| ubot5 | Ubuntu bug 1607942 in hacking "hacking not compatible with flake8 3.0.x" [Undecided,New] | 20:09 |
| blackboxsw | smoser: have you noticed that we have different distro naming conventions for hosts tmpl vs ntp nmpl in templates? | 20:13 |
| blackboxsw | hosts.suse.tmpl vs ntp.conf.sles.tmpl | 20:13 |
| blackboxsw | shall we align those | 20:13 |
| blackboxsw | it'd be nice if we had a std convention for attempting <thing>.<distro-specific>.tmpl if exists and fallback to <thing>.tmpl when no distro scoped tmpl is avail | 20:14 |
| blackboxsw | but, not sure if there are other users besides hosts, ntp and sources | 20:15 |
| blackboxsw | s/users/usecases/ | 20:15 |
| smoser | :-( | 20:15 |
| smoser | blackboxsw, yes please. | 20:15 |
| blackboxsw | ok will file a bite-size bug | 20:15 |
| blackboxsw | what's your preference "sles" or "suse"? | 20:16 |
| blackboxsw | looks like we have a lookup OSFAMILIES in cloudinit/distros/__init__.py | 20:17 |
| smoser | yeah. | 20:17 |
| smoser | cloudinit/distros/sles.py: self.osfamily = 'suse' | 20:17 |
| blackboxsw | suse it is thx | 20:18 |
| blackboxsw | ok https://bugs.launchpad.net/cloud-init/+bug/1693020 | 20:23 |
| ubot5 | Ubuntu bug 1693020 in cloud-init "Cloud.get_template_filename should start with distro-specific template and fallback to generic template files before warning !found" [Low,Triaged] | 20:23 |
| blackboxsw | smoser: addressed your review comments and pushed https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/324450 | 20:33 |
| blackboxsw | do we want to make all unit tests logged ? 2min 20 second runtime vs 1min 30? | 20:33 |
| smoser | blackboxsw, good judgement | 21:01 |
| smoser | no need to log all | 21:01 |
| blackboxsw | ok will use the with_logs = True where needed then | 21:01 |
| blackboxsw | thx smoser | 21:01 |
| blackboxsw | all review comments addressed then | 21:02 |
| blackboxsw | will have the real branch up in a few. adding a couple extra unit tests for test_schema | 21:02 |
| blackboxsw | so it'll sit for tomorrow. and I am in review debt | 21:02 |
| === rangerpb is now known as rangerpbzzzz | ||
| powersj | blackboxsw: smoser: https://jenkins.ubuntu.com/server/job/cloud-init-build/183/console | 22:39 |
| powersj | Did python3-pycodestyle get added some how as a depends? | 22:40 |
| powersj | That test attempts to build cloud-init's master in a xenial sbuild env. | 22:40 |
| blackboxsw | checking | 22:40 |
| blackboxsw | powersj: those deb package deps are generated automatically based on what's in requirements.txt and test-requirements.txt. hmm I'm not finding what pulls that in ATM. | 22:45 |
| blackboxsw | maybe my branch needs updating. | 22:46 |
| blackboxsw | it should be pulled in via ./tools/read-dependencies and python(3)?- prefix attached automagically | 22:47 |
| powersj | smoser: https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/324497 that updated test-requirements.txt | 22:52 |
| powersj | which updated build deps then | 22:52 |
| powersj | so you can't build on xenial atm | 22:52 |
| powersj | tbh I didn't look hard enough I thought you updated the versions in the tox file | 22:53 |
| powersj | Looks like python3-pycodestyle is only in yakkety and newer too | 22:53 |
| blackboxsw | yeah I haven't found it in xenial either, we'd have to backport and host the package maybe in a cloud-init-deps ppa. | 22:54 |
| blackboxsw | powersj: do we have a cloud-init-deps ppa I don't see any ppas listed at https://launchpad.net/~cloud-init associated w/ the cloud-init team ? | 22:56 |
| powersj | blackboxsw: I don't believe so | 22:57 |
| blackboxsw | or do we just rely on <series>/updates etc for newer bits? | 22:57 |
| powersj | blackboxsw: that | 22:57 |
| blackboxsw | +1 | 22:57 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!