/srv/irclogs.ubuntu.com/2017/05/23/#juju-dev.txt

axwwallyworld: was doing dropoff (same goes for every tuesday), hence not at standup. yesterday I worked on taking instance AZ from volume attachments01:11
wallyworldaxw: no worries, figured that's where you were01:12
axwI think I've got it working with AWS01:12
wallyworldawesome01:12
wallyworldaxw: we also need to look at bug 169272901:12
mupBug #1692729: juju add-storage doesn't always grab ebs volumes on aws <juju:New> <https://launchpad.net/bugs/1692729>01:12
axwweird01:13
axwok01:13
hmlwallyworld: can you take a look at the updates to: https://github.com/juju/juju/pull/735401:18
wallyworldhml: yep01:19
hmlwallyworld: ty01:19
axwwallyworld: is https://bugs.launchpad.net/juju/+bug/1692729 a release blocker?01:26
mupBug #1692729: juju add-storage doesn't always grab ebs volumes on aws <juju:Triaged by axwalk> <https://launchpad.net/bugs/1692729>01:26
wallyworldaxw: i think so, given a stakeholder found it and it affects conjure-up01:27
axwok01:27
axwI'll finish up what I'm doing and look at that next01:27
wallyworldhml: LGTM, but with some tweaks to the test structure01:37
hmlwallyworld: looking01:38
thumperbabbageclunk: I need a rubberduck... or teddybear01:44
thumperbabbageclunk: can I use you?01:44
babbageclunkthumper: yay, of course!01:44
thumperbabbageclunk: stuff it is01:45
wallyworldbabbageclunk: here's a PR with an upstream patch if you have a moment later https://github.com/juju/juju/pull/737503:02
babbageclunkwallyworld: lgtm's03:28
wallyworldty03:28
babbageclunkoops - lgtm'd03:28
wallyworldbabbageclunk: let's hope it fixes one of the source of races03:29
babbageclunk<fingers crossed emoji>03:38
* thumper gets on filing bugs03:53
thumperjam: got 5 minutes for an update03:53
thumper?03:53
jamthumper: sure03:53
thumperjam: 1:103:53
jamjoining03:54
mupBug #1629113 changed: Juju deploy wordpress fails with MaaS <juju-core:Expired> <https://launchpad.net/bugs/1629113>04:20
wallyworldaxw: when you get a moment, here's a small PR to fix some CI test races https://github.com/juju/juju/pull/737604:40
axwwallyworld: left some comments04:46
wallyworldok, ta04:48
wallyworldaxw: i replied, see what you think04:54
axwwallyworld: "The race is because a test patches the Period value. This is done outside the watcher and is normally ok, except when race test are run."  <- if it's outside the watcher, how is there a race?04:55
wallyworldaxw: because other tests use the watcher04:56
wallyworldso one test patches the global var04:56
wallyworldand another test is using a watcher which tries to access that var04:56
wallyworldthat's my theory. i could repro easily. the PR fixes it04:57
axwwallyworld: the tests within a package are run sequentially. it sounds an awful lot like the test is doing dodgy things, and we should fix that too. the code change is fine though.04:59
wallyworldeven with race?04:59
wallyworldit only shows up with race testing04:59
axwwallyworld: it won't ever do anything particularly bad, just maybe affect the timing of unrelated tests05:00
wallyworldthe test doesn't do anything too bad on the surface. the Test() itself runs s.PatchValue(&watcher.Period, 200*time.Millisecond)05:01
wallyworldand then it starts up stuff05:01
axwwhich test is it?05:01
wallyworldTestDowngradeOnMasterWhenOtherControllerDoesntStartUpgrade05:01
wallyworldcore issue looks like a problem with clean up05:03
wallyworldmaybe watcher isn't being stopped05:03
wallyworldor stops when the cleanup runs to reset the patched value05:03
axwwallyworld: that test is totally doing the wrong thing. once the test has started, State (thus the watcher) will already have been created05:03
axwwallyworld: I think the PatchValue should be moved to SetUpSuite05:04
wallyworldhmmm, i think that's a good point. so it is patching the value after the watcher starts and tries to rely on that05:04
wallyworldyeah, moving it would be better05:05
axwwallyworld: changing the code to pass the period in is a step in the right direction though IMO05:05
wallyworldyeah, agreed05:05
axwwallyworld: i.e. away from using globals05:05
wallyworldyup05:05
wallyworldi'll move the patch code also05:05
axwwallyworld: thanks. just wanted to make sure the test wasn't doing anything too heinous05:05
wallyworldnp, thanks for being thorough05:06
wallyworldthumper: can you attach relevant log snippets to the txnlog bug?05:24
thumpersure05:27
babbageclunkwallyworld: Can you take another look at https://github.com/juju/juju/pull/7369? It's changed a bit...05:48
wallyworldsure05:48
babbageclunkthanks05:49
wallyworldbabbageclunk: reviewed, thanks. i'm still quibbling about a set and a slice in the watcher. i like the uniter facade rework. oops, one thing i forgot - we should really catch and handle any CodeNotImplemented errors in the api uniter client. there's not much that can be done except to log a nice message and error out so the uniter restarts with the expectaction that the server will eventually start running the right version (I think)06:24
wallyworldor maybe it's not an issue since the controller always gets upgraded first06:24
=== frankban|afk is now known as frankban
wpka one-liner: https://github.com/juju/juju/pull/737707:32
=== d is now known as Guest60253
=== Guest60253 is now known as domas-from-canon
babbageclunkwallyworld: yeah - I think you're right about the slice+set. Doesn't make sense on the scale of relations we're talking about.11:29
mupBug #1692866 opened: /snap/bin not in path for juju run/juju ssh <juju-core:New> <https://launchpad.net/bugs/1692866>11:41
=== salmankhan1 is now known as salmankhan
babbageclunkwpk: around? I've changed the Uniter API, and needed to change some of the versioning there. https://github.com/juju/juju/pull/736912:09
babbageclunkwpk: Could you take a look and confirm that I've handled your NetworkConfig/NetworkInfo change right?12:09
babbageclunkwpk: I've got NetworkConfig only on the v4 API and NetworkInfo only on v5. Make sense?12:10
wpkIs that the right PR? I don't see any Network{Info,Config} related things there12:18
wpkAh, OK, NOw I see12:19
babbageclunkwpk: Well, none of it's about those, but if you look at the changes to apiserver/uniter/uniter.go12:19
babbageclunkwpk :)12:19
wpkAh, the diff wasn't loaded12:20
wpkIMHO it's cleaner to have a 'clean' object on top (like UniterAPI) with everything implemented and make all the workarounds in 'older' stuff, so that if we want to get rid of old one we can simply, well, get rid of it12:21
wpkso UniterAPI is complete V5, and UniterAPIv{somethingolder} has the newer functions e.g. masked out12:22
wpkBut that's a political decision :)12:22
wpk(we can even have the old functions in separate file, for cleaniness sake)12:23
babbageclunkwpk: Well, there's no way to mask out functions properly if you embed the pristine one, so the only way to do that would be not to embed but to explicitly delegate all the ones we want on each version.12:25
wpkWhy there's no way?12:25
wpkFrom API standpoint if you create same-named function with 'wrong' signature it won't get published12:25
babbageclunkwpk: ? I'm not sure that's right.12:26
wpkfunc (u *UniterAPIV3) NetworkInfo(_, _ struct{}) {}12:26
wpkthis one12:26
wpkit masks NetworkInfo from UniterAPIV312:26
wpksince we don't publish functions with 2 arguments12:27
babbageclunkwpk: Hmm, didn't know about the 2-argument thing.12:27
wpkthe rules are in rpc/rpcreflect/type.go, newMethod12:28
babbageclunkwpk: Ok, I'll check that out in the morning. Thanks.12:29
wpkfunction can have 0 or 1 argument, and 0 or 1 return values + optional error12:29
wpk(so (), (error), (x), (x, error), but not (x,y) )12:29
babbageclunkwpk: Yeah, makes sense. Ok, I'll do that, thanks!12:32
wpkGood night :)12:33
babbageclunkwpk: 'night!12:35
=== rvba` is now known as rvba
mupBug #1692866 changed: /snap/bin not in path for juju run/juju ssh <juju:Incomplete> <snapd (Ubuntu):New> <https://launchpad.net/bugs/1692866>14:21
=== frankban is now known as frankban|afk
=== akhavr1 is now known as akhavr
thumperI'm at that phase of bug diagnostics where I'm wondering: how can this possibly be happening23:23
babbageclunkthumper: oh I love that bit23:29
thumperbabbageclunk: I'm hitting the same code path from two different directions, one succeeds and one fails23:30
thumperWTF23:30
thumperbabbageclunk: got 5 minutes to be a teddy bear?23:37
babbageclunkthumper: sure!23:38

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!