[00:01]  * thumper headdesks some more
[00:01] <thumper> why...
[00:01] <thumper> WHY???
[00:01] <thumper> testing resources written to the db are invalid when read back out
[00:01] <thumper> using the resourcetesting package
[00:01] <thumper> FFS
[00:18]  * thumper backs up before he gets more angry
[01:57] <wallyworld_> babbageclunk: free if you still want to talk
[02:03] <babbageclunk> wallyworld_: sorry, was just grabbing some lunch. now good?
[02:03] <wallyworld_> sure
[02:04] <babbageclunk> wallyworld_: in standup?
[02:36] <thumper> someone seriously needs to rewrite resources in the standard way
[02:37] <thumper> I've spent over two hours trying to get some test data in
[02:37] <thumper> and still no closer
[02:53] <anastasiamac> thumper: totally agree \o/ who and when?
[02:53] <babbageclunk> thumper: fell like an easy review to take your mind off resources? https://github.com/juju/juju/pull/7385
[02:53]  * thumper takes a look to see if it will make me feel better
[02:54] <thumper> babbageclunk: wallyworld_ has approved it already
[02:58] <babbageclunk> gah, missed that!
[03:10] <thumper> phew
[03:10] <thumper> finally got tests for this
[03:38] <wallyworld_> thumper: i've pushed changes to https://github.com/juju/juju/pull/7382 once you get a chance
[03:38] <wallyworld_> i commented on the upgrade issue in the pr comments
[03:38] <thumper> ok, I'll trade you once I've finished writing up the PR for mine
[03:38] <wallyworld_> ok
[03:39] <wallyworld_> also need to look at CI failures
[03:46] <axw> wallyworld_: I've added another commit to my PR, wouldy ou please take a look at https://github.com/juju/juju/pull/7381/commits/e1972615d535b01efd43151acafe50ed4af0f84a
[03:46] <wallyworld_> sure
[03:48] <thumper> wallyworld_: https://github.com/juju/juju/pull/7387
[03:48] <wallyworld_> ok
[03:53] <wallyworld_> axw: can we factor out a common function to fill in missing storage constraints, shared between importer and upgrader
[03:59] <axw> wallyworld_: it would be non-trivial (one's entirely in-memory, one's fetchign from mongo; one iterates over all volumes, one queries specific ones, one normalises info/params, one doesn't...)
[03:59] <axw> wallyworld_: so I don't think it'd be a net win
[04:01] <wallyworld_> righto, just thought i'd check, didn't look at the upgrade code, just recalled from yesterday
[04:01] <wallyworld_> axw: lgtm then
[04:03] <axw> wallyworld_: I'm not happy about having to write it twice though. I wonder if we could do upgrades by doing an export+import when the schema changes, rather than what we do now
[04:03] <axw> I was going to add a tech board itemm
[04:04] <wallyworld_> yeah, let's discuss
[04:10] <wallyworld_> thumper: lgtm, nice testing notes
[06:38] <wpk> thumper: ping?
[08:20] <thumper> wpk: pong... thought I closed this
[08:20] <thumper> whazzup?
[08:23] <wpk> thumper: About the discoverspaces API - as I understand (and it's very probable that I'm wrong) it's only used by controller so it'd be impossible to have discoverspaces worker (from old controller) to connect to discoverspacesAPI-less controller
[08:25] <thumper> wpk: I was wondering that. double check with jam. if it is the case that it is only used by the controller itself, then we can remove it
[08:26] <wpk> -	if !authorizer.AuthController() {		
[08:26] <wpk>  -		return nil, common.ErrPerm		
[08:26] <wpk>  -	}
[08:26]  * thumper is closing out for the day now
[08:26] <wpk> bye
[08:26] <thumper> ok
[08:26] <thumper> night all
[09:51] <wpk> https://github.com/juju/juju/pull/7392
[09:51] <wpk> jam: ^^^
=== akhavr1 is now known as akhavr
[23:04] <thumper> veebers: any idea why the merge bot is failing with  Error: retrieving gpg key timed out. ?
[23:17] <veebers> thumper: not fully yet, we'll have a look
[23:17] <thumper> that's ok, I know you are busy
[23:17] <veebers> thumper: odd, babbageclunk was able to land something
[23:18] <veebers> (just after you)
[23:32] <thumper> weird, must be some timing issue somewhere
[23:46] <wallyworld> thumper: standup?
[23:54] <wallyworld> babbageclunk: could you also review that cmr feature branch pr today?
[23:57] <babbageclunk> wallyworld: oh yes! Sorry, completely forgot about it.
[23:57] <wallyworld> np