slashd | rbasak, morning, I'm re-sending the message just in case you missed it yesterday as it was probably EOD for you when I sent it, but I have re-uploaded the isc-dhcp for Trusty. | 11:53 |
---|---|---|
=== alan_g is now known as alan_g|lunch | ||
rbasak | Hi! | 11:59 |
rbasak | I've reviewed, thanks. One issue. Sorry I didn't notice this before, because of the line wrapping I hadn't read the changelog message in detail. | 12:00 |
rbasak | And I appreciate the pain and am sorry about so many round trips. | 12:00 |
rbasak | "* Disable tracing and failover." | 12:00 |
rbasak | I really appreciate you noting this. | 12:00 |
rbasak | And I checked that it only applies to the -noddns package, so appreciate there is no regression. | 12:01 |
rbasak | So that's fine, but I feel that the changelog as it is right now is misleading and suggests that failover is being disabled for the entire source package. | 12:01 |
rbasak | I'd prefer to avoid readers panicking on that. | 12:01 |
rbasak | I think the readers who actually read the changelog are likely to be misled. | 12:02 |
slashd | rbasak, so you want me to remove this portion ? | 12:05 |
slashd | rbasak, sorry I missed the wrong channel by the way, still early for me, haven't took my coffee yet ;) | 12:05 |
rbasak | slashd: or just reword to make it clear that it applies only to the -noddns part? | 12:08 |
rbasak | That would be clearest I think. | 12:09 |
rbasak | slashd: do you want to pastebin it to I can see it to save going round again? | 12:09 |
slashd | rbasak, sure make sense, same thing as yesterday you reject and I re-upload ? | 12:09 |
rbasak | Yep | 12:09 |
slashd | rbasak, yes for the pastebin | 12:09 |
slashd | rbasak, http://pastebin.ubuntu.com/24654858/ | 12:15 |
rbasak | slashd: that's fine, thanks! Please upload. | 12:15 |
slashd | rbasak, perfect | 12:15 |
slashd | will do in a couples of minutes | 12:16 |
slashd | rbasak, thanks for reviewing it | 12:16 |
rbasak | No problem. Sorry for the round trips. | 12:16 |
slashd | rbasak, no problem at all, you were totally right | 12:16 |
=== alan_g|lunch is now known as alan_g | ||
roaksoax | win 8 | 13:19 |
=== dupondje_ is now known as dupondje |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!