[13:47] Good morning [13:56] morning [14:02] morning [14:12] I have to perform my first code review today. It's for our intern. [14:12] remember, always ask questions [14:12] goes so much better if phrased as a question ime [14:12] WTF were you thinking here? [14:13] heh [14:13] "Are you an idiot?" [14:14] These seem useful https://smartbear.com/learn/code-review/best-practices-for-peer-code-review/ [14:14] :) [14:14] "What do you think of trying this way" [14:14] "can you walk me through how it'll work in this case" (which I know will cause it to go boom) [14:15] "you have checked out the style guide link here: .... " [14:15] err have you that is [14:16] Heh, no style guides here. [14:16] We do have PEP8 checker on some stuff [14:16] "have you run this through make check" :) [14:18] I like the annotation tip: have him annotate the code before I review [14:19] oh yea, always have the person self-review before asking someone else to look [14:20] create the PR, get a coffee, then review the diff stand along in the review tool [14:20] and only THEN ask folks to spend their time looking at it [14:20] But above all make it clear that it's not a hearing [14:20] but watch out, if the PR needs a lot of annotations then the code might as well [14:20] which means comments and docs and ... vs just a PR comment [14:23] Heh, looking at the code. He's definitely gonna need some PEP8 love. He is learning PYthon while writing this [14:24] Nice [14:24] So far he's learned C++ at UM. He's going into Sophomore year [14:26] morning [14:27] Ah, so you have C++ as interpreted via Python [14:28] pet peeve: making a class when you don't need a class. :) [14:29] class Addition(object): [14:29] def __init__(self, a, b): [14:30] self.a = a [14:30] self.b = b [14:30] def add_setter(a): [14:30] self.a = a [14:30] feh, I goofed my own goofy example [14:30] def add_setter_a(a): [14:31] self.a = a [14:31] etc. [14:40] even modern c++ doesn't use classes unless needed. [14:40] Stroustrup even said he was astounded at how C++ was used and that it was never his intent for classes to be used so much. [14:42] jrwren: but but but OOP dude! [14:43] when classes are mistaken for a namespace [14:45] They're not? :) [14:45] * cmaloney whistles at the number of times he used a class as a global. [14:48] So is it pretty much a given that when something say "this doesn't use a Framework" that JQuery 3 is not a framework? :) [14:49] (I know that's a strange question, but saw a tutorial that said "Single Page Application with no Frameworks" and the first few paragraphs say "we're using JQuery / Handlebars because it's easier to manipulate the DOM that way") [15:00] access to globals being slow in python is a pretty good reason to always use classes... in python :p [15:10] heh [15:11] Hadn't heard that global access in Python is slow [15:11] i always forget that it is, but yes, it is. [15:12] https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Local_Variables [15:12] huh [15:12] Ah, because it takes longer for it to find it [15:12] that makes sense [15:12] shouldn't be miliseconds though, but huh [15:13] yeah, its not a big deal at all... because if you care about perf, you'll use pypy anyway and it won't matter. [15:13] Heh [15:13] I tried playing around with CPython to speed p a probram gor JoDee. That was fun [15:13] s/CPython/Cython/ [15:14] and pypy [15:14] cython is awesome. I used it a lot at arbor. [15:14] also ufora, but couldn't get it working right [15:14] though I think that was my fault [15:14] but seemed rather heavy for what I was trying to do [15:40] mm python tho [16:57] "do you wear underwear? when you're in bed?" "no" "me neither, watch!" [16:57] oh to overhear 5-7 year olds playing in the morning [16:59] o.0 [17:00] I wear underwear in bed [17:02] rowan wears pants, but not underwear, most of the time [17:02] tmi? :) [17:02] meh. Whatever works. [17:03] <_stink__> my kids are usually the opposite [17:03] pants optional? [17:03] _stink__++ [17:03] <_stink__> yes [17:03] well, that is when he *does* wear pants, usually he's "shirt cocking" (as they say at burning man) [17:04] <_stink__> or perhaps discouraged [17:04] <_stink__> haha [17:05] oh, my! [17:06] shirt cocking? [17:06] "This is the type of nudity known as "shirtcocking." Shirtcocking is when a man wears a top but is naked from the waist down. I have also heard this look referred to as "the toddler," or "Porky Pigging."" [17:07] Thank you, Quora [17:07] heh I had to look it up as well [17:07] <_stink__> i just used the ol' imagination [17:07] I had a vague idea, but needed the confirmation [17:07] yea, sometimes you have to go "no...that can't really ..." [17:08] <_stink__> hah [17:13] Isn't it really uncomfortable to have your johnson flopping and slapping all over? [17:14] <_stink__> s/uncomfortable/liberating [17:14] zomg, why this conversation??? [17:15] greg-g started it [17:15] some women rip their bra off as soon as they get home, some men rip their pants off... comfort is subjective. lets move on :) [17:15] true, but I blame the 5-7 year olds below my window :) [17:19] oh hey what happened to mrgoodcat [17:19] D: [17:20] Not sure. he's been quiet lately. [17:20] i guess i should note that i'm friends with him; he's who told me of this group [17:21] Hoping everything is OK. Last I talked with him he was going through a rough patch [17:21] we were at a wedding and bachelor party together two and three weeks ago, it was a good time and he was good [17:22] hell, he helped me out a lot because i drank a bit too much haha [17:23] welcome to open bar weddings [17:25] Leave your keys at the door [17:26] our airbnb was only about a half-mile walk away, it was great === Guest25093 is now known as mrgoodcat [17:47] wb mrgoodcat :) [17:47] hi [17:48] my client keeps re-nicking me to "danny" when we netwplit