[13:47] <cmaloney> Good morning
[13:56] <rick_h> morning
[14:02] <shakes808_> morning
[14:12] <brousch> I have to perform my first code review today. It's for our intern.
[14:12] <rick_h> remember, always ask questions
[14:12] <rick_h> goes so much better if phrased as a question ime
[14:12] <brousch> WTF were you thinking here?
[14:13] <cmaloney> heh
[14:13] <brousch> "Are you an idiot?"
[14:14] <brousch> These seem useful https://smartbear.com/learn/code-review/best-practices-for-peer-code-review/
[14:14] <rick_h> :)
[14:14] <rick_h> "What do you think of trying this way"
[14:14] <rick_h> "can you walk me through how it'll work in this case" (which I know will cause it to go boom)
[14:15] <rick_h> "you have checked out the style guide link here: .... "
[14:15] <rick_h> err have you that is
[14:16] <brousch> Heh, no style guides here.
[14:16] <brousch> We do have PEP8 checker on some stuff
[14:16] <rick_h> "have you run this through make check" :)
[14:18] <brousch> I like the annotation tip: have him annotate the code before I review
[14:19] <rick_h> oh yea, always have the person self-review before asking someone else to look
[14:20] <rick_h> create the PR, get a coffee, then review the diff stand along in the review tool
[14:20] <rick_h> and only THEN ask folks to spend their time looking at it
[14:20] <cmaloney> But above all make it clear that it's not a hearing
[14:20] <rick_h> but watch out, if the PR needs a lot of annotations then the code might as well
[14:20] <rick_h> which means comments and docs and ... vs just a PR comment
[14:23] <brousch> Heh, looking at the code. He's definitely gonna need some PEP8 love.  He is learning PYthon while writing this
[14:24] <cmaloney> Nice
[14:24] <brousch> So far he's learned C++ at UM. He's going into Sophomore year
[14:26] <notlikethesoup> morning
[14:27] <cmaloney> Ah, so you have C++ as interpreted via Python
[14:28] <jrwren> pet peeve: making a class when you don't need a class. :)
[14:29] <cmaloney> class Addition(object):
[14:29] <cmaloney>    def __init__(self, a, b):
[14:30] <cmaloney>     self.a = a
[14:30] <cmaloney>     self.b = b
[14:30] <cmaloney>     def add_setter(a):
[14:30] <cmaloney>     self.a = a
[14:30] <cmaloney> feh, I goofed my own goofy example
[14:30] <cmaloney> def add_setter_a(a):
[14:31] <cmaloney>   self.a = a
[14:31] <cmaloney> etc.
[14:40] <jrwren> even modern c++ doesn't use classes unless needed.
[14:40] <jrwren> Stroustrup even said he was astounded at how C++ was used and that it was never his intent for classes to be used so much.
[14:42] <rick_h> jrwren: but but but OOP dude!
[14:43] <rick_h> when classes are mistaken for a namespace
[14:45] <cmaloney> They're not? :)
[14:45]  * cmaloney whistles at the number of times he used a class as a global.
[14:48] <cmaloney> So is it pretty much a given that when something say "this doesn't use a Framework" that JQuery 3 is not a framework? :)
[14:49] <cmaloney> (I know that's a strange question, but saw a tutorial that said "Single Page Application with no Frameworks" and the first few paragraphs say "we're using JQuery / Handlebars because it's easier to manipulate the DOM that way")
[15:00] <jrwren> access to globals being slow in python is a pretty good reason to always use classes... in python :p
[15:10] <cmaloney> heh
[15:11] <cmaloney> Hadn't heard that global access in Python is slow
[15:11] <jrwren> i always forget that it is, but yes, it is.
[15:12] <jrwren> https://wiki.python.org/moin/PythonSpeed/PerformanceTips#Local_Variables
[15:12] <cmaloney> huh
[15:12] <cmaloney> Ah, because it takes longer for it to find it
[15:12] <cmaloney> that makes sense
[15:12] <cmaloney> shouldn't be miliseconds though, but huh
[15:13] <jrwren> yeah, its not a big deal at all... because if you care about perf, you'll use pypy anyway and it won't matter.
[15:13] <cmaloney> Heh
[15:13] <cmaloney> I tried playing around with CPython to speed p a probram gor JoDee. That was fun
[15:13] <cmaloney> s/CPython/Cython/
[15:14] <cmaloney> and pypy
[15:14] <jrwren> cython is awesome. I used it a lot at arbor.
[15:14] <cmaloney> also ufora, but couldn't get it working right
[15:14] <cmaloney> though I think that was my fault
[15:14] <cmaloney> but seemed rather heavy for what I was trying to do
[15:40] <notlikethesoup> mm python tho
[16:57] <greg-g> "do you wear underwear? when you're in bed?" "no" "me neither, watch!"
[16:57] <greg-g> oh to overhear 5-7 year olds playing in the morning
[16:59] <cmaloney> o.0
[17:00] <cmaloney> I wear underwear in bed
[17:02] <greg-g> rowan wears pants, but not underwear, most of the time
[17:02] <greg-g> tmi? :)
[17:02] <cmaloney> meh. Whatever works.
[17:03] <_stink__> my kids are usually the opposite
[17:03] <cmaloney> pants optional?
[17:03] <brousch> _stink__++
[17:03] <_stink__> yes
[17:03] <greg-g> well, that is when he *does* wear pants, usually he's "shirt cocking" (as they say at burning man)
[17:04] <_stink__> or perhaps discouraged
[17:04] <_stink__> haha
[17:05] <jrwren> oh, my!
[17:06] <cmaloney> shirt cocking?
[17:06] <cmaloney> "This is the type of nudity known as "shirtcocking." Shirtcocking is when a man wears a top but is naked from the waist down. I have also heard this look referred to as "the toddler," or "Porky Pigging.""
[17:07] <cmaloney> Thank you, Quora
[17:07] <rick_h> heh I had to look it up as well
[17:07] <_stink__> i just used the ol' imagination
[17:07] <cmaloney> I had a vague idea, but needed the confirmation
[17:07] <rick_h> yea, sometimes you have to go "no...that can't really ..."
[17:08] <_stink__> hah
[17:13] <brousch> Isn't it really uncomfortable to have your johnson flopping and slapping all over?
[17:14] <_stink__> s/uncomfortable/liberating
[17:14] <jrwren> zomg, why this conversation???
[17:15] <brousch> greg-g started it
[17:15] <jrwren> some women rip their bra off as soon as they get home, some men rip their pants off... comfort is subjective. lets move on :)
[17:15] <greg-g> true, but I blame the 5-7 year olds below my window :)
[17:19] <notlikethesoup> oh hey what happened to mrgoodcat
[17:19] <notlikethesoup> D:
[17:20] <cmaloney> Not sure. he's been quiet lately.
[17:20] <notlikethesoup> i guess i should note that i'm friends with him; he's who told me of this group
[17:21] <cmaloney> Hoping everything is OK. Last I talked with him he was going through a rough patch
[17:21] <notlikethesoup> we were at a wedding and bachelor party together two and three weeks ago, it was a good time and he was good
[17:22] <notlikethesoup> hell, he helped me out a lot because i drank a bit too much haha
[17:23] <notlikethesoup> welcome to open bar weddings
[17:25] <cmaloney> Leave your keys at the door
[17:26] <notlikethesoup> our airbnb was only about a half-mile walk away, it was great
[17:47] <notlikethesoup> wb mrgoodcat :)
[17:47] <mrgoodcat> hi
[17:48] <mrgoodcat> my client keeps re-nicking me to "danny" when we netwplit