| === sambetts|afk is now known as sambetts | ||
| smoser | blackboxsw, wonder if you ahve thoughts on https://code.launchpad.net/~redriver/cloud-init/+git/cloud-init/+merge/325207 | 14:09 |
|---|---|---|
| smoser | the 'open' is the only thing i wonder about (and the annoying method of mocking open). | 14:09 |
| smoser | (and 'open' was my suggestion) | 14:09 |
| smoser | the one thought i have would be just to move that hunk (line 23 -> 27) to a function 'cdrom_is_readable()' or something. | 14:10 |
| smoser | then makes easier mocking of it | 14:10 |
| blackboxsw | checking smoser | 14:39 |
| rharper | running tox, on a branch recent from master, saw this; I recall we chased this one down last week but I don't remember the fix , blackboxsw smoser ?: Problem importing module imports.py: cannot import name 'input' | 16:01 |
| rharper | during pylint run | 16:01 |
| rharper | huh, non fatal, but noisy | 16:02 |
| blackboxsw | hmm I recall seeing that at some point. but I don't recall the remedy (I know I had missed deps in the past and ran tox -r to rebuild) | 16:02 |
| === sambetts is now known as sambetts|afk | ||
| smoser | rharper, tox -e pylint ? i didn't see that here. | 17:18 |
| rharper | smoser: pylint runtests: commands[0] | /home/rharper/work/git/cloud-init/.tox/pylint/bin/python -m pylint cloudinit | 18:16 |
| rharper | I just ran tox at the top level | 18:17 |
| rharper | I think it's the coverage | 18:17 |
| rharper | report | 18:17 |
| smoser | hm.. rharper i dont see that. | 18:30 |
| smoser | http://paste.ubuntu.com/24850671/ | 18:30 |
| smoser | am i doing something wrong ? | 18:30 |
| rharper | I'll blame it on my local stuff | 18:30 |
| rharper | it's non fatal, so I'm fine; I likely have cruft or old stuff | 18:31 |
| smoser | well, just rm -Rf .tox | 18:31 |
| smoser | give that a try. | 18:31 |
| rharper | k | 18:37 |
| smoser | blackboxsw, good news. | 19:07 |
| smoser | work to do. | 19:07 |
| blackboxsw | do tell | 19:07 |
| smoser | (sru x, y, z all accepted) | 19:07 |
| smoser | "good news" | 19:07 |
| blackboxsw | good ahasenack warned that he saw lots of bug mail, figured it'd be coming across soon | 19:07 |
| blackboxsw | ok SRU template writeups time | 19:08 |
| blackboxsw | trying to wrap up a review and will move over to that. | 19:08 |
| ahasenack | blackboxsw: how many bugs are you fixing in one upload? | 19:24 |
| blackboxsw | ahasenack: this one's big 20 bugs | 19:25 |
| blackboxsw | last two were 12 and 15 I *think8 | 19:25 |
| blackboxsw | last two were 12 and 15 I *think* | 19:25 |
| blackboxsw | ok onto SRU testing. | 19:33 |
| smoser | blackboxsw, i am going afk. i will help tomorrow with sru verification. just finished my | 20:57 |
| smoser | bug https://bugs.launchpad.net/ubuntu/+source/cloud-initramfs-tools/+bug/1666573 | 20:57 |
| ubot5 | Ubuntu bug 1666573 in cloud-initramfs-tools (Ubuntu) "transient systemd ordering cycle in boot with overlayroot ver read-only open-iscsi root" [Medium,In progress] | 20:57 |
| blackboxsw | +1 smoser | 20:57 |
| powersj | blackboxsw: do you have an open build service account? | 21:26 |
| blackboxsw | powersj: will check. not sure if I went through that setup yet | 21:26 |
| blackboxsw | powersj: sure enough blackboxsw | 21:27 |
| * rharper does subnet static route math harder, and now has it passing under redhat | 22:01 | |
| rharper | \o/ | 22:01 |
| powersj | woohoo | 22:08 |
| rharper | let's just say I learn something today | 22:09 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!