/srv/irclogs.ubuntu.com/2017/06/15/#juju-dev.txt

rick_hhml: hi, I just wanted to ping because I'm attempting to rain on a parade I guess.00:00
hmlrick_h: :-(00:00
rick_hhml: and wanted to make sure my comment was coherent and make myself available if there were any questions/etc but please don't land https://github.com/juju/juju/pull/744900:00
hmlrick_h: okay - i’ll give it a look - we wanted to get something out there for feedback - expected input - you were on my list to ping.00:01
rick_hhml: k, I think the intent is <3 but the way the command is put together is a bad precedent imo00:01
hmlrick_h: sounds like a chat is a good way to go.  do you have some time now? or tomorrow?00:05
rick_hhml: yes I can now00:08
rick_hLet me head my headphones00:08
rick_hhml: https://hangouts.google.com/hangouts/_/canonical.com/rick?authuser=1 when you want00:09
axwwallyworld: do you know where I can find peer-xplod? jam's charm says unauthorized for me01:39
axwwallyworld: ISTR you used it recently01:39
wallyworldaxw: yeah, i copied the source locally01:39
wallyworldaxw: i go tthe source from juju acceptance tests01:41
wallyworldthere's a copy of peer-xplod in there that is up to date01:41
axwwallyworld: cool, thanks01:42
wallyworldmenn0: not sure how busy you are - it's ok if you won't get a chance to look at my recent cmr pr today - i'll bug someone else tomorrow. just need to know so that i can plan next steps04:31
menn0wallyworld: i'm in calls and usual household crazy period at the moment so am unlikely to be able to review today04:38
menn0wallyworld: I could do first thing tomorrow though04:38
wallyworldnp, all good04:38
wallyworldi'll branch off that branch and continue work04:38
menn0wallyworld: email me with the link if you want me to take a look04:38
wallyworldwill do ta04:38
wallyworldhttps://github.com/juju/juju/pull/750404:38
wallyworldi asked you because we discussed a bit yesterday04:39
wallyworldthe new controller details collection04:39
menn0wallyworld: cool cool04:39
menn0jam: i'm likely to be a bit late to the standup. have to pick up a child.04:39
jammenn0: understood04:39
axwwallyworld jam: I've just added some data to https://github.com/juju/juju/pull/7502#issuecomment-308411294, going for a ride - I'll land when I get back if you're happy05:13
wallyworldok05:14
wallyworldlooking05:14
mupBug #1697175 changed: juju 2.1.2 trusty node put into recovery mode <juju-core:New> <https://launchpad.net/bugs/1697175>07:10
mupBug #1697175 opened: juju 2.1.2 trusty node put into recovery mode <juju-core:New> <https://launchpad.net/bugs/1697175>07:13
mupBug #1697175 changed: juju 2.1.2 trusty node put into recovery mode <juju-core:New> <https://launchpad.net/bugs/1697175>07:19
rogpeppein case anyone's around, here's a PR that provides a drop-in replacement for context.WithDeadline that uses mockable clocks: https://github.com/juju/utils/pull/28214:03
tvansteenburghthumper: wallyworld: can either of you clarify what, if any, logging changes were made in 2.2? i noticed yesterday, using a 2.2 client, that i was not getting charm logging by default like i used to. is that expected? if it is, we really need to announce that and explain how to turn it back on, because w/o those logs it's much harder to debug charm problems14:09
tvansteenburghthis was on a model that i created on an aws jaas controller14:10
=== frankban is now known as frankban|afk
rogpeppethis PR makes api.Open time out more reliably: https://github.com/juju/juju/pull/750716:58
anastasiamacaxw: any objections? https://github.com/juju/juju/pull/750821:27
menn0wallyworld, axw: do you happen to know the prometheus collection interval?23:02
menn0typically23:02
wallyworld_menn0: 15s i think by default23:02
wallyworld_menn0: it depends on the yaml config23:02
menn0ok23:02
wallyworld_prometheus will poll juju23:03
menn0wallyworld_: b/c the state metrics collector is written in a fairly inefficient way23:03
menn0every poll it calls ForModel for every model23:03
menn0that's going to hurt23:03
wallyworld_yeah23:04
wallyworld_menn0: we have a todo to fix that, maybe it's a mental todo23:04
menn0wallyworld_: ok cool23:06
menn0wallyworld_: I'm going through where ForModel is used, looking into problems axino is seeing23:06
menn0I've found one bad and unnecessary use in the allwatcher23:07
menn0easy to fix too so i'll do that today23:07
wallyworld_menn0: yeah, there's no reason ti use for model anymore - state pool should be it. we just haven't updated evertything yet. we've been doing as a driveby23:08
wallyworld_as we find things23:08
menn0wallyworld_: the reason i'm looking is that axino is seeing query storms on txns.log23:10
menn0wallyworld_: this is when the txn watcher resyncs23:11
menn0he's seeing 300 at a time23:11
menn0there shouldn't be that many watcher instances23:11
menn0possible cause is lots of new State creation for some reason23:12
menn0hence me looking at ForModel calls23:12
menn0wallyworld_: I also have an idea for getting rid of all the txn watchers so there's just one23:13
menn0wallyworld_: without major code churn (I think)23:13
menn0wallyworld_: I'd like to chat about that later23:13
menn0wallyworld_: does your PR still need review?23:13
wallyworld_menn0: yeah it does :-)23:14
wallyworld_menn0: axw is also looking at txn watchers, so let's chat for sure23:14
axwanastasiamac: I fear that exposing that charm method will lead to misuse; it's just a convenience. maybe you can show how you would use it?23:40
axwwallyworld_: can you please take a look at https://github.com/juju/juju/pull/7505 when you have a few minutes?23:43
wallyworld_sure23:43
axwmenn0: I'd love to know how you plan to have just one txn watcher. I spent some time on it, it got messy... but I was going for a more drastic refactor too23:44
wallyworld_menn0: standup?23:46
axwmenn0: btw I started looking at using StatePool for the statemetrics code yesterday, happy to continue if you have other things you'd rather do23:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!