| === pisi is now known as Guest10960 | ||
| robert_ancell | jbicha, hi | 02:18 |
|---|---|---|
| robert_ancell | jbicha, still confused by bileto... | 02:18 |
| jbicha | robert_ancell: happy Sunday (!) | 02:18 |
| robert_ancell | jbicha, oh, congrats on the core membership! | 02:19 |
| jbicha | https://code.launchpad.net/~jbicha/indicator-sound/build-with-vala36/+merge/325859 | 02:19 |
| robert_ancell | oh, I just have to approve the MPs? | 02:19 |
| jbicha | I'll talk to Seb next week about seeing whether Core Dev should be part of those indciator teams | 02:19 |
| jbicha | yes | 02:19 |
| robert_ancell | jbicha, what's the "private set" issue? | 02:20 |
| jbicha | that patch came straight from ricotz so I assume he knows what he's doing with vala :) | 02:20 |
| jbicha | the other MPs were mine | 02:20 |
| robert_ancell | jbicha, the indent issue is not just a warning, it must fix a bug right? Or was 'pos' not being used? | 02:21 |
| jbicha | I don't know anything about dee, I just guessed there :| | 02:22 |
| jbicha | it fixed the build but I didn't know how to test functionality for it | 02:22 |
| robert_ancell | jbicha, I thought the comment was a bit misleading as it has actually changed the code | 02:22 |
| jbicha | robert_ancell: if you want, I could ask Ken about that next week since he's touched dee more in the past | 02:23 |
| robert_ancell | jbicha, MPs all updated | 02:27 |
| jbicha | that's amazing work on gnome-software 3.20 | 02:29 |
| * robert_ancell misses the Unity volume indicator that didn't plonk itself in the middle of the screen over the video you're watching | 02:29 | |
| jbicha | the Xenial branch was always too confusing for me to do much with it before | 02:29 |
| robert_ancell | jbicha, I still can't believe I got to the end of it | 02:29 |
| robert_ancell | We do still have 44 patches, which is a bit scary. | 02:30 |
| robert_ancell | I'm going to a sprint with hughsie in a week though so I'll see if we can reduce that a little | 02:30 |
| jbicha | robert_ancell: you're running Artful now, right? | 02:31 |
| robert_ancell | yep | 02:31 |
| jbicha | robert_ancell: did you get the gnome-software update I pushed yesterday? Add-ons>Fonts and Input Sources now works from the homepage :) | 02:32 |
| robert_ancell | I didn't notice, but nice work! | 02:32 |
| jbicha | hughsie did the work, I just pointed out the issue to ximion and cherry-picked | 02:33 |
| robert_ancell | The lack of 'bzr cherry-pick' always annoyed me. Such a handy feature | 02:35 |
| robert_ancell | Sure you can do 'bzr merge -c' but it doesn't have the same nice feel | 02:36 |
| jbicha | robert_ancell: the part about bileto I have the most trouble with is its handling of commit messages | 02:40 |
| jbicha | https://launchpad.net/ubuntu/+source/dee/1.2.7+17.10.20170616-0ubuntu1 | 02:40 |
| robert_ancell | huh, It didn't pick up my change? | 02:40 |
| jbicha | I had the same problem with indicator-sound where I wanted to give ricotz credit for writing the patch | 02:41 |
| robert_ancell | Is there a bug open about that? | 02:42 |
| jbicha | maybe if I had rebuilt after changing the commit message… | 02:42 |
| jbicha | I don't think bileto is being actively developed | 02:42 |
| robert_ancell | ah, that would be it | 02:43 |
| robert_ancell | It must just copy over after the MP is approved | 02:43 |
| jbicha | robert_ancell: sorry to keep asking you stuff on the weekend, but what do you plan to do with LP: #1640605 ? | 02:47 |
| ubot5 | Launchpad bug 1640605 in unity-greeter (Ubuntu) "Fails to build due to failing tests" [Critical,Triaged] https://launchpad.net/bugs/1640605 | 02:47 |
| jbicha | should we just disable the tests? | 02:47 |
| robert_ancell | jbicha, pretend it doesn't exist? | 02:47 |
| robert_ancell | I would | 02:47 |
| * robert_ancell will be glad to see the back of unity-greeter. It has much bit rot. | 02:47 | |
| robert_ancell | I hope the forked versions will tidy up and live a long life. | 02:48 |
| jbicha | slick-greeter doesn't integrate with Ubuntu indicators but whatever | 02:48 |
| robert_ancell | jbicha, yeah, seriously disabling the tests makes sense to me, because it's more work than it's worth to try and fix them. | 02:48 |
| jbicha | robert_ancell: can I drop unity-greeter's recommends on lightdm too? | 02:49 |
| robert_ancell | jbicha, I noticed there was an older fork the other day on github, not sure what it's state is | 02:49 |
| robert_ancell | jbicha, and change to a suggests? | 02:49 |
| jbicha | I don't think we want someone who has GNOME installed and then installs Unity to have that lightdm/gdm debconf question | 02:49 |
| robert_ancell | jbicha, ah, sure | 02:50 |
| robert_ancell | It's really only there for completeness, there's probably not a lot of people who install unity-greeter and wonder why it doesn't work without lightdm. | 02:50 |
| jbicha | gnome-shell all the way back to Xenial has an alternate dependency on lightdm to stop that question from now on (the SRU just landed for that) | 02:50 |
| robert_ancell | nice | 02:51 |
| robert_ancell | I hear my son has woken up, that's me for until they head back to bed (though not sure if I'll be doing much tonight, I think the g-s rebase work is all done now) | 02:52 |
| robert_ancell | jbicha, nice to catch up! | 02:52 |
| jbicha | good :) | 02:52 |
| robert_ancell | bye | 02:53 |
| === jhernandez_ is now known as jhernandez | ||
| === Guest14397 is now known as fredp | ||
| === fredp is now known as Guest41026 | ||
| === pisi is now known as Guest76201 | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!