[01:05] <wallyworld> axw: quick HO? 1:1
[01:07] <wallyworld> thumper: you around?
[01:10] <axw> wallyworld: just got back, brt
[01:19] <babbageclunk> axw: take a look at https://github.com/juju/juju/pull/7547?
[01:19] <babbageclunk> wallyworld: too late?
[01:19] <wallyworld> babbageclunk: no, there's a unit test failure we're trying to fix
[01:19] <wallyworld> i'll look
[01:20] <babbageclunk> wallyworld: thanks
[01:24] <wallyworld> babbageclunk: yeah, i think that looks good. a small surface area
[01:27] <babbageclunk> wallyworld: cool, thanks - hopefully makes it in!
[01:27] <wallyworld> it will :-)
[01:29] <wallyworld> axw: interestingly, i now see the test fails without --race but succeeds with --race. it seems likely related to the mutex i added to fix the race failures
[01:30] <axw> wallyworld: it doesn't matter whether you use -race or not, it's just time sensitive. I *think* the issue is due to flushing on ErrDying
[01:30] <axw> not sure tho yet
[01:30] <wallyworld> ok, i'll check back in soon hopefully
[01:31] <wallyworld> axw: you may need to pull my branch and re-propose  if you get a fix done before i get back
[01:31] <axw> wallyworld: ok
[01:31] <wallyworld> tyvm
[01:33] <wallyworld> axw: yeah, if we don't flush on dying that test passes and another fails
[01:34] <axw> wallyworld: I think the test is kinda bogus, and shouldn't assume it'll return an error
[01:35] <wallyworld> and now i can't get it to faio anymore
[01:36] <wallyworld> *fail
[01:36] <wallyworld> axw: i kinda agree
[01:37] <wallyworld> i might just tweak the test not to check for that error
[01:37] <wallyworld> it still checks that sync returns on shutdown
[01:39] <wallyworld> axw: done that, will land now
[01:39] <axw> wallyworld: we should probably have another tests that checks that that error is returned after the PingBatcher has completely stopped
[01:40] <wallyworld> probably
[01:40] <wallyworld> done
[01:42] <thumper> wallyworld: for now
[01:42] <wallyworld> thumper: tis ok
[01:42] <thumper> ack
[01:43] <wallyworld> axw: landing now, could you keep an eye out while i pop out and remerge if there's a spurious failure?
[01:44] <wallyworld> babbageclunk: your pr failed
[01:45] <babbageclunk> wallyworld: I saw - looks spurious
[01:45] <wallyworld> faaaark
[01:45] <wallyworld> yeah it does :-(
[01:46] <axw> wallyworld: yep np
[01:46] <babbageclunk> Running it under race detector now just to see
[01:46] <wallyworld> babbageclunk: tempted to merge by hand
[01:46] <wallyworld> so we can unblock the release
[01:46] <wallyworld> but i gotta run out for an hour]
[01:47] <wallyworld> veebers: burton-aus: race fix landing now. there's another pr from babbageclunk which just failed with a spurious error - we could merge that directly since CI will run the tests anyway
[01:48] <wallyworld> i'll check back in a bit
[01:50] <veebers> wallyworld: ack sounds good. Let us know which lands last, we'll check the build make sure everything is in there and watch the CI run
[02:02] <axw> babbageclunk: I have to go out for a little while too, can you please let veebers know when your branch has landed? wallyworld's just finished
[02:13] <babbageclunk> axw: wilco
[02:16] <babbageclunk> Everyone's going out. I think I'll go out in a bit.
[02:19] <blahdeblah> anyone able to give me a quick update on https://bugs.launchpad.net/juju/+bug/1676279 ?
[02:19] <mup> Bug #1676279: canceling destroy-model prevents further calls to destroy-model to succeed <destroy-model> <list-models> <juju:Fix Committed by anastasia-macmood> <https://launchpad.net/bugs/1676279>
[02:19] <blahdeblah> anastasiamac: ^
[02:22]  * anastasiamac looking
[02:22] <anastasiamac> blahdeblah: yes, it would have been included in 2.2.0 as it was committed back in time for 2.2-b3.. I'll answer on the bug as well
[02:24] <blahdeblah> thanks anastasiamac
[02:24] <blahdeblah> also, any idea when 2.2.1 will be out?
[02:25] <blahdeblah> Also, any clarification on https://bugs.launchpad.net/juju/+bug/1699050 as to whether the workaround which wgrant tested needs to be applied to each model?
[02:25] <mup> Bug #1699050: remove-application regression on 2.1 -> 2.2 upgrade with subordinates <juju:In Progress by 2-xtian> <https://launchpad.net/bugs/1699050>
[02:25] <blahdeblah> babbageclunk: ^
[02:33] <babbageclunk> veebers: Hey, my PR's just landed: https://github.com/juju/juju/pull/7547
[02:33] <anastasiamac> blahdeblah: aiming to release 2.2.1 today (last i've heard)
[02:36] <blahdeblah> babbageclunk: that's the one for the last bug above?
[02:36] <babbageclunk> blahdeblah: yup
[02:36] <blahdeblah> cool - thanks
[02:36] <blahdeblah> Anyone able to comment on https://bugs.launchpad.net/juju/+bug/1669046 as well?
[02:36] <mup> Bug #1669046: juju-db very high load on primary controller unit <juju:Confirmed> <https://launchpad.net/bugs/1669046>
[02:37] <veebers> babbageclunk: sweet
[02:37] <babbageclunk> blahdeblah: I was answering your second question. (Just in case you weren't sure.) It'll be in 2.2.1.
[02:38] <blahdeblah> yep
[02:38] <veebers> babbageclunk: that went in after Ians pingbatcher fix right?
[02:38] <babbageclunk> blahdeblah: so hopefully you don't need to apply the workaround?
[02:38] <babbageclunk> veebers: I think so - just checking...
[02:38] <blahdeblah> babbageclunk: Once 2.2.1 comes out?
[02:38] <babbageclunk> veebers: yup
[02:38] <babbageclunk> blahdeblah: yes
[02:39] <blahdeblah> We're hoping that 2.2.x will resolve a number of our load issues, but since it was never confirmed that the root cause in 1669046 is 1676279, I wonder whether the former needs more diagnosis.
[02:42] <veebers> babbageclunk: cool, once it gets a revision build we'll monitor it for release
[02:49] <babbageclunk> Are we going to do a mass-merge from 2.2 to develop at some point, or should I be forward-porting things myself?
[03:14]  * babbageclunk goes for a run for a bit
[03:27] <wallyworld> babbageclunk: no, we will merge 2.2 into develop. i was waiting for all the things to land
[04:33] <babbageclunk> wallyworld: yeah, I thought we'd probably be doing that again
[05:06] <wallyworld> babbageclunk: yeah, all done :-)
[05:07] <babbageclunk> wallyworld: nice one!
[05:32] <babbageclunk> Booking my shuttle for the sprint - when are people mostly leaving the place? Don't want to be hanging out all by myself in Mooloolaba when everyone's already left! My flight's not until 7.
[05:32] <babbageclunk> (on the Saturday)
[05:33] <veebers> babbageclunk: I've only booked my shuttle from airport -> venue. Was going to book the return during the week
[05:34] <babbageclunk> veebers: but you're missing out on a $6 saving!
[05:35] <veebers> babbageclunk: hah true. But something better might pop up. In the past I've been able to hitch rides with people heading to the airport etc. Although I geuess this time around it's a bit more of a trip
[05:36] <babbageclunk> veebers: Actually, I like your plan, I'm going to do the same.
[05:36] <babbageclunk> And then say it was my idea all along.
[05:40] <veebers> babbageclunk: well, if we get stranded and miss our flights you can take all the credit you want ^_^
[05:40] <babbageclunk> Yay!
[05:41] <veebers> babbageclunk: any idea how many hours (or days) your supposed to be at BNE before your flight?
[05:41] <babbageclunk> Oh no - that's a good point, I'd forgotten to factor that into my return booking anyway.
[05:42] <veebers> hmm
[05:43]  * veebers needs to make sure he has enough clean cloths to pack
[05:43] <veebers> Will have to break the shorts out of storage, that is if it's not frozen shut
[05:48] <blahdeblah> You folks aren't coming in via MCY?
[05:48] <blahdeblah> Much nicer :-)
[05:49] <veebers> blahdeblah: I'm just glad there is a direct flight from Dunners and I don't need to be waiting around for hours between flights :-)
[05:49] <blahdeblah> Yeah - pretty unlikely to get MCY direct to there, I guess.
[05:49] <blahdeblah> veebers: BTW, standard in .au is 2 hrs for intl. flights; they might be a bit more lenient with NZ flights - not sure.
[05:50] <blahdeblah> (that was re: being there before your flight)
[05:50] <veebers> blahdeblah: ack thanks. That's about what I expected
[05:50] <veebers> (considering the flights only 4 hours :-P)
[06:02] <axw> wallyworld: whenever you're free, https://github.com/juju/juju/pull/7550 and https://github.com/juju/juju/pull/7551
[06:02] <wallyworld> ok
[06:15] <axw> wallyworld: so how do you did the forward port? branch off develop, merge 2.2, revert whatever things you don't want like version bump?
[06:16] <wallyworld> axw: yeah. i only normally revert the version number in 3 places
[06:19] <wallyworld> babbageclunk: i think we can close pr 7542
[06:19] <wallyworld> as it is obsolete with the new, smaller fix
[08:42] <babbageclunk> wallyworld: Yup yup