| axw | mwhudson: there's a new gollvm package, which sits between gofrontend and llvm. it's totally separate from the LLVM Go bindings (aka GoLLVM), and llgo (the thing I originally wrote, but also had a significant amount of work by a googler) | 00:34 |
|---|---|---|
| axw | s/package/project/ | 00:34 |
| mwhudson | ah ok | 00:34 |
| mwhudson | i was thinking of llgo yeah | 00:35 |
| axw | wallyworld: would you please review https://github.com/juju/juju/pull/7607? | 04:12 |
| wallyworld | sure | 04:12 |
| wallyworld | axw: i suspect the controller used to need to talk to the key manager facade a long time ago perhaps | 04:20 |
| axw | wallyworld: I guess so | 04:29 |
| axw | doesn't now tho | 04:29 |
| wallyworld | yeah | 04:30 |
| wallyworld | axw: your recent model upgrade changes fixed this bug right? bug 1700434 | 04:56 |
| mup | Bug #1700434: missing credential stops upgrade from running <juju:Triaged> <https://launchpad.net/bugs/1700434> | 04:56 |
| axw | wallyworld: yes | 04:58 |
| axw | wallyworld: aka https://bugs.launchpad.net/juju/+bug/1700451 | 04:58 |
| mup | Bug #1700451: Upgrade from 2.1.x to 2.2.1 blocked by missing Azure resources <canonical-is> <upgrade-juju> <juju:Fix Committed by axwalk> <https://launchpad.net/bugs/1700451> | 04:58 |
| wallyworld | axw: and were you looking at this one ? bug 1701438 | 04:59 |
| mup | Bug #1701438: worker/apicaller: timeout for api dials is too low <juju:Triaged> <https://launchpad.net/bugs/1701438> | 04:59 |
| wallyworld | if not we can pick it up | 04:59 |
| axw | wallyworld: I haven't yet | 04:59 |
| wallyworld | axw: i'll get it done | 04:59 |
| wallyworld | jam: axw: given the size of the diff, i wouldn't mind a quick eyeball (there were a few conflicts). this merges 2.2 into develop, the biggest changes are status history pruning and model upgrades https://github.com/juju/juju/pull/7608 | 06:01 |
| axw | wallyworld: sure, just finishing up status changes for model upgrades, will look after that | 06:02 |
| wallyworld | sgtm, no hurry | 06:02 |
| wallyworld | i know there's changes coming, but i wanted to get the baseline a little mnore up to date and clear the conflicts for folks | 06:02 |
| veebers | wallyworld: is that merge including the CI parts? (acceptancetests and releasetests) | 06:03 |
| wallyworld | veebers: it's tip of 2.2 | 06:06 |
| wallyworld | so whatever that included | 06:06 |
| wallyworld | i pulled 2.2 just before doing the mrge just now | 06:07 |
| veebers | wallyworld: ah ok, cool. I get the feeling there is some differences there for the CI stuff, let me take a look :-) | 06:09 |
| wallyworld | ok, thank you | 06:09 |
| veebers | wallyworld: I don't see any changes to either acceptancetests/ or releasetests/ so we should be good | 06:11 |
| wallyworld | veebers: excellent, thanks for looking. i didn't notice any such changes come through with the merge, but always good to be sure | 06:12 |
| veebers | wallyworld: aye, it got my interest because I got tripped up with CI things being in 2.2 but not develop (which is what we currently deploy, until we change that to be in branch) | 06:13 |
| wallyworld | yeah. multilple branches is fun | 06:14 |
| veebers | Life would be boring if it was easy | 06:14 |
| axw | wallyworld: while I'm looking, can you please review https://github.com/juju/juju/pull/7609 ? | 06:21 |
| wallyworld | sure | 06:21 |
| wallyworld | axw: the worker can only ever run with the newer facade, so there's no need for a version check, right? | 06:26 |
| wallyworld | what about HA though | 06:26 |
| axw | wallyworld: right, it's a new facade in 2.2.2 | 06:26 |
| wallyworld | the worker could hit a 2.2.1 facade | 06:27 |
| axw | wallyworld: the controller agents all upgrade first before the model workers start | 06:27 |
| wallyworld | yeah, that is true | 06:28 |
| wallyworld | axw: lgtm but with a request to include the error in the status message | 06:32 |
| axw | wallyworld: ok | 06:34 |
| axw | wallyworld: ta | 06:34 |
| axw | wallyworld: merge looks fine, just one little issue about some test code which I think can be dropped | 06:42 |
| === frankban|afk is now known as frankban | ||
| wallyworld | axw: thanks, looking | 07:29 |
| wallyworld | axw: i'll pull your last PR into the merge as well | 07:29 |
| axw | wallyworld: great, thanks | 07:30 |
| wallyworld | axw: if it's not too late, otherwise it can wait till tomorrow, a tweak to find/show endpoints https://github.com/juju/juju/pull/7610 | 09:00 |
| axw | wallyworld: what is this "user feedback" you speak of :) | 09:01 |
| axw | looking | 09:01 |
| wallyworld | axw: it's in the bugs, from rick | 09:01 |
| axw | I jest | 09:01 |
| wallyworld | :-) | 09:02 |
| * wallyworld bbiab, making dinner | 09:03 | |
| rick_h | wallyworld: axw :P | 11:34 |
| wallyworld | rick_h: he started it :-) | 11:37 |
| menn0 | jam: the PR is here: https://github.com/juju/juju/pull/7612 | 11:40 |
| menn0 | jam: I need to stop now. could you do a custom build for dimitrii and get him to try it out? | 11:40 |
| === frankban is now known as frankban|afk | ||
| wallyworld | externalreality: hey, did you want to catch up? | 22:33 |
| externalreality | wallyworld, yes | 23:08 |
| externalreality | @wallyworld, are you available now | 23:09 |
| wallyworld | externalreality: sure, give me one minute | 23:09 |
| externalreality | ok | 23:09 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!