[00:34] mwhudson: there's a new gollvm package, which sits between gofrontend and llvm. it's totally separate from the LLVM Go bindings (aka GoLLVM), and llgo (the thing I originally wrote, but also had a significant amount of work by a googler) [00:34] s/package/project/ [00:34] ah ok [00:35] i was thinking of llgo yeah [04:12] wallyworld: would you please review https://github.com/juju/juju/pull/7607? [04:12] sure [04:20] axw: i suspect the controller used to need to talk to the key manager facade a long time ago perhaps [04:29] wallyworld: I guess so [04:29] doesn't now tho [04:30] yeah [04:56] axw: your recent model upgrade changes fixed this bug right? bug 1700434 [04:56] Bug #1700434: missing credential stops upgrade from running [04:58] wallyworld: yes [04:58] wallyworld: aka https://bugs.launchpad.net/juju/+bug/1700451 [04:58] Bug #1700451: Upgrade from 2.1.x to 2.2.1 blocked by missing Azure resources [04:59] axw: and were you looking at this one ? bug 1701438 [04:59] Bug #1701438: worker/apicaller: timeout for api dials is too low [04:59] if not we can pick it up [04:59] wallyworld: I haven't yet [04:59] axw: i'll get it done [06:01] jam: axw: given the size of the diff, i wouldn't mind a quick eyeball (there were a few conflicts). this merges 2.2 into develop, the biggest changes are status history pruning and model upgrades https://github.com/juju/juju/pull/7608 [06:02] wallyworld: sure, just finishing up status changes for model upgrades, will look after that [06:02] sgtm, no hurry [06:02] i know there's changes coming, but i wanted to get the baseline a little mnore up to date and clear the conflicts for folks [06:03] wallyworld: is that merge including the CI parts? (acceptancetests and releasetests) [06:06] veebers: it's tip of 2.2 [06:06] so whatever that included [06:07] i pulled 2.2 just before doing the mrge just now [06:09] wallyworld: ah ok, cool. I get the feeling there is some differences there for the CI stuff, let me take a look :-) [06:09] ok, thank you [06:11] wallyworld: I don't see any changes to either acceptancetests/ or releasetests/ so we should be good [06:12] veebers: excellent, thanks for looking. i didn't notice any such changes come through with the merge, but always good to be sure [06:13] wallyworld: aye, it got my interest because I got tripped up with CI things being in 2.2 but not develop (which is what we currently deploy, until we change that to be in branch) [06:14] yeah. multilple branches is fun [06:14] Life would be boring if it was easy [06:21] wallyworld: while I'm looking, can you please review https://github.com/juju/juju/pull/7609 ? [06:21] sure [06:26] axw: the worker can only ever run with the newer facade, so there's no need for a version check, right? [06:26] what about HA though [06:26] wallyworld: right, it's a new facade in 2.2.2 [06:27] the worker could hit a 2.2.1 facade [06:27] wallyworld: the controller agents all upgrade first before the model workers start [06:28] yeah, that is true [06:32] axw: lgtm but with a request to include the error in the status message [06:34] wallyworld: ok [06:34] wallyworld: ta [06:42] wallyworld: merge looks fine, just one little issue about some test code which I think can be dropped === frankban|afk is now known as frankban [07:29] axw: thanks, looking [07:29] axw: i'll pull your last PR into the merge as well [07:30] wallyworld: great, thanks [09:00] axw: if it's not too late, otherwise it can wait till tomorrow, a tweak to find/show endpoints https://github.com/juju/juju/pull/7610 [09:01] wallyworld: what is this "user feedback" you speak of :) [09:01] looking [09:01] axw: it's in the bugs, from rick [09:01] I jest [09:02] :-) [09:03] * wallyworld bbiab, making dinner [11:34] wallyworld: axw :P [11:37] rick_h: he started it :-) [11:40] jam: the PR is here: https://github.com/juju/juju/pull/7612 [11:40] jam: I need to stop now. could you do a custom build for dimitrii and get him to try it out? === frankban is now known as frankban|afk [22:33] externalreality: hey, did you want to catch up? [23:08] wallyworld, yes [23:09] @wallyworld, are you available now [23:09] externalreality: sure, give me one minute [23:09] ok