| niluje | smoser: blackboxsw: thanks a lot for your help for the MR | 08:29 |
|---|---|---|
| niluje | and sorry it took so long to make it good - is it that long for every datasource? | 08:30 |
| niluje | do you have a release schedule? | 08:30 |
| === ahasenac` is now known as ahasenack | ||
| === ahasenack is now known as Guest49405 | ||
| blackboxsw | niluje I think that time was due in part to multiple vacations on our end impacting the branch review, discussion and landing. (Yes, we were thinking we held you up a bit too long on the feedback loop). As per releases, we get something into ubuntu artful fairly frequently. And then monthly-ish try to get backported critical bug fixes through an SRU process into xenial, yakkety and zesty | 13:39 |
| niluje | blackboxsw: honestly, I think it's 100% my fault if it has been so long :) | 13:44 |
| niluje | one of my coworker asked me to review his PR in 2015, I had to rewrite it, some unittests were failing, I had something else to do and looked back to fix the issue less than 2 months ago :p | 13:45 |
| niluje | the first commit of the scaleway datasource was nearly 2 years ago | 13:45 |
| blackboxsw | niluje: well we ❤ the contributions, doesn't matter how long they take, and Scaleway datasource is a bit more complex than most given the secure port requirement. | 13:45 |
| niluje | yeah | 13:45 |
| blackboxsw | :) | 13:45 |
| niluje | oh and anyway | 13:45 |
| niluje | do you still want servers for cloud-init? | 13:45 |
| blackboxsw | niluje: it would be nice if there were a comp'd account with limited resources, like an account that would allow us to spin up one instance for integration and QA/automated testing. We would make sure we only spin up the instance in limited capacity, such as when we are preparing to release SRU updates to make sure it doesn't break Scaleway. | 13:51 |
| blackboxsw | but I'm not sure if that's hard to do. | 13:52 |
| blackboxsw | or if we ping you once we are ready for an integration test | 13:52 |
| niluje | blackboxsw: sooo I asked how our sponsorship works (I don't deal with them here) | 14:04 |
| niluje | what we ca do is give a discount of 10e/m (which is enough to have 3 small VPN) to your organization | 14:05 |
| niluje | but it requires to have an account with a valid credit card, which won't be charged unless you reach more than 10e | 14:05 |
| niluje | s/VPN/VPS | 14:06 |
| smoser | niluje, we can probably work with that. just to clarify, we're not in search of "generic compute". | 14:09 |
| niluje | yeah I got it :) | 14:10 |
| smoser | we were asking for resources for integration test explicitly to ensure that scaleway would work and put that into some (future) continuous integration. | 14:10 |
| niluje | yep | 14:10 |
| smoser | if you dont mind, i will feel free to bother you later. | 14:11 |
| niluje | no problem, I'll be here and the offer will still stand | 14:11 |
| niluje | thanks a lot for everything :) | 14:12 |
| smoser | niluje, wrt releases... we are well over due | 14:17 |
| smoser | blackboxsw, if you are around, a quick read of | 14:19 |
| smoser | https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327534 would be nice. | 14:19 |
| smoser | https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327344 too. and then i'd like to upload that to artful to un-block python3.6 in ubuntu | 14:39 |
| blackboxsw | smoser: I'm going through that review now but it will probaby be in ~25 mins. Tuesday mornings I need to drop a kiddo at school at the same time as standup | 14:50 |
| smoser | blackboxsw, it appears apparmour will allow dhclient to run | 15:50 |
| smoser | /etc/dhcp/dhclient-script | 15:50 |
| smoser | and that does not exist | 15:51 |
| blackboxsw | yeah, I was concerned about whether it did exist on some clouds | 15:51 |
| smoser | so, while it has the same issues as /sbin/dhclient-script ... | 15:51 |
| smoser | well, in ubuntu we can search if anything in the archive has that file | 15:51 |
| blackboxsw | but maybe we could take that approach if not present. | 15:51 |
| smoser | and i doubt it does | 15:51 |
| smoser | $ apt-file search dhclient-script 2>&1 | grep -v '^W:' | 15:52 |
| smoser | apparmor-profiles: /usr/share/doc/apparmor-profiles/extras/sbin.dhclient-script | 15:52 |
| smoser | dracut-network: /usr/lib/dracut/modules.d/40network/dhclient-script.sh | 15:52 |
| smoser | isc-dhcp-client: /sbin/dhclient-script | 15:52 |
| smoser | isc-dhcp-client: /usr/share/man/man8/dhclient-script.8.gz | 15:52 |
| smoser | rear: /usr/share/rear/skel/default/bin/dhclient-script | 15:52 |
| smoser | we should pose question to security team though | 15:53 |
| smoser | ask what they'd recommend. | 15:53 |
| blackboxsw | smoser: I'll hit up the security channel. | 15:54 |
| blackboxsw | oops you already did | 15:54 |
| === Guest49405 is now known as ahasenack | ||
| smoser | blackboxsw, updated https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327344 with comments . more palatable now i think | 16:24 |
| smoser | and i actually verified that all tests/unittests/ use TestCase from helpers | 16:24 |
| smoser | err... *now* i updated | 16:25 |
| * blackboxsw is trying to rework register_helper a little bit on your to make it a bit more DRY | 16:58 | |
| smoser | ): | 16:59 |
| smoser | :) | 16:59 |
| blackboxsw | on your other branch. | 16:59 |
| smoser | i started that too | 16:59 |
| smoser | oh. | 16:59 |
| smoser | i thoguht you were going to say you were reworking reset_global-state() | 16:59 |
| blackboxsw | heh | 16:59 |
| smoser | to use setattr | 16:59 |
| blackboxsw | nah | 16:59 |
| blackboxsw | sorry for the slow goings on this. I just want to make sure I understand and tested what I've reviewed. | 17:00 |
| blackboxsw | speed will come... | 17:00 |
| smoser | blackboxsw, well, ifyou're looking for generalization.. | 17:01 |
| smoser | tests/unittests/test_datasource/test_aliyun.py | 17:01 |
| smoser | uses something similar | 17:01 |
| smoser | thats where i started with register_helper | 17:01 |
| smoser | but the py3.6 one | 17:02 |
| smoser | if you can quick read that one. | 17:02 |
| smoser | that is more important | 17:02 |
| smoser | as it is blocking things in ubuntu | 17:02 |
| blackboxsw | yeah definitely. committed WIP comments on your ec2, grabbing py3.6 and playing on my aartful box | 17:05 |
| smoser | there is actually nothing python3.6 specific in those changes | 17:15 |
| smoser | they're all just bad expectations in tests, and one actual fix | 17:15 |
| blackboxsw | smoser: when I tweak tox.ini environment to basepython = python3.6. I still hit an error: http://pastebin.ubuntu.com/25119991/ digging in now | 17:34 |
| smoser | blackboxsw, i think you have a bad .pyc or something | 17:48 |
| smoser | something is wrong | 17:48 |
| blackboxsw | yeah I'm running tox -r to rebuild now | 17:49 |
| smoser | as line 23 in your paste is not line 212 in my merge proposal | 17:49 |
| smoser | ie, open cloudinit/net/netplan.py and go to line 212 | 17:49 |
| smoser | fpnplan = os.path.join(util.target_path(target), self.netplan_path) | 17:49 |
| smoser | is what you shoudl see | 17:49 |
| blackboxsw | ok that plus a clean_pyc worked for me | 17:49 |
| powersj | smoser: submitted merge for kvm backend. I have it working locally and on torkoal. Would like to see what you think. https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/327646 | 17:49 |
| powersj | smoser: I also have the workflow documented and can walk you through it if you want. | 17:50 |
| blackboxsw | ok I'm out of your way on https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327344 . approved | 17:52 |
| blackboxsw | back to ec2 tests branch | 17:52 |
| smoser | thanks | 17:54 |
| rharper | smoser: https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/327648 (sysconfig update MP) | 18:27 |
| smoser | powersj, you want to chat in 20 minutes ? | 19:40 |
| powersj | smoser: sure | 19:40 |
| smoser | rharper, from | 20:56 |
| smoser | 8da074f831ce8e4ad781163b0301d6e0b07e0d12 | 20:56 |
| smoser | er... from your link above, that first one looks fine. i'll just grab that. | 20:56 |
| smoser | bah. i'll look more tomrorow. | 21:00 |
| smoser | i'm reallyconfused. | 21:00 |
| smoser | i was going to cherry pick the above, but it leaves tox broken | 21:02 |
| smoser | well, fixed that | 21:10 |
| smoser | 1 commit down, 11 to go | 21:10 |
| smoser | commented in your mp | 21:10 |
| rharper | smoser: thanks, I'll run tox on my mp (can't believe I didn't already) | 21:15 |
| smoser | well just when i cherry picked that one | 21:18 |
| smoser | it probably means you now have merge conflicts in another commit | 21:18 |
| smoser | ie, i bet you didn't fix that one and fixed it later. | 21:18 |
| smoser | i have to run.. i think the way i'll do thi sis just to work one at a time | 21:19 |
| smoser | sound reasonable ? | 21:19 |
| blackboxsw | smoser, approved https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327534 take what you will as far as review comments. | 21:21 |
| smoser | rharper, http://paste.ubuntu.com/25121184/ | 21:22 |
| smoser | thats my next commit review | 21:22 |
| smoser | and i need to run now, really this time | 21:22 |
| blackboxsw | it feels like those httppretty tests are expensive. ~4 seconds per test, though I haven't profiled where we are spending our time in those tests yet. | 21:22 |
| blackboxsw | see you smoser have a good one | 21:23 |
| smoser | hm.. | 21:23 |
| smoser | :-( | 21:23 |
| blackboxsw | smoser: nevermind, they were expensive because I had manipulated the mocked metadata urls locally and leaked calls were timing out. | 21:28 |
| blackboxsw | real0m0.480s ok better | 21:29 |
| rharper | smoser: ok, looks like the IPV6_ gateway prefix gets fixed in the next commit (whic his fine) | 21:41 |
| powersj | rharper: thx for the review | 22:17 |
| powersj | rharper: smoser: what is the proper way to format this command via mount-image-callback: http://paste.ubuntu.com/25121627/ | 22:18 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!