[01:35] blackboxsw, right. [01:35] it *should* be ok to do what we're doing. [01:35] and this path (dhcp and use that address) is actually less likely to cause any issues [01:35] than using the ipv4 link local path. [01:35] we can talk about that... maybe we don't need a fallback path. [01:35] have to think more === shardy is now known as shardy_lunch === shardy_lunch is now known as shardy === shardy is now known as shardy_mtg === shardy_mtg is now known as shardy [15:54] smoser: rharper if I want to run a single cloud-init module and pass in user data how do I do that with: cloud-init single -n hostname [16:05] cloud-init single --name=hostname --frequency=always [16:06] and for changing the config that that thing sees.... [16:06] i always just end up writing different content into /etc/cloud/cloud.cfg.d/99-smoser.cfg [16:06] and re-running boave [16:08] if you to pass in user-data, you need --file /path/to/cfg [17:28] rharper, blackboxsw https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327532 [17:28] that is updated with commits for your feeback (and flake fixes too) [17:31] k [17:38] quick view of https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327896 [17:38] would be helpful too [17:49] hrm trying to test freebsd instances with the dhclient changes I can't seem to ssh to the instance w/ root@ec2-..... and the pem file. It's prompting me for a password [17:49] will check those branches now smoser [17:53] hrm indeed. :) [17:53] https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327896 approved [17:54] your extensions to mock in https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327532 remind me about adding linters which should balk if we are importing mock directly [17:56] blackboxsw, ? [17:57] i think it doesnt matter though [17:57] unless you know otherwise [17:57] i wondered about this and tested quickly [17:57] if a test does import the 'helpers' [17:57] and then (before or after) import mock via 'import mock' [17:57] then the mock is still patched everywhere [17:58] is that what you were meaning? [18:01] hrm, I lemme check on that. I probably misinterpreted what mock monkey patching we were doing there in helpers. [18:06] blackboxsw, theres only one "copy" of an import [18:07] just differntly namespaced based on how its imported [18:07] right? [18:07] that fact is part of the reason on why you can fail to un-mock something in a unit test and have another unit test affected. [18:07] smoser, ok confirmed the proper behavior as you suggested. Anything that imports helpers will have the properly patch mock.Mock which has assert_not_called since the import already "happened" in original helpers import [18:08] yeah correct [18:08] either before or after [18:08] import mock [18:08] import helpers [18:08] or the other way [18:08] doesn't matter [18:10] so we *don't* have to worry about where we import mock as we have enxtended mock.Mock at helper module import time [18:10] right [18:39] as long as helper gets loaded [19:36] ugh [19:36] cloud-init in archive now depends on nplan | ifupdown [19:36] updated, then purged ifupdown [19:37] in lxc container [19:37] cleaned out /var/lib/cloud [19:37] reboot [19:37] does not have an ipv4 dhcp address [19:37] :-( [19:39] hm.. maybe it did [19:48] smoser: around? [20:04] larsks, here. [20:04] sorry... slow reply [20:05] No worries. So, (a) approved for cloud-init summit. [20:05] (b) does this seem like a reasonable explanation of the ovirt issue? [20:05] https://gist.github.com/larsks/62841738dbfad27155628a2560cb818c [20:06] a. \0/ [20:07] larsks, that sounds pretty reasonable yes. [20:07] Excellent. Thanks. [20:07] larsks, i think we *could* keep both the instance id and the previous dmi id around and compare [20:07] i think that woudl work. [20:08] Just an extra symlink in /var/lib/cloud/instances, maybe? [20:08] well, cloud-init loads /var/lib/cloud/instance/obj.pkl [20:08] and that, which is the ConfigDrive class [20:08] has the ability to look around and decide if it is new or not [20:08] i think ... (memory here) [20:09] we could keep the uuid from dmi and the instance id. [20:09] and if uuid did not change, we could assume we were same. [20:09] I guess. It seems better if ovirt were to fix things, since they're pretending to be an openstack data source. [20:09] yes. [20:46] hrm, I'm not sure our is_connected function in cloudinit/net/__init__ works on aws cloud instances [20:46] cat /sys/class/net/eth0/carrier [20:46] 1 [20:46] I'm seeing a 1 returned from my active eth0 interface (so is_connected returns False) [20:47] ahh wait a sec, sorry n/m. we check iflink first [20:49] ok ignore the peanut gallery: python3 -c 'from cloudinit.net import is_connected; print(is_connected("eth0"))' [20:49] True [21:18] rharper, https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/327921 should be good now. [21:48] k