| === chihchun_afk is now known as chihchun | ||
| mup | Bug #1705985 opened: snaps fail to install on juju1 deployed lxc container <canonical-bootstack> <Snappy:New> <https://launchpad.net/bugs/1705985> | 06:12 |
|---|---|---|
| zyga-ubuntu | o/ | 06:27 |
| zyga-ubuntu | good morning everyone | 06:27 |
| zyga-ubuntu | mvo: how are you doing? | 06:46 |
| mvo | zyga-ubuntu: hey, good morning. doing fine, how are you? | 06:47 |
| zyga-ubuntu | just finishing my coffee, good; today will be a nice day (for protests) | 06:47 |
| mup | PR snapd#3592 closed: interfaces: opengl support pci device and vendor <Created by kyrofa> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/3592> | 06:49 |
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| zyga-ubuntu | !!! | 08:15 |
| zyga-ubuntu | kissiel: duda vetoes! | 08:15 |
| zyga-ubuntu | \o/ | 08:15 |
| kissiel | zyga-ubuntu: you know it's because they voted for the wrong one? | 08:16 |
| kissiel | zyga-ubuntu: the one pushed was not the one they wanted | 08:16 |
| kissiel | it's a mess | 08:16 |
| zyga-ubuntu | kissiel: well, they could have paper-wrapped that | 08:16 |
| zyga-ubuntu | kissiel: but it seems he's not totally corrupt and spineless | 08:16 |
| zyga-ubuntu | kissiel: this is a major step forward | 08:16 |
| kissiel | we'll see | 08:17 |
| === JamieBen_ is now known as JamieBennett | ||
| Chipaca | zyga-ubuntu: thank for the reviews! | 08:41 |
| mup | PR snapd#3612 closed: vendor: update go-flags to address crash in "snap debug" <Created by zyga> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/3612> | 08:44 |
| === chihchun is now known as chihchun_afk | ||
| zyga-ubuntu | Chipaca: my pleasure | 08:45 |
| mup | PR snapd#3610 closed: snap: do not always quote the snap info summary <Created by mvo5> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/3610> | 08:45 |
| === chihchun_afk is now known as chihchun | ||
| zyga-ubuntu | if it wasn't for the political turmoil I'd be pushing my branch for review so if you want to look at the query -> result API similarity I'd love your review | 08:45 |
| zyga-ubuntu | but | 08:45 |
| zyga-ubuntu | there's a lot of hope now | 08:45 |
| zyga-ubuntu | after the week of protests the president just announced he will not sign the controversial law | 08:46 |
| zyga-ubuntu | Chipaca: sorry, how have you been? :-) I keep talking about .pl lately | 08:46 |
| * zyga-ubuntu is reviewing 3594 | 08:46 | |
| Chipaca | zyga-ubuntu: sounds like you're back into .pl politics big time | 08:50 |
| zyga-ubuntu | Chipaca: hard to ignore such changes | 08:50 |
| zyga-ubuntu | Chipaca: during the sprint mvo, gustavo and me went for a walk and we passed by the presidential palace, having walked past 1000s of people peacefully protesting | 08:50 |
| zyga-ubuntu | Chipaca: it's not over but there's a lot more hope now than during the last few days | 08:51 |
| mup | PR snapd#3605 closed: packaging: have Ubuntu snapd package recommend squashfuse <Created by dustinkirkland> <Closed by chipaca> <https://github.com/snapcore/snapd/pull/3605> | 08:54 |
| === chihchun is now known as chihchun_afk | ||
| pedronis | zyga-ubuntu: mvo: Chipaca: hi | 09:08 |
| zyga-ubuntu | pedronis: hey, how are you doing? :) | 09:09 |
| pedronis | ok | 09:09 |
| === chihchun_afk is now known as chihchun | ||
| mvo | Chipaca: re tab-completion (forum) profile.d file - is that something you want me to look into? I am keen to get it for 2.27 | 09:26 |
| mvo | fgimenez: any word from CE yet about the 2.26.14 stable core? I would love to release that today if JamieBennett is ok with it too | 09:26 |
| JamieBennett | mvo: I believe we are OK to release, lets leave it until this afternoon when our US colleagues come online to confirm. | 09:30 |
| fgimenez | hey mvo, not yet, looks like they are running smoke test on it, according to the thread the results should be available today | 09:30 |
| mvo | fgimenez, JamieBennett: thank you both! | 09:30 |
| * zyga-ubuntu keeps fingers crossed for an open path to 2.27 | 09:30 | |
| ogra_ | zyga-ubuntu, congrats (nice president ...) | 09:39 |
| zyga-ubuntu | ogra_: nice is too strong but it seems he's waking up | 09:41 |
| zyga-ubuntu | mvo: partially reviewed 3594 | 09:51 |
| mvo | zyga-ubuntu: ta, nice | 09:54 |
| === Kamilion is now known as |{amilion | ||
| === |{amilion is now known as Kamilion | ||
| zyga-ubuntu | Chipaca: tab completion question | 11:11 |
| zyga-ubuntu | Chipaca: snap command --optio$ argument | 11:12 |
| zyga-ubuntu | Chipaca: if I hit tab when cursor is indicated at $, should it complete --option | 11:12 |
| zyga-ubuntu | Chipaca: as a user I'd say, sure | 11:12 |
| zyga-ubuntu | but it doesn't | 11:12 |
| zyga-ubuntu | er | 11:12 |
| zyga-ubuntu | sorry | 11:12 |
| zyga-ubuntu | reverse that | 11:12 |
| zyga-ubuntu | Chipaca: snap command arg$ --option | 11:13 |
| zyga-ubuntu | Chipaca: I try to tab complete "argument" | 11:13 |
| zyga-ubuntu | both normally work but when cursor is not at the end, things misbehave | 11:13 |
| ogra_ | ppisati, any idea about https://forum.snapcraft.io/t/wifi-and-bluetooth-on-snappy-ubuntu-on-a-dragonboard/1297 ? | 11:22 |
| zyga-ubuntu | Chipaca: I think 3399 is ready for review now | 11:30 |
| ppisati | ogra_: replied | 11:33 |
| Chipaca | zyga-ubuntu: sorry, was away | 11:36 |
| zyga-ubuntu | Chipaca: no worries at all | 11:36 |
| Chipaca | zyga-ubuntu: yes it should | 11:36 |
| Chipaca | zyga-ubuntu: doing that is possible | 11:37 |
| Chipaca | zyga-ubuntu: but, i have yet to see a completer that does it | 11:37 |
| zyga-ubuntu | aha | 11:37 |
| zyga-ubuntu | so it's just harder to do and requires some extra features in go-flags? | 11:37 |
| Chipaca | zyga-ubuntu: not necessarily go-flags | 11:38 |
| Chipaca | zyga-ubuntu: it's harder to do, and involves looking at some bash variables | 11:39 |
| Chipaca | zyga-ubuntu: go-flags carefully avoids looking at bash variables i think | 11:39 |
| Chipaca | zyga-ubuntu: by this i mean: it's probably the snapd completion snipped that needs the extra work, not go-flags | 11:44 |
| zyga-ubuntu | aha | 11:45 |
| Chipaca | snippet* | 11:45 |
| === chihchun is now known as chihchun_afk | ||
| ogra_ | ppisati, thanks! | 11:53 |
| ogra_ | ppisati, hmm, i wonder if that guy in the forum uses an oldish "build a dragonboard" tutorial or what | 12:03 |
| * zyga-ubuntu is hungry | 12:04 | |
| zyga-ubuntu | time for something that resembles breakfast and includes not just coffee | 12:04 |
| niemeyer | Good morning all | 12:05 |
| niemeyer | Good afternoon to the other all | 12:05 |
| zyga-ubuntu | niemeyer: hey, how was the trip back? | 12:06 |
| niemeyer | zyga-ubuntu: Heya! | 12:06 |
| niemeyer | It was event-less ;) | 12:06 |
| mvo | Chipaca: if I want to test my profile.d complete.sh integration, what is the best snap to test that with? do we have a test-snapd-with-completion in the store? | 12:07 |
| zyga-ubuntu | niemeyer: please have a look at 3399 when you have a moment | 12:07 |
| niemeyer | zyga-ubuntu: ack | 12:07 |
| zyga-ubuntu | niemeyer: I think all the major issues are resolved and we should either land it or iterate on some details and land it | 12:07 |
| zyga-ubuntu | niemeyer: after eating something I'll start working on layouts | 12:07 |
| zyga-ubuntu | niemeyer: unless I forgot something and there's some catch up from last week, I'll review my nots | 12:07 |
| zyga-ubuntu | noteS* | 12:07 |
| niemeyer | zyga-ubuntu: Sounds great! | 12:08 |
| zyga-ubuntu | niemeyer: and on the upside, president vetoed (2/3 bill) so +1 for democracy :) | 12:08 |
| niemeyer | zyga-ubuntu: Wow, \o/ | 12:08 |
| niemeyer | zyga-ubuntu: Close call.. :) | 12:08 |
| zyga-ubuntu | yes, not over but everyone is very suprised and enthusiastic, it was commonly assumed he would just sign it | 12:09 |
| Chipaca | mvo: I don't think we have it in the store; there's tests/lib/snaps/complexion/ | 12:10 |
| mvo | Chipaca: thank you | 12:14 |
| mvo | Chipaca: ok, I have complexion now installed, what is the easiest test to see if tab completion for it works? | 12:18 |
| mvo | Chipaca: pardon my ignorace, I can dig into the tests to figure it out if you are busy | 12:19 |
| Son_Goku | morning all | 12:28 |
| Son_Goku | zyga-ubuntu, did you manage to fix the snap-seccomp failure on 32-bit arches? | 12:29 |
| ogra_ | flexiondotorg, "Once upgraded to stretch I ran sudo snap install snapd " ?? | 12:30 |
| ogra_ | (did you mean apt install ?) | 12:30 |
| mvo | flexiondotorg: thanks a bunch for the details - I'm back so I can try this now too. we tried it during the sprint but couldn't reproduce the issue | 12:30 |
| flexiondotorg | mvo No problem. | 12:31 |
| flexiondotorg | ogra_ Yes, I'll edit. Thanks, | 12:31 |
| flexiondotorg | I type snap more than apt these days. Muscle memory is replaced :-) | 12:31 |
| ogra_ | yeah, i know what you mean :) | 12:34 |
| zyga-ubuntu | Son_Goku: not yet, I'll look at it after lunch | 12:39 |
| zyga-ubuntu | Son_Goku: just finished PR 3399 | 12:39 |
| Son_Goku | PR#3399? | 12:39 |
| Son_Goku | oh, right... snapd#3399 | 12:39 |
| mup | PR snapd#3399: many: add the interface command <Created by zyga> <https://github.com/snapcore/snapd/pull/3399> | 12:39 |
| Son_Goku | nope | 12:39 |
| Son_Goku | what's the magic thing to make the bot tell us stuff? | 12:39 |
| flexiondotorg | ogra_ Is now a good time to make an introduction? | 12:41 |
| ogra_ | as good as any time :) | 12:41 |
| mup | PR snapd#3616 opened: cmd/snap-repair: implement Runner.Verify and use it to check signatures of repairs from Next <Created by pedronis> <https://github.com/snapcore/snapd/pull/3616> | 12:45 |
| flexiondotorg | ogra_ I like to introduce you to ikey | 12:53 |
| * ikey bows | 12:53 | |
| flexiondotorg | ogra_ ikey is the lead for Solus. A from scratch Linux OS. | 12:54 |
| flexiondotorg | ikey ogra_ is, well, a bit a legend around here ;-) | 12:54 |
| ikey | :] nice to meet ya. | 12:54 |
| Son_Goku | O.o | 12:54 |
| flexiondotorg | ogra_ As discussed last week ikey is interested in enabling snapd in Solus. | 12:54 |
| Son_Goku | ikey, hello | 12:54 |
| Son_Goku | wait, wut | 12:54 |
| Son_Goku | really? | 12:55 |
| ogra_ | hey ikey ! | 12:55 |
| ikey | howdo :] | 12:55 |
| ikey | Son_Goku, gotta adapt. i wont be the HD-DVD in this battle. | 12:55 |
| Son_Goku | well, I guess that's fair | 12:55 |
| * ikey figures its not appropriate to use tape comparisons anymore | 12:55 | |
| Son_Goku | that's why I have ze snapd in Fedora :) | 12:55 |
| flexiondotorg | ogra_ From my discussion with ikey he would like someone on hand to answer questions regarding landing AppArmor (plus our patches) in the kernel Solus ship. | 12:56 |
| ogra_ | well, happy to help, thought we might need some help from kernel guys like ppisati or jj | 12:57 |
| ogra_ | *though | 12:57 |
| flexiondotorg | ikey I think you'll generally be OK packaging snapd itself, but should you need any clue ogra_ can either assist or get the right people involved. | 12:57 |
| ogra_ | yeah | 12:57 |
| ikey | sounds good to me | 12:57 |
| ogra_ | you will need the appramor patches but also some kernel config defaults (for seccomp cgroups etc) | 12:57 |
| flexiondotorg | ogra_ Yes, JamieBennett did suggest that p_pisati and j_j might be needed. | 12:58 |
| ogra_ | yup | 12:58 |
| ikey | are the apparmor patches contained anywhere .. sane? | 12:58 |
| flexiondotorg | ogra_ ikey I'll consider you two introduced and bow out. | 12:58 |
| ikey | by sane i mean "not a hidden kernel team ppa on launchpad that i cant access" | 12:58 |
| flexiondotorg | But I'm happy to be tagged here and brought back into the discussion. | 12:58 |
| ikey | which has been my experience so far .. | 12:58 |
| ikey | cheers flexiondotorg | 12:58 |
| ogra_ | ikey, like http://kernel.ubuntu.com/git/jj/linux-apparmor-backports/ ? | 12:59 |
| ikey | anyways im not gonna be able to get snapd packaged for a couple of days yet, got a bit of a workload to get through myself | 12:59 |
| ikey | looks legit | 13:00 |
| ikey | cheers | 13:00 |
| * ikey bookmarks | 13:00 | |
| ogra_ | :) | 13:00 |
| Son_Goku | hmm | 13:00 |
| Son_Goku | well, if it's not all merged by 4.14, then I'll probably have to use some part of this too :/ | 13:01 |
| ogra_ | ikey, so i'D suggest you just start once you have time for it and bomb me with questions as they come up :) | 13:01 |
| * Son_Goku bookmarks | 13:01 | |
| ikey | thanks :] | 13:01 |
| JamieBennett | Son_Goku: We are trying to get everything upstream by 4.14, it is down to the kernel upstream gods though | 13:05 |
| Son_Goku | JamieBennett, with AppArmor, aren't you guys the upstream gods too? | 13:05 |
| JamieBennett | Son_Goku: Yup but we rely on code flowing upstream to the kernel | 13:06 |
| JamieBennett | i.e. Linus | 13:06 |
| bloodearnest | hey folks. I've been trying to run nginx in strict confinement, but the setgroups(2) syscall is not allowed. The only interfaces I have are network and network-bind | 13:14 |
| bloodearnest | is there another interface I can request to be able to do this | 13:14 |
| bloodearnest | squid also has this issue, fwiw | 13:14 |
| ogra_ | snap services run as root ... try to reflect that in your config | 13:15 |
| ogra_ | (i.e. if there is a user/group option in the config, point it to root) | 13:15 |
| bloodearnest | ogra_, yep, have done already | 13:15 |
| bloodearnest | still seems to want to setgroups stuff | 13:16 |
| bloodearnest | it runs as root fine in devmode | 13:16 |
| zyga-ubuntu | bloodearnest: not yet, but this is going to be implemented soonish | 13:29 |
| zyga-ubuntu | bloodearnest: we desiged how it would work | 13:29 |
| zyga-ubuntu | bloodearnest: as there are a few snaps that are affected already | 13:29 |
| bloodearnest | zyga-ubuntu, thanks for the info | 13:30 |
| * ogra_ tickles zyga-ubuntu with https://github.com/snapcore/pi3-gadget/pull/11 again ... | 13:31 | |
| mup | PR pi3-gadget#11: build uboot from source, pull blobs from upstream, use dtbs from archive <Created by ogra1> <https://github.com/snapcore/pi3-gadget/pull/11> | 13:31 |
| ogra_ | (i have pending stuff that waits for it to land ...) | 13:32 |
| zyga-ubuntu | ogra_: I'll check today for sure, sorry, I'm getting back to "what shall I do" after all the backlog | 13:34 |
| ogra_ | zyga-ubuntu, thanks ... as i said before it has all been tested in and out and my local images all run with it already ... just needs a second ack so i can move on and apply the same to pi2 and cm3 | 13:35 |
| ogra_ | the resulting binary snap is identical... | 13:36 |
| zyga-ubuntu | excellent | 13:37 |
| * mcphail wonders when we'll be seeing zyga-solus..? | 13:42 | |
| zyga-ubuntu | mcphail: I don't have enough desk space :) | 13:46 |
| mcphail | heh :) | 13:47 |
| pedronis | Chipaca: going to have a break and then will look at your open PRs I think instead of starting something new | 13:53 |
| Chipaca | pedronis: that sounds like an objectively stupendous idea | 13:54 |
| fgimenez | mvo: the title of bug #1690083 should be set to .14 instead of .10, right? | 13:57 |
| mup | Bug #1690083: [SRU] 2.26.10 <verification-needed> <verification-needed-trusty> <verification-needed-xenial> <verification-needed-yakkety> <verification-needed-zesty> <snapd (Ubuntu):Fix Released> <snapd (Ubuntu Trusty):Fix Committed> <snapd (Ubuntu Xenial):Fix Released> <snapd (Ubuntu Yakkety):Fix | 13:57 |
| mup | Committed> <snapd (Ubuntu Zesty):Fix Committed> <https://launchpad.net/bugs/1690083> | 13:57 |
| mvo | fgimenez: yes | 13:57 |
| mvo | fgimenez: eh, one sec | 13:58 |
| mvo | fgimenez: actually we only release 2.26.10 as a deb, the other fixes were all re-exec releated so not releavant for the deb itself | 13:58 |
| mvo | fgimenez: but if you feel it should be in sync I can do that too | 13:58 |
| fgimenez | mvo: np not needed at all, then there won't be a 2.26.14 deb release, right? | 14:01 |
| mvo | fgimenez: correct | 14:03 |
| fgimenez | mvo: cool thx | 14:04 |
| zyga-ubuntu | mvo: when you reproduced the problem on raspbian, which versions did you have and what did system logs say? | 14:05 |
| mvo | zyga-ubuntu: I started with 2.21 and when to stable (2.26.10). the configure hook was in defunct state in ps afx | 14:06 |
| mvo | zyga-ubuntu: no denials AFAICS in the system logs, but let me double check that | 14:07 |
| mvo | zyga-ubuntu: also subsequent dpkg --purge snapd; apt install snapd; snap install core worked so something is either racy or setup on first deb install or something, I'm running this in a loop now (except that it takes forever so the loop iteration is ~2 or so so far) | 14:08 |
| zyga-ubuntu | aha | 14:08 |
| zyga-ubuntu | interesting | 14:08 |
| ogra_ | raspbian should just switch to ubuntu core :P | 14:09 |
| ogra_ | reading about hours for upgrading always makes me think that | 14:09 |
| cachio | niemeyer, so, should i leave 1 worker for fedora? | 14:11 |
| cachio | I have merged with trunk and testing new tests within fedora, I'll be pushing soon | 14:12 |
| ogra_ | mvo, did you see bug 1705708 ? ... fun fact ... having the same core on two different machines here (laptop vs desktop) and using the same gui snap , on one machine opening urls does actually still work, the other doesnt ... | 14:17 |
| mup | Bug #1705708: latest change to xdg-open not applied to the unity7 interface <snapd:In Progress by ogra> <https://launchpad.net/bugs/1705708> | 14:17 |
| ogra_ | (both run core 2381) | 14:17 |
| Chipaca | ogra_: something something armel something | 14:34 |
| ogra_ | Chipaca, hmm ? | 14:34 |
| Chipaca | ogra_: re <ogra_> raspbian should just switch to ubuntu core :P | 14:35 |
| ogra_ | ah | 14:35 |
| ogra_ | yeah | 14:35 |
| ogra_ | we need a v6 build | 14:35 |
| cachio | niemeyer, it is ready PR 3505 | 14:59 |
| cachio | merged with latest changes in trunk and running with 1 worker for fedora | 15:00 |
| niemeyer | cachio: Thanks! | 15:02 |
| niemeyer | The report is out: | 15:09 |
| niemeyer | https://forum.snapcraft.io/t/weeks-24-29-of-2017-in-snapd/1421/1 | 15:09 |
| pedronis | Chipaca: posted some first pass comments on two of the PRs | 15:14 |
| Chipaca | pedronis: i saw them, thank you! haven't replied yet though | 15:16 |
| flexiondotorg | Snapcraft Office Hours is starting in a few minutes here - https://www.youtube.com/watch?v=xPtPiaHIghs | 15:28 |
| diddledan | I'm there, thanks flexiondotorg | 15:29 |
| === matteo` is now known as matteo | ||
| === JanC is now known as Guest39739 | ||
| === JanC_ is now known as JanC | ||
| cachio | Chipaca, if you have some time, could you please take a look to this one PR 3505 | 16:29 |
| cachio | Chipaca, it is almost ready to lunch | 16:29 |
| Chipaca | cachio: hungry lapsus there? | 16:32 |
| cachio | Chipaca, hehehe, land, sorry :) | 16:32 |
| cachio | Chipaca, my stomach betrays me :) | 16:34 |
| Chipaca | cachio: question for you: why dropping the call to MountDir() in snapEnv? | 16:34 |
| Chipaca | ahhhh | 16:35 |
| Chipaca | because of inside vs outside | 16:35 |
| Chipaca | this is going to get confusing :-( | 16:36 |
| Chipaca | cachio: anyway, you have two +1's already, go for it | 16:38 |
| cachio | Chipaca, yes | 16:41 |
| cachio | also we could join dirs.CoreSnapMountDir, info.MountDir() | 16:41 |
| mcphail | That ruby plugin looks good. I'm sure there was a ruby app I was going to try to snappify. If I could only rememebr what it was... | 16:46 |
| cachio | niemeyer, do you think the fedora PR is ready to be landed? | 16:46 |
| niemeyer | cachio: Which one? | 16:46 |
| cachio | 3505 | 16:46 |
| cachio | niemeyer, once that is merged, I'll push the changes on the opensuse one | 16:50 |
| niemeyer | cachio: "The snap is leaving in $SNAPMOUNTDIR the .sh, and in $SNAP_INSTALL_DIR the commands." | 16:54 |
| niemeyer | cachio: The question is why SNAP___INSTALL___DIR vs. SNAPMOUNTDIR. | 16:54 |
| cachio | niemeyer, looking | 16:59 |
| cachio | niemeyer, as I see, both can be used | 17:04 |
| cachio | $SNAP_INSTALL_DIR/bin/sh or $SNAPMOUNTDIR/bin/test-snapd-tools.sh | 17:05 |
| niemeyer | cachio: Do you see the clear difference in syntax in those two variables? | 17:06 |
| niemeyer | cachio: Although they look *extremely* alike? | 17:06 |
| cachio | niemeyer, between which ones? | 17:07 |
| cachio | niemeyer, SNAPMOUNTDIR and SNAP_INSTALL_DIR? | 17:07 |
| niemeyer | cachio: My obsessive-compulsive disorder is extremely bothered by the fact you can't even see what I'm talking about :P | 17:07 |
| niemeyer | cachio: Of course.. isn't that why I just asked above | 17:09 |
| niemeyer | cachio: The question is why SNAP___INSTALL___DIR vs. SNAPMOUNTDIR. | 17:09 |
| niemeyer | cachio: See the underlines? | 17:09 |
| cachio | yes | 17:09 |
| niemeyer | cachio: SNAP***INSTALL**DIR | 17:09 |
| niemeyer | cachio: SNAP**MOUNT**DIR | 17:09 |
| cachio | niemeyer, you mean, why we are not using underscores? | 17:09 |
| cachio | for SNAPMOUNTDIR | 17:10 |
| niemeyer | cachio: I don't really care so much about which way we go.. the first question is why do we have those two conventions side by side instead of one | 17:10 |
| cachio | and we are using for SNAP_INSTALL_DIR | 17:10 |
| cachio | niemeyer, well, agree we should have a convention for that | 17:11 |
| niemeyer | Phew ;) | 17:11 |
| cachio | for example, TESTSLIB has not any _ | 17:12 |
| cachio | so, the convention seem to be "no _" | 17:13 |
| niemeyer | cachio: I'd be fine with that.. it also doesn't have to be done in this PR | 17:13 |
| niemeyer | cachio: We just need to ack the conflict and have a plan to eventually converge | 17:13 |
| cachio | niemeyer, sure, I'll take a look to see in which places we have this divergence | 17:14 |
| cachio | niemeyer, so if the change is so big, we can discuss it in the forum | 17:15 |
| cachio | otherwise I'll create a PR to unify it | 17:16 |
| niemeyer | cachio: Thanks | 17:16 |
| niemeyer | cachio: We should evaluate which way is more clear | 17:17 |
| niemeyer | cachio: Wehavesomelongstringsandingeneralreadingthingslikethisbecomeshard | 17:17 |
| cachio | niemeyer, yes, I prefer with '_' | 17:17 |
| cachio | but, it would be a big change | 17:18 |
| niemeyer | cachio: We don't need to rush this.. at first just making sure we don't have such obvious divergences would be easy | 17:18 |
| niemeyer | SNAP_MOUNT_DIR, for example | 17:18 |
| cachio | niemeyer, sure | 17:19 |
| cachio | niemeyer, doing a fast check, just TESTSLIB, SNAPMOUNTDIR and LIBEXECDIR are without _ | 17:29 |
| cachio | niemeyer, then, all the variables that we use for the environment and spread are using _ | 17:30 |
| cachio | niemeyer, the change is really easy but the diff will be huge, I could split it by variable | 17:32 |
| niemeyer | cachio: If that's the only change, even if it's huge it's easy to review | 17:35 |
| niemeyer | cachio: #3505 is in | 17:36 |
| cachio | niemeyer, thanks | 17:37 |
| mup | PR snapd#3505 closed: tests: enable main suite on fedora <Created by morphis> <Merged by niemeyer> <https://github.com/snapcore/snapd/pull/3505> | 17:37 |
| === cachio is now known as cachio_afk | ||
| === jkridner|pd is now known as jkridner | ||
| jdstrand | zyga-suse: hey, I have a fix for gary's https://github.com/snapcore/snapd/pull/3587 | 18:48 |
| mup | PR snapd#3587: Using udev tagging for snap interfaces <Created by adglkh> <https://github.com/snapcore/snapd/pull/3587> | 18:48 |
| jdstrand | zyga-suse: iirc, we can commit to other branches. what is the trick to doing that? | 18:49 |
| zyga-ubuntu | jdstrand: hey | 18:49 |
| zyga-ubuntu | jdstrand: oh, that's intereting | 18:49 |
| zyga-ubuntu | jdstrand: the trick is to add a remote and just push to the branch directly | 18:49 |
| zyga-ubuntu | jdstrand: git remote add adglkh git@github.com:adglkh/snapd | 18:49 |
| zyga-ubuntu | jdstrand: that should do it | 18:50 |
| zyga-ubuntu | jdstrand: then git fethc adglkh | 18:50 |
| zyga-ubuntu | jdstrand: then git checkout udev_tagging | 18:50 |
| zyga-ubuntu | jdstrand: then do whatever you want and "git push adglkh" | 18:50 |
| zyga-ubuntu | jdstrand: quick question, I actually joined to ask you one :) | 18:50 |
| zyga-ubuntu | jdstrand: location control is not constrained to core snap but the interface talkes about unconfined peers | 18:50 |
| zyga-ubuntu | jdstrand: missing check? | 18:50 |
| zyga-ubuntu | (well, partially talks about unconfined, maybe I'm mistaken) | 18:51 |
| jdstrand | zyga-ubuntu: location-control is written to only be available as an app snap (ie, no deb) | 18:54 |
| jdstrand | zyga-ubuntu: I assume you are talking about the rule at line 66? | 18:55 |
| jdstrand | zyga-ubuntu: that should have a comment above it, but the idea is that unconfined is allowed to talk to location-service | 18:55 |
| zyga-ubuntu | jdstrand: yes, I understand my mistake now | 18:56 |
| jdstrand | zyga-ubuntu: sigh, I did what you said for adglkh but the review is all messed up. see https://github.com/snapcore/snapd/pull/3587/files | 18:57 |
| mup | PR snapd#3587: Using udev tagging for snap interfaces <Created by adglkh> <https://github.com/snapcore/snapd/pull/3587> | 18:57 |
| zyga-ubuntu | jdstrand: let me look | 18:57 |
| jdstrand | zyga-ubuntu: eg, arch/arch.go. that isn't a change he made | 18:57 |
| zyga-ubuntu | note that you can always push --force to undo your changes | 18:58 |
| zyga-ubuntu | jdstrand: I refreshed the diff | 18:58 |
| zyga-ubuntu | jdstrand: I cannot see any changes to arch.go | 18:58 |
| * zyga-ubuntu goes to get some tea | 18:59 | |
| zyga-ubuntu | jdstrand: I'll be back shortly | 18:59 |
| jdstrand | zyga-ubuntu: https://github.com/snapcore/snapd/pull/3587/files | 19:00 |
| mup | PR snapd#3587: Using udev tagging for snap interfaces <Created by adglkh> <https://github.com/snapcore/snapd/pull/3587> | 19:00 |
| jdstrand | zyga-ubuntu: first thing shows arch/arch.go | 19:00 |
| jdstrand | tyhicks: hey, can you help me with a git thing? | 19:02 |
| tyhicks | jdstrand: what's up? | 19:02 |
| jdstrand | tyhicks: can you read backscroll between me and zyga? basically, I want to do the 'you can always push --force to undo your changes' | 19:03 |
| jdstrand | tyhicks: I want to get this back to 8401774d3b2f5fa2d7e59120d56988b92e5995c6 in the remote branch | 19:05 |
| kyrofa | jdstrand, create a new branch based on that commit: `git branch my-new-branch 8401774d3b2f5fa2d7e59120d56988b92e5995c6` | 19:06 |
| kyrofa | jdstrand, then force-push it back to the branch in the PR | 19:06 |
| kyrofa | `git push adglkh my-new-branch:udev_tagging --force` | 19:07 |
| kyrofa | (assuming your adglkh remote is called that) | 19:07 |
| tyhicks | I'd expect `git push --force adglkh 8401774d3b2f5fa2d7e59120d56988b92e5995c6:udev-tagging` to also work | 19:07 |
| kyrofa | Man that is so hard to type | 19:07 |
| jdstrand | neither works | 19:08 |
| jdstrand | ah, I typoed something | 19:09 |
| mup | PR snapd#3587 closed: Using udev tagging for snap interfaces <Created by adglkh> <Closed by jdstrand> <https://github.com/snapcore/snapd/pull/3587> | 19:09 |
| jdstrand | now all the changes are gone | 19:09 |
| jdstrand | jeez | 19:09 |
| jdstrand | and it says I closed it | 19:10 |
| jdstrand | maybe I picked the wrong commit | 19:10 |
| kyrofa | Hahaha, you still have your modified branch around I assume? | 19:10 |
| jdstrand | I do | 19:10 |
| kyrofa | Yeah, make sure you grabbed the right commit | 19:11 |
| tyhicks | "adglkh:udev_tagging was force-pushed and no longer has any new commits." | 19:12 |
| tyhicks | "Pushing new commits will allow the pull request to be re-opened." | 19:12 |
| tyhicks | I can help you with how to use git to do what you want to do but I'm not as much help in knowing what the result will be in the github web interface :/ | 19:13 |
| jdstrand | well, at this point I just want to go back to what he had | 19:13 |
| tyhicks | jdstrand: what's the name of the local branch representing his last changes? | 19:14 |
| kyrofa | jdstrand, can you push that branch to your fork? | 19:14 |
| jdstrand | tyhicks: ok. I have a local branch called adglkh.udev_tagging | 19:17 |
| tyhicks | jdstrand: it sounds like `git push adglkh adglkh.udev_tagging:udev_tagging` (try without --force first) will get the web ui back into shape | 19:17 |
| jdstrand | tyhicks: this was created with: git checkout -b adglkh.udev_tagging upstream/master ; git pull git@github.com:adglkh/snapd.git udev_tagging | 19:18 |
| zyga-suse | kyrofa: no need for a branch | 19:18 |
| jdstrand | tyhicks: that has a merge from master and a fix to opengl_test.go. ie, where I was before I tried to undo things | 19:18 |
| zyga-suse | hmm | 19:18 |
| zyga-suse | I see some things happened since I made tea | 19:18 |
| zyga-suse | (disclaimer, my lovely wife made tea and I just found it) | 19:18 |
| zyga-suse | jdstrand: note that you stil have the full history locally in your machine in reflog | 19:19 |
| zyga-suse | git reflog | 19:19 |
| tyhicks | it sounds like he already has a branch with full history so I didn't want to steer him towards reflog just yet | 19:19 |
| jdstrand | To git@github.com:adglkh/snapd | 19:19 |
| jdstrand | ! [remote rejected] adglkh.udev_tagging -> udev_tagging (permission denied) | 19:19 |
| ubottu | jdstrand: I am only a bot, please don't think I'm intelligent :) | 19:19 |
| jdstrand | error: failed to push some refs to 'git@github.com:adglkh/snapd' | 19:19 |
| jdstrand | that is from inside a checkout of adglkh.udev_tagging | 19:20 |
| tyhicks | I'm confused how you were able to write to that branch before if you're getting a permission denied error now | 19:21 |
| tyhicks | (I did think it was odd that you could write to someone else's branch but I wasn't sure how github branch perms work) | 19:22 |
| === cachio_afk is now known as cachio | ||
| kyrofa | tyhicks, github magic | 19:22 |
| kyrofa | tyhicks, when creating a PR there's a checkbox saying "allow modifications from maintainers" | 19:22 |
| tyhicks | ah | 19:23 |
| jdstrand | github seems to know that I don't know what I'm doing and took that away from me :P | 19:23 |
| jdstrand | I'm guessing when the PR was closed that was unchecked? | 19:23 |
| kyrofa | Ah, I bet so, indeed | 19:23 |
| kyrofa | Hahaha, so it let you kill his branch, but won't let you fix it. How kind | 19:24 |
| jdstrand | sigh, I was trying to help gary and I just created work for him | 19:24 |
| * zyga-suse looks | 19:24 | |
| zyga-suse | yeah, no more push there | 19:25 |
| zyga-suse | on the up side, atom has git and github integration now | 19:25 |
| zyga-suse | so when git command line bites, there's a nice UI around the corner | 19:25 |
| zyga-ubuntu | jdstrand: btw, not security related really but maybe you're interested in 3399 | 19:28 |
| jdstrand | zyga-ubuntu: ack | 19:33 |
| zyga-suse | jdstrand: thank you | 19:34 |
| zyga-suse | jdstrand: there's going to be a similar for connections | 19:34 |
| zyga-suse | jdstrand: that will largely replace "snap interfaces" (with an s) | 19:34 |
| tyhicks | jdstrand: did you ever figure out what the problem was? was that the wrong commit? | 19:41 |
| jdstrand | tyhicks: I think so yes; I should've used e9a9366d74fe70b966d6020877efdd55a28675dd, which was gary's last commit | 19:43 |
| tyhicks | ok | 19:44 |
| jdstrand | there was something which made me think it was the other commit but since everything is gone I can't say what. sigh | 19:45 |
| zyga-ubuntu | reflog knows the truth :) | 19:45 |
| jdstrand | I did push up my branch which has all his commits: https://github.com/snapcore/snapd/compare/master...jdstrand:adglkh.udev_tagging?expand=1 | 19:46 |
| jdstrand | so the work is not gone. I left a comment in the pr | 19:46 |
| bladernr | This seems kinda stupid, but how do you install a text editor on Ubuntu Core to edit config files that need to exist in snaps? For example, if I need to edit the hosts file for the dnsmasq snap to work as a DNS server, the only option I can find is vi, I'd much rather have VIM. I can install a pinano snap to get Nano, but it won't allow me to edit anything outside of the snap itself, making it a bit useless. Did I | 19:51 |
| bladernr | miss something for installing pinano? | 19:51 |
| bladernr | Maybe it needs to be in classic mode? or dev mode? | 19:51 |
| zyga-suse | bladernr: hey, you can snap install classic | 19:53 |
| zyga-suse | (not sure if it is in --edge or stable now) | 19:53 |
| bladernr | zyga-suse, thanks.. looks like --edge, installing now. | 19:58 |
| zyga-ubuntu | bladernr: great o/ | 20:01 |
| bladernr | zyga-ubuntu, ummm.... so classic is installed. How to I get into "classic" mode? | 20:05 |
| bladernr | bladernr@localhost:~$ snap install --classic pinano | 20:05 |
| bladernr | error: cannot install "pinano": classic confinement is only supported on classic systems | 20:05 |
| zyga-ubuntu | bladernr: it's a snap, run the app | 20:06 |
| zyga-ubuntu | bladernr: you cannot install classic confinement snaps | 20:06 |
| zyga-ubuntu | bladernr: but inside clasic the snap you can install vim with apt-get | 20:06 |
| bladernr | ahhhh ok | 20:07 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!