| menn0 | axw: ping | 01:03 |
|---|---|---|
| axw | wallyworld: finally got this up, can you please take a look when you're free? https://github.com/juju/juju/pull/7675 | 03:00 |
| wallyworld | sure | 03:00 |
| axw | wallyworld: apologies for the size | 03:00 |
| wallyworld | that's that they all say | 03:00 |
| wallyworld | axw: did you want to fix the conflicts in that brnch? | 04:24 |
| axw | wallyworld: yep, in progress | 04:24 |
| axw | wallyworld: done, sorry about that | 04:57 |
| wallyworld | np | 04:57 |
| wpk | wallyworld axw: Q: do you think that placement directive (--to <foo>, add-machine <foo>) should ignore model constraints? | 05:21 |
| axw | wpk: yes | 05:21 |
| wallyworld | i would hace though tso | 05:21 |
| wallyworld | the user is asking for a specific machine | 05:21 |
| wpk | ok | 05:23 |
| wallyworld | axw: lgtm, faer out, how many more env->model cases will we find; it's never ending | 05:29 |
| axw | wallyworld: heh yeah :/ | 05:29 |
| axw | wallyworld: thanks | 05:29 |
| wallyworld | sure | 05:29 |
| axw | wallyworld: the cleanup args thing felt a bit yucky, don't suppose you had any ideas on alternatives? | 05:30 |
| wallyworld | axw: not really. it seemed ok to me tbh | 05:30 |
| axw | wallyworld: ok | 05:31 |
| wallyworld | i mean we could encode specific attrs in the struct, but generic args is ok too? | 05:31 |
| === frankban|afk is now known as frankban | ||
| rogpeppe | is anyone around that might be able to do a second review on this goose swift change, please? https://github.com/go-goose/goose/pull/54 | 09:34 |
| rogpeppe | i've got one review but it's reasonably involved code, so i'd really like another | 09:35 |
| stokachu | axw: are you still online? | 12:35 |
| === frankban is now known as frankban|afk | ||
| wallyworld | rick_h: you around for 1:1? | 22:02 |
| rick_h | wallyworld: yep omw | 22:04 |
| === akhavr1 is now known as akhavr | ||
| babbageclunk | axw_: some reviews for you! https://github.com/juju/1.25-upgrade/pulls | 23:33 |
| babbageclunk | axw_: (if that really is you) | 23:33 |
| * babbageclunk narrows eyes | 23:33 | |
| axw_ | babbageclunk: okey dokey. probably won't get to it until after school dropoff | 23:33 |
| === axw_ is now known as axw | ||
| babbageclunk | axw_: cool cool. Also don't get freaked out by the line counts! :) | 23:34 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!