[01:03] axw: ping [03:00] wallyworld: finally got this up, can you please take a look when you're free? https://github.com/juju/juju/pull/7675 [03:00] sure [03:00] wallyworld: apologies for the size [03:00] that's that they all say [04:24] axw: did you want to fix the conflicts in that brnch? [04:24] wallyworld: yep, in progress [04:57] wallyworld: done, sorry about that [04:57] np [05:21] wallyworld axw: Q: do you think that placement directive (--to , add-machine ) should ignore model constraints? [05:21] wpk: yes [05:21] i would hace though tso [05:21] the user is asking for a specific machine [05:23] ok [05:29] axw: lgtm, faer out, how many more env->model cases will we find; it's never ending [05:29] wallyworld: heh yeah :/ [05:29] wallyworld: thanks [05:29] sure [05:30] wallyworld: the cleanup args thing felt a bit yucky, don't suppose you had any ideas on alternatives? [05:30] axw: not really. it seemed ok to me tbh [05:31] wallyworld: ok [05:31] i mean we could encode specific attrs in the struct, but generic args is ok too? === frankban|afk is now known as frankban [09:34] is anyone around that might be able to do a second review on this goose swift change, please? https://github.com/go-goose/goose/pull/54 [09:35] i've got one review but it's reasonably involved code, so i'd really like another [12:35] axw: are you still online? === frankban is now known as frankban|afk [22:02] rick_h: you around for 1:1? [22:04] wallyworld: yep omw === akhavr1 is now known as akhavr [23:33] axw_: some reviews for you! https://github.com/juju/1.25-upgrade/pulls [23:33] axw_: (if that really is you) [23:33] * babbageclunk narrows eyes [23:33] babbageclunk: okey dokey. probably won't get to it until after school dropoff === axw_ is now known as axw [23:34] axw_: cool cool. Also don't get freaked out by the line counts! :)