/srv/irclogs.ubuntu.com/2017/07/27/#snappy.txt

=== JanC_ is now known as JanC
zyga-susegood morning06:46
mvohey zyga-suse, good morning06:47
zyga-susemvo: hey,06:47
zyga-susemvo: did you see https://forum.snapcraft.io/t/simplenote-snap-cannot-stat-var-lib-snapd-seccomp-bpf-no-such-file-or-directory/1446/9 ?06:48
zyga-susemvo: I thought this is another instance of the rrexec bug from last week but I'm not so sure anymore06:52
zyga-suseI found it interesting that half of snapd reexecuted06:53
zyga-susebut the rest did not06:53
zyga-ubuntumvo: I'll grab some food and I'll be back soon to do code reviews06:58
mvozyga-ubuntu: yeah, will do the same06:58
mvozyga-ubuntu: interessting bug :/06:59
mupPR snapd#3614 closed: daemon, client, cmd/snap: implement "snap services" <Created by chipaca> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/3614>07:14
zyga-susemvo: last night gustavo asked everyone to upgrade spread07:24
zyga-ubuntuI wrote a test simulating 2.0.2 and re-execing snapd, let's see how it works07:29
* zyga-suse wonders what the movie crew outside is doing?07:34
zyga-suseI need a 2nd review for 361907:36
zyga-susethey are shooting a TV show outside now07:38
* zyga-suse wonders what's going on07:38
pedroniszyga-suse: why each of this check that the interface match?  shouldn't this be done before/somewhere in the caller?  is there a case where that shouldn't hold?07:39
zyga-susepedronis: I think we never call this incorrectly but this is part of the code that was written veeery long time ago07:39
zyga-susepedronis: and I think we just kept the cross-checking semantics07:39
zyga-susepedronis: I wasn't trying to change it, just improve how it is done07:40
pedroniswell, given we are cleaning up, I question why not clean up even more07:40
pedronisnotice that pawel will have to touch these again btw07:40
pedronisnew names, new signatures07:40
zyga-suseaha, indeed07:40
zyga-susewell, I can yank the sanitize calls if you feel strongly about them07:41
zyga-susein theory this ensures that we are not, by mistake, allowing sanitize to pass with a wrong interface07:41
pedronisI don't feel strongly but you are asking to check you put everywhere something, where that probably means it's done in the wrong place07:41
zyga-suseI think it's more of a security paranoia at play; I just checked how we call Sanitize and we always call it with a matching interface that is looked up from the Interface field07:44
zyga-suseso again, I can remove it as there seems to be no harm done07:44
pedroniswell, you can define helpers on repo07:45
pedronissanitizePlug  and sanizeSlot07:45
pedronisthat would do the check07:45
pedronisif you feel the paranoia is worth07:45
pedronisit's a bit strange to ask everybody writing an interface to help taking of this paranoia07:46
zyga-susethey are taking another shot of the same scene07:46
zyga-suseindeed07:46
pedronisthis things are called in 4 places at all07:46
zyga-susethough I think we had those helpers and they were nacked before (they checked for any panics as well)07:46
pedronisI think Gustavo was gainst the catching panics07:46
pedronisnot the helpers07:47
zyga-suseI think you are right07:47
zyga-suselet me put private helpers in the repo and drop the checks in each interface then07:47
pedronisyou could even have private helpers sanitize on Slot and Plug themselves07:49
zyga-susehmm, interesting07:49
zyga-suselet me experiment07:49
zyga-suse(and another shot)07:50
pedronismmh07:52
pedronissorry07:52
zyga-suseabout what?07:52
pedronisnothing was thinking something07:53
zyga-susemvo: ha08:18
zyga-susemvo: so weird08:18
zyga-susemvo: if I start with 2.0.208:18
zyga-susemvo: there's no core transition yet08:18
zyga-suseso.... we're on 2.0.2 forever08:18
zyga-suse(and ever and ever)08:18
zyga-suseit seems08:18
zyga-susenot sure if we can even do anything about it08:19
mvozyga-suse: does 2.0.2 do re-exec?08:20
zyga-susenope08:24
zyga-suseI don't see any traces of that08:24
mvozyga-suse: then there is really nothing we can do :/08:24
mupPR snapd#3615 closed: add broadcom-asic-control interface <Created by knitzsche> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/3615>08:24
zyga-suseI think we only managed to do it for a later version that was also in debian stable08:24
zyga-susemvo: yep, I just found this very unfortunate as this is the version the reporter of that bug was using08:25
mvozyga-suse: I mean, without re-exec its irrelevant if it fetches core or ubuntu-core. in general if things re-exec it will work even if ubuntu-core is used. then it will fetch ubuntu-core re-exec into that snapd and that snapd will transition to core08:25
mvozyga-suse: version 2.21 is doing re-exec but we had a experimental re-exec in some earlier versions that got disabled again. iirc 2.0.10 is also re-execing08:26
mvozyga-suse: unfortunate> totally :/08:26
zyga-susemvo: one idea, unpublish ubuntu-core08:26
zyga-suseor even tweak the store to say something like "update your snapd package"08:26
zyga-suseas an error message, if one can be shoved to 2.0.208:26
mvozyga-suse: if people start from a version that fetches ubuntu-core, thats fine, things will work.08:28
zyga-susedo we know which version is requesting the snap?08:28
mvozyga-suse: I mean, the problem with 2.0.2 is that it is not doing re-exec at all. or am I missing something?08:28
zyga-susemaybe we could reject ubuntu-core on 2.0.2 installs08:28
zyga-susemvo: yes, that's the problem08:28
zyga-suseand somehow people keep having it because it's on the ISO08:28
mvozyga-suse: aha, I see. well, ideally the store would reply to every request from 2.0.2 with "please upgrade your snapd". so +1 for this proposal, we just need to check if the error message is visiable to the end-user08:31
zyga-susenow we just need to check with store people to see if we can craft this08:31
zyga-ubu1tuChipaca: o/08:36
=== zyga-ubu1tu is now known as zyga-ubuntu
Chipacazyga-ubuntu: \o08:36
mvozyga-ubuntu: does 3591 look good to you?08:38
mvozyga-ubuntu: you did a review before and jamie addressed things afaict08:38
mvohey Chipaca08:38
Chipacamvo: how's things with you?08:38
zyga-susemvo: just a sec08:39
zyga-ubuntumvo: I wrote a forum topic on the 2.0.2 problem https://forum.snapcraft.io/t/snapd-2-0-2-doesnt-reexecute-pulls-in-ubuntu-core-stays-stale/145508:39
zyga-ubuntumvo: yep, +108:40
mvoChipaca: doing well, finally doing reviews :)08:40
mvoChipaca: and you?08:40
Chipacamvo: no longer working on 'snap status'!08:40
zyga-ubuntuChipaca: congrats on merging your PR08:40
* Chipaca dances08:41
Chipacaof course, the next one is 'snap logs', so... :-)08:41
Chipaca¯\_(ツ)_/¯08:41
zyga-ubuntuChipaca: just put an easter egg when you run "snap logs everything"08:41
mupPR snapd#3591 closed: interfaces/greengrass-support: adjust accesses now that have working snap <Created by jdstrand> <Merged by zyga> <https://github.com/snapcore/snapd/pull/3591>08:41
zyga-ubuntucould be an ester egg theme08:41
Chipacazyga-ubuntu: I couldn't possibly comment08:42
mvoChipaca: yay!08:47
ppisatiogra_: since when we required the dtb to be part of the kernel snap? wasn't it supposed to be part of the gadget snap?09:50
zyga-suseppisati: it was discussed in london, the idea is that it is tied to the kernel snap as the kernel may or may not boot depending on the dbt that is used10:07
zyga-suseppisati: (in the pi specific case)10:07
ppisatizyga-suse: ok10:07
zyga-suseppisati: https://forum.snapcraft.io/t/development-sprint-june-26th-2017/415/46?u=zyga10:11
ogra_ppisati, it is only part of the gadget for pi ... all other boards use it from the kernel snap10:35
ogra_ppisati, and what we discussed in london was to move for the pi to the same model and additionally include the binary blobs in the kernel snap10:36
ogra_ppisati, essentially everything that is version wise bound together will go into the kernel snap on pi ... making us lose any kind of rollback for the kernel though10:37
ppisatiogra_: ack10:40
zyga-ubuntuchanging anything about interfaces in genral is a chore11:26
morphismvo, zyga-ubuntu: do you guys have time to look at https://github.com/snapcore/snapd/pull/3260 ?11:26
mupPR snapd#3260: cmd/snap: implement userd command as replacement for snapd-xdg-open <Created by morphis> <https://github.com/snapcore/snapd/pull/3260>11:26
zyga-ubuntumorphis: not at present11:27
morphishm11:27
zyga-ubuntuI'm wrapping up stuff to switch to packaging and layouts11:27
zyga-ubuntumaybe after packaging11:27
flexiondotorgTrevinho Afternoon. What is the current status of your Telegram snap?11:32
Trevinhoflexiondotorg: hey11:32
Trevinhoflexiondotorg: I've replied to an email from popey some weeks ago about it..11:32
flexiondotorgCan you forward that to me please?11:32
Trevinhoflexiondotorg: basically, it needs work... Which I might do to finish if there's interest and we can have proper upstream contacts11:33
Trevinhoflexiondotorg: sure I can11:33
flexiondotorgThanks.11:33
flexiondotorgDoes the email outline what work is required?11:33
* zyga-ubuntu uses telegram snap all the time, would love to see upstream adopt it11:34
* ogra_ uses sergios telegram snap ... 11:38
ogra_i didnt even know Trevinho has one as well !11:40
Trevinhoogra_: mine is basde on sources11:40
Trevinhoogra_: but I didn't publish on store11:40
Trevinhoogra_: or well not public11:40
ogra_ah11:40
TrevinhoI wanted to get snapcraft to do the cool job of compilinng all the ellemtns and such11:40
Trevinhoas they do upstream..11:40
Trevinhoogra_: there is an email I sent to canonical-snapcraft ML11:41
ogra_ages ago ... i remember that11:42
Trevinhoflexiondotorg: sent11:42
flexiondotorgty11:42
ChipacaTrevinho: flexiondotorg: what's the relation between your telegram snap and sergiusen's?11:44
TrevinhoChipaca: none..11:45
TrevinhoChipaca: sergio's one takes the upstream built telegram and ships it11:45
Trevinhomine takes upstream code, and builds it as telegram does11:45
Trevinhoit doesn't sign the binary of course, as it's something they only can do11:46
zyga-ubuntupedronis: 3619 updated11:54
pedroniszyga-ubuntu: did you change anything in core/repo ?12:02
zyga-ubuntupedronis: I'm adding {plug,slot}.Sanitize12:03
zyga-ubuntuand making Sanitize{Plug,Slot} optional :D12:03
pedronisin the branch ?12:03
zyga-ubuntuyep12:03
pedronisbut not yet?12:04
zyga-ubuntuI just pushed the initial huge patch in case I missed something there12:04
zyga-ubuntuin a moment12:04
pedroniscachio: hi, I'm getting this unrelated errors on this branch, quite regularly:  https://travis-ci.org/snapcore/snapd/builds/257198925?utm_source=github_status&utm_medium=notification  do I need to merge branch or they new problems12:56
cachiopedronis, taking a look12:56
pedronismerge trunk12:57
=== sergiusens_ is now known as sergiusens
magicaltrouthello folks13:02
magicaltroutrandom snap creation question13:02
magicaltroutif I use the maven plugin to build some archive13:02
magicaltroutcan i then use something to extract the finished tarball?13:02
magicaltroutor use the dump plugin to extract stuff from a previous part?13:07
ogra_snapcraft keeps every by-product around after build ... so yes, if there is a tarball created, you will find it somewhere in your build directory13:08
ogra_btw, http://rocket.ubuntu.com is probably the better place for snapcraft questions13:08
ogra_(there is a #snapcraft channel)13:09
magicaltroutaww but that involves more browser tabs13:09
ogra_snap install rocketchat-desktop13:09
ogra_;)13:09
ogra_no tabs needed13:09
mupPR snapcraft#1403 closed: lxd: Only remove container if one exists <Created by kalikiana> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1403>13:21
ogra_morphis, hey13:24
morphisogra_: hey13:25
ogra_morphis, could i bribe you for a second ack on https://github.com/snapcore/pi3-gadget/pull/11 (already tested and ondra reviewed and approved it already)13:25
mupPR pi3-gadget#11: build uboot from source, pull blobs from upstream, use dtbs from archive <Created by ogra1> <https://github.com/snapcore/pi3-gadget/pull/11>13:25
morphisogra_: sure13:26
morphiswill have a look in a bit13:26
* ogra_ hugs morphis 13:26
morphis:-)13:26
zyga-ubuntufg13:26
zyga-ubuntubg13:26
zyga-ubuntuah13:26
zyga-ubuntudarn )13:26
ogra_pick the middle ground ... thats the best compromise13:27
fgimenezcachio: you can point the suite to staging with "export SPREAD_REMOTE_STORE=staging" before executing13:35
cachiofgimenez, ok, thanks13:36
fgimenezcachio: np, this is the forum post with the beta validation details https://forum.snapcraft.io/t/core-snap-validation-process-at-beta-channel/145413:41
cachiofgimenez, great!!!13:42
fgimenezzyga-ubuntu: this is the error in the orangepi using the latest core from edge https://forum.snapcraft.io/t/how-to-use-spread-to-test-ubuntucore-image/1323/44?u=fgimenez13:47
fgimenezzyga-ubuntu: if you could take a look that would be great, it seems to pass with core from beta13:49
zyga-suseack13:49
zyga-suseI'll check it out after lunch13:49
fgimenezzyga-suse: great, thanks!13:55
zyga-susemvo: did you push that parser branch by any chance?14:21
zyga-ubuntumvo: we hit the hook issue again14:22
zyga-ubuntu- Run install hook of "core" snap if present (internal error: no registered handlers for hook "install")14:22
zyga-ubuntu :/14:22
=== sergiusens_ is now known as sergiusens
pedroniszyga-ubuntu: is that on a revert?14:24
zyga-ubuntuhttps://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-zesty-snappy-dev-image/zesty/amd64/s/snapd/20170727_125232_a75a6@/log.gz14:24
zyga-ubuntuupgrade/basic14:24
mvozyga-ubuntu: meh, how annoying14:27
zyga-susefeels like a blocker to me14:29
zyga-susewe need to understand what is going on14:29
fgimenezit happened on amd64 this time, yesterday it was i38614:30
zyga-ubuntuI think it is random14:30
zyga-ubuntusomething is racing there14:30
ogra_hmm14:35
ogra_ogra@styx:~/tmp$ snap run --shell hello-world14:35
ogra_To run a command as administrator (user "root"), use "sudo <command>".14:35
ogra_See "man sudo_root" for details.14:35
ogra_why do i get that sudo hint ?14:35
Chipacaof course the only path I didn't unit test has a off-by-one panic14:38
zyga-susehuh, interesting14:38
* Chipaca hugs everything14:38
zyga-suseis that done by profilerc perhaps?14:39
zyga-susehehe14:39
Slashmanhello, I'm stuck on debian 9 after "snap install lx" with "[/] Run configure hook of "core" snap if present", any idea how I can solve this?15:03
zyga-suseSlashman: hey15:04
zyga-susehmm15:04
zyga-susemvo: ^15:04
zyga-suseSlashman: I think rebooting will just fix that15:04
zyga-suseand after that it will work OK15:04
Slashmanzyga-suse: ok, I wanted to avoid that but oh well15:04
zyga-susetechincally15:05
ogra_well, it is a bug ...15:05
zyga-susetry this:15:05
zyga-susesudo umount /run/snapd/ns/core.mnt15:05
Slashmantoo late, I just rebooted :p15:05
zyga-suseah15:05
zyga-suse:D15:05
zyga-suseok15:05
zyga-suseanyway, rebooting is easier to explain15:05
zyga-suseogra_: yes, but a pretty obscure one15:05
zyga-suseit's not obvious what is going on15:06
ogra_yeah, i just meant to say that it isnt normal that you have to reboot for anything *snap15:06
Slashmanhm, now I have 'error: cannot install "lxd": snap "lxd" has changes in progress'15:06
Slashmansnap list doesn't list lxd15:07
zyga-suseSlashman: what does snap changes say?15:07
Slashman"1    Doing   2017-07-27T14:51:42Z  -                     Install "lxd" snap"15:07
zyga-susesnap change 115:07
Slashmanhttps://apaste.info/GmKr15:08
zyga-suseSlashman: is it stuck there now?15:09
zyga-suseyou can perhaps kill snapctl process (it should be stuck somewhere)15:09
Slashmanhow can I know ?15:09
zyga-susethat will unblock it15:09
zyga-suseit should finish in a few seconds15:09
zyga-suseif not it's the bug15:09
Slashmansnapctl is already dead it seems: https://apaste.info/1hOT15:10
Slashmanwell I killed it15:11
Slashmannot sure if the error are a real issue: https://apaste.info/rut015:12
zyga-susehmmm15:12
zyga-suseman15:12
zyga-susemvo: ^^15:12
Slashmanhttps://apaste.info/qrre15:12
zyga-suseyeah it's gone15:13
zyga-suseplease unmount /run/snapd/ns/core.mnt15:13
zyga-susesudo snap install core15:13
zyga-suseand let's see if that works15:13
zyga-susewhich version of snapd are you on right now? 2.21 something?15:13
mvoSlashman: what is the output of "snap version"?15:13
Slashmanyeah, the one on debian 915:13
Slashman2.21-215:13
mvoSlashman: "snap version" may give different numbers, snapd will try to use bits from the core if it can15:14
Slashmanok, here is the output: https://apaste.info/Vqic15:14
zyga-suseok15:15
zyga-susemvo: again15:15
zyga-susesame case as https://forum.snapcraft.io/t/simplenote-snap-cannot-stat-var-lib-snapd-seccomp-bpf-no-such-file-or-directory/1446/915:15
Slashmananyway I can make it work?15:16
mvozyga-suse: yeah, snapd restarted, configure failed and it reverted to 2.21 but did not restart the new snapd15:16
mvoSlashman: sudo systemctl restart snapd should bring it back to normal operation. then "snap install core"  - would be interessting to see if that works15:17
ogra_what a mess :(15:17
mvoyes, re-exec has a problem we have not found yet on debian15:17
Slashmanseems to work, one strange info message but I see the core snap: https://apaste.info/1z6015:18
Slashmantrying lxd now15:18
ogra_devmode ?!?15:18
mvoSlashman: and snap version should how now that you are on 2.26.14 - does it do that?15:18
Slashmanindeed15:19
zyga-suseogra_: that's been fixed post 2.21, I think new snapd will correct that15:19
mvoSlashman: could you try something trivial like snap install hello ?15:19
ogra_ah, k15:19
SlashmanI just installed the lxd snap15:19
ogra_irritating though ... :)15:19
mvoSlashman: even better!15:19
Slashmanmvo: https://apaste.info/olsa15:19
mvozyga-suse: I suspect it has something to do with "snap install $thing" without core, i.e. the implicit download of core15:19
zyga-susemvo: we need a debian-9 out of the box test ra15:19
zyga-susemvo: yes15:20
zyga-susemvo: I agree15:20
mvoSlashman: yes, that looks better :)15:20
zyga-susemvo: note that we don't have a debian 9 linode image15:20
mvozyga-suse: yeah, I have a debian-9 and couldn't find a way to reproduce the error in there :/15:20
Slashmanso, if I understand correctly, after snap installation, I should: 1) reboot 2) snap install core 3) systemctl restart snap 4) snap install core ?15:20
ogra_Slashman, normally not ... but yes15:21
zyga-suseSlashman: I think we don't know yet15:21
ogra_:P15:21
zyga-suseSlashman: umounting one special file and restarting snapd is the trick15:21
zyga-susebut we're hazy on the details15:21
ogra_Slashman, the normal behaviour is that you snap install lxd and it automagically pulls in core first without you having to do anythinng15:21
Slashmanyeah, I understand that's not the normal behavior :D15:22
Slashmanbut until it is fixed, I'll have to document it my team doesn't get stuck trying to install it15:23
Slashmananyway, thank you for your help guys!15:24
mupPR snapd#3630 opened: many: implement "snap logs" <Created by chipaca> <https://github.com/snapcore/snapd/pull/3630>15:29
zyga-suseSlashman: thank you for reporting this, we're sorry for the bad experience15:29
Chipaca^ "snap logs" \o/15:29
zyga-ubuntuChipaca: nice!!15:29
Chipacafavourite thing i learned: http.Flusher15:29
Chipaca(making "snap logs -f" nice an' responsive)15:30
zyga-susewhat is it?15:30
Slashmanzyga-suse: don't worry about it, I'm grateful that snap exists ;)15:30
zyga-suseflush an ongoing log?15:30
zyga-suselike tail -f?15:30
zyga-suseSlashman: thank you! :-)15:31
Chipacazyga-suse: http.ResponseWriter can optionally also be an http.Flusher15:31
Chipacazyga-suse: if it is, then you can call w.Flush()15:31
Chipacaand it flushes the writer15:31
Chipacathe default writers are flushers15:31
Pharaoh_Atem😩15:31
* Chipaca hugs Pharaoh_Atem 15:32
Pharaoh_Atem😫15:32
ChipacaPharaoh_Atem: what's wrong?15:32
Pharaoh_AtemI was working late last night on a maint window and it went wrong15:32
Chipacaouh :-(15:32
zyga-suseouch15:32
Pharaoh_Atemso now I'm really tired today15:34
* Chipaca sends cake15:35
mvofgimenez, cachio: 2.27~rc4 for testing is now available in beta15:35
* mvo hugs Pharaoh_Atem15:35
Pharaoh_Atemzyga-suse: I don't suppose you've fixed 32-bit arches for fedora yet on snap-seccomp>15:36
Pharaoh_Atem?15:36
mvoChipaca: nice, I learned something new!15:36
Pharaoh_Atemzyga-suse: it's the same thing that bit us before with snap-confine a long time back15:37
zyga-suseno, I'm still burried15:37
zyga-susesorry :/15:37
Pharaoh_Atemzyga-suse: could you please fix it before mvo makes 2.27?15:43
Pharaoh_AtemI'd really rather not have to skip 2.27 :(15:43
mcphailIs it safe to remove old revisions of the core snap?15:44
zyga-suseyeah, I think it should be easy15:44
zyga-susemvo: when do you want to tag 2.27?15:44
zyga-susemcphail: yes15:44
mcphailzyga-suse: thanks!15:45
Pharaoh_Atemwe should also probably add an i686 fedora test15:45
Pharaoh_Atemto make sure we don't break this again15:45
zyga-ubuntuI don't know if we have a compatible i386 image in linode today15:46
zyga-ubuntubut totally agreed otherwise15:46
zyga-susepedronis: pushed with all the stuff I wanted15:53
zyga-suseoh wow15:53
zyga-susegithub has a new "jump to symbol" feature!15:53
pedronissorry chasing something completely different15:54
zyga-susepedronis: no worries15:54
zyga-suse-1449 +61815:54
zyga-susemy fingers hurt15:54
ogra_from running rm ?15:55
ogra_:P15:55
zyga-suseI think pawel's work will be easier now16:03
zyga-suse1722 removed16:03
zyga-suseonly 24 actual non-empty sanitize functions left16:04
* zyga-ubuntu -> coffee 16:07
* genii sips16:08
fgimenezmvo: \o/ thanks a lot, cachio want to give it a try? :)16:26
cachiofgimenez, mvo sure, I'll do16:27
cachiofgimenez, starting now16:28
fgimenezcachio: great thanks a lot, pls let me know how it goes and if i can be of any help, i think the forum post has all the details, let's see16:29
cachiofgimenez, I'll follow that16:29
fgimenezcachio: cool thank you16:29
cachiofgimenez, yaw16:30
mupPR snapd#3631 opened: tests: apply underscore convention for SNAPMOUNTDIR variable <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/3631>16:45
zyga-ubuntumvo: do you intend to investigate the debian issue?16:47
zyga-ubuntuif not I can pick that up16:47
zyga-ubuntuChipaca: why don't you write longer commit messages?16:50
cachiomvo, if you have 1 minute to look at PR 363116:52
cachioit is trivial but large16:52
zyga-ubuntucachio, mvo: note that I'd like to squash merge it16:52
zyga-ubuntuthere's a lot of junk in the history for a patch like that16:53
cachiozyga-ubuntu, yes, trying to fix that16:53
cachionot sure why it is showing the history16:53
zyga-ubuntuI can explain later, for now it's just a matter of squash merging that16:53
cachiobut most of the commits are already merged16:53
zyga-ubuntualternatively you can squash locally and push that over16:54
cachiozyga-ubuntu, i'll try that16:54
zyga-ubuntucachio: git rebase -i origin/master16:54
zyga-ubuntusquash everything16:54
zyga-ubuntuand reuse the commit message from the PR (I edited it)16:54
zyga-ubuntucachio: also if you do this, please pull16:57
zyga-ubuntucachio: I pushed one patch into your branch16:57
zyga-ubuntucachio: did you force push?17:06
zyga-ubuntucachio: my commit is gone and the whole history is there still17:06
cachiozyga-ubuntu, I found the problem why it is showing all the commits17:06
cachioone sec17:06
cachiozyga-ubuntu, I'll create a new Pr17:12
zyga-ubuntucachio: stop17:12
zyga-ubuntucachio: why?17:12
zyga-ubuntucachio: let me show you how to fix this, ok?17:12
zyga-ubuntucachio: do you want to hop on a hangout?17:12
cachioI had differences between origin/master and upstream/master17:12
zyga-ubuntucachio: (why do you think a new PR is needed)17:12
zyga-ubuntuanyway17:12
cachiozyga-ubuntu, so I reset my master and then merged17:12
zyga-ubuntummm17:12
zyga-ubuntuwhy didn't you do what I said earlier?17:13
zyga-ubuntugit fetch origin; git rebase -i origin/master; squash everything17:13
zyga-ubuntuyou have one commit then17:13
zyga-ubuntuyou can review it to ensure it's sane17:13
zyga-ubuntuthen push that over this17:13
cachiozyga-ubuntu, tried, but ti was not fixing the root cause17:13
zyga-ubuntuin which way?17:13
zyga-ubuntucan we do that together?17:13
zyga-ubuntucachio: I'll join the standup HO17:14
cachiojust a minute, letme try to rebase the branch17:14
* zyga-ubuntu takes a break and will look at the hook issue breaking everything on master now17:31
zyga-ubuntuI wonder why it doesn't show up in spread linode, just autopkgtest17:31
zyga-ubuntumvo: can this be related to autopkgtest talking directly to DC vs the CDN?17:31
zyga-ubuntuand getting some weird different copy of the core?17:31
=== cachio is now known as cachio_afk
* zyga-ubuntu installs debian 9 to explore the bug17:50
=== cachio_afk is now known as cachio
cachioChipaca, could you please take a quick view to the PR 363119:38
cachioChipaca, I would like to merge it asap  :)19:39
mupPR snapcraft#1424 opened: Release changelog for 2.33 <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/1424>20:30
cachioChipaca, there?21:25
mupPR snapcraft#1425 opened: options: properly handle missing compiler prefix <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1425>22:30
=== JanC_ is now known as JanC
=== ondra_ is now known as ondra
=== souther_ is now known as souther
=== sarnold_ is now known as sarnold
=== cjwatson_ is now known as cjwatson
=== AdmWiggin is now known as tianon

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!