| wallyworld | anastasiamac: sure, sorry i had to go out and buy a new sim card as someone took my phone at soccer last night :-( | 00:22 |
|---|---|---|
| anastasiamac | wallyworld: that's awful!! all these contacts and messages and saved games... :( | 00:25 |
| wallyworld | yeah | 00:26 |
| anastasiamac | wallyworld: oh... just sim? u mean u had to get a new phone too, right?... | 00:26 |
| anastasiamac | wallyworld: what did u get? | 00:26 |
| wallyworld | i have a spare for now | 00:26 |
| anastasiamac | u mean like a very old, very heavy, very dusty one? :) | 00:27 |
| wallyworld | pretty much | 00:27 |
| menn0 | menn0: great * 2 | 00:45 |
| babbageclunk | axw: Forgot to say, I reviewed https://github.com/juju/1.25-upgrade/pull/13 | 00:58 |
| axw | babbageclunk: gracias | 01:19 |
| axw | babbageclunk: actually my prefixWriter implementation is broken :) fixing now... | 01:38 |
| menn0 | babbageclunk: would mind joining a call pls? I suspect you have some state which will help | 01:48 |
| menn0 | babbageclunk: https://hangouts.google.com/hangouts/_/canonical.com/menno-tim | 01:48 |
| babbageclunk | menn0: sure | 01:51 |
| wallyworld | menn0: this commit (on the followup pr) refactors the api calling to be more clear as per your other pr request. if you are happy, i'll merge the 2 prs together and land https://github.com/wallyworld/juju/pull/44/commits/011102c8d3768389aa0961795e0b5eaf40a8a38d | 01:58 |
| wallyworld | menn0: and it also exposed a bug which resulted in a test change | 02:03 |
| menn0 | wallyworld: cool. i'm in a call but will look after. | 02:04 |
| wallyworld | np | 02:04 |
| menn0 | wallyworld: that commit looks great. exactly what I was thinking. happy for that to land. | 02:24 |
| axw | babbageclunk: I've updated https://github.com/juju/1.25-upgrade/pull/13 | 02:34 |
| babbageclunk | axw: thanks - on a call, but I'll look after | 02:50 |
| mup | Bug #1709520 opened: juju-db spams syslog, fills disk <juju-core:New> <https://launchpad.net/bugs/1709520> | 03:19 |
| babbageclunk | axw: Thanks, that's heaps better. | 04:19 |
| axw | babbageclunk: cool, thank you | 04:19 |
| menn0 | wallyworld: another look at https://github.com/juju/juju/pull/7710 pls | 05:43 |
| wallyworld | menn0: sure | 05:46 |
| wallyworld | menn0: lgtm with a couple of todos for the state pool stuff we discussed | 05:56 |
| === frankban|afk is now known as frankban | ||
| === hml_ is now known as hml | ||
| === frankban is now known as frankban|afk | ||
| balloons | just fyi all CI is paused for a little bit; this includes check merge jobs. | 20:34 |
| babbageclunk | wallyworld: around? | 21:57 |
| wallyworld | babbageclunk: hi | 22:01 |
| babbageclunk | wallyworld: fixing a weird status bug and trying to understand an existing test - the expected output seems wrong. | 22:02 |
| babbageclunk | wallyworld: got time for a ho? | 22:02 |
| wallyworld | sure | 22:02 |
| wallyworld | standup | 22:02 |
| babbageclunk | wallyworld: here's what it would look like: http://paste.ubuntu.com/25279863/ | 22:35 |
| babbageclunk | wallyworld: not sure about the headings - I guess consumes feels wrong now that we have offer/consume. | 22:37 |
| wallyworld | babbageclunk: i don't think we need extra columns, but perhaps the endpoint names could be tabbed out like in Go with var/type blocks | 22:37 |
| wallyworld | yeah, maybe Requires | 22:37 |
| babbageclunk | wallyworld: so they're lined up? Might say a min of one space between them (so they're closer related than between cols) | 22:38 |
| wallyworld | yeah | 22:38 |
| wallyworld | just a though | 22:39 |
| wallyworld | t | 22:39 |
| wallyworld | instead of the : | 22:39 |
| babbageclunk | wallyworld: http://paste.ubuntu.com/25279902/ | 22:40 |
| babbageclunk | wallyworld: not sure about that | 22:41 |
| wallyworld | hmmm, but now it doeslook like it should just be an extra column :-( | 22:41 |
| wallyworld | yeah | 22:41 |
| wpk | wind 39 | 22:42 |
| wallyworld | babbageclunk: maybe stikc with first one and get feedback | 22:42 |
| wallyworld | wpk: i assume you're talking about the weather :-) | 22:43 |
| babbageclunk | wpk: did you eat a curry? | 22:43 |
| wallyworld | that's what i was thinking :-) | 22:43 |
| thumper | morning | 22:45 |
| thumper | babbageclunk: https://github.com/juju/description/pull/17 | 22:45 |
| thumper | veebers: ping | 22:48 |
| babbageclunk | thumper: Oh hai - taking a look at that now. Which do you prefer out of these? http://paste.ubuntu.com/25279938/ | 22:49 |
| * thumper looks | 22:50 | |
| babbageclunk | thumper: (should be principals) | 22:50 |
| thumper | ugh | 22:50 |
| thumper | ok | 22:50 |
| wpk | wallyworld: babbageclunk https://vignette1.wikia.nocookie.net/fantendo/images/8/8f/Nothing-to-see-here.gif/revision/latest?cb=20160415175201 :P | 22:53 |
| wpk | And g'nite :) | 22:53 |
| thumper | night wpk | 22:53 |
| thumper | babbageclunk: I feel that we should have Relation in the heading somewhere | 22:53 |
| babbageclunk | bye wpk | 22:53 |
| babbageclunk | thumper: Yeah, that's definitely a problem. But according to wallyworld the fact that it's sorted by provider endpoint name makes it not very useful. I tried with the headings Relation/To but it felt a bit forced. | 22:55 |
| wallyworld | thumper: we discussed with ante at the sprint and having the left column sorted by "provides" was the most important thing. Ideally yes, "Relation" in heading but not at the expense of sorting | 22:57 |
| babbageclunk | thumper: So a better heading for the requirer column that let us use Relation for the requirer column would be ideal. | 22:57 |
| thumper | why not just have the heading called "Relation Provider" ? | 22:57 |
| thumper | babbageclunk: fixed principal spelling, review plz? | 22:58 |
| babbageclunk | thumper: yeah, I like Relation Provider | 23:00 |
| babbageclunk | thumper: continuing review | 23:00 |
| thumper | ta | 23:00 |
| babbageclunk | thumper, wallyworld: http://paste.ubuntu.com/25279987/ | 23:01 |
| thumper | babbageclunk: I think that is OK' | 23:01 |
| babbageclunk | good enough for me! | 23:02 |
| babbageclunk | thumper: Don't you also need to fix the error in migration_export? | 23:07 |
| babbageclunk | thumper: I thought there was a missing relation scope error? | 23:08 |
| * babbageclunk gets it | 23:08 | |
| babbageclunk | Oh, this is the description change. | 23:09 |
| thumper | yes I do, that's next | 23:09 |
| babbageclunk | thumper: lgtm'd | 23:10 |
| thumper | veebers: ping-a-ling | 23:16 |
| veebers | thumper: pong o/ Wat's the haps | 23:39 |
| thumper | I need to talk about updating migration acceptance test | 23:40 |
| thumper | hangout? | 23:40 |
| veebers | thumper: yeah sure, just need 2 seconds | 23:40 |
| thumper | akc | 23:40 |
| anastasiamac | a small review plz: https://github.com/juju/juju/pull/7723 | 23:43 |
| veebers | thumper: release call HO? | 23:43 |
| thumper | veebers: sure | 23:43 |
| anastasiamac | and another equally tiny: https://github.com/juju/juju/pull/7716 | 23:43 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
