[00:08] <anastasiamac> thumper: \o/ tyvm!
[00:23] <anastasiamac> and another tiny pr plz: https://github.com/juju/juju/pull/7724
[00:37] <babbageclunk> anastasiamac: ding!
[00:38] <anastasiamac> babbageclunk: \o/
[00:38] <anastasiamac> and another one plz: https://github.com/juju/juju/pull/7725
[00:39] <babbageclunk> gah
[00:41] <babbageclunk> anastasiamac: done
[00:42] <anastasiamac> babbageclunk: not necessarily for u to review :D anyone really ;) but TYVM
[00:42] <babbageclunk> :)
[01:13] <anastasiamac> another review plz - https://github.com/juju/juju/pull/7726
[01:32] <thumper> wallyworld: there shortly
[01:36] <anastasiamac> babbageclunk: on fire! :) tyvm
[01:52] <wallyworld> thumper: ?
[02:29] <thumper> babbageclunk: test added https://github.com/juju/juju/pull/7722/commits/f1c7e8618d2ad5dd37c4dacdd85ac0c0cbe690eb
[02:29] <wallyworld> veebers: is this a known issue? http://juju-ci.vapour.ws:8080/blue/organizations/jenkins/github-merge-juju/detail/github-merge-juju/103/pipeline
[02:31]  * veebers looks
[02:31] <babbageclunk> thumper: test looks great - don't you still need the - on the index?
[02:32] <thumper> babbageclunk: yes, yes I do
[02:32] <thumper> thanks
[02:32] <veebers> wallyworld: I'll take a look onw
[02:32] <veebers> now*
[02:32] <babbageclunk> thumper: Do you need an upgrade step to drop the old index as well?
[02:32]  * babbageclunk might be pushing it
[02:33] <thumper> ah... I'll check
[02:33] <veebers> wallyworld: oh, that slave is out of space. Fixing now.
[02:34] <wallyworld> ta
[02:34] <babbageclunk> wallyworld: So, not changing the YAML/JSON status output - what about if I just added a top-level relations key?
[02:35] <wallyworld> babbageclunk: to the yaml/json? i thought those were ok as is?
[02:35] <babbageclunk> wallyworld: I can hide the new info I need for the tabular output by just making one field non-public, but it seems a little perverse.
[02:36] <wallyworld> we typically have bespoke structs don't we for yaml ve tabular? i can't recall the code of fhand
[02:38] <wallyworld> oh, looks like we use the same one for both
[02:39] <wallyworld> if what comes off the wire is ok, you'll either need a "-" in the format tag to hide, or use a new struct for tubular. i don't see anything wrong with hide fields
[02:40] <babbageclunk> wallyworld: ok cool - hiding is nicer than just lowercasing the field name which is what I was thinking.
[02:40] <wallyworld> yeah, just use "-"
[02:54] <veebers> wallyworld: I have cleared out that node so we're moving forward with merge jobs now
[02:54] <veebers> I have also fixed the merge job itself to clean up properly after itself and will land that now too.
[02:57] <thumper> meetingology: https://github.com/juju/juju/pull/7709 updated
[02:58] <thumper> menn0: https://github.com/juju/juju/pull/7709 updated
[02:58] <thumper> babbageclunk: https://github.com/juju/juju/pull/7722 updated too
[02:59] <menn0> thumper: k, will look in a sec
[03:02] <thumper> ta
[03:15] <babbageclunk> thumper: lgtm'd!
[03:46] <wallyworld> thumper: do you have time to look at this fix for the instance id bug for 2.2? https://github.com/juju/juju/pull/7728
[03:46] <thumper> wallyworld: just need to send an email
[03:47] <thumper> not sure ... have calls coming too
[03:47] <wallyworld> ok
[04:07] <babbageclunk> thumper or wallyworld: can you review my status fix? https://github.com/juju/juju/pull/7729
[04:07] <wallyworld> ok
[04:13] <wallyworld> babbageclunk: just a couple of nits
[04:13] <wallyworld> good to have htis fixed
[04:14] <babbageclunk> wallyworld: cool cool, thanks
[05:18] <wallyworld> babbageclunk: we don't export dying or dead thigs do we?
[05:19] <babbageclunk> wallyworld: In a migration? I don't think we'll allow a migration to happen when there are things in flux like that.
[05:20] <wallyworld> ok, in a pr i have up, i added a field but it's only relevant if a machine is dead
[05:20] <wallyworld> i probably can add that to the ignore list then
[05:28] <babbageclunk> wallyworld: sounds right - in migration/precheck.go, checkMachines it will fail if there are any dead machines.
[06:39] <anastasiamac> wallyworld: i was just looking at big merge... there were couple of things i wanted to bring from 2.2 into dvelop...
[06:39] <anastasiamac> :(
[06:40] <mup> Bug #1709791 opened: juju deployed lxd falls back to lxdbr0 bridge when binding is specified <juju-core:New> <https://launchpad.net/bugs/1709791>
[06:42] <wallyworld> anastasiamac: i realise there's more to land into 2.2 - i have a PR myself. it's trivial to do another merge whenever needed
[06:43] <anastasiamac> not into 2.2.. from 2.2.
[06:43] <wallyworld> but the decks needed to be cleared as the diff was getting out of hand
[06:43] <wallyworld> exactly
[06:43] <wallyworld> i have a pr to land into 2.2
[06:43] <wallyworld> which also then needs to be in develop
[06:43] <anastasiamac> eceything i have in 2.2 landed. i just wanted to check that it is brough over
[06:45] <wallyworld> now that the big merge is happening, anything else should hopefully be trivial
=== frankban|afk is now known as frankban
=== frankban is now known as frankban|afk
[22:32] <wallyworld> babbageclunk: any chance of a small mechanical review? https://github.com/juju/juju/pull/7731
[22:34] <babbageclunk> sure
[22:36] <wallyworld> yay, ty
[22:36] <hml> wallyworld: i *think* I have the update-series application changes done.  any chance you’re ready to look again?
[22:36] <wallyworld> can do
[22:37] <hml> wallyworld: still towards 2.2 - changing to develop will be interesting.  a few things have changed
[22:37] <hml> wallyworld: ty
[22:37] <wallyworld> yeah, hopefully retarget should not be too bad
[22:47] <menn0> wallyworld: have you got time for a hangout? i'm stuck with something that you might be able to shine some light on.
[22:47] <wallyworld> sure
[22:47] <wallyworld> team ho?
[22:48] <menn0> wallyworld: sure
[22:51] <babbageclunk> wallyworld: lgtm'd
[23:47] <axw> babbageclunk: standup
[23:47] <wallyworld> babbageclunk: awesome, ty for review
[23:47] <babbageclunk> oh, sorry!