wallyworld | hml: let me know if the next round of comments make sense. the txn stuff is close but the business logic and ops generation needs to be separated | 00:11 |
---|---|---|
hml | wallyworld: looking. | 00:12 |
hml | wallyworld: do you have a few mintues for an HO? | 00:17 |
anastasiamac | hmmm 'user-cat'? | 00:32 |
wallyworld | hml: sure | 00:35 |
wallyworld | sorry, missed ping | 00:35 |
wallyworld | samde one as before | 00:36 |
hml | wallyworld: sure | 00:36 |
wallyworld | babbageclunk: here's a small juju/description followup to the other juju one if you have a moment whenever https://github.com/juju/description/pull/18 | 01:43 |
babbageclunk | wallyworld: approved | 02:28 |
wallyworld | awesome ty | 02:28 |
axw_ | wallyworld: yay, finally got my VLAN setup right with openvswitch. I think. | 02:57 |
wallyworld | awesome | 03:00 |
menn0 | wallyworld, axw_ : i've got to stop now but I've put up a WIP: https://github.com/juju/juju/pull/7733 | 03:21 |
wallyworld | ok, will look | 03:22 |
menn0 | it's almost done, a few tests still fail | 03:22 |
menn0 | no rush though | 03:22 |
wallyworld | will look this arvo | 03:22 |
menn0 | I need to write a few docstrings and tests too | 03:22 |
wallyworld | axw_: would you have time to look at a 98% mechanical change? essentially s/offerurl/offeruuid. i've got 1 failing unit test still (gui related), but will be trivial to fix https://github.com/juju/juju/pull/7734 | 05:41 |
axw_ | wallyworld: ok | 05:58 |
axw_ | wallyworld: let me know when you've finished changing it please | 06:02 |
wallyworld | axw_: sorry, was fixing that test | 06:03 |
wallyworld | should be ok now. i'm about to re-run all the unit tests to be sure | 06:03 |
wallyworld | the changes were a test fix | 06:04 |
=== frankban|afk is now known as frankban | ||
wallyworld | axw_: awesome, thanks for review. good pickup on the json tag | 06:35 |
axw_ | wallyworld: np | 06:35 |
babbageclunk | wallyworld: hey, are you watching that stream on youtube? | 07:31 |
=== frankban is now known as frankban|afk |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!