[01:00] <menn0> wallyworld: thanks for the review
[01:00] <wallyworld> menn0: no worries, might be worth an eyball from andrew also?
[01:01] <menn0> axw_: ^^ https://github.com/juju/juju/pull/7738 pls
[01:01] <menn0> wallyworld: I've got a monster ready for review once this one lands :)
[01:02] <wallyworld> i bet
[01:14] <axw_> menn0: looking
[01:23] <axw_> menn0: LGTM, thanks
[01:24] <axw> babbageclunk: in case you've not seen them, I have a couple of PRs up for review on 1.25-upgrade
[01:24] <babbageclunk> axw: oh sorry - looking at them now
[01:26] <axw> babbageclunk: I have some more changes in the works, which ~require me to make use of the juju2 tree. to build some of the juju2 packages, I have to kill some of the (unused) code as it doesn't all build with the dependencies required by juju1
[01:27] <babbageclunk> axw: Yeah, I had to make some small changes in juju2 to resolve version conflicts before too.
[01:29] <anastasiamac> axw: could u PTAL @ https://github.com/juju/juju/pull/7740 (state pwd reset in prep for token re-issuing)
[01:29] <axw> anastasiamac: okey dokey
[01:29] <anastasiamac> axw: \o/
[01:42] <babbageclunk> axw: both approved
[01:42] <axw> babbageclunk: thanks
[01:44] <axw> babbageclunk: by "to the description", you mean in the output displayed to the user?
[01:48] <babbageclunk> axw: oh, no - I meant on the PR. But actually, that might be good call too.
[01:48] <axw> babbageclunk: ah right, ok
[01:53] <thumper> wallyworld: https://github.com/juju/juju/pull/7742
[01:53] <wallyworld> looking
[02:01] <wallyworld> thumper: lgtm with a suggestion
[02:01] <thumper> wallyworld: ta
[02:03] <wallyworld> axw: small one. for some reason, the cloud city creds didn't work for me, with any azure region, not just the new ones https://github.com/juju/juju/pull/7743
[02:08] <axw> wallyworld: LGTM, thanks
[02:09] <wallyworld> ta
[02:36]  * babbageclunk goes for a run
[02:52] <thumper> wallyworld: are long running actions landed?
[02:52] <thumper> and are they 2.3?
[02:53] <wallyworld> thumper: no, there was disagreement about the spec/solution
[02:53] <wallyworld> so sort of put on hold
[02:53] <thumper> hmm...
[02:53] <thumper> disagreement between whom?
[02:53] <wallyworld> next thing was going to be action file i/o
[02:54] <wallyworld> disagreement internally - what stakeholders wanted was quite loosely defined
[03:09] <axw> babbageclunk: I know it doesn't matter too much, but the command name "verify-source" doesn't sit well with me. I'm thinking of renaming it, perhaps to "export-source". thoughts?
[03:10] <axw> babbageclunk: and I'm thinking of making it responsible for installing LXD on the LXC hosts...
[03:38] <wallyworld> i have 2 PRs that need reviewing if anyone is bored... https://github.com/juju/juju/pull/7741 https://github.com/juju/juju/pull/7744
[03:59] <menn0> babbageclunk, wallyworld: here's the big GetModel removal: https://github.com/juju/juju/pull/7745
[03:59] <menn0> +353, -473
[04:01] <babbageclunk> axw: I'm fine with that - the command predates me. Although I wasn't envisaging that we'd be exporting, saving the output, then importing - there are things like charms to think about too.
[04:01] <babbageclunk> menn0: ok, looking now
[04:04] <wallyworld> menn0: looking
[04:04] <menn0> thanks guys
[05:32] <axw> babbageclunk: ah ok. maybe we should just stop writing out the model description then
[05:33] <axw> babbageclunk: I'll leave it for now
[05:34] <babbageclunk> axw: yeah, it's useful for now, but I don't think we'd want it to be dumped for users. Maybe make it an option.
[06:05] <axw> babbageclunk: so I've put up https://github.com/juju/1.25-upgrade/pull/16, which augments the model description written by verify-source. the meat is in a function, so it should be reusable in the command used to import into the target controller
[06:16] <thumper> poo
[06:16] <thumper> I have an initialization loop
[06:16]  * thumper things how to unloop it
[06:17] <thumper> axw: I don't suppose you have 5 minutes?
[06:17] <axw> thumper: for you I might even have 6
[06:17] <thumper> :)
[06:18] <thumper> 1:1?
[06:18] <axw> thumper: ok, brt
[14:18] <mup> Bug #1710886 opened: juju 2.1 issues certificates with wrong DNS alternative names on juju upgrade. <juju-core:New> <https://launchpad.net/bugs/1710886>