| hml | wallyworld: i’m not going to change unit to use refresh instead of common.Life - it’s not strictly needed and we can’t get ride of common.Life easily anyways. | 00:12 |
|---|---|---|
| wallyworld | where is the life() call made? | 00:12 |
| hml | wallyworld: st.Unit(tag) api/uniter/uniter.go ln 147 ish | 00:15 |
| wallyworld | we should be calling refresh there | 00:16 |
| wallyworld | why construct an incomplete unit | 00:16 |
| wallyworld | when we can call refresh() instead of life() and get all the data | 00:16 |
| hml | wallyworld: okay - | 00:17 |
| wallyworld | but there are places in Application that call life() that we would retain | 00:17 |
| wallyworld | as currently the application life mirrors the unit life | 00:17 |
| wallyworld | babbageclunk: if you had time for a smallish mechanical review that would be great https://github.com/juju/juju/pull/7815 | 00:48 |
| babbageclunk | wallyworld: sure | 00:49 |
| wallyworld | axw: were you free now for 1:1? or soon? | 01:03 |
| axw | wallyworld: sure, can do now | 01:03 |
| wallyworld | ok | 01:03 |
| babbageclunk | axw: thanks for the review - can you look at https://github.com/juju/1.25-upgrade/pull/24 as well? :) | 02:00 |
| axw | babbageclunk: yup, looking now | 02:00 |
| babbageclunk | wallyworld: sorry, I totally got sidetracked on your review - back to it now | 02:11 |
| babbageclunk | wallyworld: approved! | 02:27 |
| babbageclunk | wallyworld: I'm popping out for a while, but I'll be back online tonight. | 03:52 |
| wallyworld | babbageclunk: awesome, thank you for review | 04:52 |
| wallyworld | axw: swap you reviews? https://github.com/juju/juju/pull/7818 | 07:18 |
| axw | wallyworld: sorry, I took jeremy to his friend's place. sure, but I think you're getting a raw deal ;p | 09:57 |
| wallyworld | axw: no worries, thanks for review. the azure one looked sane; i can't give expert opinion on the implementation but testing seemed thorough | 10:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!