| anastasiamac | a review anyone plz - https://github.com/juju/juju/pull/7824 | 00:02 |
|---|---|---|
| anastasiamac | thumper: disallow self-reset and old facade version fix ^^ | 00:02 |
| wallyworld | babbageclunk: axw: late for standup, still doing interview | 00:26 |
| babbageclunk | wallyworld: ok | 00:26 |
| wallyworld | babbageclunk: axw: finished now | 00:37 |
| wallyworld | thumper: if you get a chance to look at my pr? https://github.com/juju/juju/pull/7823 | 00:40 |
| * babbageclunk goes for a run | 01:22 | |
| * thumper headdesks | 02:43 | |
| babbageclunk | uh oh | 02:44 |
| * thumper saves a minute off the test time by not running things twice | 02:47 | |
| thumper | the bundle resource tests were composed of a concrete test suite | 02:47 |
| thumper | which tested all bundle deployment | 02:48 |
| thumper | so to run the resource test, it reran all the bundle tests | 02:48 |
| thumper | I've fixed that in my branch | 02:48 |
| thumper | ugh... | 02:51 |
| thumper | I see why it was needed now | 02:51 |
| thumper | but it is horrible | 02:51 |
| thumper | cyclic includes | 02:51 |
| babbageclunk | ugh | 03:02 |
| thumper | babbageclunk: https://github.com/juju/juju/pull/7825 | 03:15 |
| babbageclunk | thumper: looking | 03:16 |
| thumper | babbageclunk: thanks | 03:19 |
| thumper | hmm... local test failure that is nothing to do with my work... | 03:19 |
| thumper | FAIL: config_test.go:39: ConfigSuite.TestGenerateControllerCertAndKey | 03:19 |
| thumper | in controller package | 03:19 |
| thumper | fails for anyone else? | 03:19 |
| thumper | seems to consistently fail | 03:20 |
| thumper | how did this get in? | 03:20 |
| babbageclunk | thumper: on develop or 2.2? | 03:21 |
| thumper | 2.2 | 03:21 |
| babbageclunk | thumper: hang on, building | 03:21 |
| thumper | oh... | 03:21 |
| thumper | I wonder if it is an embedded time in the testing certs | 03:22 |
| babbageclunk | thumper: and they've just expired? | 03:22 |
| thumper | hmm.. I'd expect more failures if that was the case | 03:22 |
| thumper | config_test.go:62: | 03:22 |
| thumper | c.Assert(err, jc.ErrorIsNil) | 03:22 |
| thumper | ... value x509.HostnameError = x509.HostnameError{Certificate:(*x509.Certificate)(0xc420125900), Host:"anyServer"} ("x509: certificate is not valid for any names, but wanted to match anyServer") | 03:22 |
| babbageclunk | thumper: sorry, got distracted. It passes for me. | 03:29 |
| thumper | hmm... | 03:29 |
| thumper | weird | 03:29 |
| thumper | I wonder why it started failing for me... | 03:29 |
| babbageclunk | thumper: probably you broke it somehow. ;) | 03:33 |
| thumper | babbageclunk: we'll see if the merge bot likes it I guess | 03:33 |
| * thumper shrugs | 03:33 | |
| * thumper follows his own instructions on setting up metrics gathering | 03:33 | |
| thumper | I'm giving a presentation this afternoon on prometheus and grafana | 03:34 |
| babbageclunk | thumper: approved | 03:55 |
| thumper | babbageclunk: awesome, ta | 03:55 |
| babbageclunk | thumper: looks like the mergebot liked it - did you work out why that test was failing? | 04:26 |
| thumper | nope | 04:44 |
| thumper | also...\ | 04:44 |
| thumper | babbageclunk: Yay | 04:44 |
| axw | wallyworld: just realised a bit too late, might be worth changing Save to accept a FirewallRule. can be done later since you're already merging | 05:47 |
| wallyworld | axw: i have a followup to add the cli and facades i'm about to propose, can do a drive by | 05:48 |
| axw | wallyworld: thanks | 05:48 |
| wallyworld | you feeling better? | 05:48 |
| wallyworld | thanks for first review | 05:48 |
| wallyworld | axw: if you get a chance at some point, here's PR with lots of boilerplate to add the firewall rules CLI; it also tweaks the state save api. the boilerplate stuff can be skimmed to make the review quicker https://github.com/juju/juju/pull/7826 | 06:31 |
| === wpk_ is now known as wpk | ||
| === rharper` is now known as rharper | ||
| * thumper rolls 2.2 into develop again | 20:58 | |
| thumper | wallyworld: you around yet? | 21:16 |
| wallyworld | maybe | 21:17 |
| thumper | wanna jump in the release call early? | 21:17 |
| wallyworld | sure | 21:17 |
| thumper | I have a few questions around some of your work | 21:17 |
| babbageclunk | thumper: ping | 22:48 |
| babbageclunk | ? | 22:48 |
| thumper | hey | 22:48 |
| thumper | otp | 22:48 |
| thumper | babbageclunk: what is your go version? | 22:52 |
| babbageclunk | thumper: still 1.8 | 22:54 |
| thumper | I think that is why the test is passing for you | 22:55 |
| thumper | and not me nor wallyworld | 22:55 |
| babbageclunk | oh sting | 22:55 |
| babbageclunk | k | 22:56 |
| babbageclunk | Seems like a weird thing for a go version change to break. Maybe we were inadvertently relying on something undocumented/incorrect? | 22:57 |
| thumper | it is a bug fix in the x509 package | 22:57 |
| thumper | If any SAN extension, including with no DNS names, is present in the certificate, then the Common Name from Subject is ignored. In previous releases, the code tested only whether DNS-name SANs were present in a certificate. | 22:57 |
| thumper | from the release notes | 22:57 |
| babbageclunk | thumper: yeah, that would do it. | 22:57 |
| thumper | we need to fix juju | 22:57 |
| babbageclunk | thumper: when you get a moment, I'm having real trouble working out how to create an environ in juju1 - all of my understanding about it is juju2, and it changed a lot! | 23:10 |
| thumper | babbageclunk: I can chat now... | 23:48 |
| babbageclunk | thumper: cool - ho? | 23:48 |
| babbageclunk | duh, I mean 1:1? | 23:48 |
| thumper | ack | 23:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!