smoser | blackboxsw, well... i was saying instead of doing os.access, you just do | 00:05 |
---|---|---|
smoser | open(devpath, "wb", ... some flags that mean dont truncate) | 00:06 |
smoser | but now that i think about it that likely causes issues. | 00:06 |
smoser | as udev or systemd watch open/close on devices. | 00:06 |
smoser | so bad idea | 00:06 |
smoser | ugh https://bugs.launchpad.net/cloud-init/+bug/1717477 | 13:43 |
ubot5 | Ubuntu bug 1717477 in cloud-init "cloud-init generates ordering cycle via After=cloud-init in systemd-fsck" [High,New] | 13:43 |
dpb1 | :/ | 13:51 |
blackboxsw | gah | 14:59 |
larsks | Yay ordering cycles! | 15:30 |
blackboxsw | yeah, larsks scott's pushing a fix for this release && an SRU update on that today. | 16:22 |
=== shardy is now known as shardy_afk | ||
smoser | blackboxsw, https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330846 | 16:55 |
smoser | ordering cycles are like a game of russian roulette | 16:56 |
blackboxsw | smoser: checking, just pushed https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330626 | 17:02 |
blackboxsw | we'd just need to carry the following for series we want to deliver apport functionality to http://paste.ubuntu.com/25541681/ | 17:04 |
blackboxsw | adding it as a comment on the branch | 17:04 |
smoser | blackboxsw, does it know that it is python somehow ? | 17:18 |
smoser | that is good though | 17:18 |
blackboxsw | Oops missed the response yeah just tested apport knows what python to use. So I dropped the bang py3 I'll push another unit test for optional --include-userdata to collect logs | 17:48 |
blackboxsw | Smoser | 17:48 |
smoser | ok. reading. please read my branch | 18:03 |
smoser | blackboxsw, | 18:05 |
smoser | a quick read of https://code.launchpad.net/~rbalint/cloud-init/+git/cloud-init/+merge/330842 | 18:05 |
smoser | woudl be appreciated too | 18:05 |
smoser | blackboxsw, | 18:11 |
smoser | http://paste.ubuntu.com/25542078/ | 18:11 |
blackboxsw | checking | 18:12 |
blackboxsw | +1 | 18:12 |
smoser | on a overlayroot boot (maas), we see this: | 18:12 |
smoser | 14 19:45:28,372 - cc_resizefs.py[WARNING]: Device 'overlayroot' did not exist. c | 18:12 |
smoser | annot resize: dev=overlayroot mnt_point=/ path=/ | 18:12 |
blackboxsw | want me to fold that into the drop patch? | 18:12 |
smoser | yeah. | 18:12 |
smoser | i'd like to do that so that we dont WARN there | 18:12 |
smoser | but just debug | 18:12 |
blackboxsw | makes sense | 18:12 |
blackboxsw | adding a unit test on that aspect | 18:16 |
blackboxsw | unit test added and pushed | 18:24 |
blackboxsw | tests-fix-root-os-access-leak 1367b2b911d61ae95c2c635259b2f2b85c8eb541 | 18:24 |
blackboxsw | back on your branch | 18:25 |
blackboxsw | flake errors https://jenkins.ubuntu.com/server/job/cloud-init-ci/309/console | 18:26 |
smoser | fixing flake errors | 18:28 |
smoser | done | 18:29 |
smoser | blackboxsw, | 18:31 |
smoser | $ git show 1367b2b911d61ae95c2c635259b2f2b85c8eb541:cloudinit/config/cc_resizefs.py | grep overlay || echo no overlay mention there | 18:31 |
smoser | no overlay mention there | 18:31 |
smoser | maybe you didn't push that ? | 18:31 |
blackboxsw | smoser: wrong log. was looking at the os.access branch git log | 18:34 |
blackboxsw | hmm | 18:34 |
blackboxsw | wait a sec | 18:35 |
blackboxsw | hah didn't commit | 18:35 |
blackboxsw | e19de87fdae9fb58d39ac415b73fa37e6b6e1e83 pushed sorry about that smoser | 18:36 |
blackboxsw | almost done w/ your dhclient branch | 18:39 |
blackboxsw | review comment posted https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330846 | 18:41 |
smoser | blackboxsw, ok. i addressed that and pushed | 18:56 |
smoser | and i commented on https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330626 | 18:56 |
blackboxsw | smoser: I saw you landed resizefs (overlayroot) thx | 18:59 |
blackboxsw | TIL: open a trello card and ctrl-V a link and it auto attaches | 18:59 |
smoser | ? | 19:09 |
dpb1 | oh cool tip | 19:11 |
blackboxsw | I had always clicked the paper clip icon, then ctrl-v in the textbox labeled link | 19:20 |
blackboxsw | and then clicked attach. But ctrl-v just does the right thing | 19:21 |
smoser | blackboxsw, i linked a mp to | 19:26 |
smoser | https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330626 | 19:26 |
blackboxsw | smoser: you mean as prerequisite? | 19:30 |
smoser | well post req | 19:31 |
smoser | i guess. | 19:31 |
smoser | mine depends on yours | 19:31 |
blackboxsw | powersj: a couple branches ago your nose-timer additions saved me. thanks again. it alerted me to a problem w/ a unit test that I didn't know I had | 19:33 |
powersj | Woohoo!! Thanks for the feedback | 19:33 |
blackboxsw | retreis on url_helper.read_url are costly (waiting a full second between retries) so my unit test was taking 20 seconds on retries (so I mocked it) :) | 19:34 |
blackboxsw | well looking at the code, I guess I could have set sec_between parameter to 0 :) | 19:34 |
blackboxsw | ahh well, I'll drop the mock next time | 19:34 |
blackboxsw | but in either case I would have unknowingly introduced 20 seconds into our run if tox -e py3 hadn't shown me the "red" tests | 19:35 |
blackboxsw | less mocks == a better world | 19:36 |
blackboxsw | landed https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330846 | 19:40 |
blackboxsw | waiting on CI for https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330626 then I'll land the collect-logs/apport stuff | 19:41 |
smoser | blackboxsw, shoot. | 19:46 |
smoser | i have that locally about to go | 19:46 |
smoser | but i can cancel | 19:46 |
smoser | here. | 19:46 |
smoser | blackboxsw, i'm landing it. | 19:47 |
smoser | tox && git push upstream HEAD | 19:47 |
smoser | i re-worked the commit message a bit | 19:48 |
smoser | http://paste.ubuntu.com/25542524/ | 19:48 |
blackboxsw | smoser: sorry per your branch | 19:48 |
blackboxsw | ohh you meant my collect-logs | 19:48 |
blackboxsw | +1 on commit message | 19:49 |
blackboxsw | smoser: | 19:49 |
smoser | blackboxsw, can you give my https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330858 a sanity check ? | 19:55 |
smoser | or a test ? | 19:55 |
smoser | an then i'd like to shove a new upload to artful | 19:56 |
smoser | hm.. | 19:58 |
smoser | why isnt that packaging my apport-launcher.py | 19:58 |
blackboxsw | smoser: added this https://trello.com/c/2FXn8S9x/385-centos-7-fix-cloudstack-datasource-to-regression-to-handle-dhclient-lease-filenames for hilight | 19:59 |
blackboxsw | checking smoser | 19:59 |
blackboxsw | powersj: this afternoon, I'm working on that trello-board script for processing cards | 20:00 |
blackboxsw | once these branches land | 20:00 |
smoser | ugh. | 20:00 |
smoser | i need to run shortly. | 20:00 |
smoser | i uploaded to xenial and to zesty the regression revert cherry-pick | 20:01 |
smoser | dpb1, ^ | 20:01 |
smoser | but we still need an upload to artful | 20:01 |
powersj | blackboxsw: sweet | 20:01 |
blackboxsw | smoser: content looks good on https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330858 don't know how I missed that | 20:03 |
blackboxsw | powersj: https://trello.com/c/zGxaIodz/372-tests-support-command-as-string is merged right? it's in doing lane | 20:05 |
smoser | blackboxsw, ok. i'm adding | 20:05 |
dpb1 | smoser: xenial and zesty are indeed prio | 20:09 |
dpb1 | thx | 20:09 |
dpb1 | smoser: whats stopping the artful upload? | 20:10 |
smoser | landing those other things | 20:10 |
smoser | i'md oing build && upload && push on it right now | 20:10 |
dpb1 | great | 20:10 |
smoser | ok. thats pushed. | 20:15 |
smoser | i have to run | 20:15 |
smoser | the one thing left for right now is to update the ubuntu/xenial and ubuntu/zesty branches to drop (remove) the cherry pick patch | 20:15 |
smoser | as right now our recipe builds of those branches will fail because they have a patch in them that wont apply to trunk. | 20:15 |
smoser | if someone wanted to try to thikn of a way to make us not have to do that... that'd be good. | 20:15 |
smoser | if we could someohow get the recipe builds to drop all 'cherry-pick-*' patches. | 20:16 |
smoser | i'll check back in later | 20:16 |
powersj | blackboxsw: yes landed | 20:17 |
powersj | as is KVM! | 20:17 |
powersj | \o/ | 20:17 |
blackboxsw | good push smoser ! | 20:19 |
blackboxsw | powersj: https://trello.com/c/XGGri1K2/315-sru-get-oil-1 and https://trello.com/c/MMRiKIL9/316-sru-get-maas-1 are these ongoing cards? | 20:21 |
blackboxsw | if you can't tell I'm scrubbing the board :) | 20:22 |
powersj | blackboxsw: not on going. working to get sign off on the SRU exception | 20:23 |
powersj | see updates to: https://wiki.ubuntu.com/CloudinitUpdates | 20:23 |
Odd_Bloke | Is https://pastebin.canonical.com/198539/ a known issue? | 20:42 |
Odd_Bloke | Oh, hmph, internal pastebin. | 20:42 |
Odd_Bloke | http://paste.ubuntu.com/25542802/ | 20:42 |
blackboxsw | hrm | 20:52 |
blackboxsw | checking | 20:52 |
blackboxsw | Odd_Bloke: don't see any outstanding bugs related to that | 20:54 |
Odd_Bloke | Filed https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1717598 | 20:57 |
ubot5 | Ubuntu bug 1717598 in cloud-init (Ubuntu) "Traceback when passing user-data on GCE" [Undecided,New] | 20:57 |
blackboxsw | what version of cloudinit? I know we toucheds cloudinit/stages.py today, and a couple of config modules, but nothing specifically in the handlers code. | 20:57 |
blackboxsw | ahh checking the bug thanks | 20:57 |
blackboxsw | I have touched bootcmd module recently | 20:58 |
blackboxsw | Sept 2nd in fact | 20:58 |
blackboxsw | ok. digging | 20:58 |
blackboxsw | thx Odd_Bloke | 20:59 |
Odd_Bloke | blackboxsw: An artful image built today. | 20:59 |
Odd_Bloke | So 0.7.9-267-g922c3c5c-0ubuntu1, I believe. | 21:00 |
blackboxsw | thanks again will work on that | 21:50 |
smoser | :-( | 21:57 |
blackboxsw | strange, can't reproduce w/ rev 267 on ec2 with basically the same user-data http://paste.ubuntu.com/25543349/ | 22:24 |
blackboxsw | cloud-init0.7.9-267-g922c3c5c-0ubuntu1 | 22:24 |
blackboxsw | though just found another bug in Ec2Local | 22:26 |
blackboxsw | cloudinit.util.ProcessExecutionError: Unexpected error while running command. | 22:26 |
blackboxsw | Command: ['/run/cloud-init/tmp/cloud-init-dhcp-jlm8h6x2/dhclient', '-1', '-v', '-lf', '/run/cloud-init/tmp/cloud-init-dhcp-jlm8h6x2/dhcp.leases', '-pf', '/run/cloud-init/tmp/cloud-init-dhcp-jlm8h6x2/dhclient.pid', 'eth0', '-sf', '/bin/true'] | 22:26 |
blackboxsw | Exit code: - | 22:26 |
blackboxsw | Reason: [Errno 13] Permission denied | 22:26 |
blackboxsw | so we are now getting perm errors trying to run dhclient. I'll debug before fiiling this one | 22:27 |
blackboxsw | Open a socket for LPF: Operation not permitted.... even with apparmor disabled. hmm | 22:42 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!