[00:05] blackboxsw, well... i was saying instead of doing os.access, you just do [00:06] open(devpath, "wb", ... some flags that mean dont truncate) [00:06] but now that i think about it that likely causes issues. [00:06] as udev or systemd watch open/close on devices. [00:06] so bad idea [13:43] ugh https://bugs.launchpad.net/cloud-init/+bug/1717477 [13:43] Ubuntu bug 1717477 in cloud-init "cloud-init generates ordering cycle via After=cloud-init in systemd-fsck" [High,New] [13:51] :/ [14:59] gah [15:30] Yay ordering cycles! [16:22] yeah, larsks scott's pushing a fix for this release && an SRU update on that today. === shardy is now known as shardy_afk [16:55] blackboxsw, https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330846 [16:56] ordering cycles are like a game of russian roulette [17:02] smoser: checking, just pushed https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330626 [17:04] we'd just need to carry the following for series we want to deliver apport functionality to http://paste.ubuntu.com/25541681/ [17:04] adding it as a comment on the branch [17:18] blackboxsw, does it know that it is python somehow ? [17:18] that is good though [17:48] Oops missed the response yeah just tested apport knows what python to use. So I dropped the bang py3 I'll push another unit test for optional --include-userdata to collect logs [17:48] Smoser [18:03] ok. reading. please read my branch [18:05] blackboxsw, [18:05] a quick read of https://code.launchpad.net/~rbalint/cloud-init/+git/cloud-init/+merge/330842 [18:05] woudl be appreciated too [18:11] blackboxsw, [18:11] http://paste.ubuntu.com/25542078/ [18:12] checking [18:12] +1 [18:12] on a overlayroot boot (maas), we see this: [18:12] 14 19:45:28,372 - cc_resizefs.py[WARNING]: Device 'overlayroot' did not exist. c [18:12] annot resize: dev=overlayroot mnt_point=/ path=/ [18:12] want me to fold that into the drop patch? [18:12] yeah. [18:12] i'd like to do that so that we dont WARN there [18:12] but just debug [18:12] makes sense [18:16] adding a unit test on that aspect [18:24] unit test added and pushed [18:24] tests-fix-root-os-access-leak 1367b2b911d61ae95c2c635259b2f2b85c8eb541 [18:25] back on your branch [18:26] flake errors https://jenkins.ubuntu.com/server/job/cloud-init-ci/309/console [18:28] fixing flake errors [18:29] done [18:31] blackboxsw, [18:31] $ git show 1367b2b911d61ae95c2c635259b2f2b85c8eb541:cloudinit/config/cc_resizefs.py | grep overlay || echo no overlay mention there [18:31] no overlay mention there [18:31] maybe you didn't push that ? [18:34] smoser: wrong log. was looking at the os.access branch git log [18:34] hmm [18:35] wait a sec [18:35] hah didn't commit [18:36] e19de87fdae9fb58d39ac415b73fa37e6b6e1e83 pushed sorry about that smoser [18:39] almost done w/ your dhclient branch [18:41] review comment posted https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330846 [18:56] blackboxsw, ok. i addressed that and pushed [18:56] and i commented on https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330626 [18:59] smoser: I saw you landed resizefs (overlayroot) thx [18:59] TIL: open a trello card and ctrl-V a link and it auto attaches [19:09] ? [19:11] oh cool tip [19:20] I had always clicked the paper clip icon, then ctrl-v in the textbox labeled link [19:21] and then clicked attach. But ctrl-v just does the right thing [19:26] blackboxsw, i linked a mp to [19:26] https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330626 [19:30] smoser: you mean as prerequisite? [19:31] well post req [19:31] i guess. [19:31] mine depends on yours [19:33] powersj: a couple branches ago your nose-timer additions saved me. thanks again. it alerted me to a problem w/ a unit test that I didn't know I had [19:33] Woohoo!! Thanks for the feedback [19:34] retreis on url_helper.read_url are costly (waiting a full second between retries) so my unit test was taking 20 seconds on retries (so I mocked it) :) [19:34] well looking at the code, I guess I could have set sec_between parameter to 0 :) [19:34] ahh well, I'll drop the mock next time [19:35] but in either case I would have unknowingly introduced 20 seconds into our run if tox -e py3 hadn't shown me the "red" tests [19:36] less mocks == a better world [19:40] landed https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330846 [19:41] waiting on CI for https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/330626 then I'll land the collect-logs/apport stuff [19:46] blackboxsw, shoot. [19:46] i have that locally about to go [19:46] but i can cancel [19:46] here. [19:47] blackboxsw, i'm landing it. [19:47] tox && git push upstream HEAD [19:48] i re-worked the commit message a bit [19:48] http://paste.ubuntu.com/25542524/ [19:48] smoser: sorry per your branch [19:48] ohh you meant my collect-logs [19:49] +1 on commit message [19:49] smoser: [19:55] blackboxsw, can you give my https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330858 a sanity check ? [19:55] or a test ? [19:56] an then i'd like to shove a new upload to artful [19:58] hm.. [19:58] why isnt that packaging my apport-launcher.py [19:59] smoser: added this https://trello.com/c/2FXn8S9x/385-centos-7-fix-cloudstack-datasource-to-regression-to-handle-dhclient-lease-filenames for hilight [19:59] checking smoser [20:00] powersj: this afternoon, I'm working on that trello-board script for processing cards [20:00] once these branches land [20:00] ugh. [20:00] i need to run shortly. [20:01] i uploaded to xenial and to zesty the regression revert cherry-pick [20:01] dpb1, ^ [20:01] but we still need an upload to artful [20:01] blackboxsw: sweet [20:03] smoser: content looks good on https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/330858 don't know how I missed that [20:05] powersj: https://trello.com/c/zGxaIodz/372-tests-support-command-as-string is merged right? it's in doing lane [20:05] blackboxsw, ok. i'm adding [20:09] smoser: xenial and zesty are indeed prio [20:09] thx [20:10] smoser: whats stopping the artful upload? [20:10] landing those other things [20:10] i'md oing build && upload && push on it right now [20:10] great [20:15] ok. thats pushed. [20:15] i have to run [20:15] the one thing left for right now is to update the ubuntu/xenial and ubuntu/zesty branches to drop (remove) the cherry pick patch [20:15] as right now our recipe builds of those branches will fail because they have a patch in them that wont apply to trunk. [20:15] if someone wanted to try to thikn of a way to make us not have to do that... that'd be good. [20:16] if we could someohow get the recipe builds to drop all 'cherry-pick-*' patches. [20:16] i'll check back in later [20:17] blackboxsw: yes landed [20:17] as is KVM! [20:17] \o/ [20:19] good push smoser ! [20:21] powersj: https://trello.com/c/XGGri1K2/315-sru-get-oil-1 and https://trello.com/c/MMRiKIL9/316-sru-get-maas-1 are these ongoing cards? [20:22] if you can't tell I'm scrubbing the board :) [20:23] blackboxsw: not on going. working to get sign off on the SRU exception [20:23] see updates to: https://wiki.ubuntu.com/CloudinitUpdates [20:42] Is https://pastebin.canonical.com/198539/ a known issue? [20:42] Oh, hmph, internal pastebin. [20:42] http://paste.ubuntu.com/25542802/ [20:52] hrm [20:52] checking [20:54] Odd_Bloke: don't see any outstanding bugs related to that [20:57] Filed https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1717598 [20:57] Ubuntu bug 1717598 in cloud-init (Ubuntu) "Traceback when passing user-data on GCE" [Undecided,New] [20:57] what version of cloudinit? I know we toucheds cloudinit/stages.py today, and a couple of config modules, but nothing specifically in the handlers code. [20:57] ahh checking the bug thanks [20:58] I have touched bootcmd module recently [20:58] Sept 2nd in fact [20:58] ok. digging [20:59] thx Odd_Bloke [20:59] blackboxsw: An artful image built today. [21:00] So 0.7.9-267-g922c3c5c-0ubuntu1, I believe. [21:50] thanks again will work on that [21:57] :-( [22:24] strange, can't reproduce w/ rev 267 on ec2 with basically the same user-data http://paste.ubuntu.com/25543349/ [22:24] cloud-init 0.7.9-267-g922c3c5c-0ubuntu1 [22:26] though just found another bug in Ec2Local [22:26] cloudinit.util.ProcessExecutionError: Unexpected error while running command. [22:26] Command: ['/run/cloud-init/tmp/cloud-init-dhcp-jlm8h6x2/dhclient', '-1', '-v', '-lf', '/run/cloud-init/tmp/cloud-init-dhcp-jlm8h6x2/dhcp.leases', '-pf', '/run/cloud-init/tmp/cloud-init-dhcp-jlm8h6x2/dhclient.pid', 'eth0', '-sf', '/bin/true'] [22:26] Exit code: - [22:26] Reason: [Errno 13] Permission denied [22:27] so we are now getting perm errors trying to run dhclient. I'll debug before fiiling this one [22:42] Open a socket for LPF: Operation not permitted.... even with apparmor disabled. hmm