| wallyworld_ | axw: you see this at all, go vet error: provider/vsphere/internal/vsphereclient/createvm_test.go:455: possible formatting directive in Fatal call | 00:38 |
|---|---|---|
| wallyworld_ | maybe fix as a drive by in the other pr? | 00:39 |
| wallyworld_ | ah, already merged, i'll fix | 00:43 |
| wallyworld_ | axw: here's a followup PR which finishes the new suspend/resume processing https://github.com/juju/juju/pull/7857 | 01:03 |
| axw | wallyworld_: doh, thanks. looking | 01:08 |
| wallyworld_ | ta | 01:09 |
| * babbageclunk goes for a run | 02:21 | |
| anastasiamac | thumper: axw: do we have plans to support temporary aws credentials? bug 1714022 | 02:36 |
| mup | Bug #1714022: Juju failed to run on aws with authentication failed <juju:New> <https://launchpad.net/bugs/1714022> | 02:36 |
| axw | anastasiamac: it has been asked for, but AFAIK nobody has put time into designing a solution | 02:37 |
| anastasiamac | axw: k, i guess I'll triage to wishlist then :) | 02:37 |
| axw | anastasiamac: it would be relatively straightforward for non-JAAS, and support for multiple credentials (models with separate credentials) | 02:38 |
| thumper | triaged | 02:38 |
| axw | supporting JAAS and multiple creds (controller and model machines in different accounts) makes things more complicated | 02:39 |
| mup | Bug #1714130 changed: juju reports units in non-existent OpenStack availability zones <juju-core:Won't Fix> <https://launchpad.net/bugs/1714130> | 02:53 |
| anastasiamac | thumper: babbageclunk: i think ur work last week (or so?..) addressed this too :) bug 1597490 | 03:09 |
| mup | Bug #1597490: juju 2.0-beta9.1: juju relation status PROVIDES and CONSUMES confused <usability> <juju:Triaged> <https://launchpad.net/bugs/1597490> | 03:09 |
| babbageclunk | anastasiamac: true! | 03:42 |
| anastasiamac | babbageclunk: \o/ nice... do u remember if it went in 2.2.3? | 03:45 |
| babbageclunk | anastasiamac: yup - just commenting. It was fixed in August, so it'll be in 2.2.3. | 03:45 |
| thumper | https://github.com/juju/names/pull/82 needed for bundlechanges work | 03:45 |
| anastasiamac | babbageclunk: k, i'll do milestone magicking... | 03:46 |
| anastasiamac | wallyworld: yucks... another failure where juju is going to "dev version" for no apparent reason :( bug 1714526 | 03:52 |
| mup | Bug #1714526: juju 2.2.2.1 unable to add a unit to an existing service, no matching agent binaries found <canonical-is> <juju:New> <https://launchpad.net/bugs/1714526> | 03:52 |
| wallyworld | it's a dev version because a non-streams agent was used | 03:55 |
| anastasiamac | wallyworld: that's not the point | 03:57 |
| wallyworld | it is the cause of that error message | 03:59 |
| wallyworld | if it weren't a dev build, the error wouldn't happen | 03:59 |
| anastasiamac | wallyworld: it's in IS, bootstrapped with released 2.2.2, then something happen... according to the bug, they r not sure what... the point is - "this should not happen" or "we should know why it's happening and fix it" | 04:12 |
| wallyworld | agreed. i was merely commenting on the error message being valid if agent is dev version | 04:12 |
| wallyworld | it happends because there's a bug in upgrade-juju | 04:13 |
| wallyworld | which is on the todo list | 04:13 |
| anastasiamac | wallyworld: of coure. i was not asking for the cause. I was saying "yet again..." | 04:16 |
| wallyworld | ok :-) | 04:16 |
| wallyworld_ | axw: i've updated the pr with leadership checks etc. was a little messy to weave it into the uniter. pushed as another commit. i had to add an IsLeader attribute to the hook info (not serialised to state though). | 05:36 |
| axw | wallyworld_: ok, will take a look after I finish lunch | 05:36 |
| wallyworld_ | no rush, ty | 05:36 |
| axw | wallyworld_: I think it might be better if you put the SetStatus call in uniter/operation/runhook.go (specifically, runHook.afterHook) | 06:08 |
| axw | wallyworld_: there's already code in there that sets status after Start and Stop hooks | 06:08 |
| wallyworld_ | could do, ok | 06:08 |
| axw | wallyworld_: then you can use the HookContext directly | 06:08 |
| axw | no need to add IsLeader to hook.Info | 06:08 |
| wallyworld_ | i did look there and discounted for some reason | 06:08 |
| wallyworld_ | no idea why off hand | 06:09 |
| wallyworld_ | axw: oh i know why - the runner has no access to the relation so i'll have to add an extra method to the context | 06:20 |
| wallyworld_ | probably cleaner though | 06:20 |
| === akhavr1 is now known as akhavr | ||
| === frankban|afk is now known as frankban | ||
| wallyworld_ | axw: i've moved the set status to the afterHook callback | 08:25 |
| wallyworld_ | axw: not sure if you saw my msg above as you disconnected; i've moved the set status to the afterHook callback | 08:28 |
| axw | wallyworld_: thanks, I didn't. will take a look in a moment | 08:28 |
| wallyworld_ | no worries, no hurry | 08:28 |
| wallyworld_ | axw: what do you mean by "token is propagated to setStatus"? | 09:06 |
| axw | wallyworld_: see my earlier comment, "this token should be passed down to the SetStatus call. state.setStatusParams has room for a token." | 09:07 |
| wallyworld_ | ah, didn''t see that comment | 09:08 |
| wallyworld_ | axw: huh, nothing sets that token param at the moment that i can see. whoever put it there didn't wire it up | 09:15 |
| wallyworld_ | i think because the SetStatus interface method doesn't allow for it | 09:16 |
| wallyworld_ | set status in application facade also doesn't use it | 09:16 |
| axw | wallyworld_: the application facade? only thing setting status in there is your code isn't it? | 09:17 |
| axw | wallyworld_: I think it was added by William, but he didn't finish plumbing it through | 09:18 |
| axw | wallyworld_: in the case of Relation.SetStatus, I don't think we're using an interface, so it should be straight forward to add an optional leadership token | 09:19 |
| axw | we may not always want to set from the app leader, hence optional | 09:19 |
| axw | wallyworld_: please see my reply about application facade. I'll sign off, just want to make sure we're on the same page | 09:31 |
| axw | wallyworld_: in your other PR, I was thrown by the info.Info[0]. why do we assume that there's only one? | 09:36 |
| axw | wallyworld_: ping? did you see this? I'm OK with that, since it's non critical. Please file a bug and leave a TODO(wallyworld). | 09:55 |
| axw | FWIW, I don't think it's necessary to pass a token in the application facade (I assume you're referring to SetRelationsSuspended), because that's not being done by the application leader, but rather a client. And that code's meant to be going away anyway, right? In fact I think this PR is meant to be replacing it... except you're not setting the Joined status yet. | 09:55 |
| axw | wallyworld_: (I saw a !!build!! but no response) | 09:55 |
| rick_h | axw: what makes it harder in jaas? it's on the jaas tools to make that work mirroring the controller work. Is it because in the jaas clase it multiple clouds as well so the api is more complicated? | 10:23 |
| wallyworld_ | axw: sorry, didn't norice ping :-( | 10:45 |
| wallyworld_ | i'll add a todo | 10:45 |
| wallyworld_ | i just pushed a change to remove an api call | 10:45 |
| wallyworld_ | axw: i'm referring to SetStatus() | 10:46 |
| wallyworld_ | axw: with the network-get stuff, the code has historically used the first one for --primary-address | 10:47 |
| wallyworld_ | rogpeppe: hey, were you interested in the walking tour in NY? | 10:59 |
| rogpeppe | wallyworld_: hiya | 10:59 |
| rogpeppe | wallyworld_: possibly! i'd let it slide by without actually looking. let me take a look. | 10:59 |
| wallyworld_ | ok, just trying to get numbers as wit will affect what we do | 11:00 |
| rogpeppe | wallyworld_: i reckon i'm up for it | 11:07 |
| wallyworld_ | rogpeppe: ok, great, i think we have 6 | 11:46 |
| wallyworld_ | i'll see what I can tee up | 11:46 |
| rogpeppe | wallyworld_: cool | 11:46 |
| rogpeppe | wallyworld_: just so long as it doesn't interfere with my Irish trad session at 10pm :) | 11:47 |
| wallyworld_ | it won't :-) | 11:47 |
| axw | rick_h: IIANM, for it to work you'd need to use IAM roles. one controller with multiple credentials would make that complicated, I think | 12:01 |
| axw | wallyworld_: network-get can use the first one, but that doesn't mean we need to hide all the others up in the apiserver code. make that a frontend decision | 12:02 |
| wallyworld_ | axw: pretty much agree, was just being cautious about changing the semantics. since it was first written, network-get has returned Info[0] for primary-address | 12:03 |
| wallyworld_ | i can add them all | 12:04 |
| axw | wallyworld_: I'm saying you don't need to change network-get. make the decision in the network-get code, not in the apiserver side. | 12:04 |
| wallyworld_ | right, but there could be another api user, but probs not | 12:05 |
| wallyworld_ | i'll add all of them | 12:05 |
| axw | wallyworld_: was the *apiserver* code previously returning only the first one? I couldn't see it filtering out before | 12:07 |
| wallyworld_ | i thought it was, but maybe i am misremembering | 12:07 |
| axw | wallyworld_: AFAICS, only in NetworkGetCommand | 12:07 |
| axw | wallyworld_: I'm approving the relation one now, but in case you miss it: "See SetRelationsSuspended in the application facade, specifically the TODO you left." | 12:08 |
| axw | that's what I was referring to, re setting Joined/Suspended | 12:08 |
| wallyworld_ | ok, ty | 12:08 |
| axw | wallyworld_: I'm off now, will take another look at the network-get PR on Monday. have a nice weekend | 12:08 |
| wallyworld_ | axw: tyvm for reviews | 12:09 |
| wallyworld_ | you too | 12:09 |
| === beisner is now known as Beisner | ||
| === cory_fu_ is now known as cory_fu | ||
| === frankban is now known as frankban|afk | ||
| === Beisner is now known as beisner | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!