[05:44] Hi. Having problem with 0.7.9 where NoCloud (meta-data) files network-interfaces: | gateway won't be set when defined. address and netmask seems to be working. The system is using sysconfig.py as a renderer in my CentOS 7.4 and seems that gateway parameter is not reached in that renderer. Would there be some way in meta-data to by pass this problem in CentOS 7.4 case? Thanks a lot! [12:26] Managed to get it working with network-config file. [13:09] elurkki, what did you figure out ? [13:10] basically, the 'network-interfaces' is a legacy input [13:10] /etc/network/interfaces format is a poor and incomplete mechanism for defining network configuration. the network-config is the right way. [19:05] smoser: Where is the variant set for the templating engine? For some reason I am getting "linux" [19:07] the distro variant [19:07] from the sysinfo, one sec [19:08] robjo: see cloudinit/util.py:system_info() [19:09] looks like we'd need another elif linux_disk in [19:11] rharper: thanks, yes, but I think with complications due to build service .. investigating [19:24] OK, got that sorted out, but still failing with "KeyError: 'user'" from the templater, when processing the config template :( [19:25] https://pastebin.com/hLrLKBU0 [19:25] man. it just hurts my eyes to look at pastebin.com [19:27] robjo, you have no other changes ? [19:28] Well I am adding patches to try to get the templater to behave, so I added a variant for suse in the config template [19:28] I can push what I have to the build service if that would help [19:29] i think you dont have jinja [19:29] which clearly should fail in a more obvious way [19:31] bingo [19:32] and yes, when I set up the py3 build I have a BuildRequires for python3-Jinja2, but clearly I neglected this for the python2 build :( [19:32] thanks [19:41] robjo, did you see my response about python2 and argparse ? [19:41] i dont understand how you all hit this (nor do i understand the weird things i've seen on centos wrt argparse) [19:42] I did only skim your response since I am in the middle of getting the current version packaged [19:43] btw, setup.py still says 0.7.9, I was expecting 2017.1 ;) [19:44] well, it wont say that until the release. [19:44] but i think at this point we're one commit away. basically updating that. [19:47] I should have a bunch of patches by the end of the week basically more integration work do you want bugs for those? [19:50] robjo, yes pleas.e [19:50] OK [20:05] the get_data_file() test is failing in base.py , self.data is None, but I cannot find where self.data is supposed to be set?? [20:08] robjo, that isnt a test... it shouldnt be run [20:08] tests start with test_ [20:11] duh, the test triggering the issue is test_no_stages_errors [20:14] robjo, wow. that test has probably been broken for a while. [20:14] it wont get run because the file doesnt start with test_ [20:15] During package build I need to run with "python3 -m testtools.run" [20:15] oh [20:15] rigth [20:15] those arent for nose [20:16] those are c-i tests (continuous integration) [20:16] I guess I can just remove base.py [20:16] why ? [20:16] i'm sorry. [20:16] my first response was wrong [20:17] what is testtools.run ? [20:17] we don't use testtools we use nose. [20:17] its possible that both could be made to have the same behavior, but what *does* work is nose. [20:18] https://testtools.readthedocs.io/en/latest/ [20:19] blackboxsw, when we added cloudinit/ to the dirs that get tested, we did not add it in Makefile unittest3 [20:20] robjo, thats not how we run our tests. [20:20] its not to say its not valid or useful, just not what is used. [20:20] smoser: ahh right you are [20:21] it's under the makefile "unittest" target, ! unittest3 [20:21] I know, need to get the package build to resemble upstream testing, it's a time issue, as always.... [20:21] robjo, so what i'd suggest is you install nose and run 'make test' [20:22] what was it that is forcing you to run testtools.run ? [20:22] I'll try nose and see what falls over [20:22] smoser: we also have cloudinit module in tox -e py3 but not py27 [20:22] probably need it added everywhere [20:22] I forgot why I am running testtools, bad notes in the spec file :( [20:24] blackboxsw, i guess. [20:24] http://paste.ubuntu.com/25582039/ [20:24] running tests now [20:27] green for me: make unittest; tox. red: make unittest3 [20:30] hm. [20:30] blackboxsw, well make sure youd' have all deps installed [20:30] since you're not using tox [20:30] but i have to run. i'll be back in a few hours to check. [20:30] smoser: yeah I have make ci-deps-ubuntu :) [20:30] but it's a mock issue. [20:30] assert_called_once() DNE [20:31] cloudinit/net/tests/test_dhcp.py [20:31] need to use assert_called_once_with() [20:31] making the change [20:32] or assertEqual(1, mock_obj.call_count) [20:33] Well better than before, meaning I remove fewer tests :) those will have to wait for another day [20:34] ok tweaks to master work for me on ubuntu to include unit tests under cloudinit for make targets and tox envs [20:34] http://paste.ubuntu.com/25582096/ [20:34] will put up a trivial branch [20:39] https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/331099 [20:53] Cloud:Tools:Next cloud-init in OBS is building :) [20:53] will test in AWS tomorrow..... [21:07] woohoo \o/ [21:41] msaikia: sorry for the delay review posted on your branch [21:58] just merged just merged smoser/fix/makefile-not-find-bin [21:59] ok. thanks. [21:59] blackboxsw, https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/331099 [21:59] is that just an improvement on the test ? [22:00] smoser: yep, it just usess mocked_obj.call_count instead of assert_called_once (which isn't defined on py3 unittests) [22:00] hmm. [22:00] and it adds a failure message of 'dhcp_discovery not called once' instead of 0 != 1 [22:01] if the assert were to fail [22:01] I'll check centos w/ that to see if that jives [22:01] yeah. [22:01] i think that it just did nothing [22:02] hm.. [22:02] wonder how it worked [22:02] it is "new in version 3.6" [22:02] https://docs.python.org/3/library/unittest.mock.html [22:03] I thought we added it in tests/helpers too [22:03] for earlier versions of unittest [22:04] we added assert_not_called [22:07] yeah. i commented in there [22:07] when you ran not in tox you did not have python3-mock installed [22:08] so you got the builtin version of python3.5's mock [22:08] and that didnt have that function [22:08] i think [22:08] anyway. i ack'd [22:08] please merge that. [22:08] and i have to go afk again . thanks blackboxsw [22:08] cheers [22:08] will do [22:08] robjo, you have a link to a build ? [22:09] yeah I've got kid's soccer practice to head to in 30. I think I can beat them this time [22:10] https://build.opensuse.org/project/show/Cloud:Tools:Next [22:10] smoser: ^^^^ [22:22] excellent robjo care if we add a link to that in the weekly cloud-init status (credited to you of course)? [22:27] example of the syndicated content https://insights.ubuntu.com/2017/09/19/ubuntu-server-development-summary-19-sep-2017/ for weekly status is here < [22:30] tested on cent7 and cent6 [22:42] merged