/srv/irclogs.ubuntu.com/2017/10/02/#cloud-init.txt

robjosmoser: blackboxsw So where do we stand with https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/33114913:34
robjoFrom my point of view things become ever more confusing13:34
robjoif we agree on the format then I will carry the patch that we have in the SUSE package, I need to move forward on that front13:35
smoserrobjo, sorry... we stand where i was in a sprint all last week and delinquent13:37
robjoif the patch cannot move forward for whatever reasons then so be it, given the current state I do not see how fiddling anymore with this patch set before committing makes any sense as we have comments upon comments upon changes and more comments, I've lost track of it all13:37
smoseri'll look and/or talk to chad today. oh. looks like chad just commented 11 minutes ago.13:37
smoser i'll read some13:37
robjothanks,13:38
robjosmoser: and I still cannot reproduce the bot failure locally :( worse yet I do not understand what the log is telling me13:42
smoserrobjo, ok. i have one other thing i need to be looking at at the moment, but someone will get a look at it today13:52
robjosmoser: thanks13:52
blackboxswrobjo: I'm backing down on the patch suggestion, but I'll add some inline comments about some of the code in add zypper to reorder a bit of the required/defaulted  checks to avoid what feels like a bit of extra work.15:30
blackboxswmeh robjo you took the patch. sorry 'bout that. nits etc.15:34
robjoblackboxsw: took some of the changes yes, will look at the next set of comments15:35
blackboxswI'm looking over the latest and it feels good. just CI complaints on testing. I'm giving it a thorough review now (not a mid-trevel review)15:36
blackboxswmid-travel rather15:36
ajorgquestion: I thought if my boothook had output I'd see it on the console and in the cloud-init-output.log, but I don't. Is this expected behavior? (on Ubuntu 16.04 LTS)15:42
smoserajorg, you should yes.15:58
ajorghmm, will have to troubleshoot after the meeting then15:58
ajorgthanks15:58
smoseryikes.16:02
smosermeeting16:02
smoserblackboxsw, rharper16:02
blackboxswoops I set wrong UTC time16:03
ajorgtoo early? :-)16:03
blackboxswright should be now16:03
smoserhtis is right.16:03
smoseryeah16:03
=== blackboxsw changed the topic of #cloud-init to: is Reviews: http://bit.ly/ci-reviews | Meeting minutes: https://goo.gl/mrHdaj | Next status meeting: Monday 10/2 16:00 UTC | cloud-init 17.1 released
blackboxswoops16:03
smoseris the but here, blackboxsw  ?16:04
smosershould that work ?16:04
rharperbah16:05
rharperhere16:05
rharperbot16:05
blackboxswyep it should16:05
rharpersmoser: I see meetingology16:05
smoser#startmeeting cloud-init16:05
meetingologyMeeting started Mon Oct  2 16:05:47 2017 UTC.  The chair is smoser. Information about MeetBot at http://wiki.ubuntu.com/meetingology.16:05
meetingologyAvailable commands: action commands idea info link nick16:05
smoser#topic Recent Changes / Highlights16:06
smoserhm..16:06
smoser17.1 released https://lists.launchpad.net/cloud-init/msg00106.html16:06
smoserthats the biggest thing and only thing i have for this topic16:06
blackboxsw#link  https://lists.launchpad.net/cloud-init/msg00106.html16:06
smoserhoray for a release, thanks to those who contributed.16:06
rharper\o/16:07
smoser17.2 is set for 2017-12-1416:07
smoser https://launchpad.net/cloud-init/+milestone/17.216:08
ajorgyay!16:08
smoserfeel free to target bugs to that release.16:08
rharper#link https://launchpad.net/cloud-init/+milestone/17.216:08
rharper#info please target bugs to the next release16:08
smoserdoes that do anyting ?16:09
rharperin the meeting summary, it does16:09
blackboxswsmoser: the links showed up in meeting minutes last time16:09
smoserk. i always expected the bot to tell me that in a pm16:09
blackboxswmeetingology didn't echo though16:09
rharperwell, smoser may have to do those16:09
smoser#topic In Progress Development / Highlights16:09
blackboxswsame. but something is up that needs attention.16:09
blackboxswI'll properly handle it when publishing16:10
rharpercool16:10
smoserMerge Proposals16:11
smoser#link http://bit.ly/ci-reviews16:11
smoserthere are some there for sure. i know that robjo has some he's interested in, and i think ajorg's instance-identity deserves a look16:11
smoseras well as simpletable for 17.216:12
ajorgI'd be grateful for both, yes.16:12
smoseri am looking at the 'networkd' one which is a blocker as currently Ubuntu does not work properly on azure16:12
blackboxswwe should have more bandwidth this week16:12
smoserand all sysstemd-networkd systems will not work properly on CloudStack.16:12
smoseranything else there?16:12
robjoThe task limit increase has been tested and solves our problem, thus merging would be great16:13
smoserrobjo, yeah. athat does seem unlikely to cause issue16:13
smoserTrello Board16:13
smoser# https://trello.com/b/hFtWKUn3/daily-cloud-init-curtin16:13
rharper#link  ?16:13
smoser#link https://trello.com/b/hFtWKUn3/daily-cloud-init-curtin16:13
robjohttps://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+ref/taskLimit that's the branch for the task limit16:14
robjoSorry, I can never find the link for the open merge proposals :( problem exists between the keyboard and the chair16:15
blackboxswwill get eyes on that today robjo as your addZypper is about wrapped16:16
smoserBugs16:16
smoser#link https://bugs.launchpad.net/cloud-init16:16
smoserjust mostly pointers... above.16:16
smoserfor Ubuntu in 16.04, there is one SRU in progress that blackboxsw and i need to verify today16:16
smoserand then we will be soon looking at doing an SRU of 17.1-ish16:16
robjoThanks, still in europe, my day is about done, will pick it up tomorrow16:17
smoserrobjo, link is in topic16:17
smoserhttp://bit.ly/ci-reviews16:17
smoserok. so open discussion i guess. no w?16:17
smoser#topic Open Discussion / Office Hours16:17
smoserwe'll hang around and pay attention to pings and discussion fro the next 30  minutes or so.16:17
smoserand after that, feel free to ping.16:18
ajorgI'm writing a unit test for a bugfix I'm preparing to submit. It works, but it's slow because readurl retries and waits a second each time16:19
ajorgI'm a bit of a mock / patch newb. Anyone can help me see how to patch that argument?16:20
smoseryou can feel free to  mock readurl16:20
smoserand set its return_value and look at calls16:20
smoserthen you dont have to httppretty.16:21
ajorgThe only thing I want to change about it is the sleep though. Is there a straightforward way to just change one arg?16:21
blackboxswtests/unittests/test_handler/test_handler_chef.py is an example and tests/unittests/test_datasource/test_maas.py16:21
blackboxswI think16:21
ajorgHmm, I could do that, yeah. Would be sufficient for this.16:21
ajorgI'd still like to know if there's an easy way to just change one argument to something that gets called somewhere else.16:22
smoseryou could also mock the time.sleep from url_helper16:22
ajorghahaha, yes. that's what I need to do.16:22
rharperajorg: if you want to mock the sleep you can decorate the test_ method with @mock.patch(time.sleep)16:22
smoserwe're suggesting other ways generally because there isn't :) at least that i know of.16:22
ajorgthat's cool, patching time.sleep will do nicely16:23
ajorgis there an integration test that looks at what lands on the console?16:24
ajorg(going back to my question from before the meeting)16:24
smoserno. there coudl be on the nocloud-kvm backend16:25
smoserbut i think there is no console access currently on lxd16:25
smoserand i think that we do not collect console access on nocloud-kvm16:25
smoserbut as you suggest we should for sure16:25
ajorgk16:25
ajorgI wondered if systemd might be swallowing my output, or maybe python (boothook in this case is a python script) is making a strange choice when it sets up logging.16:26
rharpercertainly possible;  I know there were issues with cloud-init starting before say rsyslog on non-systemd boots16:27
rharperand the python logging has changed w.r.t the default configuration;  cloud-init main sort of expects this transition as it starts up in init-local and it has not yet read the cloud-config for logging configuration yet, so it reads that and then does some replay16:28
ajorginteresting16:28
smoserajorg, you're writing to stdout/err with logging from a boothook ?16:29
ajorgat least I would have thought cloud-init-output.log would contain my logs though, since it's more a redirect of stderr and stdout, right?16:29
ajorgyeah16:29
rharpercorrect16:29
rharperthis is from a bootcmd ?16:29
ajorgno, #cloud-boothook16:29
* rharper hasn't used boothook16:29
smoserhm..16:29
ajorgboothooks are super useful16:30
rharpersmoser: when do boot_hooks run ?  local ?  net ?16:32
rharperI'm not sure yet where stdout/err for boot hooks occur, but you can dump each from the units via:  journalctl -u cloud-init-local.service   (or cloud-init.service)16:33
blackboxsw"This is the earliest hook available. Note, that there is no mechanism provided for running only once"16:33
blackboxswI'm checking the code now (local/pre-local maybe)?16:34
rharperyeah, saw that;  it runs in-image scripts programs16:34
ajorgI did that too, and don't see anything.16:34
ajorg(journalctl)16:34
rharperyou should see some output16:34
rharperbut not seeing your hook in there ?16:34
ajorgI can tell by other means that the hook ran16:34
ajorgjust don't see that it printed anything16:34
ajorgmy prime suspect if systemd can't do something bad here is that python makes some decision about not actually logging.16:35
ajorgand I need to be more explicit that it should log16:35
rharperso, the boot_hook will sub out each part, I see no capture on the stderr/stdout ; so I would expect those to go to whatever is currently capturing those;16:36
rharpers/sub/subprocess16:37
ajorgyup, that's what I expect too, and what I recall seeing on Amazon Linux16:38
rharpersince it's using cloud-init's util.subp, there *should* be a debug level message saying 'Running command %s with allowed return codes %s' which maches a path to the boothook16:38
rharperI would expect to see that in the cloud-init.log16:38
smoserhttp://paste.ubuntu.com/25661692/16:39
ajorgyup, I do see that16:39
rharperthe output of script, I *think* should go to cloud-init-output.log16:39
smoseri'm testing ^ on serverstack now.16:39
smoseri verified the commands run on lxd but not look at console there.16:39
ajorgthanks16:39
smoseractually.. yeah, BOOTHOOK does run, but doesnt seem to have stdout tied to same place as bootcmd16:40
ajorgoh?16:41
ajorgI'm slightly surprised it's not just me16:41
smoserhttp://paste.ubuntu.com/25661714/16:42
rharperit really should be in the journal/console if stdout is not redirected to a file, cloud-init-local service16:42
smoserthat reproduces in lxc16:43
rharpersmoser: in your  instance on serverstack, do you see your BOOTHOOK in journalctl -b -u cloud-init-local.service ?16:44
smoserajorg, please go ahead and open a bug.16:44
ajorgcool (not cool :-P)16:44
ajorgwill do16:44
smoser# journalctl -b -u cloud-init.service | grep BOOT16:44
smoserOct 02 16:37:41 a5 cloud-init[121]: BOOTCMD: Mon, 02 Oct 2017 16:37:41 +0000: a516:44
smoser^ that is from lxd16:44
rharperand what about the welcome message from cloud-init ?16:45
smoseri think not.16:45
rharperbootcmd does:  util.subp(cmd, env=env, capture=False) ; where boot_hook does: util.subp([filepath], env=env)16:45
smoseryeah, so boot_hook definitely swallowed. and should not be.16:46
rharperyeah16:47
ajorghttps://bugs.launchpad.net/cloud-init/+bug/172084116:49
ubot5Ubuntu bug 1720841 in cloud-init "Output from boothook is not logged" [Undecided,New]16:49
ajorgMeanwhile I need to setup more explicit logging from that boothook anyway, so I'm okay.16:50
blackboxsw#link https://bugs.launchpad.net/cloud-init/+bug/172084116:51
ubot5Ubuntu bug 1720841 in cloud-init "Output from boothook is not logged" [Medium,Confirmed]16:51
ajorgHere's another one, which I've confirmed with a unit test and proposed a patch: https://bugs.launchpad.net/cloud-init/+bug/172084416:55
ubot5Ubuntu bug 1720844 in cloud-init "UrlError from #include aborts stage" [Undecided,New]16:55
ajorg(what is this #link thing you're doing there?)16:55
smoserwell, the bot is supposed to care and do somethign with it.16:55
smoserbut /me thinks it doesnt work right :)16:56
blackboxswajorg: since meetingology is still active, the theory is it is keeping track of links  during this meeting16:56
smoser(during the meeting)16:56
ajorgah, okay16:56
ajorgI think simpletable is completely ready to merge, btw. Any objections? https://code.launchpad.net/~ajorgens/cloud-init/+git/cloud-init/+merge/33052516:57
blackboxswThe theory is it writes the meeting notes out for us so we can publish to https://cloud-init.github.io16:57
ajorg#link https://code.launchpad.net/~ajorgens/cloud-init/+git/cloud-init/+merge/330525 ;-)16:57
blackboxswgeg16:57
blackboxswheh16:57
blackboxswajorg: I think we were good on that changeset, and we only wanted to wait post 17.1 cut to avoid potential regression16:58
ajorggreat16:59
blackboxswI'm +1 on that will give it a spin today and then I think we can land it16:59
smoserblackboxsw, ajorg my thoughts on the simpletable...17:01
ajorghere it comes...17:01
ajorg:-P17:01
blackboxsw:)17:01
smoseri would like to have a machine friendly output available17:02
smoserhuman friendly is good, but machine friendly solves the actual goal of writing the stuff.17:02
ajorgSo I modified it to display *exactly* as prettytable did17:02
smoseroh really.17:02
smoserwow17:02
ajorgwhich is admittedly not machine friendly17:02
ajorgnot especially17:02
smoserthen i guess i can't object at all.17:02
ajorgbut it's at least as good as prettytable17:02
smoserin that its backwards compat17:03
smoserright.17:03
ajorg^ this was my goal, to get you to not object17:03
smoseri still think we should probaly additionally write some machine friendly json17:03
ajorgagreed, that would be better17:03
smoseri tihnk having something human friendly is good though17:03
smoseras i know *I* look at that output17:03
ajorgit meets my goal of not depending on prettytable17:04
smoserand parsing json would be less nice17:04
smoseryeah17:04
smoserso based on your assertion that it outputs the same as pretty table, i have no objections. only future hopes.17:05
smoserand i do agree dropping pretty table is nice17:05
ajorgwinning17:05
blackboxswsmoser: yeah I was wondering how we generally expect people/machines to parse cloud-init-output.log. Right now it's kindof hard to do machine parsing of cloud-init-output.log.17:06
smoserblackboxsw, yeah. cloud-init-output.log is not intended to be machine friendly.17:07
blackboxswdo we know already of non-human consumers of the formatting in cloud-init.output.log?17:07
smoserbut the console actually has value in having machien friendly things on it.17:07
smosermy feeling is if you have access to /var/log/cloud-init.log, then you could very easily have written whatever you wanted to another file that was purely machine friendly.17:08
blackboxswwas wondering where we would intend to dump machine-friendly json17:08
blackboxswyeah17:08
smoserbut the console (/dev/ttyS0) boot log is different17:08
smoserin that it can give you a couple things you'd not find easy access to17:08
smosera.) ssh public keys for the system (providing out of band communication of this data)17:09
smoserb.) network configuration info: providn useful bits of data on how you might get to this system17:09
smosersystemd makes it "fun" to get that data to the console in a safe way17:10
ajorgugh yes. systemd like to stomp all over your consoles.17:12
blackboxswok so did we want to iterate on simpletable to dump json, or just look for cloud-init to write supplementary json files under /run/cloud-init17:19
blackboxsw.. after we land ajorg's branch17:20
ajorgI think it's a good idea to dump json fragments to console for some things, but I suspect smoser will still not want to break anyone who might be using the tables, so probably best to land my branch as-is17:21
smoseryeah, i agree with ajorg. for now, we can just take a replacement that drops prettytable17:23
smoserthere are improvments to be done there, but this is a simple win17:23
smoserwe'll go ahead and end meeting here.17:29
smoseri'll still be around. thanks all!17:29
smoser#endmeeting17:29
meetingologyMeeting ended Mon Oct  2 17:29:26 2017 UTC.17:29
meetingologyMinutes:        http://ubottu.com/meetingology/logs/cloud-init/2017/cloud-init.2017-10-02-16.05.moin.txt17:29
smoserblackboxsw, https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/33166417:29
smoserwould appreciate input there.17:29
blackboxswlooks like links got handled by meetingology, not infos. ok will fix that for next meeting17:30
smoserblackboxsw, http://paste.ubuntu.com/25662210/18:27
smoserthat was my "mark-released" that i used for cloud-init18:27
smoserpowersj, ^. mentioned we'd want to put that somewhere and then can improve on it for other things too18:28
smosermainly i'm using pastebin and irc logs as a persistent storage system right now18:28
powersjsmoser: thx18:29
blackboxswsmoser: powersj pushing it to qa-scripts18:37
blackboxswon the review too18:37
blackboxswajorg: landed simpletable18:58
ajorg\o/19:01
ajorgthank you19:01
blackboxswrobjo, sorry I forgot to hit approve button w/ final comments https://code.launchpad.net/~rjschwei/cloud-init/+git/cloud-init/+merge/33114919:09
=== blackboxsw changed the topic of #cloud-init to: is Reviews: http://bit.ly/ci-reviews | Meeting minutes: https://goo.gl/mrHdaj | Next status meeting: Monday 10/16 16:00 UTC | cloud-init 17.1 released
blackboxswsmoser: powersj rharper time/date check on next cloud-init meeting in topic19:10
smoserk19:10
blackboxswso I don't mess that up again19:10
rharper% date --utc -d "2 weeks"19:11
rharperMon Oct 16 19:11:22 UTC 201719:11
blackboxsw:) just checking that we weren't all up to something else (trips/early Halloween etc.)19:12
powersjI think we are good19:12
rharperlol19:12
rharpershould be fine19:12
smoserblackboxsw,19:14
smoser$ python3 -c 'from cloudinit.simpletable import SimpleTable'19:14
smoserTraceback (most recent call last):19:14
smoser  File "<string>", line 1, in <module>19:14
smoserModuleNotFoundError: No module named 'cloudinit.simpletable'19:15
smoseri think somehow you didn't get the simpletable.py file added19:15
blackboxswbah, merge fail. grabbing it19:15
blackboxswpushed19:17
blackboxswgoing fresh checkout again to be sure19:18
blackboxswtox passes clean master19:21
blackboxswstarting off the week right19:22
smoserpowersj, https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/33167019:22
smoserif you review that i'll get the other branches19:23
smoserby 'get', i mean i'll just commit to the ubuntu packaging branches.19:23
blackboxswsmoser: approved w/ nits https://code.launchpad.net/~smoser/curtin/trunk.doc-interface/+merge/33160819:37
blackboxswwrong channel19:38
powersjCI isn't happy at the moment... ERROR: Failure: ImportError (No module named simpletable)19:40
powersjsmoser: looking19:40
powersj+119:40
blackboxswpowersj: just pushed a fix19:46
blackboxswb3acdff390329c8091b880b490e1f27441a7a48619:46
blackboxswI had missed it when merging ajorg's branch19:47
blackboxswI forgot to 'git add' the new files19:47
ajorgoh?19:47
smoserblackboxsw, did you say you did https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/33166419:48
smoseri dont see a comment19:48
blackboxswsorry ajorg, I shouldn't have hilighted you. it was PEBKAC on my merge of your branch19:49
blackboxswall good now19:49
ajorgblackboxsw: did I prepare that MP in some wrong way that lead to the mistake?19:49
blackboxswnope, all my fault19:49
blackboxswwon't happen next merge19:49
ajorgk19:49
ajorgno judgement19:50
blackboxsw<- the judgement is all in this guy's head19:50
blackboxswsmoser: I hadn't yet commenting now, wrapped up your curtin branch and robjo's, now the dhcp19:50
blackboxswonly comment I have so far smoser is that the sort order should be reversed I think for systemd's/leases directory (isn't higher # more recent? )20:07
blackboxswtesting meetingology for a sec21:13
blackboxsw#startmeeting Test captured commands21:14
meetingologyMeeting started Mon Oct  2 21:14:28 2017 UTC.  The chair is blackboxsw. Information about MeetBot at http://wiki.ubuntu.com/meetingology.21:14
meetingologyAvailable commands: action commands idea info link nick21:14
blackboxsw#commands21:15
meetingologyAvailable commands: action commands idea info link nick21:15
blackboxsw#info test info21:15
blackboxsw#link test link21:15
blackboxsw#nick test nick21:15
blackboxsw#idea test idea21:15
blackboxsw#meetingtopic topic change doesn't work21:15
blackboxsw#topic do topics work?21:16
seditionlol21:16
blackboxsw#action sedition joins in on the fun (but actions don't work)21:16
meetingologyACTION: sedition joins in on the fun (but actions don't work)21:16
blackboxswahh thank you meetingology21:16
blackboxsw#idea I think only circle of friends commands work here21:17
blackboxswguess not21:17
blackboxsw#subtopic sub topic doesn't work21:17
blackboxsw#endmeeting21:17
meetingologyMeeting ended Mon Oct  2 21:17:34 2017 UTC.21:17
meetingologyMinutes:        http://ubottu.com/meetingology/logs/cloud-init/2017/cloud-init.2017-10-02-21.14.moin.txt21:17
blackboxswthis concludes our broken broadcast. I'm hitting up #meetingology to see what gives21:17
seditionwhat an interesting concept21:18
blackboxswlooks like action, idea, subtopic work21:18
blackboxsw:)21:18
seditioni dont think ive ever seen a meeting minutes bot21:18
blackboxswheh, it's supposed to make meeting minutes publishing easier... per commands listed here: https://wiki.ubuntu.com/meetingology21:19
blackboxswok looks like most of those commands were properly handled21:22
blackboxswjust that meetingology doesn't repeat (it's silent)21:23
blackboxswok I think we are good then.21:23
smoserblackboxsw,  https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/331664 updated21:34
smoseri can hp back in later tonight and upload that or address further feedback21:35
blackboxswsmoser: looks good on the changeset.21:49
blackboxswI'll approve and give it a whirl on on upgrade azure21:49
blackboxswupgraded21:49
blackboxsw&& lxd21:52
powersjblackboxsw: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/331678 (if you have time)22:01
blackboxswshould be able to get that today22:03
blackboxswstraight forward fix22:03

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!