[01:41] <sergiusens> kyrofa snapcraft#1581 should be fine
[01:41] <mup> PR snapcraft#1581: catkin plugin: support rosdep pip dependencies <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1581>
[04:18] <mup> Bug #1577471 changed: Snap applications cannot access the user's normal XDG directories <personal> <snap-desktop-issue> <snapd-interface> <Canonical System Image:Invalid by pat-mcgowan> <Snappy:Expired> <https://launchpad.net/bugs/1577471>
[06:26] <mup> PR snapd#3996 opened: snap: refrain from running filepath.Base on random strings <Created by chipaca> <https://github.com/snapcore/snapd/pull/3996>
[06:34] <mup> PR snapd#3997 opened: cmd/snap: completion for alias and unalias <Created by chipaca> <https://github.com/snapcore/snapd/pull/3997>
[06:43] <mup> PR snapd#3998 opened: snap-confine, snap-seccomp: Utilize new seccomp logging features <Created by tyhicks> <https://github.com/snapcore/snapd/pull/3998>
[07:02] <mup> PR snapd#3991 closed:  wrappers: fail install if exec-line cannot be re-written <Created by mvo5> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/3991>
[08:04] <pstolowski> yay, my rpis3 should arrive on friday
[08:08] <zyga-ubuntu> pstolowski: nice :)
[08:08] <zyga-ubuntu> pstolowski: did you get any cases?
[08:08] <zyga-ubuntu> pstolowski: I have a few and I can share experiences
[08:10] <pstolowski> zyga-ubuntu, yeah, I got 2 different cases - https://www.amazon.de/gp/product/B01F1PSFY6/ref=oh_aui_detailpage_o00_s00?ie=UTF8&psc=1 and https://www.amazon.de/gp/product/B00MQLB1N6/ref=oh_aui_detailpage_o00_s00?ie=UTF8&psc=1
[08:11] <zyga-ubuntu> pstolowski: I have the first one
[08:11] <zyga-ubuntu> pstolowski: it's easy to assemble and disassemble but doesn't stack
[08:12] <zyga-ubuntu> the second one looks very nice
[08:12] <pstolowski> right, it's curved
[08:58]  * zyga-ubuntu -> walk
[09:32] <zyga-ubuntu> re
[09:32] <zyga-ubuntu> ok, now just focus on work :)
[10:27] <__chip__> zyga-ubuntu: as opposed to focus on what?
[10:28] <zyga-ubuntu> __chip__: distractions that plague this morning
[10:29] <ikey> heh
[10:29] <__chip__> zyga-ubuntu: like https://guacamole.incubator.apache.org ?
[10:30]  * __chip__ might be eviler than usual today
[10:30] <zyga-ubuntu> hmm?
[10:30] <zyga-ubuntu> what is that?
[10:31] <zyga-ubuntu> interesting software I see
[12:25] <Son_Goku> morning all
[12:26] <zyga-ubuntu> Son_Goku: hey
[12:26] <ikey> Morn
[12:27] <Son_Goku> ikey: you're alive!
[12:27] <ikey> yessir - hows it?
[12:31] <Son_Goku> ikey: I got sick literally the moment I got home
[12:31] <ikey> yikes
[12:33] <Son_Goku> my nose is completely stuffed and I have a constant headache :(
[12:35] <ogra_> Son_Goku, welcome to the club
[12:36]  * zyga-ubuntu is sick just because of weather, not any fancy travel smavel
[12:36] <Son_Goku> well, I think I'm sick because of the weather rather than anything else
[12:36] <Son_Goku> I didn't travel very far...
[12:38] <ikey> 7C here atm
[12:41]  * ogra_ wonders if xnox has an idea about https://forum.snapcraft.io/t/networkd-fail-to-set-ip-address-between-leases-if-ip-address-changes/2333 ... being fluid in system-networkd
[12:42] <Son_Goku> ikey: 12C here
[12:42] <Son_Goku> but it was 8C a few hours ago
[12:44] <zyga-ubuntu> pstolowski: hey, would you mind looking at https://github.com/snapcore/snapd/pull/3971
[12:44] <mup> PR #3971: interfaces/mount: make Change.Perform testable and test it <Created by zyga> <https://github.com/snapcore/snapd/pull/3971>
[12:46] <pstolowski> zyga-ubuntu, will do
[12:49] <sergiusens> nacc are you registered on the forum?
[12:49] <zyga-ubuntu> pstolowski: thanks, there's also a small second branch if you want to look
[12:51] <Son_Goku> zyga-ubuntu, so, when are you going to start writing the SELinux backend for snap-confine? :)
[12:53] <xnox> ogra_, i need a dump of /run/systemd/netif/leases/* during all stages (one lease, two leases, first expired, both expired), in a launchpad bug report filed with ubuntu-bug systemd
[12:54] <ogra_> xnox, no "ubuntu-bug" on core
[12:54] <xnox> config for the dhcp server / interactive script to reproduce would be helptful too.
[12:55] <xnox> ogra_, if a bug needs to be looked into a bug report is needed
[12:55] <zyga-ubuntu> Son_Goku: not sure, I need to finish layouts still, though I'm not alone anymore so that's a big relief
[12:55] <ogra_> xnox, well, the forum kind of became the bugtracker for snap, but i can ask him to file a LLP bug
[12:55] <ogra_> -L
[12:56] <xnox> sure but this particular part (systemd-networkd) comes from a package in ubuntu, for which bug tracker is launchpad.net/ubuntu/+source/systemd
[12:57] <xnox> and lp:~ubuntu-core-dev/ubuntu/+git/systemd git repository
[12:57] <ogra_> sure
[12:58] <ogra_> note that there are PPAs for backported packages involved (netplan specifically)
[12:59] <ogra_> (also ... i think core is the only flavour that makes use of networkd in xenial)
[13:01] <pstolowski> zyga-ubuntu, I can try :). nb, I've adressed your review feedback for early-sanitize
[13:01] <zyga-ubuntu> pstolowski: I saw, thank you
[13:01] <pstolowski> ah, you replied, just noticed
[13:30] <zyga-ubuntu> niemeyer: oh, one more thing
[13:30] <zyga-ubuntu> niemeyer: we need manjaro icon on https://snapcraft.io/
[13:31] <davidcalle> zyga-ubuntu: this is coming today/tomorrow
[13:35] <ogra_> Mister_Q, should the UBports installer site there for a long time in "Ready to install..." (trying to switch my pro5 to ubports via the ubports-installer snap here)
[13:36] <ogra_> *sit there
[13:36] <ogra_> (seems to not move at all)
[13:37]  * zyga-ubuntu -> break for lunch and back to small PRs that improve snap-confine
[13:37] <mup> PR snapd#3999 opened: cmd/snap-confine: add detection of stale mount namespace <Created by zyga> <https://github.com/snapcore/snapd/pull/3999>
[13:46] <niemeyer> zyga-ubuntu: And also that other one...
[13:52] <sergiusens> kyrofa when you are up, can you read through this thread so we can have conversation later in the day on where/how this https://forum.snapcraft.io/t/classic-snaps-failing-on-ubuntu-17-10/2324/37 ?
[13:54] <zyga-ubuntu> niemeyer: indeed :)
[13:54] <zyga-ubuntu> niemeyer: I'll note to do that
[13:54] <zyga-ubuntu> re :)
[13:55] <niemeyer> zyga-ubuntu: Although I haven't really found good references to snaps in the web page, so maybe let's not add until there's something we can explicitly point to
[13:55] <zyga-ubuntu> niemeyer: I think having install instructions is a must, I'll install them and check in the evening
[13:55] <zyga-ubuntu> I need to find a moment to swap my HDD, I bought a 2TB HDD as update to my laptop
[13:56] <zyga-ubuntu> (I ran out of VM space)
[13:56] <niemeyer> zyga-ubuntu: I wouldn't worry about it.. layouts are way more important
[13:56] <ikey> i know the snap-update-ns changes bricked solus btw
[13:56] <ikey> i was toying with git master last week
[13:56] <zyga-ubuntu> niemeyer: ok :)
[13:56] <zyga-ubuntu> ikey: oh, can you tell me more?
[13:56] <ikey> ya basically i was getting no such file or directory error from it
[13:56] <ikey> when it was invoked from snapd
[13:56] <zyga-ubuntu> aha...
[13:56] <ikey> (i straced which is how i know it came from snap-update-ns itself)
[13:57] <zyga-ubuntu> ikey: is that on current solus package? I investigate
[13:57] <zyga-ubuntu> ikey: do you have the strace somewhere?
[13:57] <ikey> nah not on the current pkg
[13:57] <ikey> we're at, um
[13:57]  * ikey looks
[13:58] <ikey> 2.27
[13:58] <ikey> ill need to rebase it to newer master anyway as some of my PRs are in
[13:58] <ikey> and i gotta figure out what strays i have left from ubuntu rally
[13:58] <zyga-ubuntu> ok
[13:58] <niemeyer> ikey: Thanks for letting us know. As an aside, please note we're working on major improvements around mounting  flexibility so we can support layouts and more. Following git too closely may be a bumpy ride for a while for that reason.
[13:58] <zyga-ubuntu> ikey: let me know if you have some details
[13:59] <zyga-ubuntu> ikey: strace is one thing
[13:59] <zyga-ubuntu> ikey: but golang and strace don't work very well AFAIK
[13:59] <zyga-ubuntu> ikey: you may need some prints here and there
[13:59] <ikey> niemeyer, yeah this was on-the-day-git-master
[13:59] <ikey> zyga-ubuntu, thats what im thinking
[13:59] <ikey> just printf the hell out of it
[14:00] <ikey> but if git is rocky right now then ill leave it a little while longer
[14:00] <niemeyer> zyga-ubuntu: strace shouldn't care about language
[14:00] <ikey> strace will just follow the underlying syscalls
[14:00] <niemeyer> zyga-ubuntu: You may be thinking of ltrace?
[14:01] <zyga-ubuntu> niemeyer: hmmm, last time I tried strace and golang didn't work at all, maybe it is because of the threads and I dind't specify -f and I assumed it's something broken somewhere
[14:01] <niemeyer> ikey: Yeah, I suggest following the releases.. once it reaches candidate we're pretty sure we have a winner
[14:01] <ikey> yeah
[14:02] <ikey> then i can get the last of the needed solus PRs together
[14:02] <ikey> and 2.29 would be full upstream solus support
[14:02] <ikey> \o/
[14:03] <niemeyer> https://www.irccloud.com/pastebin/zJXwdBQ8/
[14:03] <niemeyer> zyga-ubuntu: ^
[14:04] <niemeyer> zyga-ubuntu: It wouldn't really make sense for it not to work.. this traces system calls, not application logic
[14:04] <niemeyer> zyga-ubuntu: It will likely be much noiser though, due to the runtime
[14:06] <elopio> Good morning!
[14:07] <zyga-ubuntu> elopio: o/
[14:07] <elopio> I hope everybody is safe back home now. It was nice to meet you all last week.
[14:08] <elopio> zyga-ubuntu: and we missed you. Hopefully next time it won't be in the US
[14:08] <zyga-ubuntu> elopio: or I will be able to come
[14:10] <elopio> A different country will be better 😃
[14:11] <zyga-ubuntu> costa rica maybe?
[14:12] <ogra_> +100
[14:13] <niemeyer> zyga-ubuntu: https://github.com/nomad-desktop/nx-software-center
[14:14] <ikey> nx = nixos right?
[14:14] <ikey> er
[14:14] <ikey> nxos
[14:14] <ikey> the kde desktop that looks like budgie but isnt
[14:14] <ogra_> nixos
[14:14] <ogra_> using the nix package manager
[14:14] <ikey> right its the one that isnt that one
[14:14] <niemeyer> zyga-ubuntu: Or Puerto Rico.. I've heard the gov doesn't mind as much there.. </troll>
[14:14]  * ikey gets confused on that too
[14:15] <ikey> https://nxos.org/#nomad-desktop
[14:15] <ikey> there, nxos
[14:15] <ikey> the not-budgie-budgie
[14:15] <ogra_> https://nixos.org/nix/
[14:15] <ogra_> :P
[14:15] <ikey> not confusing at all
[14:15] <ikey> lol
[14:16] <niemeyer> ikey: Yeah.. I was surprised to find out about it.. seems like a curious mixture.. claims it's based on Ubuntu, but no debs, pacman, plus snaps
[14:16] <niemeyer> Wonder if the author is around here
[14:16] <ikey> wonder if they've jumped on the ostree bandwag.. wait.. pacman?
[14:16] <ikey> what the shizz
[14:16] <niemeyer> Yeah, don't ask me
[14:17] <ikey> pls excuse me while i find a corner to cry in
[14:18] <ogra_> ikey, funnily i was looking at nixos before because niemeyer and sergio were discussing their patchelf tool (which is a core part of the nix package manager) on the forum
[14:18] <ikey> yeah the nixos approach honestly confuses me
[14:19] <ogra_> seems to be nix and nx day today :)
[14:19] <ogra_> (despite bein german re-unification day too :) )
[14:19] <ikey> instead of actually addressing the root cause of statelessness they worked around it with yocto style sysroots and reinvented subvolumes
[14:19] <ogra_> and pattching ninaries
[14:19] <ogra_> *binaries
[14:19] <zyga-ubuntu> niemeyer: *nice*
[14:20] <ikey> ninaries
[14:20] <ikey> lol
[14:20] <ogra_> heh
[14:20] <ogra_> hello jetlag :)
[14:20] <ikey> my old friend ...
[14:20] <zyga-ubuntu> we are at the golden era of OS development
[14:20] <zyga-ubuntu> you sneeze and wham, an OS pops out
[14:20] <ikey> accompanied by a couple dozen symlink farms
[14:20] <zyga-ubuntu> and it has access to all the apps :)
[14:21] <niemeyer> ikey: ninaries sounds great!
[14:21] <niemeyer> ikey: it's like a bit, but has nine states
[14:21] <ikey> well i mean thats kinda the "dream" right? package manager is relegated to an implementation detail
[14:21] <ikey> nessita, bitField ^= &derpFace ?
[14:21]  * zyga-ubuntu thinks "90s"
[14:21] <ikey> er niemeyer *
[14:22] <ikey> somethin somethin jetlag..
[14:22] <ikey> this is what i get for poking fun. instant karma.
[14:22] <niemeyer> ikey: Is there any package manager that isn't relegated to an implementation detail? :P
[14:22] <ikey> pacman
[14:22] <ikey> its a badge of honour
[14:22] <ikey> a way of life
[14:22] <niemeyer> LOL
[14:22] <niemeyer> I should work on that then
[14:23] <niemeyer> Because apparently we all work very hard so that our work eventually becomes invisible :)
[14:23] <ikey> yea sorta backfired there on the fame plan..
[14:23] <niemeyer> Yeah :P
[14:23] <zyga-ubuntu> niemeyer: if you want to work on something visible
[14:23] <zyga-ubuntu> niemeyer: we should make snap support wallpapers
[14:23] <zyga-ubuntu> ^_^
[14:24] <ikey> yes.
[14:24] <niemeyer> Or we just make it crash a lot
[14:24] <ikey> black and white animated tiffs.
[14:24] <zyga-ubuntu> hahaha
[14:24] <ikey> "why is gnome-shell using 48GB RAM"
[14:24] <zyga-ubuntu> ikey: because it can :>
[14:24] <ikey> oh burn
[14:24] <ikey> lol
[14:24] <zyga-ubuntu> it's like vista
[14:24] <zyga-ubuntu> yes
[14:25] <zyga-ubuntu> it sucks
[14:25] <zyga-ubuntu> ram
[14:25] <zyga-ubuntu> literally
[14:25] <zyga-ubuntu> but then you have free ram in laptops
[14:25] <niemeyer> panic: snapd word undetected by microphones in last 10 days
[14:25] <ikey> the henry hoover of desktops. :p
[14:25] <zyga-ubuntu> not like nowadays when windows 10 makes 4GB laptops common because it's one single time when windows actually improved memory usage so you don't need 8GB in baseline models
[14:26] <ikey> ah damn you ubunturally.
[14:26] <ikey> i got still-face-derp-faced from the chris fisher vlogs
[14:26] <ikey> er stillframe*
[14:26] <ikey> https://plus.google.com/114713706129194876663/posts/PfL3dKtdMXc :(
[14:27] <ikey> "a face you can trust"
[14:30] <zyga-ubuntu> OMG
[14:30] <zyga-ubuntu> can you edit that to prevent mental burn-in ;D
[14:32] <ikey> XD
[14:33] <zyga-ubuntu> I have something appropriate
[14:38] <kyrofa> sergiusens, alright, I'm up to speed
[14:51] <mup> PR snapd#3973 closed: cmd/snap-confine: put processes into freezer hierarchy <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/3973>
[14:57] <kyrofa> elopio, are you in today?
[15:03] <nacc> sergiusens: probably not :/ i'll fix that today
[15:05] <nacc> sergiusens: done, as nacc
[15:05] <sergiusens> great, in any case, you might be interested in https://forum.snapcraft.io/t/classic-snaps-failing-on-ubuntu-17-10/2324/
[15:05] <sergiusens> nacc ^
[15:12] <elopio> kyrofa: I am here, yes
[15:13] <nacc> sergiusens: thanks will read
[15:13] <nacc> sergiusens: i would highly recommend tests added to fix this
[15:14] <sergiusens> nacc it might be hard in adt, but certainly doable on travis
[15:14] <kyrofa> elopio, when you get a few minutes, can I get reviews on snapcraft#1581 and snapcraft#1582?
[15:14] <mup> PR snapcraft#1581: catkin plugin: support rosdep pip dependencies <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1581>
[15:14] <mup> PR snapcraft#1582: plugins: add ros2 boostrapper <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1582>
[15:14] <sergiusens> kyrofa (and elopio if you want) hangout?
[15:15] <kyrofa> sergiusens, sure thing
[15:15] <sergiusens> the weekly
[15:15] <kyrofa> omw
[15:17] <elopio> The gardener is cutting the grass just now. You won't be able to hear a thing.
[15:17] <elopio> I can jump in there and listen.
[15:21] <rogpeppe1> so... i want to make a snap that comprises a daemon that runs all the time, and a command that talks to the daemon via a unix-domain socket. what's the best way to structure that?
[15:23] <rogpeppe> do i need to declare a new interface and have two apps in my snapcraft.yaml that use it?
[15:25] <rogpeppe> is network-bind sufficient to create a unix-domain socket?
[15:55] <kyrofa> rogpeppe, yeah, use network and network-bind
[15:55] <kyrofa> You should be set
[15:56] <rogpeppe> kyrofa: that will allow me to make a unix-domain socket in $SNAP_COMMON?
[15:56] <kyrofa> rogpeppe, yep. Although I suggest putting things like that in /tmp
[15:56] <rogpeppe> kyrofa: i saw the listen-stream attribute in https://docs.snapcraft.io/build-snaps/syntax#apps-and-commands but that doesn't appear to be an actual thing
[15:57] <rogpeppe> kyrofa: i suspect the docs might be out of date
[15:57] <rogpeppe> kyrofa: so, do all apps declared in snapcraft.yaml share the same /tmp ?
[15:57] <kyrofa> rogpeppe, ah, that may be new actually
[15:57] <kyrofa> rogpeppe, yes indeed
[15:58] <rogpeppe> kyrofa: do they all share the same SNAP_COMMON too? I'm a bit confused as to what an app actually is actually.
[15:58] <kyrofa> rogpeppe, although it's namespaced when looking at it from outside the snap, so you probably don't want that if you ever want access from outside
[15:58] <rogpeppe> kyrofa: in this case, it's quite nice if only the command can get access to the socket actually
[15:58] <rogpeppe> kyrofa: so if I just listen on /tmp/socket and dial /tmp/socket, then i should be good?
[15:59] <kyrofa> rogpeppe, a snap is just a big blob of bundled binaries. You define how the user interacts with it using `apps`, which allows you to define either services or commands that are called by the user
[16:00] <kyrofa> rogpeppe, yep, should work. That's what I do
[16:00] <rogpeppe> kyrofa: ok, cool. it might be nice if the docs mention that "network" means unix sockets too
[16:01] <kyrofa> rogpeppe, it looks like listen-stream and socket are for socket activation, so those features must be new
[16:02] <davidcalle> kyrofa: months old iirc
[16:02] <kyrofa> davidcalle, hahaha
[16:03] <davidcalle> sergiusens: do you recall? I think you added these ^
[16:03] <davidcalle> (in the docs I mean)
[16:05] <sergiusens> davidcalle not me, it was someone working on lxd that proposed a new implementation for sockets
[16:06] <sergiusens> sanpcraft 2.0 never had socket support, snap.yaml had it hidden though
[16:08] <sergiusens> davidcalle here's the long thread for it https://forum.snapcraft.io/t/socket-activation-support/2050/31
[16:08]  * sergiusens takes a lunch break
[16:08] <davidcalle> sergiusens: thank you
[16:14] <kyrofa> elopio, this PR is failing the CLA check with an email I don't recognize: https://github.com/snapcore/snapcraft/pull/1580
[16:14] <mup> PR snapcraft#1580: cli: setup gitignore when working from git directory at init <Created by msis> <https://github.com/snapcore/snapcraft/pull/1580>
[16:14] <kyrofa> None of the commits seem to have it
[16:18] <elopio> kyrofa: that is Jeff, from heroku.
[16:18] <elopio> not sure where is it coming from.
[16:18] <kyrofa> What the heck. Master?
[16:19] <elopio> if you tell him to squash and rebase, don't they go away?
[16:20] <kyrofa> I'll try updating the branch first
[16:37] <kyrofa> sergiusens, elopio two OSRF +1s on snapcraft#1582
[16:37] <mup> PR snapcraft#1582: plugins: add ros2 boostrapper <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1582>
[16:38] <kyrofa> Hey zyga-ubuntu, I seem to remember you poking at snapd on gentoo a while back. Did that seem to work?
[16:55] <zyga-ubuntu> jdstrand: hello
[16:57] <zyga-ubuntu> jdstrand: would you have the time to look at https://github.com/snapcore/snapd/pull/3999 today, I'd like to get initial feedback and iterate daily, the branch is rather small and instead of a full security review I'd like to just ack the basic principle
[16:57] <mup> PR #3999: cmd/snap-confine: add detection of stale mount namespace <Created by zyga> <https://github.com/snapcore/snapd/pull/3999>
[17:00] <rogpeppe> sergiusens: so i've made progress, but the client command gets a "permission denied" error trying to connect to the socket
[17:00] <rogpeppe> sergiusens: do I need to manually chmod it after listening, do you think?
[17:01] <rogpeppe> oops, kyrofa ^
[17:18] <rogpeppe> kyrofa: the socket mode is Srwxr-xr-x so I think it *should* be open. I can only suspect app armor
[17:19] <kyrofa> rogpeppe, if you suspect apparmor, check the syslog, or use snappy-debug
[17:19] <kyrofa> (are you familiar with that handy tool?)
[17:26] <rogpeppe> kyrofa: no, i didn't know about it. will take a look tomorrow
[18:03] <jdstrand> zyga-ubuntu: done (I can't commit to being able to do this daily, but I'lltry)
[18:50] <zyga-ubuntu> jdstrand: thank you :)
[19:13] <mup> Issue snapcraft#1444 closed: catkin pip support <designed> <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/issue/1444>
[19:13] <mup> PR snapcraft#1581 closed: catkin plugin: support rosdep pip dependencies <Created by kyrofa> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1581>
[19:20] <sergiusens> kyrofa mind taking another look at snapcraft#1565 ?
[19:20] <mup> PR snapcraft#1565: cli: add the pack command <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/1565>
[19:20] <kyrofa> sergiusens, on it
[19:21] <sergiusens> elopio mind following up on snapcraft#1567 ?
[19:21] <mup> PR snapcraft#1567: recording: record the snaps installed on the machine <Created by elopio> <https://github.com/snapcore/snapcraft/pull/1567>
[19:24] <elopio> sergiusens: I'm on that after I finish with the dotnet tests.
[19:31] <kyrofa> elopio, can you take another pass at snapcraft#1582? Or are you good with it?
[19:31] <mup> PR snapcraft#1582: plugins: add ros2 boostrapper <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1582>
[19:33] <elopio> kyrofa: I'm good with it. I'll leave my +1.
[19:33] <kyrofa> sergiusens, okay if that one goes in next?
[19:35] <sergiusens> kyrofa  do you have the follow-up ready already?
[19:35] <kyrofa> sergiusens, mostly
[19:36] <kyrofa> sergiusens, turning the demo into an integration test
[19:36] <sergiusens> \o/
[19:37] <kyrofa> But yeah, I had it done for ROSCon
[19:37] <kyrofa> Then the stupid lighting talks...
[19:37] <kyrofa> Who raffles those
[19:37] <mup> PR snapcraft#1582 closed: plugins: add ros2 boostrapper <Created by kyrofa> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1582>
[19:37] <kyrofa> \o/ thanks :)
[20:05] <sergiusens> kyrofa mind having a second look on snapcraft#1578 ?
[20:05] <mup> PR snapcraft#1578: project_loader: quote more environment variable values <Created by malept> <https://github.com/snapcore/snapcraft/pull/1578>
[20:06] <kyrofa> Will do, just a minute
[23:20] <mup> PR core-build#11 closed: remove cruft from the writable-paths <Created by mvo5> <https://github.com/snapcore/core-build/pull/11>
[23:20] <mup> PR core-build#22 closed: unit testing for sync_dir() <Created by mvo5> <https://github.com/snapcore/core-build/pull/22>
[23:21] <mup> PR core-build#11 opened: remove cruft from the writable-paths <Created by mvo5> <https://github.com/snapcore/core-build/pull/11>
[23:21] <mup> PR core-build#22 opened: unit testing for sync_dir() <Created by mvo5> <https://github.com/snapcore/core-build/pull/22>
[23:35] <mup> PR snapcraft#1583 opened: ament plugin: new plugin <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1583>