[01:18] <babbageclunk> thumper: can you review this please? https://github.com/juju/1.25-upgrade/pull/49
[01:19] <thumper> ack
[01:19] <babbageclunk> thumper: testing the final tweaks of the container systemd/upstart rewriting
[01:31] <anastasiamac> wallyworld: thumper: PTAL - https://github.com/juju/juju/pull/7911
[01:31] <wallyworld> ok
[01:31] <anastasiamac> wallyworld: thumper: i think this is less confusing. tyvm :D
[01:40] <anastasiamac> wallyworld: replied but m so happy u liking me fixing this one!
[01:41] <wallyworld> looking
[01:42] <wallyworld> just "2.3" could imply only "2.3" and not "2.3.minor"
[01:43] <wallyworld> once we hit 2.3, there are no more betas etc
[01:43] <wallyworld> just point releases
[01:43] <anastasiamac> k, so just for clarity - 2 is major, 3 is minor, everything else is a "patch" :D
[01:44] <anastasiamac> so maybe the phrasing can be along "2.3 point releases"?
[01:44] <anastasiamac> wallyworld: ^^
[01:45] <wallyworld> ok, i'm not married to point vs patch
[01:46] <wallyworld> whatever sounds correct
[01:48] <anastasiamac> wallyworld: or "this client can only bootstrap agents using any of the 2.3 Juju versions".... wordy but then avoids ambiguitites...
[01:49] <wallyworld> sgtm
[01:51] <thumper> wallyworld: I was thinking, we should skip our 1:1 in a few minutes and just have a joint one with jam later
[01:51] <thumper> wallyworld: sound good?
[01:51] <wallyworld> sgtm
[01:51] <thumper> k
[02:16] <wallyworld> anastasiamac: here's a micro PR to fix a test race https://github.com/juju/juju/pull/7912
[02:18] <anastasiamac> wallyworld: looking
[02:18] <wallyworld> ta
[02:20] <anastasiamac> wallyworld: neat! i like explicit accessors and mutators by default :D
[02:20] <wallyworld> that's your java beackground :-)
[02:21] <anastasiamac> sh
[02:21] <anastasiamac> wallyworld: or just pendatic "don't assume u know what i want, be explicit"
[02:22] <anastasiamac> :D
[02:53] <babbageclunk> thumper: what's a sensible default for when updated on a status record is nil? https://github.com/juju/1.25-upgrade/blob/master/juju1/state/migration_export.go#L1310
[02:53] <babbageclunk> thumper: 0?
[02:59] <thumper> hmm..
[02:59] <thumper> no you don't want zero
[03:00] <thumper> what does the rest of the record look like?
[03:00] <babbageclunk> thumper: don't know, it's in IS
[03:01] <babbageclunk> https://pastebin.canonical.com/199884/
[03:04] <thumper> hmm..
[03:04] <thumper> babbageclunk: perhaps defaulting it to the time of the export
[03:05] <babbageclunk> thumper: yeah, that seems good to me.
=== frankban|afk is now known as frankban
[14:37] <mup> Bug #1721555 opened: juju bootstrap node tries to reach manually added machines through private IPs instead of public <juju-core:New> <https://launchpad.net/bugs/1721555>
=== frankban is now known as frankban|afk
[20:11] <mup> Bug #1721629 opened: No tools available via streams.canonical.com for 1.25.13 on i386 <juju-core:New> <https://launchpad.net/bugs/1721629>
[21:12] <babbageclunk> thumper: take another look at https://github.com/juju/1.25-upgrade/pull/49 ? And also https://github.com/juju/1.25-upgrade/pull/50
[21:16] <balloons> can I get a review for version bump? https://github.com/juju/juju/pull/7917
[21:20] <mup> Bug #1721629 changed: No tools available via streams.canonical.com for 1.25.13 on i386 <juju:Triaged> <https://launchpad.net/bugs/1721629>
[21:35] <babbageclunk> balloons: approved
[22:21] <babbageclunk> thumper: hey thanks!