liam-r | Hi all, is there somewhere other than the packaging & compiling forum or reddit to ask for help with a motu patch without annoying people with mailing list spam? | 11:57 |
---|---|---|
rbasak | If you're working on something intended to be uploaded to Ubuntu's universe component, here or the ubuntu-motu@ mailing list is absolutely the right place I think. | 12:47 |
liam-r | Thanks rbasak, my problem is that my changes to a package are not being reflected in the .deb. I assume I'm doing something very silly but I can't figure it out. Details are at https://ubuntuforums.org/showthread.php?t=2373652 | 12:49 |
rbasak | I'm not particularly familiar with edit-patch. | 12:54 |
rbasak | But it seems incorrect to edit debian/changelog from inside edit-patch. | 12:54 |
rbasak | edit-patch prompts for a changelog change on exit. | 12:54 |
rbasak | Otherwise your debian/changelog change ends up inside the quilt patch, which is wrong and fails to apply. | 12:54 |
rbasak | But, before you go there. | 12:54 |
rbasak | A fix for a typo in a manpage that comes from upstream is in general not appropriate to upload to Ubuntu. | 12:55 |
rbasak | Please send that fix upstream | 12:55 |
liam-r | Sure I do intend to, I just wanted to sort out the process and make sure I could build correctly on something very minor where the actual patch problem wouldn't get in the way | 12:56 |
liam-r | I'll try again this evening without doing the changleog in the tmp, thanks for your help | 12:56 |
liam-r | As far as process is concerned should I also add a patch to the launchpad issue or just mark it as patch sent upstream? | 12:57 |
rbasak | I just tried myself and your steps work as long as you miss out the first "dch -i" call in your steps | 12:58 |
rbasak | Ubuntu developers won't need to see the patch in the Launchpad bug. But it is helpful to others to record what you've done. I would send the patch upstream and link to the upstream submission in the Launchpad bug. Then all the information about what you did, and access to the patch for anyone interested, will all be available. | 12:59 |
rbasak | If the patch were suitable for upload to Ubuntu, then Ubuntu developers would need to see the patch. But usually we want to see where it landed upstream as if upstream have accepted it then taking that exact patch and having reference to it makes life much easier for us. So that's a case where linking to the upstream submission (or preferably VCS commit of it landing) is extremely useful. I'd consider | 13:00 |
rbasak | it part of the process for contributors. | 13:00 |
liam-r | Thanks a million I really appreciate the help. For upstream would the mentioned "submittodebian" script still be the preferred approach? http://packaging.ubuntu.com/html/fixing-a-bug.html | 13:01 |
liam-r | (3.10) | 13:01 |
rbasak | Not in this case. | 13:02 |
rbasak | A manpage typo probably comes all the way upstream, not just from Debian. | 13:02 |
rbasak | See the README file where there are instructions on how to contact the upstream authors | 13:03 |
rbasak | You should also check that the latest upstream tarball (or ideally VCS head if they have one) still contains the typo before contacting them, in case they have already fixed it. | 13:04 |
liam-r | Perfect I'll do that when I'm back at my dev pc. One last question - since this isn't tracked in debian should I also raise an issue there and link to the patch or is that just overkill? I realise this is a very trivial issue I'm just asking for something that might be a bit more invovled in the future | 13:04 |
rbasak | For this bug, please don't. It just creates work for the maintainer. In the general case, for a bug that might impact users more severely, it's definitely OK to file a bug and providing information on how to fix it (eg. a patch). | 13:06 |
rbasak | It all depends on understanding how much a maintainer would like to know about it, versus the fact that the fix will flow down from upstream eventually anyway. | 13:07 |
liam-r | I understand, thank you so much for your help and patience. | 13:07 |
rbasak | No problem. Welcome to the development community :-) | 13:07 |
liam-r | Thanks :) Heading out irl I'll probably be back to lurk later | 13:08 |
hwpplayer1 | Hi Team ! | 23:11 |
hwpplayer1 | Do you use #ubuntu-science channel ? | 23:11 |
sladen | hwpplayer1: ask the people on the #ubuntu-science channel! | 23:18 |
hwpplayer1 | sladen : this is not the way , i am the single person there | 23:19 |
sladen | hwpplayer1: so, I'm not a user of it. These are specialisms, and a lot of the work is likely to be shared with Debian (Debian-Science), and that may be a good next-port-of-call | 23:24 |
hwpplayer1 | Okay | 23:24 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!