[06:29] <oSoMoN> good morning desktoppers!
[06:30] <duflu> Morning oSoMoN
[06:38] <oSoMoN> hey duflu
[06:51] <koza> o/
[06:54] <duflu> Hi koza, seb128
[06:57] <seb128> hey duflu koza
[06:57] <seb128> good morning desktopers
[06:58] <jibel> morning
[06:59] <duflu> Hi jibel
[06:59] <jibel> Hi duflu
[07:15] <didrocks> good morning
[07:17] <seb128> lut didrocks
[07:18] <didrocks> salut seb128
[07:32] <GunnarHj> seb128, oSoMoN: Good morning! Is /etc/locale.conf important enough on the Ubuntu desktop to block the suggested fix of bug #1662031? The file does not even exist on my machine...
[07:33] <duflu> Hey didrocks
[07:33] <seb128> hey GunnarHj
[07:34] <didrocks> hey duflu
[07:34] <seb128> GunnarHj, I didn't say that bug/file was important, was just giving context on why the function was added
[07:34] <GunnarHj> seb128: Ok. Are you convenient with disabling it?
[07:36] <seb128> GunnarHj, I would prefer for somebody to understand why it's there before removing it, just to make sure we don't create other problems, but I think it's an important bug to fix so yes we should land your version at least (or a better fix maybe if we manage to fully understand the issue and how the behaviour should be changed)
[07:39] <GunnarHj> seb128: I can add that I studied booting with different variants of /etc/default/locale. It always has LANG, but I for instance added LC_TIME, and found that the latter resulted in the correct date format on the login screen. So I for one am not able to see any problems.
[07:39] <seb128> GunnarHj, your change is probably fine for artful but it's not an upstreamable solution, we need something that works on any distro
[07:40] <GunnarHj> seb128: Why? We are solving an Ubuntu specific issue. Or is anybody else using ~/.pam_environment the way we do?
[07:40] <seb128> GunnarHj, good question, I don't know
[07:41] <seb128> GunnarHj, I'm just uncomfortable removing code without understanding why it's there
[07:41] <GunnarHj> seb128: AFAIK it's Ubuntu only.
[07:41] <seb128> that code? no it's upstream, see the commit in the bug I pointed
[07:42] <GunnarHj> seb128: I meant ~/.pam_environment
[07:42] <seb128> not in debian?
[07:42] <GunnarHj> seb128: Nope.
[07:42] <seb128> k
[07:42] <seb128> well it doesn't change the fact that we could have code that works in Ubuntu and upstream/other distributions
[07:43] <seb128> if the logic is smart enough to tell what condition should lead to what choices
[07:43] <GunnarHj> seb128: Unless our patches in accountsservice have been upstreamed to Debian...
[07:44] <oSoMoN> GunnarHj, speaking of accountsservice, I’ve filed bug #1722151
[07:45] <GunnarHj> seb128: The overall problem here is that Ubuntu established a model for handling language/locale settings, which works fine on all the flavors, while GNOME does it their way. So we have patches in a few packages to make it work our way.
[07:45] <oSoMoN> ah, seeing you commented on it already
[07:45] <andyrock> good morning!
[07:45] <oSoMoN> good morning andyrock
[07:46] <GunnarHj> oSoMoN: I did. I'm kind of hesitating to fix something which is not broken. ;)
[07:46] <seb128> lut oSoMoN
[07:47] <oSoMoN> salut seb128
[07:47] <seb128> oSoMoN, you should stop working during the nights!
[07:47] <oSoMoN> GunnarHj, yes, it doesn't appear to be broken, but still incorrect according to documentation, let me look into the pam code again to double check
[07:48] <GunnarHj> oSoMoN: Great if you do. I had a look, but that code is over my head.
[07:48] <oSoMoN> seb128, I hate to leave things unfinished :)
[07:48] <seb128> hehe
[07:53] <GunnarHj> seb128: Just checked accountsservice in Debian. They do have our patches in the source, but they don't apply them. So yes, it's indeed Ubuntu only.
[07:53] <GunnarHj> seb128: I.e. the use of ~/.pam_environment the way we do.
[07:54] <seb128> GunnarHj, I don't understand what you are trying to get at there
[07:54] <GunnarHj> seb128: You mentioned the need to upstream the fix, and I just making sure that there is no such need.
[07:55] <seb128> GunnarHj, well if the issue is that overrides are done in the wrong order when using pam there might still be a flaw in the upstream code logic even if other distros don't use pam to set languages atm
[07:56] <seb128> the fact that they are not impacted doesn't mean the code is right
[07:56] <GunnarHj> seb128: True.
[07:57] <GunnarHj> seb128: Maybe use the fix in 17.10, and then discuss it with upstream afterwards?
[07:58] <seb128> GunnarHj, wfm, or maybe we can understand it fully and fix it correctly this week
[07:58] <seb128> but meanwhile I'm fine landing your fix if we think that's the best option
[07:59] <seb128> oSoMoN, what do you think? do you understand the issue fully now?
[08:02] <seb128> brb, changing location
[08:09] <oSoMoN> GunnarHj, so maybe it's just a matter of making sure that set_up_session_language() is called before pam_env sets up the environment?
[08:11] <GunnarHj> oSoMoN: Possibly. That would allow for an upstreamable solution, for the case the function isn't obsolete.
[08:12] <oSoMoN> GunnarHj, I'm looking into the order in which things are done in gdm
[08:18] <oSoMoN> seb128, I was saying earlier to Gunnar,  maybe it's just a matter of making sure that set_up_session_language() is called before pam_env sets up the environment?
[08:18] <seb128> oSoMoN, I think that would be something along those lines yes
[08:19] <oSoMoN> trying to figure that out, async code is hard to read :/
[08:19] <oSoMoN> or my brain is too synchronous
[08:19] <seb128> indeed :/
[08:22] <GunnarHj> seb128, oSoMoN: You can also argue that since the set_up_session_language() function is apparently run after PAM has read /etc/default/locale and ~/.pam_environment, it's obviously redundant.
[08:25] <GunnarHj> seb128, oSoMoN: OTOH I can't explain why the ~/.pam_environment values are not reflected in g_listenv().
[10:38] <andyrock> seb128: hey regarding the fix gnome-shell crash fix I proposed upstream they want to solve the issue at a different level
[10:38] <andyrock> so in a nutshell the problem is that a NaN is generated
[10:38] <andyrock> I'm avoid the crash if NaN is detected
[10:38] <andyrock> they want to know why that NaN is generated
[10:39] <andyrock> my plan is to build a ppa that will make gnome-shell crash as soon as the NaN is generated
[10:39] <andyrock> hopefully someone will be willing to install the ppa and send us the crash report
[10:39] <andyrock> this will take some time, so we might need to sru it
[11:18] <seb128> andyrock, hey
[11:18] <seb128> andyrock, maybe we could distro patch your workaround/solution for the release though?
[11:18] <seb128> but yeah, having the debug info would be useful
[11:25] <andyrock> distro patch should be possible and should not create any type of problem
[11:26] <seb128> andyrock, can you add your patch to the launchpad bug with a comment saying that?
[11:26] <andyrock> sure
[11:28] <seb128> thanks
[11:38] <duflu> didrocks, in case upstream doesn't wake up in time you may like to distro-patch this: https://bugzilla.gnome.org/show_bug.cgi?id=645433#c38
[11:38] <duflu> But I'm done and have to run
[11:41] <ricotz> hey desktopers
[11:42] <seb128> hey ricotz, how are you?
[11:42] <ricotz> I recently enabled the modern-style extension in rhythmbox which tends to crash :(
[11:43] <seb128> what is "modern-style"?
[11:43] <ricotz> hey seb128, good :), and you?
[11:43] <seb128> I'm good thanks
[11:43] <ricotz> the alternative-view
[11:44] <seb128> you mean alternative-toolbar?
[11:44] <ricotz> ah that is what it is called (just seeing the german title here)
[11:45] <seb128> are you sure the issues are due to it? do you have a backtrace/report?
[11:45] <seb128> what do you do to trigger the bugs?
[11:45] <ricotz> I assume this extension is enabled by default now?
[11:46] <andyrock> seb128: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1714542/comments/11
[11:47] <seb128> andyrock, thanks
[11:47] <seb128> ricotz, correct
[11:47] <ricotz> seb128, didn't have time to investigate it yet, it crashes in "gtk_view_column" something, didn't saw this issue before
[11:49] <seb128> ricotz, well, if you have specific action to trigger the segfault that would be useful to know which ones, nobody reported that problem before
[11:50] <ricotz> seb128, I think it is a search, followed by double-clicking on a song
[11:54] <ricotz> seb128, https://paste.debian.net/989778/
[11:58] <seb128> ricotz, thanks, I can't reproduce by filtering and double clicking a result and there is no launchpad report matching it seems
[12:06] <didrocks> ricotz: maybe try to report against https://github.com/fossfreedom/alternative-toolbar/issues? We got some crashes before, but they got fixed with their latest release
[12:06] <didrocks> (which debian and us have)
[12:07] <popey> Where would I file a bug where clicking on a notification of a file change in 17.10 will open multiple nautilus windows (one per notification), rather than just one?
[12:07] <didrocks> seb128: do you want me to handle andyrock's patch? I have another upstream potential fix we might want
[12:07] <didrocks> popey: "notification of a file change"? Not sure what you mean
[12:08] <seb128> didrocks, yes please, thanks
[12:08] <didrocks> We have notification when plugging a mpt device, or network share available
[12:08] <didrocks> seb128: will do! :)
[12:08] <seb128> thx
[12:08] <popey> didrocks: e.g. dropbox lets me know when someone changes a file, if that file is changed multiple times, i see one notification, but when i click it, I get lots of nautilus
[12:09] <seb128> sounds like a dropbox bug?
[12:09] <seb128> not replacing the notification but stacking new ones?
[12:09] <didrocks> popey: ah, interesting… One question, if you don't click on one notification, and you get the file changed again, do you get another notification or was the previous one replaced?
[12:09] <didrocks> sounds like seb128 is getting at the same point than I am :)
[12:10] <popey> only one notification is seen
[12:10] <didrocks> yeah, I think popey wants gnome-shell to remember which nautilus window was opened due to that action and have that one reused
[12:10] <seb128> because the shell probably merge them
[12:11] <didrocks> even if you click on each change
[12:11] <popey> hang on...
[12:11] <popey> https://usercontent.irccloud-cdn.com/file/6HPg1oer/The%20notification%20(there%20are%20multiple%20behind%20this)
[12:11] <popey> https://usercontent.irccloud-cdn.com/file/OL6smIvV/result%20when%20i%20click%20it
[12:12] <didrocks> you clicked on only ONE notification, correct to get that stack?
[12:12] <popey> (that file is updated hourly, so after 12 hours there's 12 notifications, and if I click it, I get 12 nautilus windows)
[12:12] <popey> there is only one notification
[12:12] <popey> so yes, I can only click on one
[12:12] <didrocks> yeah, I think seb128 is right, the shell merges them
[12:12] <didrocks> so dropbox issue
[12:12] <popey> ok
[12:12] <popey> thanks
[12:12] <didrocks> popey: you can tell them they should use the "replace" notification functionality, rather than appending
[12:12] <didrocks> yw
[12:14] <didrocks> andyrock: do you mind doing a DEP3 format patch?
[12:14] <didrocks> andyrock: I know some release team member rejecting uploads otherwise
[12:14] <didrocks> (just state there that it's a temporary hack/fix)
[12:15] <andyrock> didrocks: sure
[12:15] <didrocks> andyrock: http://bazaar.launchpad.net/~ubuntu-desktop/gnome-shell/ubuntu/view/head:/debian/patches/70_allow_sound_above_100.patch if you want an excellent (of course ;)) example :p
[12:17] <popey> Bug reported on dropbox - successfully disappeared into the aether.
[12:19] <seb128> popey, if you get a similar issue with something opensource feel free to nag us again about it
[12:19] <popey> hmm, will do, not sure I can easily reproduce with something open, but will try! :D
[12:19] <ricotz> seb128, didrocks, regarding rhythmbox, this doesn't look like fun to debug, running in gdb and clearing buffers/caches make it more reproducible -- there is also a critical before the crash "Gtk-CRITICAL **: gtk_tree_view_update_button_position: assertion 'column_el != NULL' failed"
[12:19] <popey> (pretty niche case tbh)
[12:21] <didrocks> ricotz: I guess trying to print the column_el to see what's up with it at first…
[12:22] <seb128> ricotz, so you can reproduce pretty reliably? do you click on the search icon and then type something and then double click a result? do you have several matches? is your UI layout the default one?
[12:23] <Laney> morning
[12:23] <seb128> good morning Laney!
[12:23] <didrocks> hey hey Laney
[12:23] <seb128> how was your trip? didn't wake up too early today?
[12:24] <didrocks> (et jetlag? ;))
[12:24] <didrocks> and*
[12:24] <ricotz> seb128, this profile went through several upgrades, so I wouldn't expect it to be the current default, I assume it gets triggered easier with a lot of files and while it is processing them
[12:25] <seb128> ricotz, oh, could be, I don't have many there so filtering is done when I click
[12:25] <Laney> hmmmmmmmmmm
[12:26] <Laney> yeah not too bad, this way is always easier for me anyway
[12:26] <ricotz> didrocks, not sure how to get there while it is burried in python-gi
[12:27] <andyrock> https://www.irccloud.com/pastebin/bWsqLRmd/
[12:27] <andyrock> didrocks: ^^^ is this beter?
[12:27] <andyrock> *better
[12:27] <didrocks> andyrock: perfect! Thanks :)
[12:28] <andyrock> do you want me to add a comment on the bug or it's fine here?
[12:31] <didrocks> andyrock: that's fine I think, I'll ensure the changelog mentions it
[12:34] <andyrock> kk
[13:41] <jbicha> Laney: are you working on the gdm3 update for artful?
[13:41] <jbicha> good morning
[14:02] <tkamppeter> xnox, hi
[14:49] <Laney> hi jbicha
[14:49] <Laney> not that easy this week, feel free
[14:50] <jbicha> Laney: we agreed to drop gdm3's 95_hide_x11_sessions_with_nvidia_kms.patch right?
[14:51] <Laney> tseliot says that's not needed any more
[14:52] <tseliot> Laney: yes, although I managed to reproduce the problem again, but I think the cause is somewhere in the nvidia packages, not in the driver itself, or in gdm
[14:55] <jbicha> tseliot: it sounds like we should keep the patch for now then?
[14:55] <Laney> you two can work it out
[14:56] <tseliot> jbicha: if users install the driver using the nvidia installer, they won't be able to reproduce the problem. I think we can drop it. I'll probably SRU the fix when I find out
[14:57] <jbicha> tseliot: but things won't work right if they use 'Additional Drivers' now?
[14:58] <tseliot> jbicha: if they use 'Additional Drivers', KMS will be disabled by default, so users won't be able to reproduce the problem
[15:00] <jbicha> so it might cause problems for people who force-enable KMS?
[15:01] <tseliot> jbicha: yes, when they do that, they simply won't be able to access the X11 session. The Wayland session will work
[15:01] <jbicha> and xwayland won't work for them, right?
[15:01] <tseliot> correct
[15:02] <Trevinho> Hola chicos
[15:02] <jbicha> ok, since we don't recommend users do all that, I think it sounds fine to do what you propose and drop the gdm patch
[15:02] <tseliot> jbicha: that's good. Laney ^
[15:03]  * Laney nods
[15:09] <andyrock> *chic@s
[15:10] <andyrock> Trevinho: ^^^
[15:10] <andyrock> there are girls here too :D
[15:14] <Trevinho> andyrock: oh... well.... #stilllearning
[15:18] <Laney> O_O
[15:20] <tsimonq2> (necesitamos más chicas, no?)
[15:22] <willcooke> seb128, andyrock - https://bugs.launchpad.net/ubuntu/+source/gdm3/+bug/1716160  Anything we can do with that before release?
[15:24] <andyrock> I don't have a multi monitor with me right now to fix it. I can get one in a couple of days. What we can do is to revert the distro patch that causes it
[15:26] <andyrock> but then we lose the ability to allow to chose what to do depending if AC is connected
[15:27] <willcooke> I gotta go to a meeting.  andyrock could you discuss with Seb
[15:28] <andyrock> sure
[15:30] <andyrock> seb128: so I have another monitor with me but I need an adaptor. I need to order one and this can take few days. Otherwise if someone wants to work on this...
[15:34] <jbicha> andyrock: does that even work in artful? (different behavior if AC is connected)
[15:37] <andyrock> jbicha: there is a broken distro patch that adds two hidden settings to do that
[15:39] <andyrock> we agreed with seb128 to fix the patch but I was not able to complete the fix in NY
[15:39] <jbicha> oh ok, does the patch work in Unity?
[15:40] <andyrock> and I recently moved in a different Italian city and I left the monitor in the old flat
[15:40] <andyrock> *former
[15:40] <andyrock> with unity-settings-daemon yes
[15:40] <andyrock> not with gnome-settings-daemon
[15:41] <andyrock> I need to completely rewrite it
[15:41] <jbicha> I wonder if we can convince the new gsd maintainers to take the patch
[15:41] <andyrock> I was about to propose the same
[15:41] <andyrock> I guess so
[15:42] <jbicha> I've had user requests for at least Tweaks to support that
[15:42] <andyrock> It's something useful that makes sense
[15:43] <andyrock> let's wait for seb128 to decide on what to do
[15:56] <popey> Is there a plan to ship Firefox 56.0.1 in 17.10? (current up to date 17.10 has 56.0.
[15:57] <popey> (the reason I ask is because first launch it pops up a banner telling me to update, and takes me to upstream mozilla to do that, which will be confusing for users I imagine)
[15:57] <popey> Perhaps we need to disable the upstream banner (it's on their website, not an internal update mechanism)
[16:01] <didrocks> oSoMoN: ^
[16:02] <popey> Here's a video showing how I imagine this works for a normal user:- https://youtu.be/2v35Aw-f7DI
[16:02] <popey> (still processing so not in HD yet) :D
[16:02] <popey> (lemme know if you need a bug filed)
[16:04]  * didrocks at least knows popey have seen the "extract" button on top thanks to our theme fix :)
[16:04] <ricotz> popey, hi, I don't see any linux related changes in ff 56.0.1
[16:04] <popey> ricotz: hey, interesting. I guess the problem here is users get slapped in the face with a banner from mozilla on first run (dunno if it happens on subsequent runs)
[16:04] <didrocks> I guess the issue is more about the banner popup than knowing/not knowing there is anything for linux in .1
[16:05] <popey> exactly
[16:05] <popey> didrocks: I actually did this twice, so only found the extract button _because_ you coloured it. My brain can't find buttons in headerbars yet
[16:06] <didrocks> ahah, I think it will come soon :) but yeah, at least, that give a hint (we just followed upstream btw who coloured it as well)
[16:06] <popey> Sweet!
[16:07] <popey> didrocks: you may have noticed my mouse went to the top left to close the about window at ~18 seconds in ;)
[16:08] <didrocks> oh, I didn't :)
[16:08] <didrocks> you are knowing on Xorg from what I see
[16:08] <didrocks> running*
[16:08] <didrocks> eod soon, can't type :p
[16:08] <popey> nope
[16:08] <didrocks> hum
[16:08] <didrocks> so…
[16:08] <didrocks> what did you use to record the video?
[16:08]  * didrocks puzzled
[16:08] <popey> :D
[16:09] <didrocks> the video is more than 30s and there isn't the built-in video icon from G-S
[16:09] <didrocks> so, my guess is
[16:09] <didrocks> VM!
[16:09] <didrocks> and you recorded from the outside
[16:09] <popey> X
[16:09] <popey> Try again
[16:09] <didrocks> ohhhh, I was so sure
[16:09] <didrocks> an extension?
[16:09] <popey> XX
[16:09] <popey> Last try!
[16:09] <didrocks> nooooo
[16:09] <ricotz> popey, ok, sounds like this would solve the version check -- while it is hard to get into touch with Chris not sure he wants to do another update
[16:09] <didrocks> some popey's magic?
[16:09] <didrocks> (can't be XXX on that one)
[16:10] <popey> didrocks: https://www.amazon.co.uk/Magewell-XI100DUSB-HDMI-Video-Capture-Dongle/dp/B00I16VQOY
[16:10] <didrocks> seriously… Mr is equipped :)
[16:10] <popey> Pixel perfect 60fps 1080p using ffmpeg :)
[16:10] <didrocks> would have never guessed
[16:10] <popey> Honestly, it's the only way to get reliable screen capture on Linux.
[16:10] <popey> ricotz: Chris Coulson?
[16:11] <ricotz> popey, yes
[16:11] <popey> So really, I think a bug is needed now, right?
[16:11] <ricotz> I fear so
[16:11] <popey> kk thanks for the help guys!
[16:13] <popey> didrocks: XXX
[16:13] <popey> :0
[16:13] <jbicha> if you find Chris, could you ping him about LP: #1713486 ?
[16:13] <didrocks> popey: you won :)
[16:13] <didrocks> I amdit it
[16:13] <didrocks> admit*
[16:13] <popey> ;)
[16:31] <popey> jbicha:
[16:31] <popey> passed on
[16:36] <tseliot> seb128: just FYI I have uploaded a new nvidia-prime and nvidia-settings for LP: #1721394
[17:10] <GunnarHj> oSoMoN: I'm going to fix that script which writes to ~/.pam_environment. Are you still trying to figure out a more elegant way to fix the gdm issue than just disabling the function?
[17:11] <oSoMoN> GunnarHj, I’ve put that task on hold for today, will continue looking into it tomorrow
[17:11] <oSoMoN> in the meantime I think we should go with your patch
[17:12] <GunnarHj> oSoMoN: Ok, then I know.
[17:12] <GunnarHj> seb128: ^
[17:50] <seb128> tseliot, thanks
[17:51] <tseliot> yw
[17:51] <seb128> GunnarHj, yeah, go with your change, we can iterate later if needed
[17:52] <seb128> andyrock, sorry I shifted my hours earlier today, let's talk about that tomorrow but what is the patch to drop? I can try here since I get the issue
[18:11] <GunnarHj> seb128: Ok. Will you merge/upload? Also, I stumbled on the related bug #1722002. Would be great if you could review that too.
[18:21] <fossfreedom> hi all - if I create a properly formatted patch for this crashing issue in gnome-shell and budgie do you think it can be added to mutter before release ? https://bugzilla.gnome.org/show_bug.cgi?id=788666
[18:22] <jbicha> fossfreedom: yes, but I'd like to see the patch accepted upstream first
[18:24] <fossfreedom> jbicha, thanks - anyone you know that can be gently nudged to review?
[18:24] <jbicha> you can ask in #gnome-shell on irc.gnome.org
[18:25] <fossfreedom> ok
[18:31] <andyrock> seb128: i was about to have dinner. I will send you the name of the patch in half an hour
[18:49] <seb128> GunnarHj, it would be nice if you could describe a real world issue for the gsettings/region one
[18:50] <seb128> andyrock, enjoy and thanks
[18:53] <GunnarHj> seb128: That would be that there is a "region" value, set by g-c-c, and the user later uses Language Support (which does not mess with gsettings) to change the regional format.
[18:53] <seb128> GunnarHj, would be nice to add a "steps the user can do to get the issue" to the bug
[18:53] <seb128> on that night need to wrap
[18:53] <seb128> have a good night desktopers
[18:54] <GunnarHj> seb128: Will do. Good night!
[18:54] <seb128> thanks
[20:43] <Laney> Trevinho: so coming back to that unity...
[20:43] <Laney> ...everyone that upgrades to it now will have their gnome scaling settings reset to defaults?
[20:46] <Trevinho> Laney: yes, since gnome will calculate it again
[20:47] <Trevinho> With some optimal™ algorithm
[20:47] <Laney> but they might have it as they like it?
[20:56] <Laney> not sure what the motivation for doing that is
[20:56]  * Laney is worried
[21:09] <jackpot51> I have an upstream fix that could be applied pretty easily: https://bugzilla.gnome.org/show_bug.cgi?id=788741
[21:16] <jbicha> jackpot51: that's already being taken care of :) https://launchpad.net/ubuntu/+source/gnome-control-center/1:3.26.1-0ubuntu2
[21:17] <jackpot51> Where is it? in Proposed?
[21:18] <jbicha> yes
[21:18] <jbicha> almost, it just finished building!
[21:18] <jackpot51> Cool!
[22:24] <Trevinho> Laney: we can write some migration scripts for porting the setting in unity to gnome, but not yet, since that will need the fractional scaling to work properly
[22:24] <Trevinho> it's all in my plan though