[07:05] <LocutusOfBorg> sforshee, yes please build one from me :)
[07:05] <LocutusOfBorg> https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/+packages
[07:05] <LocutusOfBorg> I got abi foo
[07:49] <LocutusOfBorg> apw, ^^ :)
[07:50] <LocutusOfBorg> maybe we should defer this to 18.04 anyway, but also oracle now got the same patch
[07:50] <LocutusOfBorg> and they confirm it works
[07:51] <apw> LocutusOfBorg: yeah I think we're past the point of switching now for 1710
[11:54] <sforshee> LocutusOfBorg: I started a build, should be done within the hour
[12:27] <LocutusOfBorg> sforshee, https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/+build/13574391
[12:27] <LocutusOfBorg> thanks to some hints I got it working
[12:27] <LocutusOfBorg> see #-release
[12:34] <sforshee> LocutusOfBorg: okay, let me know if you need anything else
[12:34] <LocutusOfBorg> sforshee, I have a question
[12:35] <LocutusOfBorg> the driver in ubuntu/vbox creates a vboxvideo.ko too
[12:35] <LocutusOfBorg> how can I be sure it is excluded or overridden by the mainline staging one?
[12:35]  * LocutusOfBorg never touched kernel builds, and now remembers why
[12:35] <sforshee> oh, it does ...
[12:35] <sforshee> I hadn't noticed that
[12:36] <LocutusOfBorg> not sure if removing the directory is enough or not
[12:36] <LocutusOfBorg> probably not I would say
[12:36] <sforshee> so for your own purposes you can use insmod and give it the exact path to the module you want to load
[12:37] <LocutusOfBorg> sure, or delete the double one :p
[12:37] <sforshee> or that
[12:38] <sforshee> in practice when we did build the staging driver it was loading that one, but that's likely just by accident
[12:38] <LocutusOfBorg> I'm just making sure that we can enable it without having a duplicate
[12:38] <LocutusOfBorg> exactly, that one ^^
[12:38] <LocutusOfBorg> I don't think there is some ordering in modprobe
[12:38] <LocutusOfBorg> other than "random" :)
[12:39] <sforshee> so once you've confirmed the fix I can apply it to the unstable kernel and reenable the driver, and when we have add the vboxguest stuff for 4.14 I'll figure out what we need to do
[12:40] <LocutusOfBorg> the fix is already confirmed by RedHat (the one who did make the module upstreamable), and by Oracle, but I have a VM ready to go right here
[12:40] <LocutusOfBorg> amd64 ppa is sloooooooooooow
[12:41] <LocutusOfBorg> so, in case artful is out from this change?
[12:41] <LocutusOfBorg> I mean, there is no way we can make it in this release
[12:41] <LocutusOfBorg> it will be eventually part of 18.04 I would presume
[12:42] <sforshee> it would have to be an sru at this point even if we enable it in artful
[12:42] <LocutusOfBorg> do we enable/disable/change kernel modules  in SRU?
[12:42] <LocutusOfBorg> nice
[12:42] <LocutusOfBorg> anyhow, this affects mostly ISO images
[12:42] <LocutusOfBorg> or not, maybe they seed the virtualbox-guest-dkms package
[12:42] <LocutusOfBorg> mmm
[12:42] <sforshee> I won't say we never do it ... but we need a good reason, and it seems we already have a working vboxvideo no?
[12:43] <LocutusOfBorg> the one in src:vbox, that is the one in src:linux/ubuntu/vbox
[12:43] <LocutusOfBorg> but having a mainline version is.... nice!
[12:43] <LocutusOfBorg> I don't have to bother you to merge it on each vbox release as example
[12:46] <sforshee> we can definitely enable the mainline driver for 18.04, just not so sure about 17.10
[12:47] <sforshee> and definitely not for the release unless the one we already have is badly broken
[13:09] <LocutusOfBorg> I probably agree, lets see in one hour
[13:29] <sforshee> LocutusOfBorg: I have a build completed already if you want it
[13:31] <LocutusOfBorg> yep please
[13:31] <sforshee> http://people.canonical.com/~sforshee/vboxvideo/
[13:32] <sforshee> LocutusOfBorg: ^
[13:32] <LocutusOfBorg> ta already starting the vm
[13:36] <LocutusOfBorg> reboot ongoing
[13:43] <LocutusOfBorg> works really nice
[13:43] <LocutusOfBorg> sforshee, for me it can be included, when you think  it is ready
[13:43] <LocutusOfBorg> I would just make sure with the build log that the module is the one built inside the kernel
[13:44] <sforshee> LocutusOfBorg: that kernel certainly has both, did you remove/rename the one in ubuntu/vbox to ensure you loaded the one you wanted?
[13:44] <LocutusOfBorg> it has not both
[13:44] <LocutusOfBorg> not sure why
[13:44] <LocutusOfBorg> but the path is good
[13:45] <LocutusOfBorg>  /lib/modules/foo-generic/kernel/drivers/staging/vboxvideo/vboxvideo.ko
[13:45] <LocutusOfBorg> so it must be the right one
[13:45] <LocutusOfBorg> the missing one has been available in /lib/modules/foo-generic/kernel/ubuntu/vbox/vboxvideo/vboxvideo.ko
[13:46] <LocutusOfBorg> build log might have the answer
[13:52] <sforshee> you should be able to run 'modprobe --show-depends vboxvideo" to tell you which one it will load
[13:54] <sforshee> I haven't made any effort yet to turn off the one we sync from the dkms package
[14:01] <LocutusOfBorg> sforshee, there is only one :p
[14:02] <LocutusOfBorg> anyhow, seems to be the right one I would say, since the other one just don't work
[14:02] <sforshee> oh, I misread, sorry
[14:02] <LocutusOfBorg> I mean, the one in the previous non-working kernel
[14:02] <LocutusOfBorg> same path, but not working
[14:03] <LocutusOfBorg> I confirm it being the right one
[14:03] <LocutusOfBorg> there is no "version:" tag, that is feeded in the vbox one
[14:03] <LocutusOfBorg> "version:        5.1.16_Ubuntu r113841"
[14:03] <LocutusOfBorg> this is missing obviously
[14:04] <LocutusOfBorg> confirmed being working, is it enough, do you want a bug/patch?
[14:04] <LocutusOfBorg> (and please delete the useless one)
[14:06] <sforshee> LocutusOfBorg: I pushed that fix to our unstable (4.14) kernel and turned the option back on
[14:07] <sforshee> I'm not sure yet what prevented the vboxvideo.ko in ubuntu/vbox to not be build, the log shows building the object but not the .ko file
[14:23] <LocutusOfBorg> maybe we can just remove that directory and reference in ubuntu/Makefile?
[14:36] <sforshee> it won't be quite that simple, we have a script to update from the dkms packages so will likely want to add a sed command or similiar to do it automatcially
[14:36] <sforshee> will figure it out once we have a vbox package compatible with 4.14
[15:18] <LocutusOfBorg> I didn't get it, but meh, I hope you fix it evenutally :)
[15:56] <LocutusOfBorg> bad news sforshee, the virtualbox-guest-dkms has not an higher priority anymore wrt the system one :(
[16:22] <apw> LocutusOfBorg, as in the staging one against dkms ?
[16:50] <LocutusOfBorg> apw, yep, that one
[16:50] <LocutusOfBorg> but honestly I don't understand why/where it gets that versioning