| burton-aus | hml CI check passed, but may need someone to review and verify it https://github.com/juju/juju/pull/7940 | 01:25 |
|---|---|---|
| hml | burton-aus: ty | 01:26 |
| burton-aus | babbageclunk and axw you may want to review the PR or verify it https://github.com/juju/juju/pull/7940 | 01:26 |
| * axw is looking | 01:27 | |
| babbageclunk | If it's a trivial backport (ie it didn't require changes to apply to the other branch) we typically don't require a review of the backport PR. | 01:29 |
| * babbageclunk goes for a run | 01:40 | |
| burton-aus | hml you can issue the merge comment now, axw has approved the change. | 01:49 |
| hml | burton-aus: done | 01:50 |
| burton-aus | hml yep | 01:50 |
| burton-aus | hml babbageclunk test failed http://ci.jujucharms.com/job/github-merge-juju/356/console, nothing is trivial. | 03:12 |
| burton-aus | hml babbageclunk weird - [xenial] -bash: line 59: go: command not found | 03:15 |
| babbageclunk | burton-aus: yeah, that seems pretty weird | 03:16 |
| burton-aus | hml babbageclunk it was run on juju-core-slave-b, so I went there and got: | 03:19 |
| burton-aus | hml babbageclunk which go | 03:20 |
| burton-aus | hml babbageclunk /snap/bin/go | 03:20 |
| burton-aus | hml babbageclunk not sure if I should create a soft link under /usr/bin | 03:20 |
| burton-aus | hml babbageclunk let me re-run the job first. | 03:21 |
| babbageclunk | burton-aus: did you work out what the problem with the test run was? | 04:01 |
| burton-aus | hml babbageclunk email sent | 04:22 |
| babbageclunk | burton-aus: if `which go` works for you, why can't the test run script run go? | 04:25 |
| burton-aus | hml babbageclunk the test runs on a instance created on the fly, not the machine I run which go. | 04:26 |
| burton-aus | hml babbageclunk overall I have no knowledge on the recent go version change, just debugging on the spot. | 04:31 |
| babbageclunk | burton-aus: ah, right | 04:32 |
| burton-aus | hml babbageclunk we may can merge it directly, to let CI handle the test. | 04:34 |
| === salmankhan1 is now known as salmankhan | ||
| thumper | o/ redir | 21:08 |
| redir | \o thumper | 21:10 |
| redir | How was NYC? | 21:16 |
| thumper | redir: pretty good | 22:01 |
| redir | sounds highly productive:) | 22:10 |
| thumper | redir: actually it was very good, good things happening | 23:36 |
| redir | That is awesome to hear | 23:45 |
| redir | \o/ | 23:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!