[01:25] hml CI check passed, but may need someone to review and verify it https://github.com/juju/juju/pull/7940 [01:26] burton-aus: ty [01:26] babbageclunk and axw you may want to review the PR or verify it https://github.com/juju/juju/pull/7940 [01:27] * axw is looking [01:29] If it's a trivial backport (ie it didn't require changes to apply to the other branch) we typically don't require a review of the backport PR. [01:40] * babbageclunk goes for a run [01:49] hml you can issue the merge comment now, axw has approved the change. [01:50] burton-aus: done [01:50] hml yep [03:12] hml babbageclunk test failed http://ci.jujucharms.com/job/github-merge-juju/356/console, nothing is trivial. [03:15] hml babbageclunk weird - [xenial] -bash: line 59: go: command not found [03:16] burton-aus: yeah, that seems pretty weird [03:19] hml babbageclunk it was run on juju-core-slave-b, so I went there and got: [03:20] hml babbageclunk which go [03:20] hml babbageclunk /snap/bin/go [03:20] hml babbageclunk not sure if I should create a soft link under /usr/bin [03:21] hml babbageclunk let me re-run the job first. [04:01] burton-aus: did you work out what the problem with the test run was? [04:22] hml babbageclunk email sent [04:25] burton-aus: if `which go` works for you, why can't the test run script run go? [04:26] hml babbageclunk the test runs on a instance created on the fly, not the machine I run which go. [04:31] hml babbageclunk overall I have no knowledge on the recent go version change, just debugging on the spot. [04:32] burton-aus: ah, right [04:34] hml babbageclunk we may can merge it directly, to let CI handle the test. === salmankhan1 is now known as salmankhan [21:08] o/ redir [21:10] \o thumper [21:16] How was NYC? [22:01] redir: pretty good [22:10] sounds highly productive:) [23:36] redir: actually it was very good, good things happening [23:45] That is awesome to hear [23:45] \o/