=== JoshStrobl is now known as JoshStrobl|AFK === robert_ancell_ is now known as robert_ancell [03:46] PR snapcraft#1568 closed: lxd: don't re-inject the same snaps [03:46] PR snapcraft#1618 closed: states: add scriptlets to build state [05:21] o/ [05:49] mvo: hey [05:49] just the man I wanted to see [05:51] mvo: https://github.com/snapcore/squashfuse/pull/1 [05:51] PR squashfuse#1: Tweak implementation of dummy go module [05:51] hey zyga-ubuntu [05:53] zyga-ubuntu: hyes, thanks for this PR! did you test it, does that work? I also tried a subdir approach and go get would only checkout the actual dir, not any other dirs. if it works, that would indeed be very nice [05:53] zyga-ubuntu: (i was doing it the other way around, the C source in a subdir) [05:53] mvo: it go builds but I didn't test the full govendor sync with it (I'd have to change paths) [05:53] mvo: right but that failed for me [05:53] mvo: the linker part was not working [05:54] mvo: and govendor complained if nothing referenced that [05:54] mvo: now it's working locally, if you commit I will be able to sync [05:54] zyga-ubuntu: let me try quickly based on your branch, if it works, +100, very nice [05:54] if it doesn't work we can remove that patch from history [05:54] mvo: one sec [05:54] http://paste.ubuntu.com/25757470/ [05:54] you want this in your snapd tree [05:55] zyga-ubuntu: oh, nice, yeah, this way around it works [05:55] zyga-ubuntu: \o/ [05:56] I can push this into your branch [05:56] zyga-ubuntu: please do, I will take care of the rest, that will simply some things [05:56] just say the word [05:56] done [05:56] zyga-ubuntu: thanks [05:56] zyga-ubuntu: (I guess that was the word your were looking for ;) [05:56] * mvo hugs zyga-ubuntu [05:57] woot, I hope we can quickly solve this [05:57] do you want to make .6 with this feature? [05:57] zyga-ubuntu: no more 2.28 :) it will be part of 2.29 [05:57] zyga-ubuntu: unless regression of course, then there will be a .6 [05:59] hmmmm [05:59] Obtaining dependencies [05:59] Found unused ./vendor packages: [05:59] vu github.com/snapcore/squashfuse [05:59] Please fix via 'govendor remove +unused' [05:59] darn, govendor is too picky [05:59] why doesn't it see the test reference? [06:00] is govendor really syncing sudirectories or nothing? [06:01] zyga-ubuntu: hm, it is not complaining here, strange [06:01] let me reset my tree [06:02] it didn't complain when I had the tree in $GOPATH [06:02] but now it does [06:02] now I just need to make autogen.sh work in squashfuse [06:02] darn govendor [06:02] maybe we can just make get-deps.sh not fail on that? [06:03] zyga-ubuntu: I removed everyting squashfuse from my GOPATH and ran tests again, no error [06:04] * zyga-ubuntu thinks [06:04] well [06:04] if it works in the build I'll be happy [06:04] mvo: and you want to twaek autogen for local development? [06:04] mvo: I'm building the package now [06:05] zyga-ubuntu: it complains for me about SQ_WANT_HIGHLEVEL missing [06:05] eh, "does not appear in AM_CONDITIONAL" [06:05] (not missing) [06:05] mvo: the beauty of autohell [06:05] zyga-ubuntu: did this work for you? [06:05] yes [06:05] but something odd is going on [06:05] zyga-ubuntu: I'm on artful, maybe because of that? [06:06] mvo: I just saw your dummy-{gcc,ld} output [06:06] something must be cached somewhere [06:06] ah [06:06] man, we didn't change the hash in vendor.json [06:06] zyga-ubuntu: git pull [06:06] I'm on artful too [06:06] k [06:06] zyga-ubuntu: that will update the vendor.json [06:06] got that now [06:06] fatal: Could not parse object 'f066269fbbcd0ec6232cdffbc0fe48c7e2f7ad97'. [06:07] woah [06:07] # cd /home/zyga/go/.cache/govendor/github.com/snapcore/squashfuse; git reset --hard f066269fbbcd0ec6232cdffbc0fe48c7e2f7ad97 [06:07] thats strange I just did "govendor fetch github.com/snapcore/squashfuse" [06:07] I'll kill that cache [06:08] now it worked [06:08] weird [06:08] maybe the cache was confused by my operations on the local tree earlier (I squashed/amended) [06:08] building in progress [06:08] zyga-ubuntu: yeah, just double checked, the hash i nthe vendor.json matches the git repo [06:09] it failed on three automake things now [06:09] Makefile.am:6: error: MAKE_EXPORT does not appear in AM_CONDITIONAL [06:09] Makefile.am:36: error: SQ_WANT_HIGHLEVEL does not appear in AM_CONDITIONAL [06:09] Makefile.am:48: error: SQ_WANT_LOWLEVEL does not appear in AM_CONDITIONAL [06:09] I think we are now in sync [06:10] yes [06:10] same that i get [06:10] brb, daughther goes to school [06:31] re [06:31] sorry, kids as usual :) [06:32] mvo: are you patching those? [06:32] I just started [06:32] zyga-ubuntu: hi, looks like issue #12 for squashfuse discusses the issue we are seeing [06:32] PR #12: Bugfix/lp1480248 test reenable [06:32] mvo: looking [06:32] zyga-ubuntu: I patched them but got stuck right after that :/ [06:33] hehe, look who reported it [06:34] mvo: how does it build in the archive? maybe there's a patch [06:34] zyga-ubuntu: aha, good idea [06:34] zyga-ubuntu: fwiw, feel free to attach your patch :) [06:35] mvo: I don't have anything yet, just reading the configure script now [06:36] zyga-ubuntu: mehhhh [06:36] mvo: I find it sad/silly that a half a dozen C file project is so hard to build [06:36] wat? [06:36] zyga-ubuntu: the m4 subdir is missing I think [06:36] I see it here [06:36] missing as in not copied somewhere? [06:36] zyga-ubuntu: thats govendor again, its really annyoing about subdirs [06:36] ah [06:36] zyga-ubuntu: rm -rf the squashfs and get it again [06:36] mv dummy m4/ [06:37] zyga-ubuntu: and then check the dir [06:37] ah, right, I was looking at the full git tree [06:39] did you get [06:39] extract.c:51:17: warning: implicit declaration of function ‘sqfs_makedev’; did you mean ‘sqfs_mode’? [-Wimplicit-function-declaration] [06:42] zyga-ubuntu: I wonder how to overcome the m4 subdir problem [06:42] mvo: mv dummy m4/dummy [06:42] done [06:42] we'll get the full set [06:42] (silly but, well it should work) [06:42] zyga-ubuntu: heh, smart [06:43] mvo: I'd say sad but I think we are in agreement :) [06:43] * mvo hugs zyga-ubuntu again [06:43] mvo: I'll try something entirely different to see how crazy that would be [06:44] zyga-ubuntu: I update the trees for your approach in the meantime [06:44] ok [06:45] mvo: note that squashfuse uses a library now [06:45] mvo: where will we keep it? [06:45] mvo: it seems we need to link that statically [06:46] zyga-ubuntu: yes, we need to link statically [06:46] mvo: note, just the library, the rest can be dynamic [06:46] (to avoid hair-pulling in other distros0 [06:53] zyga-ubuntu: hm, adding github.com/snapcore/squashfuse/ does no longer work for me without go files in it, it is just silently ignored [06:54] mvo: take a break from this problem for two hours please [06:54] mvo: if my approach fails we can go back to adding more hackery [06:57] zyga-ubuntu: ok [06:58] mvo: how are we calling the binary? snapfuse? [07:00] zyga-ubuntu: yes [07:00] zyga-ubuntu: https://github.com/snapcore/snapd/pull/4049/commits/bff17ef731ea8e2bc88a1ab2066b33a2bc8c0e31#diff-42c07ec7ffa970857b4e0db2614e482bR428 [07:00] PR #4049: debian,vendor: import github.com/snapcore/squashfs and use [07:02] thank you! [07:03] Lo. Is it still possible somehow to set up your own snap store and configure snap to use it? Looks like https://github.com/noise/snapstore/ stopped working a while ago and was abandoned recently. [07:03] I already asked on https://plus.google.com/+ThorstenLeemhuis/posts/HyHfxaFQWz2 but got no reply [07:10] knurd: please look at forum.snapcraft.io, this has been extensively discussed there under the topic "extenral repositories" [07:12] zyga-ubuntu: thx for the pointer! [07:14] wa [07:28] mvo: almost there, I think [07:30] zyga-ubuntu: btw i poked at 2.28.5 in debian, i didn't do the dependency updates though [07:30] i should push what i have to alioth i guess [07:30] vendor.json diffs are hard to read :( [07:32] fwiw 4047 needs a second review [07:34] mwhudson: ack [07:34] mwhudson: I'll have a look, I cannot promise anything soon though (I need to trim my PR list) [07:34] yeah. o [07:34] bah [07:35] yeah, i'll try to poke at it over the next couple of days too [07:35] mvo: http://pastebin.ubuntu.com/25757771/ [07:35] mvo: integrated into our build system [07:36] zyga-ubuntu: nice, I wonder if libfuse is installed by default [07:36] and 4028 (easy) needs a second review [07:39] zyga-ubuntu: curious what you did and how you overcame the m4 subdir issue [07:40] mvo: I can link that statically [07:40] zyga-ubuntu: I think we just need to check in the lxd base image [07:40] mvo: I just integrated that into our build, the whole set of m4 macros is needed for things we don't need [07:41] we can also drop code like non xz compression and windows support files [07:41] zyga-ubuntu: *nod* [07:47] mvo: shall I review 4028? :D [07:48] zyga-ubuntu: ;) I was hoping pstolowski or chipaca might have a look [07:50] mvo: I tweaked the build system to simplify what we need, I'll run a spread test if that works [07:50] mvo: I'll push this for reference but I want to re-do it so that we can import git history [07:51] mvo: we might be able to pull in fixes from squashfuse upstream this way [07:51] mvo: so far so good though [07:51] approved [07:51] mvo: we can also go through the code and simplify windows bits out [08:17] mvo: builds are ok, testing in spread [08:19] mvo: once this works I'll ask you to review and then let's see what to do about history, ok? [08:21] ok [08:21] mvo: https://github.com/zyga/snapd/tree/rfc/integrated-squashfuse [08:21] this is the code [08:22] mvo: and this is the new part essentially: https://github.com/zyga/snapd/commit/3545b115cb90e702779c43703f70db9e01b10cff [08:28] mvo: lxd test now running [08:28] fingers crossed [08:38] doh :) [08:38] silly mistake [08:38] fixed now, re-running tests [08:38] I didn't enable XZ [08:38] moin [08:40] Chipaca: hey [08:51] mvo: it works now, I think I need to expand this to cover more packaging [08:56] zyga-ubuntu: just cherry pick my bits from https://github.com/snapcore/snapd/pull/4030 [08:56] PR #4030: many: add internal squashfuse copy as "snapfuse" [08:56] mvo: aha, thank you [08:57] zyga-ubuntu: I will revert 4049 back to the original state, lets see what niemeyer thinks about the two approaches as they have boths pros/cons [09:00] Hello, I have a Dell atom based mini PC came pre-installed with Ubuntu Core 16. I would like to know if it is possible to install cmake and domoticz packages on it? I am a newbie to Snappy, please pardon me. [09:01] zyga-ubuntu: but maybe/probably the govendor approach is doomed as it cannot statically link selectively via configure [09:03] mvo: fingers croessed [09:03] mvo: https://github.com/snapcore/snapd/pull/4051 [09:03] PR #4051: many: add integrated snapfuse [09:03] PR snapd#4051 opened: many: add integrated snapfuse [09:03] mvo: I'll break for shower/coffee as I'm still in my pijamas today [09:03] Tazmania: if you want to develop its probably easiest if you "snap install classic; classic" [09:04] Tazmania: eh, "sudo snap install --devmode --beta classic" that is [09:04] zyga-ubuntu: heh, thank you! [09:04] Tazmania: and please look at forum.snapcraft.io, lots of friendly people there and lots of questions answered already [09:04] What's the difference between classic and the pre-installed? [09:04] zyga-ubuntu: thanks. I will check the forum [09:04] zyga-ubuntu: did you add a patch to fix the sqfs_makedev() error ? [09:05] mvo: compare diffstat in 4030 and 4051 [09:05] automake is crazy [09:05] mvo: hmmmmm, I don't think I did [09:05] Tazmania: classic is a environment that makes it easy to develop using the classic tools [09:05] mvo: thanks [09:05] mvo: have a look at my branch please, let's see what we can cut from snapfuse/*.[ch] [09:05] zyga-ubuntu: interessting, I get a warning that is turned into an error here [09:06] mvo: hmm, spread passed for me, hmmm [09:06] zyga-ubuntu: cool [09:06] maybe I did but I didn't notice :) [09:06] anyway, afk for a moment [09:07] zyga-ubuntu: lets see what gustavo thinks, I personally would like to make snapfuse as much "imported" as possible and ideally not modify it but I see the advantages so lets see how gustavo feels about what approach should be taken [09:07] zyga-ubuntu: see you [09:14] mvo: shall we prepare an alt version that has working imported approach? [09:15] mvo: I mean, it might be even this code, we could just depend on a script that gets the debian .orig tarball [09:15] mvo: (via get-deps) [09:16] diddledan: sorry for the delay, testing your corebird snap [09:18] zyga-ubuntu: lets talk after you had your shower, I'm not sure myself. [09:19] I'm back already [09:20] mvo: ok, I'll look at failing tests in one of my PRs and let's wait to see if 4051 is green [09:37] zyga-ubuntu: for when you are back - do you happen to know why none of our tests caught the typo https://github.com/snapcore/snapd/pull/3617/files#diff-ec8cacef522dbb27eeb9ceed25f03b22R249 ? I mean, we have a integration test for network-control, why does that not fail on invalid content? can we add that? [09:37] PR #3617: interfaces/builtin: use udev tagging more broadly [09:39] mvo: looking [09:39] aha, that typo [09:39] let me think [09:39] zyga-ubuntu: I'm breaking it on purpose now and run the spread test to see if our checks are insufficient [09:40] zyga-ubuntu: does udev not error when we write incorrect files? [09:40] mvo: are those tests checking tun devices? [09:40] mvo: I think the file was parsing OK, just not doing what we wanted [09:41] zyga-ubuntu: no, no checks for tun devices. hm, ok, if its valid syntax just the wrong one that is hard to test [09:41] mvo: maybe if the rules looks like `KERNEL=="foo", TAG+="...",\nKERNEL=="bar", TAG+="..."` the rule is just a no-op [09:41] mvo: as in, it will never match both "foo" and "bar" [09:41] zyga-ubuntu: there was an extra "," at the end of the line [09:41] I can test that theory but I need to get to the bottom of something failing in my branch first [09:41] (in this particular case) [09:41] mvo: right but , is a separator for udev expressions [09:42] zyga-ubuntu: sure, I can chase this [09:42] zyga-ubuntu: aha, ok [09:42] mvo: we could build a simple safeguard [09:42] mvo: add a new api to udev.Specification [09:42] mvo: that has less flexibility in it [09:42] mvo: we could then rewrite vast majority of udev rules to use that [09:43] mvo: and maybe keep {modem,network}-manager as the only uses of the more powerful, type-unchecked api [09:43] mvo: essentially there's no type checking anywhere there [09:43] mvo: we could also have a test that parses all the snippets [09:44] mvo: and ensures that some simple impossible conditions are not present [09:44] mvo: like tests that attr == "a" and attr == "b" at the same time [09:44] mvo: I did something similar-ish for apparmor rules earlier (I was fully parsing them, there's still a branch somewhere I can find) [09:44] zyga-ubuntu: ok, thank you. sounds all like some work [09:46] mvo: sorry, it's not apparmor, it was seccomp, [09:46] mvo: the branch starts at 87826dc09a7a43357500329032185544b53c5c91 [09:46] mvo: feature/typed-syscalls in my remote [09:46] mvo: that ensures that seccomp rules are well typed [09:47] mvo: udev rules are not too sopisticated, we could do something like that too [09:47] mvo: even if it's just for testing [09:47] * Chipaca realises the time and runs to make it to physio [09:47] Chipaca: o/ [09:47] run slowly and safely man [09:49] * zyga-ubuntu fixed his other brnach [09:52] pstolowski, zyga-ubuntu: related, the lxd-demo-server stopped because we had lxd as reserved for the OS, when that started to fail we changed something else, right? more strict checking in the interfaces code, does anyone remember details? [09:52] hey Chipaca [09:52] (sorry for the many questions, writing the retrospect right now) [09:53] mvo: I don't remember, let me look [09:53] mvo, there was a change recently (the week after the sprint) to that interface [09:54] Hi Guys, I'm trying to build Ubuntu Core for Nvidia TX1 it's a arm64 bit system. I'm following this guide: https://wiki.ubuntu.com/ARM64/FoundationModel but the link to download ubuntu-core-13.10-core-arm64.tar.gz is broken. I have tried to find a more recent version of the core for arm64 but without luck.. [09:54] mvo: I only found 042f9d0085bf6fe0ff82345cc58804d9e21eb318 [09:54] Does anyone know where I can find it, if it exist? [09:54] skjensen: ubuntu-core-13.10? [09:54] ogra_: ^ [09:54] I would like ubuntu-core-16.04 [09:54] I think that's something for you [09:55] pstolowski: yes, we fixed the issue in that PR a week after the sprint. I wonder what commit/PR broke it though, it was reserved for the OS since forever afaik. [09:55] zyga-ubuntu, mvo yes, that's the change I meant [09:55] mvo: I think we just never tested that combination mvo [09:55] mvo: you added a test for this later [09:55] mvo: after the brekage occurred [09:55] zyga-ubuntu: stgraber reported lxd-demo-server used to work and started breaking with 2.28 [09:56] zyga-ubuntu, pstolowski ok, I chase that, thanks for your input! [09:56] skjensen: ogra is the person for that question, I think there is (or might be) a model/gadget/kernel for TX1 but I'll let him answer with authority [09:56] wow, incredible, I can actually write a new feature now [09:56] and it's 11:56 [09:56] skjensen, the old ubuntu-core has been enamed to "ubuntu-base", tarballs can be found at http://cdimage.ubuntu.com/ubuntu-base/ [09:56] *renamed [09:57] Great thanks.. :) Is there one for the TX1? [09:58] mvo: I spoke too soon, the fuse stuff, no fuse on 14.04 [09:58] mvo: so packaging diverges [09:58] mvo: and this is now optional [09:58] mvo: meeh [09:59] skjensen: do you want classic ubuntu headless or the new snap-based ubuntu (aka ubuntu-core nowadays) [09:59] skjensen, if you want an actual snap based UbuntuCore install then you need to create a gadget snap and use ubuntu-image to build an image for it ... the jetson tk1 is supported in the llinux-generic-bbb kernel (by selecting the tegra124-jetson-tk1.dtb devicetree froom the gadget snap) [09:59] I want the new snap-based ubuntu due to the new features. It's for a IoT deployment [10:00] skjensen, the -base tarballs are just root filesystems just pick the arm64 one [10:01] skjensen: I'd suggest you open a forum thread about TX1 core image [10:01] skjensen, aha ... https://ograblog.wordpress.com/2017/05/30/building-u-boot-gadget-snap-packages-from-source/ and https://ograblog.wordpress.com/2017/06/13/patching-u-boot-for-use-in-an-ubuntu-core-gadget-snap/ ae what you want then [10:01] clobrano: hey [10:01] skjensen: you should familiarize yourself with some snappy concepts (models, gadget snaps, kernel snaps) to make a proper set of files needed to support this [10:01] kalikiana: hi [10:02] c-lobrano: You wanted to work on bug 1722650? [10:02] Bug #1722650: snapcraft requires optional VERSION_ID in os-release [10:02] skjensen: doing that on the forum is easier and many people can participate (across timezones) [10:02] skjensen, create that gadget, make it use tegra124-jetson-tk1.dtb and once you have that ping me again and we'll talk abut how you get yur own kernel build fom the linux-generic-bbb snap [10:02] ogra_: btw, do you have the TX1 or the TX2? [10:02] ogra_: are they decent machines? I was thinking about getting one simply because it has oodles of ram (for an arm board) [10:03] zyga-ubuntu, nope ... i stopped after tegra2 ... [10:03] kalikiana: yes, but before pushing a change according to what you suggested, I'd like to see what kind of file snapcraft is looking for [10:03] ogra_: aha, thank you [10:03] they shoudl be in the relam of a dragonbard [10:03] I got the TX1 and actually got a TK1 as well.. But we decided we needed the TX1 to run out software since it uses TensorFlow and that's not supported anymore on the TK1 [10:03] c-lobrano: Do you have a local checkout of snapcraft? [10:03] mvo: shall I change the snapfuse PR now or would you rather wait for gustavo's opinion first? [10:03] c-lobrano: You can have a look at the "libraries" folder [10:04] kalikiana: yes, I've already branched the project for a previous PR [10:04] *forked [10:04] It's a work project, so I got the next 2 months to dive into the snap universe and get a proper version up and running on the TX1. Thanks for all the help to get started on this. I will let you know how I get on.. :) [10:05] zyga-ubuntu: either way is fine with me [10:05] skjensen: welcome aboard, the forum has a "docs" category with useful documentation [10:06] Great :) [10:06] skjensen: there's also the "device" category for topics related to making and supporting new devices [10:06] https://forum.snapcraft.io/c/device [10:07] https://forum.snapcraft.io/c/doc [10:07] https://forum.snapcraft.io/t/the-gadget-snap/696 [10:07] skjensen, well, start with the gadget and for easiness i'd take the tk1 first ... the gadget between the two will only differ minimally so you can re-use it for tx1 with some minimal changes ... the difference between the tw is that you will need your own kernel for the tx1 so fr a start the tk1 will be easier ... [10:07] https://forum.snapcraft.io/t/the-kernel-snap/697 [10:08] skjensen, just folllow the blogposts i gave yu abve, they have a step by step guide and all links to alll docs yu need [10:08] ogra_ thanks, I will get started on the TK1 to get some experience.. and then move onto the TX1 [10:09] iirc there was also some jetson work done initially by parrot ... not sure if they put that in github though [10:12] c-lobrano: Perfect. So if you see the "libraries" folder, there's a file "16.04" in there, which if you open it contains a lot of filenames. [10:12] That's the ones that get stripped from the snap [10:13] kalikiana: oh, I see [10:13] ogra_ super, and I can guarantee you my work will go up on github for everyone to use.. [10:13] \o/ [10:14] kalikiana: so, if no VERSION_ID exists, there is no way to find "another equivalent" file, right? [10:16] c-lobrano: The code basically wants to know that it runs on Ubuntu 16.04 and do its thing. If VERSION_ID isn't there... it should probably be equivalent to a different version, like say 17.10, in which case there's no file [10:21] kalikiana: perfect, so I can propose my PR [10:23] c-lobrano: Yeah. I think kyrofa made a good point there with regard to abstracting it, tho not sure it should be done in the same PR... unless you'd like to look into that as well? [10:26] mvo, you might want to mention https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1724088 in the changelog for the release [10:26] Bug #1724088: All snap packages fail to start with 'udev_enumerate_scan failed' [10:30] kalikiana: oh, I wasn't subscribed to the bug yet, and I missed kryofa's comment. What about doing two PR, one for the bug and one for the "new feature"? [10:36] PR snapd#4052 opened: tests: check for invalid udev files during all tests [10:36] c-lobrano: Yeah, that's what I was thinking as well. The fix itself is straight-forward [10:37] kalikiana: alright. I'm in the middle of ./runtest.sh unit, then I can push the PR [10:43] c-lobrano: Awesome. Thanks for working on it! [10:44] kalikiana: yw :) [10:53] mvo: there's a typo in tihs: [10:53] 2017-10-12 Bureport from 16.04 users about udev_enumerate_scan failure not fixed until the machine is reported. This is unacceptable so we added cleanup code into snap-confine to cleanup the state that caused libudev to be erroring (releated to the udev device tagging that was incorrectly applied to nvidia devices) - PR#4042. [10:53] s/machine/machine is rebooted/ [10:54] mvo: otherwise great writeup, thank you! [10:58] * zyga-ubuntu goes to pick up his son from new school. will probably miss the standup in traffice, be back in two+ hours [11:41] PR snapcraft#1623 opened: Removed dependency on VERSION_ID in os-release [12:06] c-lobrano: Could you add a unit test for your fix? Probably in snapcraft/tests/test_libraries.py [12:06] kalikiana: sure [12:07] re, waiting for son in school [12:16] kalikiana: just let me see how to do it :) [12:26] o [12:26] o/ [12:28] \o [12:31] o/ [12:35] /o/ [12:35] \o\ [12:35] \_o_/ [12:36] mvo: What's up with snapfuse? (Wondering about zyga's comment above) [12:36] (and about the new PR) [12:36] first rule of the snappy yoga club ... don't talkk about the snappy yoga club [12:38] ogra_: You just broke it [12:38] yeah, the evil in me ... :) [12:39] niemeyer: its mostly about details in how we should do it. I was trying to use "govendor fetch" to get it. however its really fighting govendor more than anything else. the alternative is to embedd it, zygas approach is to integrate it pretty close (including putting it into our make files instead of using the upstream makefiles). I was mostly curious about your suggested approach [12:40] ogra_: thanks for the pointer to the bug about udev_enum_failed [12:40] np [12:41] hi, could anyone kick a CI run on https://github.com/snapcore/snapd/pull/3916? I suspect there were some infrastructure issues on the previous run [12:41] PR #3916: snap,wrappers: add support for socket activation [12:42] mvo: What happened with govendor? I was hopeful as well [12:45] niemeyer: its still there in #4049, but open issues and I had to be quite creative to make it go getable (https://github.com/snapcore/squashfuse/commit/ed6f37bbee6537e0598aa7f4f5dafa379be0c73a) [12:45] PR #4049: debian,vendor: import github.com/snapcore/squashfs and use [12:46] c-lobrano: Feel free to pester me with questions as needed :-D [12:46] mvo: Oh, I see.. so govendor will still use go get [12:46] niemeyer: we can further explore this, we need to link some (or all) libs for snapfuse statically to ensure we don't add other hidden dependencies [12:46] kalikiana: :D I'll do [12:47] niemeyer: yes, I could not make it just fetch my git tree, it was slightly confusing as you can add things and it will not err/warn but just silently ignore it if it does not look like a go repo [12:48] Hmmm [12:50] niemeyer: we can talk more in the standup, zygas PR is much much closer (and conceptually easier). the downside is that we need to track upstream [12:50] (closer) [12:50] mvo: If all we want is to get the tree and not compile, we might just drop a Go file somewhere [12:53] * kalikiana time for a break [12:53] niemeyer: that is what I did, unfortuantely once there are C files in the tree it will try to compile them (it being go) [12:53] mvo: It won't try to compile any place that you don't explicitly get [12:53] niemeyer: so yeah, we can make it work its just a bit more hacky and we need to solve how to statically linki in that PR [12:53] mvo: e.g. if you create a directory and drop a println("hi") on a .go file on it, and get _that_ package path, it won't care about the rest [12:54] niemeyer: correct, but it will also only get that directory and leave parent dirs empty [12:54] mvo: No.. it fetches the whole repository [12:55] mvo: There's no way to tell git to fetch a subtree [12:57] niemeyer: you are right, this is what I see with go get too, I wonder why I had a different experience with govendor, I can try this again and understand the details [12:58] ogra_ I'm trying to follow your beaglebone guide to build for the TK1, but I'm a bit unsure about the uboot.env.in file? Where did you get that from? [12:59] skjensen, you start with "printenv" in the uboot shell to get the default env ... then you need the load* scripts to load the right files and all the snappy_* and snap_* vars (and scripts) [13:01] * zyga-ubuntu is online but in super-noisy place [13:01] and examples are at https://github.com/ogra1/beaglebone-gadget/blob/master/uboot.env.in ... or https://github.com/ogra1/pi3-gadget/blob/master/uboot.env.in [13:03] okay, thanks.. [13:04] the essential bits are "loadfiles" and "snappy_boot" [13:06] okay.. :) [13:12] kalikiana: I'm using TestSystemLibsOnNewRelease as template, mocking get_os_release_info in order to return a dict without VERSION_ID, but somehow I still get the 16.04 list of .so, maybe you can spot my mistake http://paste.ubuntu.com/25759264/ === ShalokShalom_ is now known as ShalokShalom [13:29] c-lobrano: _get_system_libs uses a global variable. Can you try unsetting it in the setup method? [13:30] ie. `_libraries = None` [13:30] it's set and checked at the top of the _get_system_libs function [13:38] I see, but it doesn't seem to work [13:40] you tried it like that? === JoshStrobl|AFK is now known as JoshStrobl [13:42] yes, with global _libraries first [13:46] c-lobrano: Hmmm maybe you can mock.pantch _libraries? [13:46] And give it .return_value = None [13:46] kalikiana: good idea, let me try [13:47] * c-lobrano haven't used unittest.mock much so far [13:55] kalikiana: it was easier than expected "libraries._libraries = None" [13:55] Oh, nice [13:55] saint StackOverflow ;D [14:06] kalikiana: weird, can't see the PR updated [14:10] c-lobrano: I don't see it either. Did you `git push origin bug-lp1722650` the branch? [14:10] kalikiana: I did `git push -f` actually, but I can see it on my repo [14:11] https://github.com/snapcore/snapcraft/compare/master...clobrano:bug-lp1722650 [14:12] Hmm. Even if you amended the commit it should have updated automatically [14:13] Or did you completely re-do the branch under the same name? [14:15] pstolowski, mvo I have the same issue with the pi3 using 2.28.5 [14:16] I try to creata the image by using the deb ubuntu-image [14:16] cachio_, i've just finished preparations, about to run the test [14:16] cachio_: did you and pstolowski figure out in what way the test differed between you? [14:17] btw sergiusens did you want to have a one on one today? You mentioned it the other day, but I have none anymore in my calendar since you removed it last time [14:17] mvo, a diff is the tool we used to create the image [14:18] mvo, i used ubuntu-image from the distro (not snap), however the version number is the same, so perhaps that's irrelevant [14:18] kalikiana: just amended [14:18] c-lobrano: Hmm weird. It should just show up then [14:18] cachio_, pstolowski aha, thats very interessting [14:19] mvo, it's hard to compare the versions of other stuff, Sergio flashed his card already. this time we will generate beta images at the same time [14:19] pstolowski: \o/ [14:20] kalikiana, sergiusens, kyrofa, who's fielding questions along the lines of "why does a snap built with this snapcraft.yaml throw these library errors"? [14:20] * kyrofa runs [14:21] Chipaca, hit me :) [14:21] haha [14:21] * Chipaca picks up a 15kg wrench [14:21] Chipaca: are you going to mend the computer? [14:21] kyrofa: actually i'm asking on behalf of https://forum.snapcraft.io/t/how-do-i-create-an-opengles2-and-glfw3-snap/2488 [14:22] * zyga-ubuntu is in a bus, working like it's his office [14:22] zyga-ubuntu: put pants on, man! [14:23] Chipaca, alright I'll take a look, thanks for the ping :) [14:24] Chipaca: oh my! [14:24] and I thought I just looked good [14:24] all the people staring [14:27] Chipaca the title doesn't make me feel it would be easy as the text below it makes it [14:27] kalikiana: alright, changed commit message a bit, now github recognized the update :D [14:27] sergiusens: users gonna use [14:28] Chipaca isn't all the gl stuff supposed to be mirrored into the snap through the snapd mounts? [14:28] zyga-ubuntu ^ ? [14:28] was about to say, i think some magic is done, but ask zyga-ubuntu :-) [14:28] this might just be a "add the opengl interface" or something [14:28] * Chipaca no sabe [14:32] c-lobrano: One note on the test data. How about using something other than Xenial where it's normal to have no VERSION_ID field? [14:32] Otherwise it's potentially confusing to someone reading the test [14:32] kalikiana: c-lobrano: you know about os-release-zoo? [14:33] Chipaca: What's that? [14:33] kalikiana: like an animal zoo, but of os-release files [14:33] kalikiana: https://github.com/zyga/os-release-zoo [14:34] Oh, neat [14:34] MAybe this one https://github.com/zyga/os-release-zoo/blob/master/elementary/elementary-0.4.txt works for this test [14:35] kalikiana: note that one is wrong [14:35] as in, it's what they shipped, but it's invalid [14:35] they have since fixed it (i think0 [14:35] ) === anewman_ is now known as anewman [14:36] Ah, it has the invalid ID. There was even a snapcraft bug about it [14:36] :-) [14:37] * ikey sometimes thinks os-release needs an UPDATE_MECHANISM field to properly describe the core architecture [14:37] ikey: also a SUCKS_LIKE field [14:37] IS_AT_LEAST_AS_BAD_AS=... [14:38] lol [14:42] kalikiana: I think you're right. I'm not familiar with os-release-zoo [14:42] c-lobrano: hey [14:42] c-lobrano: github.com/zyga/os-release-zoo [14:42] cachio_, it failed for me with snap_mode not defined again, http://pastebin.ubuntu.com/25759787/ [14:42] mvo, ^ [14:43] hey zyga-ubuntu, thank you, I'll look into it [14:43] cachio_, my versions: http://pastebin.ubuntu.com/25759794/ [14:44] cachio_, how about yours? [14:45] pstolowski, one min please [14:45] flasing the new one [14:48] pstolowski, did you use the ubuntu-image snap? [14:48] cachio_, yes [14:52] pstolowski, https://paste.ubuntu.com/25759837/ [14:52] this is mine [14:52] flashed with deb ubuntu image [14:52] the only diff is the rev for the core [14:53] pstolowski, I am gonna run the test now [14:54] sorry for not replying kyrofa, I spent too much time fixing my wifi yesterday [14:54] cachio_, why is it different? [14:55] cachio_, please check if there is actually any corruption by running fw_printenv manuallly after the test, we found yesterday that this actually works and there might be just an issue how fw_printenv is used in the test or a bug in fw_printenv itself but no actual corruption of uboot.env or the vfat ... [14:55] elopio, quite alright. Things working better today? [14:55] kyrofa: docker will speed things, we can go back to it. However, the problem we had was that nobody is developing in docker, so it was hard to reproduce the errors. [14:55] also, we can't install snaps. [14:55] cachio_, all manual runs of fw_printenv returned proper results yesterday even if the test failed [14:55] ogra_, ok [14:55] elopio, yeah I was mostly meaning for normal units/integrations [14:56] But if there are weird failures there, yeah that would explain it [14:56] kyrofa: if we publish a snap before running the integration tests, there will be no deps to install. [14:56] Very true [14:57] elopio, but again: talking about unit tests and stuff [14:57] kyrofa: I'm not worried about unit, but I have no problem moving those to docker. [14:57] elopio, yeah I really just mean as an overall speedup step [14:57] cachio_, please paste your error if it hppens again [14:59] kyrofa: we still have the docker scripts around, because I didn't get a chance to move the CLA to lxc. My plan was to have everything consistent in lxc, but we can go the other way, no big arguments from me. [15:00] pstolowski, it works when I flash with the deb }ubuntu-image [15:00] elopio, I have no strong feelings. We all know lxd better. I was just thinking from a speed perspective [15:00] did you run the test with the image flashed with the snap ubuntu-image? [15:00] Not sure it's worth it [15:01] mvo, when I use an image flashing with the deb ubuntu-image the tst pass, when I use the snap ubuntu-image the test fails [15:02] mvo, interesting [15:02] ogra_, also for you [15:02] kyrofa: would it make sense to explore having a persistent lxc container and caching it? [15:02] elopio, caching it... in lxc? [15:02] Ugh, in s3 I mean, sorry [15:02] Not awake yet [15:02] caching it in travis [15:02] How would that work? [15:03] cachio_, hmm, has the deb even been updated sinc ethe snap exists ? [15:03] also ... the deb requires you to use the foundations PPA for it to get the ext4libs version that make you not require sudo [15:04] though neither should have any influence here [15:04] I ran with sudo [15:04] elopio: Where would the container be created/ destroyed in that case? [15:04] ogra_, is it a problem? [15:04] well, it is a difference ... :) [15:05] cachio_: yay [15:05] the version differemce might/could be a prob though [15:05] cachio_: that is awesome news, we have a smoking gun now [15:05] mvo, cachio_ well, it doesn't match my results [15:05] cachio_: I bet its the embedded mtools (or whatever vfat tools) inside the snap then [15:05] pstolowski: what do you get? [15:06] mvo, http://pastebin.ubuntu.com/25759787/ [15:06] mvo, it's from a few moments ago, i flashed with ubuntu-image from the snap (yesterday I was using ubuntu-image from the deb) [15:06] pstolowski, ubuntu-image deb or snap ? (and did you use sudo or not) [15:07] aha [15:07] so a smoking red herring then :P not a gun ... [15:07] ogra_, I always used sudo [15:07] ogra_, yes I used sudo [15:07] wwith the snap you shouldnt need to ... [15:07] and with the deb, only if you dont use the PPA [15:08] ogra_, but no harm either way? [15:08] theoretically not [15:08] practically ... i dont know :) [15:09] pstolowski: well, its the EOF again, thats slightly different than the error from cachio_ [15:09] pstolowski: still interessting and something I would love to figure out why the connection is broken [15:09] * kalikiana going to step out for a bit, to find some food [15:10] mvo, but first and foremost, it's snap_try_core and snap_mode not defined again, right? [15:10] pstolowski: it will get cleared after a successful boot, so its ok if you don't see it [15:12] pstolowski, cachio_ I need to interrupt your testing with 2.28.5 and push 2.28.1 with a wpa fix to beta now [15:13] mvo, np [15:13] should I validate it now? [15:15] Yikes... using github to update branches is not working [15:16] Something is broken here [15:16] cachio_: yes please, once its ready, I'm uploading right now [15:17] It actually does the merge, but doesn't update the PR or tests [15:18] mvo, I'll have lunch now in that case [15:18] cachio_: sure [15:18] cachio_: enjoy! [15:18] mvo, and I'll create the images with the deb ubuntu-image then :) [15:19] cachio_: \o/ [15:21] Meh. "We continue to investigate a queue backlog. You may experience that commits take longer than usual to appear in pull requests." [15:26] PR snapcraft#1624 opened: kernel plugin: use latest stable core snap [15:27] kyrofa, kalikiana: I don't know, just an idea that I would have to try. Maybe putting /var/snap/lxd in the cache, or something like that. [15:28] elopio, wait... I thought the cache required s3? [15:28] Maybe I'm mixing wires with other conversations we've had [15:30] kyrofa: you are talking about sharing files between stages. For that, they recommend not to use the cache, and use something external. [15:30] elopio, oh interesting. Wouldn't that be what we're doing if we cache lxd, though? [15:31] we want to share the snap between stages, it might be worth asking why they are recommending that. [15:31] yes. They also recommend not to cache images :) [15:31] but if there is no good reason, we can just ignore the recommendation. [15:33] Huh [15:41] ppisati, sergiusens ... what is this ? https://github.com/snapcore/snapcraft/blob/master/snapcraft/plugins/kernel.py#L456 ... why was the kernel plugin not switched to download core ? [15:41] (ubuntu-core has not been built since severeal months, all initrd scripts in there are definitely massively outdated) [15:42] cachio_: new beta core ready for testing, this is a cve fix, so feel free to bump to candidate as soon as we get ok from CE and we should also push to stable as QA allows [15:44] ppisati, sergiusens FTR: https://github.com/snapcore/snapcraft/pull/1624 [15:44] PR snapcraft#1624: kernel plugin: use latest stable core snap [15:52] mvo: cert tests are under way, we'll keep an eye out and let you know as soon as they're ready [15:55] cwayne: \o/ [15:55] cwayne: thank you, this is very important so I appreciate it [16:12] ogra_: i don't know, maybe when the rename 's/ubuntu-core/core/' was done they forget to check every plugin? [16:12] heh, well, kernel is the only plugin that downloads core ... [16:12] i dont get how we didnt notice this though [16:13] doesnt it print "downloading ubuntu-core" somewhere when it does that ? [16:14] uhm [16:16] it snt *that* bad given that all official kernel snaps re-pack the deb anyway ... but people building their own kernels miss the last fixes in the initrd scripts [16:32] elopio: Do you know if I can mock.patch for an entire module? I'm trying to patch check_open which is used in different files - and I don't want to have several mocks for all of them [16:39] kalikiana: yes, just use the path to the module they are all importing [16:39] elopio: That's what I tried... it's telling me the functions don't exist [16:49] elopio: This is how I'm specifying it `snapcraft.internal.lxd.sleep` [16:49] lxd is the folder containing __init__.py [16:52] kalikiana: are you importing snapcraft.internal.lxd in the test file? [16:52] elopio: No [16:54] elopio: even with that, I'm getting `AttributeError: does not have the attribute 'check_call'` [16:55] It seems to be looking in __init__.py, not inside the module where it's being used [16:57] elopio: I'm guessing I'd have to import those functions in __init__.py then, rather than the individual files [17:10] cwayne, are you already testing 2.28.5 with the wpa fix? [17:10] elopio: Well, doesn't seem like I can. I can't use functions from __init__.py in the other files [17:11] cachio_: if that's the core in beta currently, yes [17:12] cwayne, perfect [17:12] please tell me once it is ready [17:12] cachio_: thats rev 3242 right? [17:14] cwayne, 3247 [17:14] kalikiana: I'm confused, because you are talking about sleep, check_call and check_open. Not sure which one you are trying to mock. If it's sleep, just import time and mock.patch('time.sleep') [17:15] elopio: Yes. And right now all of these are imported individually [17:15] cachio_: ah, were there two pushes to beta today? [17:15] cwayne, yes [17:15] ok, it's ongoing [17:15] cwayne, the last is the valid one [17:20] cachio_: ack, some systems were still running on 3241, we'll cancel and start up 3247 on those now [17:22] snappy-m-o, autopkgtest 1603 artful:amd64 xenial:arm64 xenial:armhf zesty:arm64 [17:23] kyrofa: I've just triggered your test. [17:23] You're the best [17:23] cwayne, great, thanks [17:24] PR snapcraft#1625 opened: tests: use the snapcraft snap for integration tests === JoshStrobl is now known as JoshStrobl|AFK [17:31] uhm, https://travis-ci.org/snapcore/snapcraft/jobs/289097568 has a weird error [17:32] elopio: Alright, will see how far I get by not importing these by name. Already hit `open` not working. So that one I have to mock for the individual file, otherwise it silently fails [17:32] kyrofa, ^ beside that one, other tests on my PR are green [17:40] ackk, unfortunately, the other tests didn't even run due to that failure :P . I've poked it [17:40] kyrofa, thanks [18:07] nessita, i'm getting a 401 error trying to download a snap from the edge channel [18:07] - Download snap "gnome-taquin" (8) from channel "edge" (received an unexpected http response code (401) when trying to download https://api.snapcraft.io/api/v1/snaps/download/pyEMtK4uVBGIvCV2B1NHC1sb3c2bL7x6_8.snap) [18:07] nessita, is that something you can help with? [18:08] we saw this before with the same package, i released it to stable and it worked [18:08] but now there's a new revision in edge and seeing the same thing again [18:08] popey, ^^ it happened again, same package [18:23] * sergiusens is always annoyed by our unittests requiring hg, svn and bzr [18:33] PR snapcraft#1626 opened: lifecycle: split into its own package [18:38] kenvandine, checking [18:39] kenvandine, what arch? [18:39] amd64 [18:40] kenvandine, are you logged in? (is not a requirement but if you are is a different debug path) [18:40] nessita, yes and no :) [18:40] in other words, what command were you executing? [18:40] i've tried it both ways [18:40] sudo snap install --edge gnome-taquin [18:41] a wget of the url fails too [18:41] popey had tried that last time it happened [18:41] kenvandine, let me involve more relevant people then [18:41] cool [18:41] * kenvandine wasn't sure who to bug [18:41] cprov, hi hi [18:41] cprov, so "sudo snap install --edge gnome-taquin" is failing with - Download snap "gnome-taquin" (8) from channel "edge" (received an unexpected http response code (401) when trying to download https://api.snapcraft.io/api/v1/snaps/download/pyEMtK4uVBGIvCV2B1NHC1sb3c2bL7x6_8.snap) [18:42] last time i released it to another channel and it was fine in the other channel [18:42] cprov, I've checked and the snap is public and released to edge for revision 8 [18:42] now that i rebuilt the snap in edge it happens again [18:42] works for me [18:42] i am logged into the store tho [18:42] popey, what snapd are you running? [18:42] oh right... you are special though :) [18:42] that's right [18:42] 2.28.5 [18:42] oh, also, I am special [18:43] doesn't work for my login and not logged in [18:43] popey, remember we debugged this before ;) [18:43] popey, so you are on beta for snapd? [18:43] nessita, we ruled out snapd versions last time [18:43] it was his login [18:43] if popey logs out it fails for him too [18:43] popey, you are a reviewer, so that may be giving you special access [18:43] right [18:44] i am tracking beta for core, yes [18:44] because reasons [18:45] confirmed I get 401 from another (not logged in, snap 2.28.1) machine [18:45] PR snapd#3954 closed: snap: introduce structured epochs [18:46] nessita: yup, 401 comes from SCA, I will look in a bit [18:47] cprov, thx [18:49] cprov, if I login it works, and I'm guessing that's because I'm a reviewer, but I thought we killed all privileges for reviewers when downloading outside dashboard === JoshStrobl|AFK is now known as JoshStrobl [18:51] nessita: right, works when I am logged in [18:53] i can download the snap via the browser [18:57] kenvandine, what do you mean? [18:57] kenvandine, from the dashboard site while logged in as you? [18:57] PR snapcraft#1627 opened: lxd: split container classes into different files [18:57] what's the link you used in the browser? [18:58] dashboard logged in [18:59] cprov, so the above indicates that only publishers and reviewers are being able to download, not other users [19:01] oh, actually i can install it when logged in [19:01] but i can't when not logged in [19:02] nessita, isn't that by design? [19:02] i can install from the stable channel when not logged in [19:02] but only for this snap [19:04] weird... scratch that... i can't install from stable either when not logged in [19:04] * kenvandine could have sworn i could [19:05] kenvandine, but the issue was with edge, no? [19:05] was... but it exists with stable too it seems [19:05] when not logged in [19:05] nessita, i noticed there is a distribution blacklist [19:05] that lists like all the countries [19:06] * kenvandine hasn't seen that before [19:06] gah did I miss checking for country restrictins? [19:06] elopio: I was successful with not importing by name in the end :-D You'll see the result in my new PR [19:07] nah, it says no restrictions [19:07] Now time to wrap up for today [19:07] nessita, if i edit that it gives me a huge list of course [19:07] to select form [19:07] from [19:07] kenvandine, I don't see any restrictions set [19:07] kenvandine, as in the whitelist and blacklist are not defined, so that means all countries can access [19:07] package is public too [19:07] yeah [19:11] nessita: snapident & revs data match what I see in dashboard (public, not country_black/white lists and released at least once) [19:18] cprov, so revision 8 is shown as published in the channel map? [19:20] nessita: yes, released | 2017-10-17 17:28:31.979241 [19:24] Issue snapcraft#1628 opened: record lxc image used [19:46] What the heck is wrong with Travis. We're getting all sorts of errors that we didn't get before [19:46] BlockingIOErrors, address space conflicts [19:49] kalikiana, elopio we're getting container-related autopkgtest failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful-snappy-dev-snapcraft-daily/artful/amd64/s/snapcraft/20171017_173440_d185c@/log.gz [19:49] It looks valid, the raw.idmap assertion looks wrong [19:49] At least, it's obviously different than what we expect [19:51] both 1000 0/both 1234 0 Hum, this seems related to the change kalikiana did for running with sudo [19:51] PR snapcraft#1622 closed: schema: sync patterns with snapd [19:51] elopio how about retriggering adt for snapcraft#1602 ? [19:51] PR snapcraft#1602: tests: add the slow tag for ros snapd integration test [19:52] elopio and what I mean about error prone is that in setUp I change the value we can easily confuse the whole thing. The text should say something like "add it as a class attribute" [19:54] sergiusens, that's the one I'm whining about now. Doesn't look like a retrigger will succeed [19:54] Actually I'm whining about its prereq [19:55] kyrofa which one is the prereq? [19:55] elopio, note that xenial amd64 passed, and is the only amd64 I ran [19:55] sergiusens, snapcraft#1603 [19:55] PR snapcraft#1603: tests: add /snap/bin to PATH in autopkgtests [19:56] kyrofa the github side of it worked fine [19:56] kyrofa the adts of it all failed though [19:56] sergiusens: I updated the wording. Please let me know if it's better now. [19:56] sergiusens, indeed [19:58] elopio, oh wait... what. Maybe I lied. github is still weird right now, the amd64 run disappeared [19:58] Oh, no, it failed as well [19:58] I think that was an artifact from the previous run. This is really bad today [19:58] well, it's clear there's an issue in that test. It mocks getuid, and returns the wrong value. [19:59] elopio, and it looks like it fails everywhere [19:59] Obvious fix? Or would you like me to investigate? [19:59] I think we should focus on getting autopkgtests to pass until they do :P [20:01] kyrofa: obvious fix is to also patch SUDO_UID [20:06] elopio, wait... these are unit failures. Why aren't they failing on travis? [20:06] (or locally) [20:06] Because they run as root in autopkgtest? [20:08] because we don't run with SUDO maybe? [20:08] I don't like this test :/ [20:09] Ah, indeed, SUDO_UID I see what you're saying now [20:09] cachio_: looks good so far, waiting on a few more devices [20:10] cwayne, great, here also looks promising [20:10] just known issues [20:20] sergiusens, pre/post stanzas: are you thinking we'll have those around stage/prime as well? [20:21] PR snapcraft#1629 opened: lxd: fix the unit test for the ser id map [20:21] what do you kyrofa? snapcraft#1629 [20:21] PR snapcraft#1629: lxd: fix the unit test for the ser id map [20:22] elopio, I'd prefer to see it testing that SUDO_UID actually takes precedence [20:22] elopio, i.e. make them different values [20:23] And have an "expected" in the scenario [20:23] Thoughts? [20:25] sergiusens, also, do you intend them to include a third stanza that replaces the plugin's? e.g. pre-pull, pull, and post-pull? [20:27] kyrofa: please refresh the diff and see if you like it better. [20:28] elopio, much better, but I'd also like to see a third case where they're both set and SUDO_UID is used instead of getuid [20:29] Thoughts? [20:29] I feel like that precedence is probably important behavior to preserve [20:33] you are right. [20:34] I don't like this test, so I was trying to not touch it a lot. But well, that's a small change. [20:34] Hahaha [20:34] Go wash your hands after [20:36] hum, no kyrofa, this third test would be a duplicate. On the first one, the env var is set, and os.getuid is not called. [20:37] elopio, are we testing for that? Or could the test also pass if it tried to call os.getuid first, got None, and fell back to SUDO_UID? [20:37] on the second one, the env var is not set, and os.getuid is called. This third test is the same as the first one. I just set the os.getuid return value as None, to make it clearer. But apparently, it's not :p [20:38] I suppose getting None from getuid would be odd [20:38] elopio, works for me [20:39] well, I can replace getuid None for a value. [20:39] elopio, doesn't matter too much. I agree with you [21:08] snappy-m-o autopkgtest 1629 xenial:amd64 [21:08] elopio: I've just triggered your test. [22:13] cachio_: so the only change in this core is the krack fix right? [22:14] cwayne, there are few changes compared with 28.4 [22:14] but the diff with the previous 28.5 is just the fix [22:21] cachio_: shouldn't we have done just 2.28.1+krack fix since that's what's in stable today? [22:22] cwayne, that was the original idea, but it was also needed to add some other important fixes that are included in the 2.28.5 such as the fix for machines with nvidia drivers [22:22] cwayne, so it was decided to go with the 2.28.5 [22:23] cwayne, so far everything working properly on my side [22:23] cwayne, how is it going in your side? [22:24] cachio_: either way, it looks like we're having some issues with the last device (unrelated to core), so I think in interest of speediness, we can push 3247 to candidate [22:24] everything looks pretty normal here, just waiting on that last device (been having problems with the hw lately) [22:25] cwayne, ok, which device is it? [23:09] snappy-m-o autopkgtest 1629 xenial:amd64 [23:09] elopio: I've just triggered your test. [23:37] how do you guys test that snap updates work correctly? [23:38] i have a bug where the snap being updated breaks things :/ [23:38] oh revert i guess [23:44] mwhudson, it depends on the snap. I use capistrano for Nextcloud [23:45] *sigh* I mean capybara. Man what is the deal today [23:46] mwhudson, and manual testing-- install the stable version, then test refreshing to candidate [23:49] whoa snap revert blew up in an exciting way [23:50] i think that's probably the overlayfs fun and games [23:58] mwhudson, overlayfs? Do I wanna know? [23:59] kyrofa: the snap i'm working on is subiquity, the server installer [23:59] it runs out of a livecd environment so everything is strange :)