| powersj | larsks: Could you comment on: https://bugs.launchpad.net/cloud-init/+bug/1724414 | 02:18 |
|---|---|---|
| ubot5 | Ubuntu bug 1724414 in cloud-init "rhel distro selects FQDN as hostname" [Undecided,New] | 02:18 |
| === shardy is now known as shardy_afk | ||
| === shardy_afk is now known as shardy | ||
| larsks | powersj: I don't have a strong preference re: that issue; just make sure that whatever hostname we pick we are consistent. The current situation is the result of fixing an issue in which cloud-init would select the unqualified hostname initially but the fqdn would be used after a reboot (or something like that), which was causing ugly issues with stuff that used the hostname as an identifier. | 13:12 |
| larsks | I guess I'll add that to the issue. | 13:12 |
| smoser | blackboxsw: updated to take your patch on az-ubuntu. thanks. | 14:12 |
| smoser | the 'azure-ubuntu' that i had was more helpful, it "knew" of regions and sizes and things. i'd like to add that back at some point, but for this at least knows about the '--image=Canonical:UbuntuServer:17.04-DAILY:latest' magic. | 14:13 |
| blackboxsw | Network dead | 15:09 |
| rharper | sent over the network | 15:24 |
| blackboxsw | Heh cellular :) | 15:39 |
| smoser | powersj: https://github.com/canonical-server/jenkins-jobs/pull/13 | 15:56 |
| powersj | smoser: thanks | 15:58 |
| smoser | blackboxsw: bug 1724634 | 17:27 |
| ubot5 | bug 1724634 in cloud-init (Ubuntu) "groups added with a user list must have all users present." [Undecided,New] https://launchpad.net/bugs/1724634 | 17:27 |
| smoser | (just fyi) | 17:27 |
| blackboxsw | checking | 17:53 |
| blackboxsw | smoser: nice apport bug btw :) | 17:54 |
| smoser | blackboxsw: yeah. other than i coudlnt type 11 | 17:56 |
| smoser | (bug 1722564) | 17:56 |
| ubot5 | bug 1722564 in apport (Ubuntu) "apport question will not accept multi-character responses" [Medium,Triaged] https://launchpad.net/bugs/1722564 | 17:56 |
| smoser | blackboxsw: we get double '.txt' | 17:57 |
| smoser | (see attached files... user_data.txt.txt and cloud-init-output.log.txt.txt) | 17:57 |
| blackboxsw | I think I'll attach that patch to apport I suggestd to your bug there so there's something to chew on there | 17:57 |
| blackboxsw | ohh yeah, right, cloud-init apport bug there then. | 17:58 |
| smoser | blackboxsw yeah... of course you need to do that. i had thought you had. | 17:58 |
| smoser | gaughen is the maintainer of apport. lets bother her. | 17:59 |
| smoser | (per https://launchpad.net/apport) | 17:59 |
| gaughen | specifically me? | 17:59 |
| gaughen | oh geez | 18:00 |
| smoser | :) | 18:00 |
| blackboxsw | <with devious mousish voice> ... excellent Pinky.... let's take over the Foundations team :) | 18:01 |
| gaughen | I thought smoser you were making some broad stroke statement of the foundations team | 18:01 |
| smoser | gaughen: well, that definiteliy would be possible. but no, you are specifically the maintainer. | 18:02 |
| gaughen | I see that | 18:02 |
| gaughen | thus my "oh geez" | 18:02 |
| smoser | yeah, i wonder what other projects you maintain | 18:02 |
| * gaughen checks to make sure cloud-init isn't on her list | 18:04 | |
| * smoser should have thought of doing that | 18:05 | |
| gaughen | so now I have to look and see why you all are talking about apport... I see bug 1722564 | 18:08 |
| ubot5 | bug 1722564 in apport (Ubuntu) "apport question will not accept multi-character responses" [Medium,Triaged] https://launchpad.net/bugs/1722564 | 18:08 |
| smoser | powersj: i think that moving examples around broke/changed the default tests that are run in cloud_tests. | 18:21 |
| powersj | smoser: how so | 18:23 |
| smoser | ok. i guess not. its not running 'examples/' tests though | 18:24 |
| powersj | let me see if they are enabled | 18:24 |
| smoser | which the c-i runs | 18:24 |
| smoser | so i ran something locally, it passed, i pushed a MP, it failed on c-i | 18:24 |
| powersj | all tests in examples are "enabled: False" in the yaml | 18:25 |
| powersj | ci runs the following command: sh 'python3 -m tests.cloud_tests run --verbose --os-name xenial --test modules/apt_configure_sources_list.yaml --test modules/ntp_servers --test modules/set_password_list --test modules/user_groups --deb cloud-init_*_all.deb' | 18:26 |
| powersj | from: https://github.com/canonical-server/jenkins-jobs/blob/master/cloud-init/jobs-ci.yaml | 18:26 |
| smoser | powersj: powersj i'm missing something | 18:29 |
| smoser | https://jenkins.ubuntu.com/server/job/cloud-init-ci/405/console | 18:29 |
| smoser | test_no_warnings_in_log failed (line 3497) | 18:29 |
| smoser | the test test_user_barfoo ran | 18:29 |
| smoser | which is from tests/cloud_tests/testcases/examples/including_user_groups.py | 18:30 |
| powersj | which also happens to be in ./tests/cloud_tests/testcases/modules/user_groups.py | 18:31 |
| powersj | grep -ir "test_user_barfoo" . | 18:31 |
| powersj | ./tests/cloud_tests/testcases/examples/including_user_groups.py: def test_user_barfoo(self): | 18:31 |
| powersj | ./tests/cloud_tests/testcases/modules/user_groups.py: def test_user_barfoo(self): | 18:31 |
| powersj | python3 -m tests.cloud_tests run --verbose --os-name xenial --test modules/apt_configure_sources_list.yaml --test modules/ntp_servers --test modules/set_password_list --test modules/user_groups --deb cloud-init_17.1-21-gbc70e157-1~bddeb_all.deb | 18:31 |
| powersj | is the command it ran | 18:31 |
| powersj | and there is the modules/user_groups test | 18:31 |
| smoser | huh. indeed it does | 18:31 |
| smoser | :) | 18:31 |
| powersj | :) | 18:31 |
| powersj | while I like the bugs dir and our attempt to organize things | 18:32 |
| powersj | I'm not a huge fan of the examples dir | 18:32 |
| powersj | especially if everything is disabled | 18:32 |
| powersj | seems pointless | 18:32 |
| powersj | and you know... causes uncessary confusion :) | 18:32 |
| smoser | *and* its 100% duplicate | 18:32 |
| powersj | yeah | 18:32 |
| smoser | at least | 18:33 |
| smoser | tests/cloud_tests/testcases/examples/including_user_groups.py | 18:33 |
| smoser | == | 18:33 |
| smoser | tests/cloud_tests/testcases/modules/user_groups.py | 18:33 |
| * powersj would be happy to see examples get blown away | 18:33 | |
| smoser | :-( | 18:33 |
| smoser | yeah | 18:34 |
| blackboxsw | yeah, I thought the same about duplication. There is merit in making sure that the syntax/intent of our examples is testable. But, I don't think verbatim that example copies into integration tests will really *work* for us. | 18:37 |
| blackboxsw | too many external services etc that need to be faked | 18:37 |
| * blackboxsw is cut-n-pasting verification results into each SRU 17.1 sub-bug now. | 18:48 | |
| smoser | blackboxsw: i assumed you were going to be launchpad-libbing that | 18:48 |
| smoser | blackboxsw: you able to hang out for a minute ? | 18:49 |
| blackboxsw | good point, will do that. do we want it as a comment of bug description smoser | 18:49 |
| blackboxsw | yeah definitely | 18:49 |
| blackboxsw | hanging out | 18:49 |
| blackboxsw | cloud-init channel | 18:49 |
| smoser | blackboxsw: almost there. | 18:54 |
| blackboxsw | no rush. just tweaking your lp-bugs-released script | 18:57 |
| smoser | blackboxsw: https://bugs.launchpad.net/ubuntu/+source/curtin/+bug/1721808 | 19:20 |
| ubot5 | Ubuntu bug 1721808 in curtin (Ubuntu Zesty) "sru curtin 2017-10-06 - 0.1.0~bzr532-0ubuntu1" [High,Fix committed] | 19:20 |
| blackboxsw | smoser: ci passed https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/332383 | 20:00 |
| blackboxsw | shall I land it in master or are you? | 20:01 |
| smoser | blackboxsw: i can land | 20:04 |
| blackboxsw | gr8 | 20:04 |
| smoser | blackboxsw: merged. | 20:11 |
| smoser | 41152f10ddbd8681cdac44b408038a4f23ab02df | 20:11 |
| blackboxsw | ok see it. starting the cherry pick | 20:15 |
| blackboxsw | smoser: wanted to double check. so I'm upstream-snapshotting into ubuntu/devel right? | 20:16 |
| blackboxsw | then cherry pick into xenial zesty | 20:16 |
| blackboxsw | or cherry pick all ubuntu/devel, ubuntu/xenial and ubuntu/zesty | 20:17 |
| smoser | blackboxsw: just ignore artful (ubuntu/devel) for now | 20:18 |
| smoser | and cherry-pick to ubuntu/xenial and ubuntu/zesty | 20:19 |
| blackboxsw | ok won't touch it | 20:19 |
| smoser | have MP ready, and i'll review later. i have to run now. | 20:19 |
| blackboxsw | see ya | 20:19 |
| smoser | if you care... here is what i started writing | 20:19 |
| smoser | http://paste.ubuntu.com/25768023/ | 20:19 |
| smoser | for SRU template on that bug | 20:19 |
| blackboxsw | ok, debugging cherry-pick not working in my env | 20:35 |
| blackboxsw | http://pastebin.ubuntu.com/25768117/ | 20:35 |
| blackboxsw | strange thing is if I take the diff from within the cpick file, patch applies cleanly | 20:41 |
| blackboxsw | ... I'm not seeing the diff content for cloudinit/config/cc_users_groups.py and other files in the cherry picked patch diff. just a couple of the unit test files listed in the cpick file. | 20:43 |
| blackboxsw | n/m I see the full diff/patch. looks good relative to changes that went into master... although cherry-pick is claiming it didn't apply cleanly | 20:46 |
| blackboxsw | checking quilt output | 20:46 |
| blackboxsw | today bbsw learns about quilt | 21:02 |
| blackboxsw | QUILT_PATCHES=debian/patches quilt push cpick-41152f1-schema-Log-debug-instead-of-warning-when-jsonschema-is | 21:02 |
| blackboxsw | I needed to override QUILT_PATCHES defaults so it can actually find the series file in debian/patches/series so that I can run smoser's cherry-pick script | 21:03 |
| blackboxsw | ahh much better | 21:04 |
| blackboxsw | ok | 21:04 |
| blackboxsw | zesty is up for review https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/332446 | 21:09 |
| blackboxsw | xenial is up for review https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/332447 | 21:16 |
| powersj | blackboxsw: I added a few things to the SRU checklist | 21:16 |
| powersj | namely collecting results for other tests, per our SRU exception | 21:17 |
| blackboxsw | powersj: URL? is it the cloudinit SRU exception page | 21:17 |
| powersj | https://wiki.ubuntu.com/CloudinitUpdates | 21:17 |
| blackboxsw | I'll reread now since I'm in the thick https://wiki.ubuntu.com/CloudinitUpdates? | 21:17 |
| blackboxsw | yeah | 21:17 |
| powersj | thx | 21:18 |
| * blackboxsw reads the page thanks | 21:18 | |
| blackboxsw | ok pulling together suggestions now for that page. | 21:19 |
| blackboxsw | since I'm through my 2nd round of SRU uploads on this SRU. | 21:19 |
| blackboxsw | hrm not sure if I have edit rights, I can't seem to login to the wiki.ubuntu | 21:22 |
| powersj | blackboxsw: best not to make edits, but propose them first somehow | 21:23 |
| powersj | if it is more than minor, we have to get things approved | 21:23 |
| blackboxsw | sounds good pooling suggested edits now. | 21:24 |
| blackboxsw | powersj: this is all I have http://pastebin.ubuntu.com/25768388/ | 21:34 |
| blackboxsw | your changes look good | 21:34 |
| powersj | blackboxsw: that is 100% fine :) I wasn't sure if you were going to change the process or make changes such that we would need to ask for re-approval | 21:35 |
| blackboxsw | nah, nothing big, just that we've added attachements to the SRU process bug with logs instead of dumping all those manual results inline in the SRU template as it is unreadable with all that content | 21:36 |
| blackboxsw | we will also likely add bug tasks for xenial/zesty on each SRU non-process bug. to allow marking that bug as fix-released in the specific series once it's published (post SRU) | 21:37 |
| blackboxsw | not sure if that would need documenting on cloudinitupdates wiki page, but it'll be part of our process going forward | 21:37 |
| blackboxsw | to really document when a bug is released to a stable series | 21:37 |
| powersj | blackboxsw: ok, thanks :) as far as bug tasks for that page, we are concerned with the one big that tracks the SRU | 21:39 |
| blackboxsw | yeah figured | 21:41 |
| blackboxsw | thx | 21:41 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!