[01:33] babbageclunk: were you looking at the sig file stuff for beta2 release? [01:33] yup, just finished it off - I'll put the PR up while I'm doing a manual test. [01:33] yay, ty [01:59] wallyworld: small fix for offer removal: https://github.com/juju/juju/pull/7976 [01:59] ty, looking [02:00] wallyworld: https://github.com/juju/juju/pull/7977 as well [02:08] babbageclunk: ty, looking after my 1:1 with andrew [02:08] cool cool [02:24] * babbageclunk goes for a run [02:26] babbageclunk: just a small test change [03:28] wallyworld: thanks, fixed - merging now. [04:05] babbageclunk: no worries [04:30] thumper: wallyworld: axw: modelstatus fix - https://github.com/juju/juju/pull/7979... since it's kind of not-small and highly visible/usable, I think I'd need at least 2 reviews... [04:49] anastasiamac: looking after lunch [04:50] axw: tyvm [04:56] anastasiamac: +631/-179 is but a babe in the woods compared to some lately :-) [04:57] wallyworld: m glad to hear that my PR does not scare u... m not sure how i feel about the fact that big PRs r becoming more frequent [04:57] :-) [05:04] anastasiamac: revewed [05:04] jam: \o/ thnx [05:04] morning [05:05] doesn't seem like a PR that needs 2 reviews [05:06] jam: k, m happy(ier) to have just one review (ur definition of weekend is very different to mine) [05:08] anastasiamac: what, I woke up, like an hour later, went to the grocery store, will be going out for lunch [05:08] how is that not a weekend? [05:08] jam: bestversion check on cmd is needed for cases where u r using new client against an older controller (if it ever happens) as we'd come to result.Error and will panic/err since Error would not exist in returned results... [05:09] anastasiamac: no, because your api/* code forces a result.Error => result[i].Error, doesn't it? [05:09] so you've already made sure that every object has a .Error set [05:16] jam: i'd like to discuss your +1 to the pr - i don't agree with the approach [05:17] i can't see a reason to not have the api layer present the same interface for either a v3 or v4 backend [05:17] we control the call sites for the api layer so we can make everything hang othether as it should [05:19] anastasiamac: jam: axw: happy to discuss in a hangout to ensure we're all on the same page, maybe easier than irc [05:20] wallyworld: +1, gimme 10mins? [05:20] sure [05:21] wallyworld: I thought she did have the api/ layer push the global error into the each object Error [05:21] did I misread that? [05:21] maybe i did, left me check [05:22] jam: see line 84 in processModelStatusResultsV3 [05:22] line 61 of processModelStatusResults [05:22] the part where we were talking about Trace [05:23] that's for the v4 facade [05:23] not the old v3 [05:25] wallyworld: ah k. in that case, update v3 to set the error, and I think we're happy [05:25] modulo that we don't need a separate processv3 method perhaps [05:26] since v3 will just return an overall error anyway [05:26] and if we do get results we just process them with the one method [05:28] and we need to check but i thought jimm calls this api also so we'll need to update that code as well, or organise for it to be updated [05:28] so I think we're roughly aligned, in that api/* should provide a consistent view of errors, and then all the client code doesn't need BestVersion. [05:28] wallyworld: as a Controller facade, it should have some sort of implementation for it [05:28] right, so we'll break them if they compile against tip [05:28] wallyworld: though if they did it correctly, we just treat JIMM as an older controller [05:28] wallyworld: jam: axw: want to take it to team standup from this morning? [05:28] or in any case, we'll need to get them to update [05:29] sure, ok [05:29] https://hangouts.google.com/hangouts/_/canonical.com/juju-standup?authuser=1 ? [05:29] jam: yes [05:29] wallyworld: ? === frankban|afk is now known as frankban === freyes__ is now known as freyes === Guest26189 is now known as Makyo === frankban is now known as frankban|afk [16:55] What happened to the --upload-tools flag on the juju bootstrap command? What's the right way to replicate that functionality today? [23:20] Not sure if it's the right channel, but can Juju be used to deploy P3 instances on AWS that was announced a couple of days back?