=== shardy is now known as shardy_lunch
=== shardy_lunch is now known as shardy
[14:44] <smoser> blackboxsw: rharper and i both picked on your non-usage of net.find_fallback_nic in the 'if' portion of
[14:44] <smoser> https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/332954
[14:45] <smoser> other than that nit, i generally dont have any issues.
[14:46] <smoser> just seems silly to call maybe_perform_dhcp_discovery() with no interface, only to let it select the interface and then read it.
[14:46] <smoser> as opposed to just caling net.find_fallback_nic and passing that to maybe_perform...
[15:11] <powersj> smoser: blackboxsw: here's the nocloud-kvm fix with smoser's fix: https://code.launchpad.net/~powersj/cloud-init/+git/cloud-init/+merge/331736
[15:20] <smoser> powersj: you have to stop thinking i can write code
[15:20] <smoser> nothing increments _tmp_count there.
[15:20] <blackboxsw> powersj: added a couple hilights & DOC comments to the done lane for cloud-init
[15:21] <smoser> better tmpfile function:
[15:21] <powersj> smoser: haha
[15:21] <smoser>     def tmpfile(self):
[15:21] <smoser>         path = "/tmp/%s-%04d" % (type(self).__name__, self._tmp_count)
[15:21] <powersj> blackboxsw: thx
[15:21] <smoser>         self._tmp_count += 1
[15:21] <smoser>         return path
[15:33] <blackboxsw> thanks smoser rharper for the review comments. I just pushed the fix for https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/332954
[15:42] <smoser> powersj: i'm torn now... i think you can probably largely drop a bunch of your delta on that mp
[15:42] <powersj> smoser: yeah... I need to go back and review again
[15:43] <smoser> if you want to focus on other things, i can attempt a minimal fix.
[15:44] <powersj> I don't think it would take too long, I can back out the changes and re-run things, but my focus would be more on minimizing the delta and not on re-implementing things
[15:46] <smoser> powersj: right.
[15:46] <smoser> thats fine.
[16:06] <powersj> smoser: looking through the delta, I actually think most of it will stay. The majority is $home or /tmp --> /var/tmp and then some user related changes
[16:07] <powersj> I do add the "default" user back in to a few places
[16:13] <smoser> powersj: well, yeah, but you dont need the /root to /var/tmp/ changes
[16:13] <smoser> definitely dont want /tmp thought
[16:13] <powersj> hmm
[16:13] <powersj> agreed with no /tmp, understand that now
[16:14] <powersj>  /var/tmp/ seems like a more generic location anyway over using /root, but if we are expecting to do everything as root anyway I guess it doesn't matter?
=== shardy is now known as shardy_afk
[17:32] <smoser> blackboxsw: aroudn ?
[17:32] <blackboxsw> smoser: yep
[17:32] <smoser> you want to merge your thing ? then you can do 4 SRU merge requests if you want.
[17:33] <blackboxsw> ok will do
[17:33] <smoser> b, a, z, x :)
[17:35] <blackboxsw> smoser: strange I was waiting on ci
[17:35] <blackboxsw> which I don't think ran after my brancch
[17:39] <powersj> blackboxsw: master is off, if you enable it, it should go
[17:39] <powersj> I'm at Dr so can't logon easily
[17:41] <blackboxsw>  no worries powersj happy dentist ;)
[17:51] <blackboxsw> ok master is back up and jobs running again
[17:51] <blackboxsw> sorry I should have looked sooner
[17:51] <blackboxsw> I kicked a rebuild, we should have results in 15 mins
[18:43] <blackboxsw> smoser: merged eb292c1
[18:43] <blackboxsw> starting to cut branches
[18:43] <smoser> blackboxsw: thanks.
[18:53] <blackboxsw> smoser: devel MR is up for review https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/333047
[19:00] <blackboxsw> https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/333048
[19:06] <blackboxsw> just rebased artful as I forgot 17.10.1
[19:13] <blackboxsw> https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/333050
[19:14] <blackboxsw> https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/333051
[19:14] <blackboxsw> ok that's it , devel + b,a,z,x
[19:18]  * blackboxsw spins up one more ec2 instance on this to be sure
[20:15] <smoser> blackboxsw: you left the gentoo bug number in the changelog
[20:15] <smoser> was that by design ?
[20:15] <smoser> just uploaded bionic
[20:19] <blackboxsw> smoser: I had left them in there as I wasn't sure whether we were going to separate SRU template on the bugs. Ahh gentoo right, didn't need to as it didn't affect ubuntu
[20:20] <blackboxsw> want to quick hangout to see if I should repush?
[20:20] <smoser> blackboxsw: i'm fine to do it myself
[20:20] <smoser> http://paste.ubuntu.com/25860935/
[20:20] <smoser> opposed ?
[20:21] <smoser> (i grabbed his name from launchpad)
[20:21] <smoser> rather htan the name in the commit message
[20:22] <blackboxsw> +1  yes good
[20:36] <blackboxsw> thanks smoser, just saw the "    update changelog to remove Gentoo bug number and add name" revs
[20:37] <smoser> i didnt' catch it on bionic
[20:37] <smoser> oh well
[20:37] <smoser> i was kind of surprised, but cherry-pick worked
[20:37] <smoser> git cherry-pick <ubuntu-xenial hash that i did manually>
[20:38] <smoser> i thoguht it'd complain about the context (given that the version and changelog stuff around it differs)
[20:38] <smoser> but worked.
[20:50] <blackboxsw> nice. Just validated master again on EC2 stock network. Going to try to spin up an instance with local-only ipv4
[20:59] <smoser> blackboxsw: your thoughts would be appreciated on
[20:59] <smoser> https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/332958
[20:59] <smoser> and
[20:59] <smoser> https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/333059
[21:05] <blackboxsw> looking
[21:06] <smoser> powersj and rharper ^ you too on those
[21:07] <rharper> k
[21:07] <blackboxsw> smoser: did this mean that AliYun wouldn't be matched? https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1728186
[21:07] <ubot5> Ubuntu bug 1728186 in cloud-init (Ubuntu) "AliYun datasource has wrong case in config" [Medium,Confirmed]
[21:07] <blackboxsw> and the datasource wouldn't be found/attempted
[21:07] <smoser> yeah. :-(
[21:07] <smoser> you get a warning in /run/ds-identify.log
[21:08] <blackboxsw> umm so why didn't we hear about it
[21:08] <blackboxsw> ahh
[21:08] <smoser> if you manually configure it
[21:08] <smoser> and spell it right it will work
[21:08] <blackboxsw> ahh that too. ok
[21:08] <smoser> but by default package instllation is busted.
[21:08] <blackboxsw> so images in AliYun could have manually config'd it
[21:08] <smoser> i suspect so.
[21:08] <smoser> we should add to ci
[21:08] <smoser> integration test
[21:09] <smoser> a check for WARN in the ds-identify logs too
[21:09] <smoser> like i did for /var/log/cloud-init.log
[21:09] <blackboxsw> approved https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/332958
[21:10] <blackboxsw> updated description for typo
[21:12] <smoser> merged. missed your spellingfix. sorry.
[21:13]  * smoser is hallowout
=== smoser is now known as ScarySmoser
=== ScarySmoser is now known as smoser
[21:20] <blackboxsw> smoser: don't worry I'll give you a hard time about it after I eat some candy
[23:04] <msaikia_> https://code.launchpad.net/~msaikia/cloud-init/+git/cloud-init/+merge/330105/+index?ss=1
[23:05] <msaikia_> Hi, can anyone please take a look at this review request?
[23:05] <blackboxsw> good deal msaikia_ thanks for retouching that.
[23:05] <blackboxsw> I'll look at it tomorrow
[23:09] <msaikia_> Thanks..:)