| === petevg is now known as petevg|afk | ||
| axw | wallyworld: can you please take a look at https://github.com/juju/juju/pull/8011 | 02:46 |
|---|---|---|
| axw | jam: when you're on, ^^ workaround to upgrade lease docs | 02:46 |
| === TikTok is now known as michealb | ||
| === axw_ is now known as axw | ||
| jam | wallyworld_: did we lose you ? | 04:37 |
| axw | jam: are you able to share your ubuntu-lite charm? looks to be private. I'd like to try to repro the FD leak thing | 05:31 |
| axw | coming up empty when lookiung through the code | 05:31 |
| jam | axw: so I've done charm push and charm release, do you know what the next thing is to make it more public? | 05:32 |
| axw | jam: I think you need to "charm grant", just not sure what args atm | 05:33 |
| jam | looks like just "charm grant CHARM everyone" | 05:34 |
| axw | yup | 05:34 |
| jam | axw: fwiw, you can do it just fine with just "juju deploy ubuntu" over and over again, but I should have granted read to everyone on the charms involved | 05:35 |
| axw | jam: ok. I can access now, thanks | 05:36 |
| axw | jam: so I foolishly tried to run the test on azure, forgetting about container networking. tried to force the issue with lxd, adding a "wrench" in the lease manager - no leak. so I guess it only shows up when there's a lot of agents. I'm not going to be able to repro today, and I'm off till Tuesday | 09:05 |
| axw | jam: however. I did find a rather big issue with the singular/leadership apiserver calls | 09:05 |
| jam | axw: k. it only happened before your patch to clean up leases | 09:05 |
| jam | axw: want me to investigate? | 09:06 |
| axw | jam: if you're able to, that would be great | 09:06 |
| jam | just doing a deploy with old and upgrade to sligtly older than current should be enough to trigger it | 09:06 |
| jam | actually, upgrading to beta2 final, right? | 09:06 |
| jam | axw: what's the apiserver calls issue? | 09:06 |
| axw | jam: yeah I think so | 09:06 |
| axw | jam: the issue I found: the SingularClaimer and LeadershipClaimer methods on State return the worker *at that time*, they don't automatically use the internally restarted one | 09:07 |
| axw | jam: and the API server facades bind that at connection time... | 09:07 |
| axw | jam: so if you don't disconnect the API, you'll keep getting the same broken claimer | 09:07 |
| jam | gotcha | 09:07 |
| jam | you have a patch for that, or want me to look at the same time? | 09:08 |
| axw | jam: I'm working on a patch, might only get as far as WIP though. I'll let you know later on | 09:08 |
| axw | jam: https://github.com/juju/juju/pull/8014, couldn't come up with a decent way to test it, the SetClock.. thing is a bit kludgey. I've gtg shortly, feel free to take and improve if you're not keen on that | 10:02 |
| jam | k, have a good weekend | 10:08 |
| jam | I had to do something similar for PingBatcher, I'll see how it compares | 10:09 |
| === petevg|afk is now known as petevg | ||
| babbageclunk | wallyworld: hey, do we support migrating models with cross-model relations now? | 22:17 |
| anastasiamac | wallyworld: babbageclunk: could u plz rubber-stamp 1-line change? https://github.com/juju/juju/pull/8016 | 22:27 |
| babbageclunk | anastasiamac: approved! | 22:28 |
| anastasiamac | babbageclunk: \o/ | 22:28 |
| babbageclunk | wallyworld: oh ignore me, I remember now - we support exporting them (for dump-model) but not importing. | 22:34 |
| wallyworld | babbageclunk: we don't support importing models with offers | 23:06 |
| babbageclunk | wallyworld: thanks - got confused/worried about whether we allowed migrations with CMR | 23:10 |
| wallyworld | babbageclunk: yeah, we don't support migrating models with offers (yet) because we have no way of updating consuming models that the offer location has changed | 23:11 |
| babbageclunk | makes sense | 23:11 |
| wallyworld | we need to solve that though, but had to draw the line somewhere | 23:11 |
| babbageclunk | wallyworld: Can you review this please? It's the relationscopes precheck: https://github.com/juju/juju/pull/8018 | 23:31 |
| wallyworld | sure | 23:31 |
| babbageclunk | ta | 23:32 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!