/srv/irclogs.ubuntu.com/2017/11/08/#snappy.txt

ikeycrazy question here00:41
ikeylets say i wanted to control the cpu governor from inside a snap...00:41
ikeyto switch between powersave/ondemand + performance...00:41
ikeywould this be something i could ever do?00:41
=== nsg_ is now known as nsg
=== AdmWiggin is now known as tianon
=== pbek_ is now known as pbek
mborzeckimorning everyone06:02
mupPR snapd#4164 closed: interfaces/raw-usb: match on SUBSYSTEM, not SUBSYSTEMS <Created by jdstrand> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4164>06:13
zyga-ubuntuo/06:16
zyga-ubuntumborzecki: you start early :)06:16
mborzeckizyga-ubuntu: hey, yeah i plan to keep a regular 7-15 schedule, otherwise my day goes to hell quickly06:17
mborzeckibesides, my wife drives kids to school at ~7 so I'm already up at ~5:45-606:17
mborzeckizyga-ubuntu: no rush about the review :) suppose you have things to do in the morning06:18
mupPR snapd#4151 closed: tests: fix security-device-cgroup* tests on devices with framebuffer <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4151>06:21
zyga-ubuntumborzecki: yeah, I feel broken-ish still06:24
zyga-ubuntumy yesterday was a disaster, I started my day in the late afternoon after meds helped, then stayed way too long (as usual)06:24
mvomborzecki: uh, still not feeling well? take it easy then06:24
mborzeckicaught a cold?06:24
zyga-ubuntuI need to adopt the morning / early afternoon cycle06:24
zyga-ubuntuboth that and still recovering from back pain (over a week now) :/06:25
zyga-ubuntumvo: I'll prep kids and I'll focus on udev branches for 2.29 / master06:25
zyga-ubuntumvo: I got a review from jamie on udev tagging on hooks and I need to tweak it to format the output differently (sorting)06:26
mvozyga-ubuntu: more to come? meh06:26
mvozyga-ubuntu: or the hooks one?06:26
zyga-ubuntuthe hooks one06:26
mvozyga-ubuntu: aha, ok. thank you!06:26
zyga-ubuntuit will conflict after some other bits land so I'll focus on that first06:26
mvopedronis: for later (not urgent at all) - 3992 needs some love, unit test failure currently06:26
zyga-ubuntuI guess today is final 2.29.3 attempt, right?06:26
mvozyga-ubuntu: well, I would like to do 2.29.2 and then 2.29.3 a week later, unless we have regression in 2.29 that were not in 2.28 already06:30
mvozyga-ubuntu: but depends a bit on QA feedback, we wanted to release today but that seems unlikely given that we need CE results06:31
zyga-ubuntumvo: I see, ok06:35
zyga-ubuntuI'll do my best to help as soon kids are sorted06:35
mupPR snapd#4121 closed: overlord/snapstate: toggle ignore-validation as needed as we do for channel <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4121>06:58
mupPR snapd#4125 closed: corecfg:  support setting proxy.store if there's a matching store assertion <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4125>06:59
mborzeckiis /var/lib/snapd/apparmor/snap-confine needed if snap-confine was configured with --disable-apparmor?07:06
zyga-ubuntumborzecki: no07:06
zyga-ubuntubut07:07
zyga-ubuntusnapd will do runtime detection and will create and may populate that directory anyway07:07
mborzeckioh, ok07:07
zyga-ubuntuI think in general it is better to enable apparmor07:07
zyga-ubuntueven if the kernel is not apparmor aware07:07
zyga-ubuntu(as long as there is userspace)07:07
mborzeckiyeah, arch is so manly that we don't use apparmor...07:08
zyga-ubuntumy point is that the configure time options are partial, they don't affect snapd07:08
zyga-ubuntuso I'd, if you can, enable apparmor to the extent possible07:08
mborzeckii'm getting close with arch packaging, at least the blender snap works just fine (though it's classinc, but it didn't work before anyway)07:10
elopiosnappy-m-o autopkgtest 1716 xenial:amd6407:10
snappy-m-oelopio: I've just triggered your test.07:10
elopiosnappy-m-o autopkgtest 1657 xenial:amd6407:11
snappy-m-oelopio: I've just triggered your test.07:11
zyga-ubuntuclassic is actually harder :)07:11
mborzeckibtw. hello-world.evil 'If you see this line the confinement is not working correctly, please file a bug' will not show only if using apparmor?07:12
zyga-ubuntuyes07:12
zyga-ubuntuit's a _very_ old and simplistic test btw07:12
mborzeckiok, i saw the message and wasn't sure whether I've screwed sth up or the system is missing some piece of infra07:13
mborzeckioh, and cleaned up environment file, now you can properly set SNAPD_DEBUG=1 for the daemon :P07:14
mvomborzecki: 4135 has some simple nitpick things then it can go in from my POV07:18
mborzeckimvo: thanks for the review07:18
mvomborzecki: felt slightly bad as it is really just nitpicks but then consistency in the codebase++ and all that :)07:18
mborzeckisure thing07:19
mvo(I mean, I felt slightly bad about nitpicking so much)07:19
zyga-ubuntunitpick: nitpick less07:21
zyga-ubuntu:)07:21
* zyga-ubuntu looks at sorting udev rules better07:21
mborzeckiis there something like a smoke test i could use to verify that local snapd installation works as expected?07:40
zyga-ubuntumborzecki: spread tests, but that's one big leap to do07:40
zyga-ubuntumborzecki: if you run spread you will find all the interesting details that are broken07:41
mborzeckii was hoping for something i can run in 5 minutes locally to verify that the arch package works ok07:41
zyga-ubuntuyou can run something for 5 minutes or you can run spread to find out if it works well, in my experience it's almost always something unexpected that fails mysteriously due to bugs or missing packaging07:42
zyga-ubuntumborzecki: but don't get me wrong, just use it daily and we'll know over time07:43
zyga-ubuntumborzecki: but there are some many features that only a spread run is a really good measure of what is broken07:43
mborzeckihmm DirsTestSuite.TestClassicConfinementSupportOnSpecificDistributions() started failing out of the blue07:44
mborzeckiSupportsClassicConfinement() found /snap in my system07:47
zyga-ubuntuperhaps missing mocking07:48
mborzeckithere's something weird about that test, its outcome may be altered by having the package installed in the system08:04
mborzeckithe whole check-SnapMountDir-symlink should probably be mocked08:04
mvomborzecki: yeah, sounds very much like an oversight from our patrt08:10
mvopart08:10
=== JanC is now known as Guest4348
* zyga-ubuntu goes to change 26 unit tests after rendering of udev rules got changed 08:15
kalikianagood morning08:20
mvohey kalikiana - good morning08:20
mupPR snapd#4172 opened:  interfaces/kmod: simplify loadModules now that errors are ignored  <Created by mvo5> <https://github.com/snapcore/snapd/pull/4172>08:37
zyga-ubuntumvo: reviewed08:44
mborzeckithat feeling when you spend time mocking something just to come to a relization that a simpler fix is only a couple of lines08:52
* mvo hugs mborzecki - we have all been there08:52
* mvo tries to reproduce the lxd/juju bug from the forum08:54
mborzeckipushed fixes for #413509:02
mupPR #4135: cmd/{snap-seccomp,snap-confine-ns},osutil,interfaces/account_control: workaround unit test failures on Arch <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4135>09:02
zyga-ubuntumvo: can you look at https://github.com/snapcore/snapd/pull/4144 please09:07
mupPR #4144: interfaces: fix udev tagging for hooks <Created by zyga> <https://github.com/snapcore/snapd/pull/4144>09:07
zyga-ubuntuI adjusted as jdstrand requested,09:07
zyga-ubuntuthe diff is slighltly larger because of how formatting and sorting is done but this should help in readability of actual udev rules09:07
pedronismvo: about #3992, after some recent discussions is not so clear anymore that is exactly what we need, I will close until that area is been worked on concretely again09:09
mupPR #3992: asserts: add cross-checking for snap-build <Created by pedronis> <https://github.com/snapcore/snapd/pull/3992>09:09
mupPR snapd#3992 closed: asserts: add cross-checking for snap-build <Created by pedronis> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/3992>09:11
mupPR snapd#4165 closed: interfaces/raw-usb: match on SUBSYSTEM, not SUBSYSTEMS (2.29) <Created by jdstrand> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4165>09:11
zyga-ubuntuI need a review for https://github.com/snapcore/snapd/pull/416309:16
mupPR #4163: cmd/snap-update-ns: re-factor secureMkdirAll into secureMk{Prefix,Dir} <Created by zyga> <https://github.com/snapcore/snapd/pull/4163>09:16
zyga-ubuntujamesh: failing tests on 414009:20
mupPR snapd#4167 closed: cmd/snap-update-ns: fix golint and some stale comments <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4167>09:21
zyga-ubuntumborzecki: conflict on 413509:22
=== __chip__ is now known as Chipaca
mborzeckizyga-ubuntu: s/update.XSnapdGid/update.XSnapdGID/ right?09:25
mborzeckiwhen merging a branch, do you leave the list of files with conflicts in the commit message?09:28
zyga-ubuntumborzecki: hmm?09:32
zyga-ubuntumborzecki: about the conflicts, not really, I think those are stripped out09:32
mcphailGood morning all. Will the patches needed for snaps be included in the mainline 4.14 kernel? I'm thinking of switching graphics cards to AMD, and that might push me into upstream kernel territory for best performance09:36
zyga-ubuntumcphail: this is a question for jjohansen; AFAIK one patch was still discussed and that was blocking the merge so perhaps the answer is no09:41
mcphailaah. thanks zyga-ubuntu09:41
mborzeckizyga-ubuntu: conflicts are resolved now09:41
* zyga-ubuntu -> coffee, brb09:41
zyga-ubuntumborzecki: thank you09:41
mcphailmborzecki: great :)09:42
=== jero is now known as Guest45935
mupPR snapd#4173 opened: corecfg: validate refresh.schedule when it is applied <Created by mvo5> <https://github.com/snapcore/snapd/pull/4173>09:51
zyga-ubuntumvo: removed where? ^^09:54
zyga-ubuntumvo: you said that we did this in the test suite09:55
zyga-ubuntuand that you removed that now09:55
=== JoshStrobl|zzz is now known as JoshStrobl
mborzeckizyga-ubuntu: added some comments to #416309:58
mupPR #4163: cmd/snap-update-ns: re-factor secureMkdirAll into secureMk{Prefix,Dir} <Created by zyga> <https://github.com/snapcore/snapd/pull/4163>09:58
zyga-ubuntumborzecki: thank you09:59
mvozyga-ubuntu: ups, sorry, forgot to push that commit, will do so in a sec10:00
mborzeckizyga-ubuntu: i'm not entirely sure about that "/", i may be worth double checking cause it looks like you'll do `segment := segments[-1]` in secureMkDir10:01
mvozyga-ubuntu: force pushed, sorry but I also forgot to add the header to corecfg.go10:01
pedronismvo: what's the schedule for edge builds atm ?10:06
mvopedronis: its broken right now, its supposed to happen after merges to master that have a green test10:12
pedronisheh10:12
pedronisis that spread-cron, or something else?10:13
mvopedronis: yes, spread cron10:13
pedronis:(10:13
mvopedronis: I triggered it manually this morning so we should have a proper edge soon10:13
mvobut that is not a soluation of course10:14
mvosolution even10:14
pedronismvo: after or before the proxy.store= merge ?10:14
mvopedronis: I think after, this merged happend last night, right?10:14
pedronismvo: no, you merged it this morning I think10:15
* kalikiana coffee10:15
zyga-ubuntumborzecki: yeah, I'm adding tests10:16
zyga-ubuntumvo: thanks :)10:16
mvopedronis: hm, let me double check then10:17
mvozyga-ubuntu: thank you!10:17
mvopedronis: according to launchpad it is in10:17
pedronisok10:28
zyga-ubuntumborzecki: pushed with some updates, thank you for spotting that10:31
mborzeckizyga-ubuntu: similar thing with secureMkFile10:32
mborzeckibut I think you can bail out there early by checking if the path does not end with /10:32
zyga-ubuntumborzecki: or just is "/", yeah10:33
zyga-ubuntumborzecki: I decided not to bail but instead check length around critical places10:33
mborzeckijust checking / will not cover a path like /foo/bar/10:33
zyga-ubuntumborzecki: this works just as fine and has lower coverage impact10:33
zyga-ubuntumborzecki: I mean check if the actual full path is exactly "/"10:34
pedronismvo: I don't understand the refresh.schedule change in the tests? isn't the idea that we don't want refreshes during the tests? shouldn't we put something correct back?10:36
mborzeckizyga-ubuntu: uhh, yeah, i meant for secureMkFile you'll probably need to check if the path does not end with /10:36
zyga-ubuntumborzecki: we do filepath.Clean on that10:37
zyga-ubuntuit will chop off the final /10:37
zyga-ubuntuit's a bit tricky, I agree10:37
zyga-ubuntumborzecki: I'll look at mkfile now10:37
zyga-ubuntumborzecki: I think for mkfile we should error if name ends with "/"10:38
mborzeckiyup10:38
mvopedronis: I can look into this, right now the settings have no effect (they will be rejected by snapd when it reads them internally) so things are not worse than before. but I agree this is a good opportunity to ensure things are properly done10:38
mvopedronis: I fix it10:39
zyga-ubuntumvo: and perhaps this can explain random failures (some of them)10:39
zyga-ubuntuwhere we just refresh10:39
mvozyga-ubuntu: definitely10:39
zyga-ubuntumborzecki: updated and pushed https://github.com/snapcore/snapd/pull/416911:07
mupPR #4169: cmd/snap-update-ns: add secureMkfileAll <Created by zyga> <https://github.com/snapcore/snapd/pull/4169>11:07
zyga-ubuntumborzecki: In the end I rebased because somehow the merge was messy11:07
mborzeckiok11:07
zyga-ubuntumborzecki: so please look at https://github.com/snapcore/snapd/pull/4169/commits/08d3ed6f54de26a7e671b58453044baebf591e1d11:07
mborzeckizyga-ubuntu: sorry for poking your reviews :) it's just that you have so many of them11:08
zyga-ubuntumborzecki: thank you :-D I cannot be happier really11:10
zyga-ubuntuusually we beg for reviews11:10
mupPR snapd#4162 closed: interfaces/kmod: treat failure to load module as non-fatal <Created by jdstrand> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4162>11:11
zyga-ubuntumborzecki: https://github.com/snapcore/snapd/pull/4166 is trivial11:13
mupPR #4166: cmd/snap-update-ns: detect and report read-only filesystems <Created by zyga> <https://github.com/snapcore/snapd/pull/4166>11:13
zyga-ubuntujust https://github.com/snapcore/snapd/pull/4166/commits/c21a85a15c923a5935d5374fe76c29463030c588 on top of other PRs11:13
mborzeckii'm look at it right now11:13
zyga-ubuntu(I have a similar one, unpushed, for mkfile)11:13
zyga-ubuntumborzecki: once some of those land I'll rebase my working branch and start push one more trivial branch and two more interesting branches for the "tmpfs bind mount farm"11:14
zyga-ubuntuand with some luck, it will all fall into place and "just work"11:14
zyga-ubuntuI still need to implement symlink creation and generalize actions for create/destroy (so that we don't "mount" symlinks which is just confusing)11:15
mborzecki4170 is part of this work too?11:16
zyga-ubuntuyes11:16
zyga-ubuntuthat's the "main" element in many ways11:16
zyga-ubuntueverything else is to make that part work11:16
niemeyero/11:21
mborzeckiso high level view is that once you hit a read only path, you'll bind tmpfs over this and recreate all the things from that original location inside tmpfs?11:22
zyga-ubuntumborzecki: exactly11:22
mborzeckiniemeyer: hi11:22
zyga-ubuntuhey niemeyer11:22
pstolowskihi niemeyer11:24
zyga-ubuntuPharaoh_Atem: hey, did you see https://bugzilla.redhat.com/show_bug.cgi?id=150958611:27
zyga-ubuntuI don't have F27 around11:28
niemeyerHey there11:29
* zyga-ubuntu -> break11:35
pstolowskipedronis, do you have a moment for HO?11:42
mborzeckihttps://travis-ci.org/snapcore/snapd/builds/299009217 hit travis timeout, should i restart?11:46
zyga-ubuntuyes11:50
zyga-ubuntuok, I really want to break now12:01
zyga-ubuntusee you at the call12:01
mvopedronis: fwiw, core in edge should be up-to-date now12:07
mvojdstrand: the /dev/mem test that cachio did in PR 4171 is interesting - it fails with EPERM and no apparmor denial, this is strange, usually we get EPERM (instead of EACCESS) when the device cgroup access fails, but poking around in a spread VM with the failed test things look ok there. do you know if /dev/mem is handled specially (beside the strict_devmem kernel mode which should still allow us to read the first 1mb). fwiw, its correctly tagged12:18
mvoin udev afaict12:18
mupPR #4171: tests: adding test to test physical memory observe interface <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/4171>12:18
mupPR snapd#4174 opened: packaging/arch: packaging update <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4174>12:21
mupPR snapcraft#1648 closed: sources: get svn revision with --show-item flag <bug> <Created by clobrano> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1648>12:23
pedronisChipaca: hi, I do plan to look at your aliases PR today or tomorrow12:37
niemeyerjdstrand: Related to our conversation around user ids and daemon:12:45
niemeyerhttps://github.com/snapcore/snapd/pull/4135/files#diff-be7cfe1e5aff69d70d80b1c2cabcaaccL74912:45
mupPR #4135: cmd/{snap-seccomp,snap-confine-ns},osutil,interfaces/account_control: workaround unit test failures on Arch <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4135>12:45
sergiusenskalikiana mind looking into my comment on snapcraft#1633 ?12:47
mupPR snapcraft#1633:  recording: record information from the image in container builds  <Created by elopio> <https://github.com/snapcore/snapcraft/pull/1633>12:47
jdstrandniemeyer: hey, yeah I saw that and thought the same thing12:48
jdstrandmvo: there are kernel controls for /dev/mem12:48
jdstrandmvo, cachio: our kernels are configured with STRICT_DEVMEM. see interfaces/builtin/physical_memory_control.go for details12:51
* zyga-ubuntu just read a PR title as "add support for soviet activation"12:52
jdstrandzyga-ubuntu: I don't know if I should laugh or give you a hug :)12:57
zyga-ubuntujdstrand: SOVIETS TRIGGERED!12:59
jdstrandheh13:00
zyga-ubuntujdstrand: I pushed updates to udev tagging for hooks13:10
zyga-ubuntujdstrand: I'm running spread locally now to see if I broke something13:10
zyga-ubuntujdstrand: sorting by tag is actually a pretty nice idea13:12
zyga-ubuntujdstrand: I also added a comment that says # iface so that we know which interface added the rule13:12
zyga-ubuntujdstrand: have a look if you have time13:12
popeyCan someone please review my alias request? https://forum.snapcraft.io/t/alias-request-for-mgba/271013:16
mvojdstrand: my understanding is that STRICT_DEVMEM allows access to the first 1mb of mem - it is also failig in open() already, so how is this supposed to work, does it just support mmap()?13:20
mvojdstrand: if you need to look it up, no worries, I can do this too :) just wondering if you know without research13:20
jdstrandzyga-ubuntu: awesome, thanks!13:28
zyga-ubuntujdstrand: I think some spread tests fail but they are probably (probably) just too picky and grep for detailed strings13:30
zyga-ubuntuI'll fix those soon13:30
zyga-ubuntu(well, fixing now)13:30
jdstrandpopey: I planned to today (note, 1 week hasn't gone by yet)13:30
popeyok :)13:31
mupPR snapcraft#1720 opened: kernel plugin: introduce kernel-channel to select from which channel … <Created by piso77> <https://github.com/snapcore/snapcraft/pull/1720>13:47
zyga-ubuntuSon_Goku: I'm installing gnome desktop on centos now, I can try your EPEL package soon13:48
Son_Gokuzyga-ubuntu: okay, cool13:48
zyga-ubuntuSon_Goku: I forgot how to use yum :)13:48
Son_Gokuheh13:48
zyga-ubuntuSon_Goku: is there a nice way to meta-install the desktop13:48
Son_Gokuthere's a DNF for CentOS 713:48
zyga-ubuntuoh? it's not installed by default13:48
zyga-ubuntuI'm on centos 7 for sure13:49
Son_Gokuhttps://seven.centos.org/2017/10/yum-4-is-available-for-testing/13:49
zyga-ubuntuyum or dnf?13:49
Son_Gokuyum 4 == dnf13:49
zyga-ubuntuah13:49
zyga-ubuntubut is the CLI the same?13:50
Son_GokuYep13:50
Son_Gokuyum4 is a symlink to /usr/bin/dnf13:50
Son_Gokuin Fedora, this is the "dnf-yum" package13:50
Son_Gokuzyga-ubuntu: so once that's installed, you can use dnf as normal13:53
mupPR snapcraft#1655 closed: lxd: distinguish argless clean from clean -s pull <bug> <Created by kalikiana> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1655>13:57
diddledanthe build service is refusing to let me login again13:58
diddledanrefusing my launchpad oauth token13:58
diddledan"Error:Invalid association handle"13:59
diddledanhmm, maybe it's specific to firefox (I have ublock origin installed, which might be conflicting)14:02
zyga-ubuntujdstrand: oh, drat14:06
zyga-ubuntujdstrand: my bad14:06
zyga-ubuntujdstrand: KERNEL=="foo", TAG+="bar" # this is a comment14:06
zyga-ubuntuthis is not valid14:06
zyga-ubuntuudev, man... really?14:06
zyga-ubuntuI need to change that to14:06
zyga-ubuntu# this is a comment14:07
jdstrandheh, yeah. it seems pretty finicky14:09
kalikianasergiusens: now that you asked me to change the test... I'm pondering to change "image-info: {architecture: test-architecture, created_at: test-created-at, fingerprint: test-fingerprint}" to use line-broken syntax without the {} for consistency14:09
kalikiananeed to check, though, how to change that. yaml has this behavior where the syntax depends on what types you use, not sure you can choose manually14:11
diddledanflexiondotorg: or popey: the build service has lost the store-name references for inadyn, opentyrian, and warzone2100 from the snapcrafters repositories14:14
popeyque?14:14
diddledanhttps://usercontent.irccloud-cdn.com/file/sJAYGe5k/Screenshot%20from%202017-11-08%2014-14-40.png14:15
popeyhuh14:16
popeythats odd14:16
zyga-ubuntujdstrand: I'm considering dropping the # iface comment14:16
popeyfixed warzone210014:17
zyga-ubuntujdstrand: unless you think strongly we should keep it14:17
diddledanI think it's because I had duplicates building from my own repo that should have been nuked. I nuked them, and it appears they've also disassociated the snapcrafters repos.14:17
zyga-ubuntuit's just a hassle, I really hoped udev would suck less at parsing14:17
jdstrandzyga-ubuntu: it would be nice, but I don't think it is strictly required14:17
popeythats plausible14:17
popeydiddledan: fixed all three, they're all building now14:17
diddledanthankyou :-)14:18
popeynp14:18
popeyin other news. diddledan would you like to be a collaborator on these snaps?14:18
diddledanI was trying to force a build so they get i386 versions when I spotted it :-)14:18
popeyso you can help manage them in the store?14:18
jdstrandzyga-ubuntu: I wonder if you could do # comment\nKERNEL==... for the first string...14:18
mvojdstrand: sorry, I had various laptop problems14:18
jdstrandnot super pretty14:18
diddledansure :D14:19
mvojdstrand: did you write anything after I asked about STRICT_DEVMEM?14:19
jdstrandmvo: no. I don't know of anything else otoh14:19
popeyok, what email address should I add you as?14:19
diddledanmy launchpad is diddledan, I think that's pointing at daniel@bowlhat.net14:19
mvojdstrand: ok, thank you, I poke a bit more, maybe the 1mb limit is on 32bit systems only, i.e. maybe this is arch dependent or something14:20
diddledanalternatively diddledan@gmail will work14:20
mvojdstrand: eh, I mean the limit that you can access the first 1mb on dev/mem14:20
* diddledan fires up the forum to catch-up on todays posts14:20
jdstrandmvo: yeah, I don't know otoh14:20
popeywhich one do you sso with?14:20
mvojdstrand: ta14:20
diddledanI try to sso with daniel@bowlhat.net14:20
popeyok14:21
popeywill add you a bit later.14:21
diddledanta14:21
zyga-ubuntuok, soup time, I'll get back to udev shortly14:22
jdstrandmvo: did you come up with a kmod test? I thought of one that we could use on core14:24
mvojdstrand: I just wrote a unit test, I was not thinking about a kmod spread test so far14:25
jdstrandmvo: ok. I'll try a spread test soonish14:25
mvothanks14:26
mupPR snapd#4135 closed: cmd/{snap-seccomp,snap-confine-ns},osutil,interfaces/account_control: workaround unit test failures on Arch <Created by bboozzoo> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/4135>14:31
mupPR snapd#4175 opened: dirs: use alt root when checking classic confinement support without … <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4175>14:36
cachio_niemeyer, partially fixed the issue on spread-cron14:47
cachio_niemeyer, I'll add a PR to fix the problem14:47
cachio_basically, it is failing when there are conflicts on the branches, and that be caused because a change we do and push14:48
sergiusenskalikiana well the json in a yaml thing is just not nice; pseudo json I even.14:53
kalikianasergiusens: right. I'm trying to figure out if we can force the style14:54
elopiohey popey, how can I enable build.snapcraft.io for vault?14:55
sergiusenskalikiana if you just add the dict, the right thing will happen on unmarshalling14:55
popeyelopio: just did it, building now14:55
kalikianasergiusens: no it doesn't14:56
kalikianaIt's already a dict14:56
kalikianaThis is YAML14:56
elopiopopey: thanks. Do you have in mind any solution to keep the snapcrafters branches up-to-date with upstream? Latest vault stable is 8.3, and the latest we have released is 8.0.14:57
popeyelopio: pull requests against the yaml is the simplest thing14:57
popeypreferable to push it upstream of course15:01
zyga-ubunture15:01
elopiopopey: yeah, but for the ones that upstream doesn't want. Would you mind if I experiment with vault to do it automatically?15:05
cachio_elopio, could you share the setup you have done for the autopcktests exec on snapcraft?15:16
cachio_elopio, you are running agains a ppa right?15:17
popeyelopio: sure15:25
popeyelopio: flexiondotorg has some scripts to automate this too15:25
sergiusenskalikiana one comment on snapcraft#141215:26
mupPR snapcraft#1412: lxd: snapcraft refresh in containers <Created by kalikiana> <https://github.com/snapcore/snapcraft/pull/1412>15:26
elopiocachio_: https://github.com/snapcore/snapcraft/pull/164315:26
mupPR snapcraft#1643: [WIP] tests: run daily autopkgtest in travis <Created by elopio> <https://github.com/snapcore/snapcraft/pull/1643>15:26
sergiusenskalikiana also, not sure you noticed, but it would be nice to use a temfile context to copy the snap into the lxd accessible area when copying the snaps over15:27
cachio_elopio, tx15:29
diddledanI'm looking at gimp. Trying to get internationalization working. I can't figure out how to tell gimp that it's translations are in $SNAP/usr/share/locale15:32
diddledanis there an environment variable to tell libc where to look for the locale folder?15:33
Chipacadiddledan: LOCALEDIR?15:38
Chipaca'parently not15:39
Chipacadiddledan: dunno15:39
zyga-ubuntuWHYISITALLSODIFFICULT15:42
zyga-ubuntuI'm hoping that with layouts it's not going to be that hard15:42
diddledanwhen do we get layouts? :-p15:42
* diddledan ducks15:43
Chipacadiddledan: tomorrow, but only if you use layouts to override glibc's date functions15:43
sergiusensChipaca careful, if someone makes glibc return dates after tomorrow you will be N days late ;-)15:44
Chipacasergiusens: or early!15:44
Chipacasergiusens: in fact, given that we're closer to 2038 than to 1970, on average i'll be early _anyway_!15:45
* zyga-ubuntu does the right thing wrt udev15:45
zyga-ubuntueven if painful15:45
* Chipaca does the wrong things wrt everything else because he can blame pain meds15:46
zyga-ubuntuha15:46
zyga-ubuntuI need some :(15:46
zyga-ubuntuI forgot about that15:46
sergiusenskalikiana wrt to that yaml thing; a dict that is yaml dumped should produce proper yaml, unless the thing that is json loaded is interpreted as a string in itself15:46
zyga-ubuntuI almost never take painkillers as they make me numb :(15:47
kalikianasergiusens: it is YAML :-)15:47
sergiusensChipaca that is kind of like blaming bad behavior on alcohol :-)15:47
Chipacasergiusens: darn15:47
kalikianasergiusens: I'm trying to find a way to switch the syntax to multi-line in any case15:48
sergiusenskalikiana oh, I thought we had code for that in the loader thing already15:48
sergiusenskalikiana try http://paste.ubuntu.com/25918524/15:51
zyga-ubuntujdstrand: about that15:51
zyga-ubuntujdstrand: gpio has a new /dev based API15:51
zyga-ubuntujdstrand: we need to tweak the interface for that15:51
zyga-ubuntuthere are ioctls and /dev/gpiochip entries for each controller15:52
zyga-ubuntuand the sysfs interface gets depracated (slowly)15:52
jdstrandhappy to review that PR (I don't have hardware to implement that so would be best if someone who could test with real hardware could implement it)15:53
zyga-ubuntugladly :)15:53
kalikianasergiusens: Oh nice! Thanks! Was staring at why this didn't seem to work at first, turns out it also makes architectures a list. But actually it makes everything consistent.16:05
kalikianapushed16:08
kalikiananeed to get some food into my stomach, back in a bit16:09
zyga-ubuntujdstrand: there, I retained all the comments16:14
zyga-ubuntuspread is running now, fingers croessed16:14
zyga-ubuntujdstrand: man I wish we had https://github.com/snapcore/snapd/pull/4157 merged already16:15
mupPR #4157: add spread test for connecting all interfaces (excepting gadget slots) <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4157>16:15
zyga-ubuntuniemeyer, jdstrand: interesting stuff here on lwn: https://lwn.net/Articles/738306/ - we could use the same idea for persistent identifiers of hot-plug usb devices16:20
zyga-ubuntuI'll break now, kids home, I'll check back and garden my PRs16:20
zyga-ubuntuI plan to send one more feature PR today, with changes-needed patch that enables tmpfs to work (and associated tests)16:21
zyga-ubuntuthat will be two feature patches short of all the major bits, then enabling this and integration and final spread test (that already exists and just has a path disabled) to show it works16:21
zyga-ubuntuthen reality will show where I was wrong :)16:21
zyga-ubuntubut that's what I'm here for16:21
popeyelopio: i dont understand your nba-go - did you patch it? I absolutely can't get it to build. you using new snapcraft or something?16:24
popeyelopio: i am on 2.34 from candidate16:25
cachio_elopio, so, you run from a container in travis the autopkgtests16:27
cachio_elopio, you are running against all the ubuntu releases right?16:28
elopiocachio_: no, that branch is only xenial. We will move it to nightly travis, so maybe we add more releases.16:33
elopiopopey: I'm using snapcraft from source, but what gets installed in the container is the latest snapcraft deb.16:34
popeyi dont understand, your branch builds, but if i just copy your yaml to an empty dir and source upstream it fails16:34
elopiopopey: ah, maybe submodules?16:34
elopiono, doesn't look like it.16:35
elopiolet me try that way.16:35
mupPR snapd#4176 opened: cmd: fix re-exec bug with classic confinement for host snapd < 2.28 <Created by mvo5> <https://github.com/snapcore/snapd/pull/4176>16:37
Chipacaniemeyer: 15pm -> 3pm in https://forum.snapcraft.io/t/1239/616:37
niemeyerChipaca: Oops, thanks16:37
kyrofakalikiana, do you have an rpi handy?16:44
kyrofa(or any other arch, really)16:44
kyrofaWe need to make sure cleanbuilding with a remote still works in snapcraft#171816:45
mupPR snapcraft#1718: lxd: let lxd choose the architecture <Created by mwhudson> <https://github.com/snapcore/snapcraft/pull/1718>16:45
kyrofaRemote of another arch, specifically16:45
elopiopopey: yeah, you are not crazy. This only works from a fork, no idea why.16:46
kalikianakyrofa: I have only amd64 and i386 servers16:46
kyrofai386 will do16:46
popeyhah16:46
kalikianakyrofa: I didn't stress test it yet since I wanted to know that we agree on the code. I'm still finding the string splitting rather ugly...16:47
kyrofakalikiana, well, before we were doing the same thing, but pretending it was YAML, right?16:48
elopiopopey: would you mind reporting a snapcraft bug? It could be that we are not installing the devDependencies for some reason. Or I don't know, this is weird, it needs debugging.16:48
kyrofaIt's not, so I'm not sure there's a better solution16:48
popeyelopio: where should i file that?16:48
mupPR snapd#4177 opened: state: add change.LaneTasks helper <Created by stolowski> <https://github.com/snapcore/snapd/pull/4177>16:49
kalikianakyrofa: well, it parsed as YAML... are you saying it might stop working?16:49
kyrofakalikiana, it could very well. It's definitely not dumped as YAML16:50
kyrofaSeems dangerous to parse something as YAML that we know for a fact is not YAML16:50
kalikianakyrofa: Maybe stgraber should weigh in here actually16:50
pstolowskipedronis, ^ can you take a look at #4177? I found your suggestion cleaner than an alternative I mentioned in the standup16:51
mupPR #4177: state: add change.LaneTasks helper <Created by stolowski> <https://github.com/snapcore/snapd/pull/4177>16:51
kyrofaYeah stgraber, why u no yaml?16:51
nacckyrofa: funny that you typed out why but not you16:51
kyrofaDangit16:51
naccjust wasting bits!16:51
kyrofanacc, I'll admit, even typing 'u' was hard16:52
naccheh16:52
popeyelopio: https://bugs.launchpad.net/snapcraft/+bug/173100316:54
mupBug #1731003: node app builds forked, but not referencing upstream source <Snapcraft:New> <https://launchpad.net/bugs/1731003>16:54
pedronispstolowski: yes, that looks like what I had in mind16:55
zyga-ubuntumvo: wow16:56
zyga-ubuntumvo: https://github.com/snapcore/snapd/pull/4176/files16:56
mupPR #4176: cmd: fix re-exec bug with classic confinement for host snapd < 2.28 <Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/4176>16:56
cachio_elopio, you trigger the execution and where do you see the results?17:00
pedronispstolowski: that's probably a useful helper anyway but what was the problem with your other approach?17:00
cachio_elopio, in the build history?17:01
pstolowskipedronis, I stored ID of last task to wait in context (initially it was hook's task ID, then if you queued another command, it would be that command's task ID and so on. problem was servicestate.Control (and cmdstate.Exec) gives taskset17:05
pedronispstolowski: there's also a problem though that we should be waited by what was waiting for the tasks17:06
pedronissorry,17:06
pedroniss/tasks/the configure hook task/17:06
elopiocachio_: travis sends an email when the nightly fails.17:07
pedronispstolowski: there's also WaitTasks and HaltTasks on tasks to follow that btw, not sure if you knew those already17:07
elopiopopey: flexiondotorg: what do you think about this? https://github.com/snapcrafters/vault/pull/3/files17:07
mupPR snapcrafters/vault#3: Build the latest unreleased tag <Created by elopio> <https://github.com/snapcrafters/vault/pull/3>17:07
elopio(I'm kind of proud of it, so be nice :)17:08
pstolowskipedronis, hmm, yeah I knew of them, but it didn't occur to me, WaitTasks can be useful indeed17:10
=== CodeMouse92 is now known as CodeMouse92__
pstolowskielopio, I like how you motivate reviewers, and hi btw :)17:12
pedronispstolowski: tbh I'm not quite sure how important it is to serialize the restarts vs what comes after the configure17:12
pstolowskipedronis, what's the question/concern?17:15
elopiopstolowski: hello :)17:16
pedronispstolowski: should we wait  the stop/start/restart  before doing anything that was waiting on configure itself17:19
pedronisthat's the question17:19
kyrofaHey niemeyer, any progress on the LXC issues? https://forum.snapcraft.io/t/lxc-error-when-updating-snap-and-cleaning-old-revisions/786/3417:23
zyga-ubuntujdstrand: hey, udev tagging for hooks works :)17:24
pstolowskipedronis, configure is the last task, there is nothing strictly waiting for it17:26
kyrofaelopio, any idea what's happening here? https://travis-ci.org/snapcore/snapcraft/jobs/29906120217:27
pedronispstolowski: that is not true in some complex refresh cases17:27
pedronisif I remember correctly17:27
zyga-ubuntukyrofa: hey, no progress from me yet :-( I only reproduced it and didn't try to fix it17:28
zyga-ubuntukyrofa: sorry, too many things burning/working on at the same time17:28
pedronispstolowski: at the moment I think is probably fine not to worry, but it's a question17:28
kyrofazyga-ubuntu, right, niemeyer mentioned someone else would work on it17:28
pedronispstolowski: if you look at doUpdate, you'll see that sometimes if attach more tasks after the doInstall ones17:29
pedroniss/if attach/we attach/17:29
* zyga-ubuntu installs a new home router17:29
zyga-ubuntuwell, helper router17:29
zyga-ubuntuand new as in "junk people threw out"17:29
kyrofaI sorta feel like the lxc issue falls into the "make things work before working on new features" but I guess that's just me17:30
zyga-ubuntukyrofa: yes, I agree; we had some of that recently17:30
* zyga-ubuntu looks at udev17:30
zyga-ubuntukyrofa: I honestly think that we don't use lxc enough in the team to be burned by this; but I agree we should fix it as lxc is an important use-case17:31
kyrofazyga-ubuntu, yeah I keep hearing that :)17:31
pedroniskyrofa: is it lxc or lxd ?17:31
kyrofapedronis, lxd17:31
kyrofapedronis, snaps only update three times before they never update again17:32
mupPR snapd#4178 opened: asserts/assertstest:  fix use of hardcoded value when the passed  or default keys should be used <Created by pedronis> <https://github.com/snapcore/snapd/pull/4178>17:32
pstolowskipedronis, ah, I see what you mean. when waiting for configure's hook task, the remaining tasks that may potentially be waiting for configure will not be waiting on us, we essentially insert new tasks in the middle17:32
pedronispstolowski: as I said, I don't think is a problem atm, but I don't know if that will stay true17:33
pstolowskipedronis, if that ever becomes true, we will need a proper "run-queued-services" task that sits in the sequence i guess17:34
* zyga-ubuntu EODs, goes to tweak home networking to merge two networks into one17:36
mvozyga-ubuntu: yes :(17:38
mvozyga-ubuntu: sorry for the delay, had dinner17:38
mupPR snapd#4179 opened: tests:  add a spread test for proxy.store setting together with store assertion <Created by pedronis> <https://github.com/snapcore/snapd/pull/4179>17:39
kalikianasergiusens: updated snapcraft#1412 as per your suggestion17:44
mupPR snapcraft#1412: lxd: snapcraft refresh in containers <Created by kalikiana> <https://github.com/snapcore/snapcraft/pull/1412>17:44
kalikianagoing to wrap up shortly17:44
=== cachio_ is now known as cachio__afk
zyga-ubuntumvo: no worries, thank you for finding and fixing that17:47
zyga-ubuntumvo: I'm mentally drained now so I'll refrain from complex work17:47
zyga-ubuntumvo: any releases today/17:47
mvozyga-ubuntu: no release, I will push 2.29.3 tomorrow in my morning17:48
zyga-ubuntumvo: which of those do you plan to merge: https://github.com/snapcore/snapd/milestone/1417:48
mupPR snapd#4180 opened: interfaces/many: misc policy updates for browser-support, cups-control and network-status <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4180>17:51
mupPR snapd#4181 opened: interfaces/many: misc policy updates for browser-support, cups-control and network-status (2.29) <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4181>17:54
mvozyga-ubuntu: I need to look at them with a fresh mind, maybe/probably all17:55
jdstrandmvo: hey, for your consideration, PR #4181. it is not a regression. it would help mailspring and some other high profile electron snaps17:56
mupPR #4181: interfaces/many: misc policy updates for browser-support, cups-control and network-status (2.29) <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4181>17:56
mvojdstrand: looking17:57
jdstranda regression fix*17:57
jdstrandmvo: the two other denial are not important for 2.29, but cachio__afk I think would appreciate one, and ogra_ the other17:57
jdstrands/denial/denial fixes/17:57
mvojdstrand: thanks, looks fine17:58
mvocachio__afk: some more validation work tomorrow for 2.29.3 :/17:58
zyga-ubuntuman, we have 46PRs17:59
jdstrandmvo: thanks. from mailspring upstream: "How long will it take for the policy change to reach the stable channel? I’d love to ship the Mailspring snap (I’m actually getting a couple emails / tweets a day about it because I said it was coming soon on the website ) but I should probably wait until a fix for this is in the wild."17:59
jdstrandmvo (cachio__afk): in other words, they will appreciate the effort18:00
Chipacattfn18:00
mvojdstrand: we aim for Monday18:01
mvojdstrand: and yeah, looks like a no-brainer, will pull it in18:01
pedroniszyga-ubuntu: close to needing us to declare a review sprint18:01
zyga-ubuntuyes18:01
zyga-ubuntuI was just thinking about that18:01
jdstrandmvo: there is one more mpris denial I need to look at for popey. I don't know if that will turn into a PR but will try to get it in place (if needed) today18:03
jdstrandmvo: the forum has been keeping my (and us!) busy!18:03
jdstrands/my/me/18:03
mvojdstrand: yeah, if you can get it done in (your) day, I can look at it in (my) tomorrow monring :)18:03
mvojdstrand: in ~12h18:03
* jdstrand nods18:03
jdstrandyep18:03
mvojdstrand: $everything is keeping me busy :(18:03
jdstrandthat one shouldn't take too long to chase down18:03
jdstrandmvo: heh, yeah, I bet18:04
pedroniszyga-ubuntu: I don't have immediate new feature coding to do, I need to go explore/analyze some things, I can also do reviews over the next few days18:04
mvojdstrand: but lots of good stuff!18:04
mvoI will also do more reviews!18:04
zyga-ubuntupedronis: thank you!18:04
zyga-ubuntumvo: I think we need to really fix the lxc issue18:04
* mvo does the pinkey swear18:04
mvozyga-ubuntu: which one? the one in the forum?18:05
zyga-ubuntumvo: I'll break feature coding while I wait for reviews and I'll focus on that tomorrow18:05
zyga-ubuntukyrofa: all of my tomorrow I'll look at LX[cd]18:05
kyrofaThank you zyga-ubuntu, I appreciate that18:05
mvozyga-ubuntu: what lxc issue is that? sorry for being a bit slow18:06
pedronismvo: https://forum.snapcraft.io/t/lxc-snaps-dont-update/786 I think18:06
zyga-ubuntumvo: refreshes inside containers break due to mount event ordering and special /snap sharing change18:06
pedronisit's a long topic, been around since a while18:06
zyga-ubuntumvo: somewhat related to 14.0418:06
zyga-ubuntumvo: where simiar special sharing applies18:07
pedronisdidn't we fix something about order in 14.04 recently though?18:07
pedronisrewriting units?18:07
zyga-ubuntupedronis: yes but that is different18:07
zyga-ubuntupedronis: we didn't rewrite on-disk units so that's still a todo18:07
pedronisah18:07
pedronisdo we have it somewhere?18:07
pedronison the forum?18:07
zyga-ubuntupedronis: here the lxd issue is really the mount events are in wrong order and this needs some love18:07
pedronisin a bug?18:07
zyga-ubuntuhttps://forum.snapcraft.io/t/lxc-snaps-dont-update/786/3618:08
mvozyga-ubuntu: thats not a regression, right?18:08
pedronisno, the other issue, the rewrite units18:08
pedronismvo: no, it's been terrible for a long while ;)18:08
zyga-ubuntumvo: "doctor help, the patient is dying", "is it a regression?"  ;D18:08
zyga-ubuntumvo: technically no18:08
mvozyga-ubuntu: *pfff*18:08
mvozyga-ubuntu: ;)18:08
zyga-ubuntumvo: but I love your release-manager approach :)18:08
zyga-ubuntubeing very focused on making the release work more and not less18:09
* zyga-ubuntu hugs mvo for being so fantastic 18:09
mvozyga-ubuntu, pedronis well, you guys know where the term "triage" comes from, right?18:09
jdstrandzyga-ubuntu: re udev tagging for hooks> \o/18:09
pedronismvo: do we do it?18:09
zyga-ubuntumvo: actually, I don't know18:09
mvopedronis: *cough*18:09
pedronisanyway me needs to eod/have dinner18:09
zyga-ubuntujdstrand: 2.29 variant is the one without sorting changes18:09
mvozyga-ubuntu: worth looking it up, it comes from the medical triage of patients, i.e. treat the ones that need urgent attention first18:10
* zyga-ubuntu looks that up18:10
mvozyga-ubuntu: but conversely (in the worst case) don't spend time on something where there is no hope18:10
zyga-ubuntumvo: oh, that's an interesting concept18:10
zyga-ubuntudo we tell the patient when that happens?18:11
mvozyga-ubuntu: *cough*18:11
mvozyga-ubuntu: or better *shhhh* ;)18:11
zyga-ubuntuhttps://commons.wikimedia.org/wiki/File:Deconference-2002-triage-tag.jpg18:11
jdstrandzyga-ubuntu (cc niemeyer): re https://lwn.net/Articles/738306/ (usbguard), this is actually on the security team's radar. It isn't bug free though. note that it isn't actually useful for snappy since the usb authorization system in the kernel is boolean, not application specific18:11
jdstrandzyga-ubuntu (cc niemeyer): however, the idea of hooking into the kernel's uevent stream like usbguard does is absolutely something we'll want to do18:11
zyga-ubuntujdstrand: I was merely thinking about the "fingerprinting" logic where we could have stable-ish (more than now) identifiers for hotplug devices18:12
zyga-ubuntujdstrand: yeah18:12
zyga-ubuntujdstrand: I'd love to do implement that18:12
jdstrandzyga-ubuntu: if only the usbgurad fingerprinting worked well :\18:12
zyga-ubuntumvo: I like how the "minor: walking wounded" category is green18:12
jdstrandzyga-ubuntu: we can certainly look at it18:12
mvozyga-ubuntu: but seriously, if you have a fix and if its easy enough that even I can understand it I'm happy to take it18:12
mvozyga-ubuntu: lol18:12
zyga-ubuntumvo: I don't have a fix but I was thinking about one that may be very simple18:13
zyga-ubuntumvo: one-line simple, I'll try tomorrow18:13
mvozyga-ubuntu: oh? woah18:13
mvozyga-ubuntu: that would be lovely18:13
jdstrandzyga-ubuntu: eg, if I plug my mouse into different buses, it shows up differently to usbguard18:13
zyga-ubuntujdstrand: yeah, it's not a trivial problem in any way18:13
zyga-ubuntujdstrand: but trivial problems are solved by dpkg18:14
jdstrandanyway, let me get to mpris then back to look at pr #414418:14
mupPR #4144: interfaces: fix udev tagging for hooks <Created by zyga> <https://github.com/snapcore/snapd/pull/4144>18:14
zyga-ubuntujdstrand: we are fixing interesting problems -18:14
zyga-ubuntu;-)18:14
jdstrand:)18:14
zyga-ubuntuthanks :)18:14
kyrofaYikes, github18:24
zyga-ubuntu?18:26
kyrofaThey're having javascript issues it seems18:28
zyga-ubuntuSon_Goku: I have centos 7 but too exhausted to play18:31
zyga-ubuntuSon_Goku: do some code reviews if you feel like jumping into layouts :)18:32
kyrofaLooks like he doesn't want to jump into layouts18:35
zyga-ubuntukyrofa: or he jumped into layouts and is stuck in a namespace18:35
kyrofaOooo, good one18:35
Pharaoh_Atemzyga-ubuntu: I hadn't seen the bug18:44
Pharaoh_Atemand HALP, stuck in namespace!18:44
Pharaoh_Atem:D18:44
zyga-ubuntu:-)18:45
kyrofaelopio, FYI, I'm looking at the Artful ruby errors. Want to make sure we aren't stepping on each other's toes18:46
kyrofaI'm also assuming we're not starting our nightly autopkgtest idea given that we're stilling waiting for stuff from the weekend18:47
mvozyga-ubuntu: does 4146 (the 2.29 version) need cherry-picks from the changes that you did on the master version of this PR18:47
sergiusenskyrofa what do you feel about my comment on snapcraft#163318:49
mupPR snapcraft#1633:  recording: record information from the image in container builds  <Created by elopio> <https://github.com/snapcore/snapcraft/pull/1633>18:49
kyrofasergiusens, raise a warning i.e. parse the output anyway?18:49
kyrofasergiusens, I totally agree that something we know is not YAML should not be parsed as YAML18:50
kyrofaSo yeah, I like the idea of trying to use --json, warning if it doesn't work, then falling back to processing the CLI output, but not with a YAML processor18:51
sergiusenskyrofa no, if you do --format=json and it is not supported you would get an errno from the command18:51
sergiusenskyrofa I'd say, just not support it, period18:51
kyrofaOh oh, this is recording18:51
sergiusensyes, this is recording18:52
kyrofasergiusens, sorry, we're having this exact same discussion on another PR :P18:52
kyrofaWell, almost18:52
kyrofasergiusens, yes, I agree18:52
elopiokyrofa: I am debugging the autopkgtest on travis error. Not yet ready to land.18:54
sergiusenskyrofa I know about the other PR, I just want to wrap up this recording thing; elopio want to close that one up with the latest comments?18:54
elopiothanks for looking into ruby. This is the segfault, right?18:54
kyrofaelopio, indeed18:54
sergiusenskyrofa elopio decided to just continue landing things if they made sense and thoroughly tested18:55
kyrofasergiusens, fair enough. It's either that or kinda sit on our hands18:55
kyrofaI need to refresh my memory for how to run our adt suite in lxc18:56
kyrofaWe can start doing that18:56
elopiosergiusens: I agree with the --json thing. I will revert the change after lunch, and make sure that we don't crash if it fails.18:56
elopiosergiusens: ack. I'll update my branches so they are ready to land. Most of them require an autopkgtest run though :(18:57
elopiokyrofa: about that failed travis execution, the CLA fails because the email is private. Rebase with master, to no longer carry that commit.18:58
kyrofaelopio, what's confusing is that there are only two commits on that PR, mine and kalikiana's18:59
kyrofaI merged with master, we'll see what Travis says. I'll rebase if necessary18:59
sergiusenskyrofa running the suite and unit tests in lxd should be our default :-)18:59
zyga-ubuntumvo: looking19:01
kyrofasergiusens, think so? It's a bit more of a barrier to proposing something19:01
zyga-ubuntumvo: the 2.29 version is older, subsequent changes to master version are cosmetic though19:01
sergiusenskyrofa for us, not others19:01
zyga-ubuntumvo: so I'd say no, no changes needed19:01
kyrofasergiusens elopio, alright, I'll start running the autopkgtests for some of the PRs up now. I'll comment on the ones I've tested19:12
kyrofaAlthough... elopio will it install squashfuse by any chance for the snapd tests?19:13
kyrofaOtherwise it'll just fail partway through19:13
matiasb_sergiusens, elopio, o/ hey, when you get a few, any chance you can take another look at facundo's MP on metadata handling? https://github.com/snapcore/snapcraft/pull/163419:14
mupPR snapcraft#1634: Push metadata to the Store <Created by facundobatista> <https://github.com/snapcore/snapcraft/pull/1634>19:14
=== matiasb_ is now known as matiasb
elopiokyrofa yes, squashfuse should be installed for the suites that install snaps19:19
kyrofaWhew, good19:19
elopiomatiasb: sorry for the delay. We have been stuck on autopktest for too long. I'll take another look today19:20
matiasbelopio, np, just wanted to check it is in your radar, thx19:21
=== JoshStrobl is now known as JoshStrobl|Away
=== cachio__afk is now known as cachio
cachiojdstrand, nice, thanks, so the denials that I shared yesterday should be fixed with this PR, right?19:45
jdstrandcachio: yes19:49
jdstrandcachio: I mean, I didn't test it beyond the policy compile (I just took the connected slot rule and used the unconfined label), but yeah, it should work19:50
cachiojdstrand, great, tx19:51
zyga-ubuntujdstrand: still fighting the mpris bug/19:57
mupPR snapd#4175 closed: dirs: use alt root when checking classic confinement support without … <Created by bboozzoo> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4175>19:59
mwhudsonkyrofa, kalikiana: "lxc info remote:" is real yaml, "lxc info container" is not20:12
mwhudsonunfortunately it's the latter that is really needed20:12
mwhudsonheh heh "curl --silent --unix-socket /var/lib/lxd/unix.socket http://a/1.0/containers/complete-amoeba | jq .metadata.architecture" works for the local remote...20:21
jdstrandzyga-ubuntu: I just finished20:26
jdstrandcachio: fyi, I mentioned to mvo that I might have a PR for mpris. I will not. no bug in snapd (afaics)20:26
jdstrandcachio: mentioning it to you since he is offline and this was potentially something extra for 2.29.3, which I know you are helping validate20:30
* zyga-ubuntu had fun watching https://www.youtube.com/watch?v=M6xZZiaLOV420:36
kyrofaelopio, can you explain why snapcraft seems to be running units in debug mode in adt, but not normally?20:47
kyrofa(getting a failure in master due to this)20:47
cachiojdstrand, perfect20:50
cachiojdstrand, about the read access to /dev/mem20:51
cachiohow should I make to run to read in the allowed spaces20:52
jdstrandcachio: otoh, I'm not sure, but I think mvo was looking into it20:52
elopiokyrofa, do you mean with --debug?20:53
kyrofaelopio, yeah20:53
jdstrandcachio: there is something called CONFIG_STRICT_DEVMEM that is getting in the way20:53
jdstrandthere are ways to use it, but otoh idk20:54
elopiokyrofa: sounds weird that unit tests are using debug, because they don't call the snapcraft command.20:54
kyrofaelopio, I don't even now why units are run, haha20:54
kyrofaYeah something weird is happening20:54
kyrofaAll I see in debian/tests are integration and snaps tests20:55
jdstrandmvo: hey, fyi, I won't be submitting anything for mpris. I'm done (for now)20:55
jdstrandheh20:55
cachiojdstrand, so, is it any way to use that interface?20:55
elopiokyrofa: adt starts building the deb, and for that the unit tests are run20:55
kyrofaAh right, of course20:56
kyrofaI'll look that way20:56
cachioshould I disable the CONFIG_STRICT_DEVMEM?20:56
jdstrandcachio: that's a kernel config option20:56
cachiojdstrand, so the only way is rebooting the machine20:57
jdstrandcachio: there should be a way to do it (X uses it afaik), but I personally don't know the incantation required20:57
kyrofaelopio, huh, is it automatically determining how to run the units?20:58
kyrofaIt's probably wrong, then20:58
kyrofaAnd sets the logger level wrong20:59
elopiokyrofa: setup.py defines the tests to run20:59
jdstrandcachio: the kernel-module-control interface needed it for read access. that interface was written for livepatch. maybe something in there that could give a clue20:59
kyrofaOh! I've never run tests that way before21:00
elopiotests that depend on logger levele should set it up. But as far as I know, nothing on adt touches that21:02
jdstrandcachio: I suspect you can read it, but need to access it in a specific way. we have in the interfacec: "allow reading /dev/mem for read-only access to architecture-specific subset of the physical address (eg, PCI, space, BIOS code and data regions on x86, etc)."21:02
jdstrandcachio: all Ubuntu kernels use STRICT_DEVMEM=y so you wont' be able to test write access (physical-memory-control) on Ubuntu kernels21:03
pedronismmh, I'm seeing this tests fail  linode:ubuntu-16.04-32:tests/main/xdg-open-compat: with apt download snapd-xdg-open=0.0.0~16.04 => E: Version '0.0.0~16.04' for 'snapd-xdg-open' was not found21:03
jdstrandcachio: there might be a kernel snap somewhere that uses STRICT_DEVMEM=n, but I don't know which one. I would guess perhaps an armhf kernel, but that is only a guess21:03
cachiojdstrand, ok, I'll research about it21:04
pedronismmh, it works here, strange fluke21:05
kyrofaelopio, why is the ruby integration test using such an old version of ruby?21:06
cachiojdstrand, I'll take a look to the armhf ones21:06
cachiothanks21:06
jdstrandcachio: oh, I forgot we have a test for this. here is some more context: https://wiki.ubuntu.com/Security/Features#A.2Fdev.2Fmem_protection21:06
jdstrandcachio: let me get the link for the test21:06
cachiojdstrand, nice21:07
kyrofaelopio, well, it's not ancient I suppose. But versions < 2.4 don't seem to build with GCC721:08
kyrofaI'm gonna propose changing it unless there was a good reason we were using the old one21:09
elopiokyrofa: no good reason that I can think of. But should we raise an early exception if we see gcc7 and ruby < 2.4?21:09
jdstrandcachio: oh boo. the test for STRICT_DEVMEM only verifies /boot/config... is set21:09
kyrofaelopio, I don't think so, might be fixed at some point21:10
jdstrandcachio: so nothing to verify the kernel protection is working21:10
cachiojdstrand, well the the that I did :)21:11
elopiokyrofa: updating the tests works for me.21:11
jdstrandcachio: Xorg might be something to look at if research doesn't help much21:12
kyrofaelopio, alright. Testing once more, then I'll propose21:12
kyrofaelopio, back to the autopkgtests: note that `python3 setup.py test` fails with the same error21:12
kyrofaSo it's using a weird logging level21:12
* elopio runs that21:16
zyga-solusjdstrand: hmm21:17
zyga-solusjdstrand: it _is_ sorted by command now :)21:17
zyga-solusjdstrand: unless I missed something21:17
jdstrandoh, hmm. I checked the new commits and I must've missed something21:18
* zyga-solus tries to pull the diff21:18
zyga-solushttps://github.com/snapcore/snapd/pull/4144/files#diff-641ccdace7a269ed745615226d7f4cffR11121:19
mupPR #4144: interfaces: fix udev tagging for hooks <Created by zyga> <https://github.com/snapcore/snapd/pull/4144>21:19
zyga-solushere21:19
zyga-solusis that what you expected?21:19
jdstrandzyga-solus: I see it now21:19
zyga-solusjdstrand: it's not super pretty because of that comment21:19
zyga-solusand we could be smarter about how to lay out stuff21:19
zyga-solusbut it's a start21:20
zyga-solusalso because of those comments it's ordered by TAG, interface, snippet21:20
zyga-soluswhich is at least, consistent :)21:20
jdstrandthat sounds great21:21
g4lHello guys! I'm try to connect to my vpn server, on a snappy ubuntu core os. using easy-openvpn.connect-server, I face this error: "ERROR: Cannot ioctl TUNSETIFF tun: Operation not permitted (errno=1)"21:25
g4lI'm thinking about some network permissions?21:25
elopiokyrofa: snapcraft.tests.test_lifecycle.ExecutionTestCase.test_dependency_recursed_correctly ?21:26
kyrofaYep21:27
kyrofag4l, if you run `snap interfaces`, are all of them connected?21:28
ikeyzyga-solus, got 2.29.2 built21:28
ikeygonna try installing it and seeing how much i broke it21:28
kyrofaCan't remember if network management is granted by default21:28
g4l:firewall-control          docker,easy-openvpn21:28
ikeyalso yay for mkversion.sh taking an argument21:28
kyrofaelopio, see the ""GET /v2/snaps HTTP/1.1" 200 None" there throwing it off?21:29
ikeyand not causing one21:29
g4l:network-control           easy-openvpn21:29
g4l:home                      easy-openvpn21:29
g4lI think that these 3 are enough21:29
kyrofag4l, huh, yeah those are the ones I was thinking21:29
kyrofag4l, although, did you use sudo?21:29
cachiojdstrand, the good part is that the test is working in debian, fedora and opensuse21:30
elopiokyrofa: seems to be affected by another test. ugh, that's hard to reproduce.21:30
kyrofaelopio, argh, I hate those21:30
g4lI did try. some other problems show up: "Options error: In [CMD-LINE]:1: Error opening configuration file: "21:30
cachiojdstrand, it is weird, why I can ready /dev/mem from the console21:30
kyrofag4l, because adding tun/tap interfaces definitely requires sudo. For anything more snap-specific, you'll need to talk to the maintainer21:30
ikey snap run ohmygiraffe21:30
ikeycannot perform operation: mount --rbind /lib/modules /tmp/snap.rootfs_qF4Snx//lib/modules: Permission denied21:30
ikeypfft.21:31
kyrofaelopio, it happens every time for me, three times in a row21:31
zyga-solusikey: any denials?21:32
zyga-solusikey: on which snapd?21:32
zyga-solusikey: I have _that_ snap installed and it works21:32
ikeyAVC apparmor="DENIED" operation="open" profile="/usr/lib64/snapd/snap-confine" name="/etc/os-release" pid=2163 comm="snap-confine" requested_mask="r" denied_mask="r" fsuid=0 ouid=021:32
zyga-solusright here on solus21:32
zyga-solusthat's so weird, /etc/os-release is allowed by the profile21:33
ikeyNov 08 21:30:37 ironhide kernel: audit: type=1400 audit(1510176637.423:37): apparmor="DENIED" operation="mount" info="failed flags match" error=-13 profile="/usr/lib64/snapd/snap-confine" name="/tmp/snap.rootfs_qF4Snx/lib/modules/" pid=2163 comm="snap-confine" srcname="/lib64/modules/" flags="rw, rbind"21:33
zyga-solushm21:33
zyga-solusactually, it's not21:33
ikeyok well that one is fairly trivial21:33
ikeyneeds lib+lib6421:33
ikeystupid solus with its weirdisms21:33
zyga-solusbut that's an old copy of snap-confine probably21:33
ikey?21:33
g4lkyrofa, even as root, I can't make it. has no one ever try to configure this on a rpi3 ?21:33
ikeyim on snapd 2.29.221:34
ikeyand id rebooted21:34
zyga-solusikey: you will find that /lib/modules is baked into snap-confine itself21:34
ikeyaye21:34
zyga-solusikey: ah, I'm still on 2.2721:34
ikeyoh yeah 2.27 is gloriously fine21:34
ikey2.29.2 is choking on cookies21:34
ikeyima fix21:34
kyrofag4l, please file a bug, I'm afraid I don't know anything about that snap21:34
zyga-solusironically that's one of the things we could get into the new profiles now21:34
zyga-soluswhere it could be distro-based easily from snapd side21:35
zyga-solusikey: tomorrow we do 2.29.321:35
kyrofag4l, https://bugs.launchpad.net/snappy-hwe-snaps/+filebug from the look of it21:35
zyga-solusthere are a few PRs tagged for 2.2921:35
ikeyok21:35
zyga-solusmilestoned21:35
zyga-solusnot tagged in git sense21:35
ikey    mount options=(rw rbind) {,/usr}/lib{,32,64,x32}/modules/ -> /tmp/snap.rootfs_*{,/usr}/lib/modules/,21:36
ikeysurely that already covers it?21:36
ikeyor im being thick altogether21:36
ikeywhy it even needs my kernel modules ive no idea21:36
zyga-solusit looks good21:36
zyga-solus"failed flags match"21:37
ikeyright21:37
zyga-solusI'm too tired21:37
ikeymaybe somehow rw, rbind != rw rbind ?21:37
zyga-solussorry, I need to stop typing21:37
zyga-solustomorrow :)21:37
ikeykk21:37
mupPR snapcraft#1721 opened: integration tests: use ruby v2.4.2 <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1721>21:41
ikeyoo the patch isnt in 2.29.2..21:41
ikeyk well that makes sense then21:41
mupPR snapd#4182 opened: cmd/snap-confine: Ensure snap-confine is allowed to access os-release <Created by ikeydoherty> <https://github.com/snapcore/snapd/pull/4182>22:00
elopiokyrofa: can you please try this patch with your autopkgtest runs? http://paste.ubuntu.com/25920819/22:17
mupPR snapd#4183 opened: cmd/snap-confine: Respect biarch nature of libdirs <Created by ikeydoherty> <https://github.com/snapcore/snapd/pull/4183>22:52
kyrofaelopio, it's the parser test22:55
kyrofaI'm not sure how yet, but it is22:56
ikeyturns out you guys were serious about snap-update-ns being static. :p22:56
ikeytada https://plus.google.com/+Solus-Project/posts/hG14dctjrfg23:03
elopiocan somebody open build.snapcraft.io? I think I broke it :(23:22
naccelopio: or is it affected by the canonical maintenance?23:22
elopionacc: phew, so it wasn't me :)23:23
naccelopio: it's nnot explicitly metioed, but the store and "Ubuntu web sites" are23:24
nacc*Canonical and Ubuntu23:24
diddledanaha, I was just about to ask whether I broked it23:30
kyrofaIRC is back, test again23:32
mcphailikey: I love that ohmygiraffe has become the de facto test of snapd :)23:35
ikeylol yea23:35
ikeyits nice because GL + sound + xdg23:36

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!