[00:57] <wallyworld> axw: looking at 1.25 PR. interesting that in 2.x, we have leaseClientId as an attribute on State and hence set that as part of State.start() instead of during lease worker startup as your 1.25 change does
[00:58] <axw> wallyworld: yeah probably should do it in 1.25 too, since it should be a terminal error. just made things a little simpler this way
[00:59] <wallyworld> axw: yeah, it may be what's proposed is good enough. i guess if we can't get the clientId stuff will still break, but in a different way
[01:02] <wallyworld> anastasiamac: hml: axw: forgot to remind - if there's anything you want to add to release notes for beta3, now is the time
[01:03] <hml> wallyworld: nothing coming to mind
[01:03] <wallyworld> yeah, mostly bug fixes this time
[01:03] <wallyworld> i added a few key things
[01:04] <anastasiamac> wallyworld: m all good but will confirm with the rest of the squad later on in the day
[01:04] <wallyworld> ty, may be too late then :-)
[01:06] <axw> nah I don't think so
[01:06] <anastasiamac> really? 4pm our time?..
[01:06] <axw> only thing was the mutex fix, and that's out :~(
[01:06] <anastasiamac> wallyworld: most bug fixes anyway :)
[01:07] <wallyworld> indeed
[01:07] <wallyworld> anastasiamac: yeah veebers is on fire, i expect it wil be done by 4pm our time as that will be well into his evening and he will already be on the beer :-)
[01:08] <anastasiamac> wallyworld: :D
[01:11] <veebers> wallyworld: hah more like cleaning up spit-up and baby wees off my hands, but hopefully there will be a beer there sometime ^_^
[01:11] <wallyworld> the joys of parenthood
[01:11] <wallyworld> you'll be doing the same thing to yuorself when you hit 80
[01:11] <veebers> hah ^_^
[01:12] <veebers> s/when/if/ /me dies of parenthood related stress
[01:32] <axw> wallyworld: https://github.com/juju/mutex/pull/5
[01:33] <axw> currently running the network-health test with the old code to repro locally, then will run with this to make sure it's the problem
[01:33] <axw> it's definitely *a* problem though
[01:34] <wallyworld> axw: looking. good we have CI
[01:34] <axw> indeed
[01:39] <wallyworld> axw: lgtm, just a comment typo
[01:40] <axw> wallyworld: heh thanks
[01:58] <axw> wallyworld: do you have rights to merge https://github.com/juju/mutex/pull/5 ?
[01:58] <wallyworld> yup, i think so
[02:00] <wallyworld> axw: added you with perms to merge
[02:00] <wallyworld> try it?
[02:00] <axw> wallyworld: thanks
[03:24] <hml> wallyworld: changes we discussed have been made, pr updated
[03:47] <thumper> axw: what was happening with the mutex?
[03:47] <thumper> axw: was it inheriting the lock, and only one closed it, so it was still "held" or something?
[03:48] <axw> thumper: subprocess inherited the file descriptor, so flock was held by subprocess even though juju closed its FD
[03:48] <thumper> but that sub process would have finished as well, releasing it, right?
[03:48] <axw> thumper: yeah, unless it spawned off something like "timeout"
[03:55] <thumper> axw: is that what the tests were doing?
[03:55] <thumper> so that explains why some hooks were fine and others not yes?
[03:57] <axw> thumper: the network-health test starts a server from one of the hooks, and never stops it AFAICT
[03:57] <axw> thumper: yeah, depends on the hook implementation for sure
[03:58] <thumper> ah..
[03:58] <thumper> ok, I like to know why things fail :)
[05:10] <wallyworld> axw: the state we attach to the apiRoot object - the one facades get via ctx.GetState() - i can't see where that gets closed. do you know?
[05:12] <axw> wallyworld: looking, have to remind myself
[05:12] <wallyworld> i also can't see where we Stop() resources
[05:13] <axw> wallyworld: it's the same State that's attached to the Server
[05:13] <wallyworld> and we stop that one? let me look
[05:13] <axw> wallyworld: which is closed by the agent
[05:13] <wallyworld> ok, ta
[05:14] <wallyworld> axw: trying to decide whether to add a "controller" Resource
[05:14] <wallyworld> rather that yet another attribute on server
[05:14] <wallyworld> as resources i think is the preferred way to add stuff to the facade context
[05:15] <axw> wallyworld: I'd prefer it was part of the Server
[05:15] <wallyworld> there's a snaky comment from willian next to ctx.State() that it should be a resource
[05:15] <wallyworld> any reason for preferring to add to Server?
[05:16] <axw> wallyworld: I don't know what that would buy us
[05:16] <axw> wallyworld: because State and StatePool are there. and because it's not a per-connectio nresource
[05:16] <wallyworld> keeps facade Context interface stable
[05:16] <axw> it's owned by the Server, not by the connection
[05:17] <axw> and eventually it shouldn't even be owned by the Server, but passed in and owned by a manifold
[05:18] <wallyworld> hmmm, ok, let me think on it
[05:18] <axw> wallyworld: perhaps we should start a new branch for this work? I have some things I'd like to land too, but have been holding off until after 2.3
[05:19] <wallyworld> a feature branch? yeah maybe
[05:19] <axw> wallyworld: though possibly my work will make fixing https://bugs.launchpad.net/juju/+bug/1642618 easier anyway
[05:19] <mup> Bug #1642618: enable-ha using existing machines breaks agents <enable-ha> <juju:In Progress by axwalk> <https://launchpad.net/bugs/1642618>
[05:19] <wallyworld> i think we can do a few things on develop
[05:20] <wallyworld> a lot of this stuff is shifting furnature around
[05:21] <axw> wallyworld: sometimes the furniture is accidentally load bearing though :)
[05:22] <wallyworld> that is true
[05:23] <wallyworld> i'll do this work and see how it looks
[05:23] <wallyworld> can propose against a fb if it looks too messy
[05:56] <wallyworld> axw: sorry, another question. do you know why we pass in a State to startStateWorkers() but then provide a separate openState() method to the apiserverWorkerStarter? we barely use the result from openState(). but noentheless, why not just use the one we already have, especially when that one we alrready have comes from the manifold
[05:57] <wallyworld> openState() as it turns out provides a State used to get ControllerConfig(), which we could just pass in from the original st, and create an audit log sink, which we also could get from a manifold.
[05:57] <axw> wallyworld: I thought there was a comment, but can't find it now. it's because the apiserver kills the state workers
[05:58] <axw> wallyworld: so if hte apiserver restarts, it needs a new State
[05:58] <axw> sas the old's watchers, lease manager, etc. will have been stopped
[05:58] <axw> *as
[05:58] <axw> wallyworld: this is one of the things I have fixes for in the pipeline
[05:58] <axw> wallyworld: if it makes it easier for you to do what you want to do, I can look to land my work sooner rather than later
[05:59] <wallyworld> yeah, that would be good. i want to thread through a controller
[05:59] <wallyworld> but need a state
[05:59] <axw> wallyworld: I have a branch that will move the apiserver to a manifold, too, but needs a bit more work
[05:59] <axw> wallyworld: probably better to get that in, then you can use the controller manifold?
[05:59] <wallyworld> would be good to get that stuff landed
[05:59] <wallyworld> yes
[05:59] <wallyworld> maybe a fb then?
[06:00] <wallyworld> it's all very messy atm
[06:00] <wallyworld> would be good to get this cleaned up
[06:00] <axw> wallyworld: I think that'd be prudent. then fold it into develop as soon as we branch
[06:00] <wallyworld> yup
[06:00] <axw> wallyworld: first step is to land https://github.com/juju/juju/pull/8038 in a feature branch then
[06:01] <wallyworld> ok, and it's been approved
[06:01] <axw> wallyworld: want to review for me? it has rog's +1, would be good to get a second opinion tho, as it's core
[06:01] <wallyworld> ok
[06:01] <wallyworld> i'll create the fb
[06:01] <wallyworld> as well
[06:05] <wallyworld> axw: https://github.com/juju/juju/tree/state-controller-refactor
[06:05] <wallyworld> looking at PR now
[06:05] <axw> wallyworld: thanks
[06:06] <axw> wallyworld: note there's two commits, might be easier to review them independently
[06:06] <axw> one after the other, rather
[06:06] <wallyworld> ok
[06:07] <wallyworld> axw: i had a look earlier - we disucssed a bit already this week, i'll re-review
[06:07] <axw> wallyworld: we did? I don't remember htat at all :o
[06:07]  * axw is losing the plot
[06:08] <wallyworld> i was asking about exposing context to api leayer, and clarifying operation on apiserver sid eetc
[06:08]  * wallyworld has already lost the plot
[06:08] <axw> sounds vaguely familiar :p
[06:19] <wallyworld> axw: +1 to go into fb. i'd like to ensure we get some good CI runs (which we will) and do some more extensive manual testing with all the other changes we will be landing soon
[06:20] <axw> wallyworld: ok. I think I broke something in the API package with a change I made about an hour ago, will fix that and land
[06:20] <wallyworld> sgtm
[06:20] <wallyworld> axw: and then you had a followup bit of work to go on top of this?
[06:21] <wallyworld> i'll look to pick up my stuff next week perhaps
[06:21] <axw> wallyworld: yes, to move apiserver to the dependency engine
[06:21] <wallyworld> great, ok
[06:21] <axw> then there'll be more followups on top of that I'm sure
[06:21] <wallyworld> yep
[06:22] <axw> wallyworld: e.g. once we move to using a single StatePool, the introspection code can be cleaned up a bit
[06:22] <axw> it's really awkward atm, the apiserver starter needs to create a new StatePool, then set that on the agent so the introspection worker can reference it
[08:45] <wpk> wpk@minnie:~/dev/src/gopkg.in/juju/names.v2$ grep -r IsValidRelation *
[08:45] <wpk> wpk@minnie:~/dev/src/gopkg.in/juju/names.v2$ grep -r IsValidRelation relation_test.go
[08:45] <wpk> 			c.Assert(names.IsValidRelation(key), gc.Equals, isValid)
[08:45] <wpk> magic
[08:45] <wpk> 			c.Assert(names.IsValidRelation(peerKey), gc.Equals, isValid)