[00:00] <kennyloggins> What is the command to install two snaps in sequence ?
[00:01] <sergiusens> kyrofa snapcraft#1719
[00:01] <mup> PR snapcraft#1719: many: account for python shebang args in rewrite <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1719>
[00:01] <kyrofa> sergiusens, that didn't restart, it's been going for two hours
[00:01] <nacc> kennyloggins: not sure i understand? `sudo snap install <snap1>; sudo snap install <snap2>` ?
[00:01] <sergiusens> bummer, why did it start only two hours ago?
[00:01] <kyrofa> sergiusens, I had to start it because snapd toasted my local adt runs
[00:02] <kyrofa> sergiusens, https://forum.snapcraft.io/t/snapcraft-adt-failures-with-the-new-core-release/2850/12
[00:02] <kyrofa> sergiusens, also, I did comment in the PR :)
[00:03] <sergiusens> kyrofa yeah, that I did see; do we need this though?
[00:04] <kyrofa> sergiusens, up to you, I'm fairly confident given that I had successful runs before the rebase, but they were on zesty
[00:04] <sergiusens> kyrofa elopio we need less tests, or broader ones; how many of the catkin tests could be merged into one?
[00:05] <sergiusens> same for all the other components
[00:05] <sergiusens> they could be condensed into on with multiple parts/apps
[00:05] <sergiusens> unless it warrants a separate one
[00:05] <sergiusens> but I am going to be pragmatic here, many are only separate because it looks good on paper
[00:06] <kyrofa> sergiusens, remember we're still not re-using the cache
[00:07] <kyrofa> Simpler tests are way easier to maintain
[00:07] <kyrofa> But yeah, we can definitely combine some catkin ones if that's the direction we want to go
[00:09] <kyrofa> This normally doesn't hurt quite so badly, we simply need to get in the habit of running them more often and paying attention to the result. I suggest caution in making decisions about our tests in our current state of pain
[00:11] <sergiusens> kyrofa well, tonight is your night and tomorrow is your morning, right?
[00:11] <sergiusens> :-)
[00:11] <kyrofa> Indeed
[00:11] <kennyloggins> What is test-snapd-cups-control-consumer , exactly ? Is it for printers ?
[00:13] <nacc> kennyloggins: you can read it's description in `snap info test-snapd-cups-control-consumer`
[00:13] <nacc> but as the name implies, it's a test snap for snapd to test the cups-control interfcase
[00:13] <nacc> *interface
[00:14] <kennyloggins> >  A basic snap declaring a plug on cups-control
[00:14] <kennyloggins>  so its for printers ?
[00:15] <nacc> kennyloggins: it doesn't do anything, afaict
[00:15] <nacc> kennyloggins: it's a test snap
[00:15] <kennyloggins> okay thanks
[00:15] <nacc> kennyloggins: to test an interface's functionality, in this case the cups-control interface (which is an interface for printing, yes)
[00:22] <kennyloggins> nacc, thanks by the way - can now install 15 snaps ; one after another in one command, cheers pal.
[00:22] <nacc> kennyloggins: sure, that's not really snap specific :)
[00:22] <nacc> kennyloggins: i'm not sure if instll can take multiple snap names or not
[00:22] <nacc> seems like it probably could
[00:28] <kyrofa> elopio, another PR to snappy-m-o
[00:29] <kyrofa> nacc, `snap remove` certainly can
[00:29] <kyrofa> Haven't tried on install
[00:29] <nacc> kyrofa: yeah, me neither :)
[00:29] <nacc> kyrofa: never had a reason, tbh
[00:29] <kyrofa> nacc, me neither
[00:46] <kennyloggins> nacc: that kinda worked ( http://paste.ubuntu.com/25971109/ ) Althou, I think I may have boken pastebin (on the right) :(
[00:50] <nacc> kennyloggins: not sure what you mean by 'right'? it's just a long linne
[01:45] <elopio> snappy-m-o, github subscribe 1719
[01:45] <snappy-m-o> elopio: I'll send you a message if a test fails in the pull request #1719 (many: account for python shebang args in rewrite).
[01:45] <mup> PR #1719: firstboot: add firstboot assertions importing <Critical> <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/1719>
[01:47] <elopio> snappy-m-o, github subscribe 1719
[01:47] <elopio> snappy-m-o, github subscribe 1719
[01:47] <snappy-m-o> elopio: I'll send you updates as tests complete in pull request snapcraft#1719 (many: account for python shebang args in rewrite).
[01:47] <mup> PR snapcraft#1719: many: account for python shebang args in rewrite <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1719>
[01:50] <sergiusens> snappy-m-o github subscribe 1719
[01:50] <snappy-m-o> sergiusens: I'll send you updates as tests complete in pull request snapcraft#1719 (many: account for python shebang args in rewrite).
[01:50] <mup> PR snapcraft#1719: many: account for python shebang args in rewrite <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1719>
[02:01] <mup> PR snapcraft#1719 closed: many: account for python shebang args in rewrite <Created by kyrofa> <Merged by kyrofa> <https://github.com/snapcore/snapcraft/pull/1719>
[02:08] <stgraber> sergiusens: hmm, so just noticed something funny... "version: 2.20" results in a snap of version "2.2" rather than "2.20"
[02:08] <stgraber> sergiusens: updating now to be 'version: "2.20"' which hopefully will fix that issue :)
[02:10] <sergiusens> stgraber oh, yaml; pyyaml parses that as a number; we should probably just update our jsonschema (commented) and enforce the type
[02:11] <sergiusens> kyrofa elopio take a look at snapcraft#1650 again please and I'll merge and tag after the travis tests are done
[02:11] <mup> PR snapcraft#1650: Release changelog for 2.35 <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/1650>
[02:37] <kyrofa> sergiusens, bug #1732076 will still bite us
[02:37] <mup> Bug #1732076: Plainbox snapd test failure <Snapcraft:New> <https://launchpad.net/bugs/1732076>
[02:55] <sergiusens> kyrofa I'll skip the install part in packaging
[02:58] <sergiusens> kyrofa fwiw, i386 runs on lxd
[03:04] <sergiusens> kyrofa actually, I won't skip it, just document it as part of the SRU
[03:04] <sergiusens> at this point I am more interested in releasing a snap
[03:22] <mup> PR snapcraft#1740 opened: tests: add the home plug to the plainbox snap <Created by elopio> <https://github.com/snapcore/snapcraft/pull/1740>
[03:22] <elopio> snappy-m-o autopkgtest 1740 zesty:amd64
[03:22] <snappy-m-o> elopio: I've just triggered your test.
[03:23] <elopio> snappy-m-o github subscribe 1740
[03:23] <snappy-m-o> elopio: I'll send you updates as tests complete in pull request snapcraft#1740 (tests: add the home plug to the plainbox snap).
[03:23] <mup> PR snapcraft#1740: tests: add the home plug to the plainbox snap <Created by elopio> <https://github.com/snapcore/snapcraft/pull/1740>
[03:29] <elopio> snappy-m-o autopkgtest 1740 artful:amd64
[03:29] <snappy-m-o> elopio: I've just triggered your test.
[05:57] <mborzecki> morning everyone
[05:57] <zyga> hey
[05:57] <zyga> how are things?
[05:57] <mborzecki> zyga: hey
[05:58] <mborzecki> things are good, the conference was very nice
[05:58] <mborzecki> did you watch the video streams?
[05:59] <zyga> no, but I'd like to later
[05:59] <zyga> fighting release stuff
[05:59] <zyga> https://forum.snapcraft.io/t/2-29-release-cycle-started/2562/7
[05:59] <mborzecki> uhh
[05:59] <mborzecki> what else have i missed?
[06:02] <zyga> mborzecki: not much I'd say
[06:02] <zyga> mborzecki: we could use some help debugging lxd issues today
[06:02] <zyga> mborzecki: I know about one issue that I'll try to finally address but it seems we have one more
[06:02] <zyga> https://forum.snapcraft.io/t/snapcraft-adt-failures-with-the-new-core-release/2850
[06:03] <mborzecki> looking
[06:04] <zyga> I'm slowly waking up, I was working past midnight
[06:04] <zyga> after kids are in school I'll probably take a nap
[06:05]  * zyga is grumpy because everything fails and needs to be restarted 
[06:06] <zyga> we could use some time on stabilizing those tests
[06:06] <mborzecki> travis again?
[06:06] <zyga> mborzecki: some of our spread tests are flaky
[06:07] <zyga> mborzecki: https://github.com/snapcore/snapd/pulls/ all they yetllow ones failed on some random thing
[06:11] <mborzecki> i'll quickly look through those and see if there's anyting with the tests or just the CI was flaky
[06:13] <mborzecki> zyga: will artful cloud image be good enough for reproducing lxc problem that kyrofa reported?
[06:14] <zyga> mborzecki: I think so
[06:14] <mborzecki> ok
[06:14] <zyga> mborzecki: not sure if he used 16.04 or 17.10
[06:41] <zyga> mvo: good morning
[06:41] <zyga> mvo: some ungood news: https://github.com/snapcore/snapd/pull/4228
[06:41] <mup> PR #4228: interfaces,tests: skip unknown plug/slot interfaces (2.29) <Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/4228>
[06:43] <zyga> mvo: though please look at the diff, we need to see if this actually makes sense
[06:43] <zyga> (I made it after midnight so not super sure)
[06:43] <zyga> I was under the impression that the new load-time validation would handle this
[06:43] <zyga> this is a regression caused by that patch
[06:43] <zyga> it seems we validate a snap and then say "yeah it's broken but I'll load it anywy"
[06:44] <zyga> and this is probably a wider hole to fill
[06:45] <zyga> mvo: other than that we also have the LXD regression, mborzecki and I will look at that (though I'm so sleepy I plan to take a nap for an hour as soon as kids leave)
[06:45] <mvo> zyga: god morning
[06:45] <mborzecki> mvo: hey
[06:46] <mvo> zyga: thanks for the update
[06:46] <mvo> and good morning mborzecki
[06:46] <mvo> zyga: do we know anything more about the lxd issue? does it affect every snap ?
[06:46] <mvo> zyga: I also wonder why our lxd-test did not catch it :/
[06:47] <zyga> mvo: I have some ideas
[06:47] <zyga> mvo: the namespace didn't exist so snap-update-ns just bailed out
[06:47] <zyga> mvo: and there were no content changes to apply
[06:47] <zyga> mvo: this really requires the content interface test
[06:48] <mvo> zyga: and plainbox is using that iface?
[06:48] <zyga> mvo: I'm very convinced that we need to try to run the full test suite on lxd and see what is broken
[06:48] <zyga> mvo: I don't know actually,
[06:48] <zyga> mvo: it's possible
[06:48] <zyga> kissiel: ^
[06:49] <zyga> kissiel: is the checkbox/plainbox snap using content interface?
[06:49] <zyga> mvo: though AFAIK this was a test in snapcraft so perhaps an artificial one
[06:49] <zyga> and obviousl I could be wrong and there's something lurking deeper about why this failed
[06:50] <mvo> zyga: thanks, that is already quite helpful!
[06:53] <mvo> zyga: hm, kyrofa reproduced it for hello-world in lxc so I doubt its the content iface
[06:53] <mvo> zyga: it works via sudo
[06:53] <mvo> zyga: which is also strange but it explains why our test did not catch it, it means a regression test should be simple at least
[06:54] <zyga> mvo: sudo will fix it because the denial was on cap_read_search
[06:54] <zyga> mvo: we are apparently trying to traverse a directory that is not readable to us
[06:54] <zyga> mvo: and then fail on the missing capability
[06:54] <zyga> mvo: sudo will just give us that
[06:54] <zyga> mvo: (not the capability but the read permission)
[06:55] <zyga> mvo: the freezer cgroup setup insie containers is something worth looking at
[06:57] <mvo> zyga: right, I'm trying to modify the lxd test so that we have a reproducer/regression test
[07:00] <zyga> I feel like it's time to crash now, I'll be back closer to 10AM
[07:00] <mvo> zyga: sleep well
[07:11] <mup> PR snapd#4230 opened: tests: add test to run snap inside lxd as a user <Created by mvo5> <https://github.com/snapcore/snapd/pull/4230>
[07:46] <mborzecki> mvo: can i force remove core snap?
[07:59] <mvo> mborzecki: unfortunately not, you can "dpkg --purge snapd" (or fedora has a snap-mgr.sh script that does the same) to remove all snaps
[08:01] <mvo> zyga: just fyi, adding "capability dac_read_search" is not sufficient to fix the lxd issue
[08:01] <mborzecki> hmm cgroup freezer directories are left behind once a snap runs (is that ok?), anyways, when a snap is run with sudo, it will be possible to create a directory under /sys/fs/cgroup/freezer
[08:01] <mvo> mborzecki: yeah, see 4230, we have a lxd test but unfortunately it runs as root so it did not catch the bug
[08:13] <mborzecki> omg, broke lxd
[08:14] <mborzecki> i restarted an ephemeral container, now i can't remove it nor stop if
[08:14] <mborzecki> exec doesn't work either
[08:24] <mup> PR snapd#4231 opened: interfaces: add "refresh-schedule" attribute to snapd-control <Created by mvo5> <https://github.com/snapcore/snapd/pull/4231>
[08:50] <zyga> re
[08:52] <zyga> mvo: any news?
[08:56] <mborzecki> zyga: snap-confine is setuid root right?
[08:56] <mvo> zyga: not much, we have a reproducer
[08:56] <mvo> zyga: in spread
[08:57] <zyga> mborzecki: yes
[08:57] <zyga> mvo: aha, that's good
[08:57] <mborzecki> https://paste.ubuntu.com/25973100/
[08:57] <mborzecki> i build this, make it chown root:root, u+s, and cannot create a frezer group
[08:58] <mvo> zyga: and the apparmor denial is not it, I added it for testing to snap-confine.appamor.in and it still fails
[08:59] <mvo> zyga: with permission denied but no apparmor denial anymore
[09:00] <zyga> mvo: I'm running your test locally now
[09:00] <mvo> zyga: cool
[09:11] <mup> PR snapd#4232 opened: store: add support for flags in ListRefresh() <Created by mvo5> <https://github.com/snapcore/snapd/pull/4232>
[09:12] <mvo> zyga: silly question, could we revert the freezer group in 2.29? or would that cause havoc?
[09:13] <zyga> mvo: I think a bit havoc, I'd have to look
[09:14] <mvo> zyga: hm, then lets see if we can do a proper fix
[09:18] <zyga> mvo: hmm, the container is weird
[09:18] <zyga> I cannot switch to "ubuntu" user
[09:20]  * kalikiana coffee
[09:20] <zyga> mvo: I know what the problem is, I think
[09:20] <zyga> stgraber: around?
[09:23] <zyga> mvo: http://pastebin.ubuntu.com/25973198/
[09:24] <zyga> mvo: so two ideas for quick "solution":
[09:24] <zyga> mvo: 1) make that step optional and let it fail, this means mount changes are not atomic in lxd
[09:24] <zyga> mvo: 2) talk to stgraber and figure out why lxd sets up containers this way and what we can do about it
[09:26] <zyga> mvo, mborzecki: opinions?
[09:26] <mborzecki> hmm that's why g+s works i guess
[09:27] <zyga> mborzecki: correct
[09:29] <zyga> mvo: it's actually a deeper problem:
[09:29] <zyga> root@my-ubuntu:~# ls -ld /sys/fs/cgroup/devices/
[09:29] <zyga> drwxrwxr-x 5 nobody root 0 Nov 16 09:13 /sys/fs/cgroup/devices/
[09:29] <zyga> mvo: unless we somehow disabled all udev tagging inside containers
[09:30] <zyga> mvo: it will break on when creating the device cgroup
[09:30] <zyga> s/on//
[09:31] <mborzecki> that's perhaps silly, but could we g+s snap-confine too? we're dropping both anyway right after setting up
[09:32] <zyga> mborzecki: that's another option, indeed
[09:32] <zyga> though I'd like to understand the motivation behind lxd choices
[09:33] <Chipaca> moin moin
[09:33] <zyga> Chipaca: hello
[09:33] <mborzecki> Chipaca: hey
[09:33] <zyga> Chipaca: welcome to the fire dept
[09:33] <zyga> Chipaca: pick your hose and let's put out the fires ;)
[09:34] <Chipaca> oh dear
[09:34] <Chipaca> zyga: what's on fire?
[09:34] <zyga> Chipaca: lxd
[09:34] <zyga> https://forum.snapcraft.io/t/snapcraft-adt-failures-with-the-new-core-release/2850/12
[09:36] <zyga> Chipaca: also snapd crashes:
[09:36] <zyga> https://bugs.launchpad.net/snappy/+bug/1732555
[09:36] <mup> Bug #1732555: Installing bad snap has snapd crashing <Snappy:In Progress by zyga> <https://launchpad.net/bugs/1732555>
[09:37] <zyga> Chipaca: that one needs some love from pstolowski and perhaps you, something went south very much whe we switched to "validate on load"
[09:37] <mvo> zyga: hm, reading backlog. sorry, my laptop came back from repair just now (doorbell and all that)
[09:37] <zyga> Chipaca: I'm a bit sleepy still
[09:37] <zyga> mvo: great, did they hide that cable?
[09:37] <Chipaca> zyga: both of those claim to have a fix in a pr; is the fire putting out effort needed from me to review those prs?
[09:38] <zyga> mvo: btw I opened mine and I think I know why your cable was sticking out, there's a compartment for that cable where it's supposed to be held and be attached, if that part is loose it can easily slide through the hinge
[09:38] <mvo> zyga: yeah, its not longer visible, I wonder where they put it, I'm inclined to open the machine to see what happend to it. but opening the modern ones is a pita (IMO) so I probably won't
[09:38] <zyga> Chipaca: lxd is not fixed yet
[09:38] <mvo> zyga: aha, nice
[09:38] <zyga> Chipaca: and the snapd crash is just fixing the immediate problem, the deeper problem is not addresed
[09:38] <zyga> Chipaca: it seems the validate-on-load concept is validate-and-log-but-continue-anyway
[09:39] <mvo> zyga: I had it open before and tried to figure out where it belonged but couldn't find an obvious place and was too impatient then
[09:39] <zyga> mvo: I bought a x240 for a family member and I opened it to clean it and replace the heatsink thermal glue
[09:39] <zyga> mvo: (interestingly no internal battery there)
[09:40] <zyga> anyway
[09:42] <pstolowski> zyga, i'll look into this, thanks for the intermediate fix
[09:43] <zyga> pstolowski: thank you
[09:54] <mup> PR snapd#4229 closed: interfaces,tests: skip unknown plug/slot interfaces <Critical> <Created by zyga> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/4229>
[10:03]  * zyga is doing code reviews
[10:04] <zyga> mvo: offtopic, do you remember that zesty issue with the repair systemd unit?
[10:04] <zyga> mvo: is that something that needs love?
[10:04] <zyga> pstolowski: FYI: https://github.com/snapcore/snapd/pull/4228
[10:04] <mup> PR #4228: interfaces,tests: skip unknown plug/slot interfaces (2.29) <Critical> <Created by zyga> <https://github.com/snapcore/snapd/pull/4228>
[10:05] <zyga> pstolowski: 2.29 backport of that PR
[10:05] <mvo> zyga: I remember it, I thought it was conditionally dislabed and that would not put things into degraded state
[10:06] <mup> PR snapd#4228 closed: interfaces,tests: skip unknown plug/slot interfaces (2.29) <Critical> <Created by zyga> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/4228>
[10:06] <mvo> zyga: iirc I checked on a fresh VM
[10:06] <zyga> mvo: aha, thank you
[10:06] <zyga> mvo: I requested your review on https://github.com/snapcore/snapd/pull/4227 as you looked into framebuffers on pi recently
[10:06] <mup> PR #4227: tests: add test for frame buffer interface <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/4227>
[10:12] <mvo> zyga: sure, I have a look
[10:15] <zyga> Chipaca: https://github.com/snapcore/snapd/pull/4225
[10:15] <mup> PR #4225: cmd/snap-update-ns: tweak changePerform <Created by zyga> <https://github.com/snapcore/snapd/pull/4225>
[10:21] <Chipaca> zyga: +1
[10:25] <ackk> zyga, addressed all your comments on https://github.com/snapcore/snapd/pull/4219
[10:25] <mup> PR #4219: snap/validate: extend socket validation tests <Created by albertodonato> <https://github.com/snapcore/snapd/pull/4219>
[10:27] <zyga> ackk: thank you, I'll look now
[10:28] <mup> PR snapd#4225 closed: cmd/snap-update-ns: tweak changePerform <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4225>
[10:30] <mup> PR snapd#4185 closed: interfaces/builtin/account_control: use gid owning /etc/shadow to setup seccomp rules <Created by bboozzoo> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4185>
[10:40] <pstolowski> zyga, i think i've a proper fix for the bad plugs/slots. interestingy it uncovered an small issue with api tests after all these change
[10:40] <pstolowski> s
[10:41] <zyga> pstolowski: interesting
[10:42] <zyga> pstolowski: I'll gladly review the PR
[10:58] <mvo> a second review for 4232 and 4231 would be great
[10:58] <zyga> mvo: I could use a few reviews
[10:59] <mborzecki> i can take a look
[10:59] <zyga> mvo: this one is interesting: https://github.com/snapcore/snapd/pull/4224
[10:59] <mup> PR #4224: cmd/snap-update-ns: teach update logic to handle synthetic changes <Created by zyga> <https://github.com/snapcore/snapd/pull/4224>
[10:59] <zyga> mvo: the code change is tiny in one function, the rest are just tests
[11:00] <mvo> zyga, ok, looking. was about to jump to reviews anyway while me laptop restores its backup
[11:06] <mup> PR snapcraft#1740 closed: tests: add the home plug to the plainbox snap <Created by elopio> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1740>
[11:10] <mup> PR snapd#4233 opened: interfaces: remove invalid plugs/slots from SnapInfo on sanitization <Created by stolowski> <https://github.com/snapcore/snapd/pull/4233>
[11:10] <pstolowski> zyga, ^
[11:14] <zyga> pstolowski: looking
[11:20] <mborzecki> ok, conference report sent, back to snapd now
[11:20] <zyga> pstolowski: reviewed
[11:20] <mborzecki> zyga: so what do we do with lxd?
[11:21] <zyga> I'd like to discuss this with stgraber
[11:21] <zyga> setuid is problematic in itself
[11:21] <pstolowski> zyga, thanks!
[11:30]  * Chipaca ~> haircut, and lunch
[11:42] <Saviq> popey: hey, what GUI snaps would you recommend to try out?
[11:42] <popey> What's the goal?
[11:47]  * Chipaca aborts haircut plans
[11:51] <mborzecki> TestExecInCoreSnapUnsetsDidReexec fails on me with arch
[11:51] <zyga-solus> mborzecki: maybe it assumes ubuntu and lacks mocking?
[11:51] <zyga-solus> mborzecki: thank you for running that on arch
[11:51] <zyga-solus> let me try on solus
[11:51] <mborzecki> in ExecInCoreSnap(), should SNAP_DID_REEXEC be unset in all early exit paths?
[11:52] <zyga-solus> mborzecki: I don't know, sorry
[11:52] <zyga-solus> ikey: any chance for F57 soon? ^_^
[11:53] <Saviq> popey: evaluating X11 over SSH
[11:53] <ikey> its in unstable zyga-solus
[11:54] <ikey> we sync on fridays
[11:54] <zyga-solus> ikey: thank you! :) I cannot wait to see that
[11:54] <ikey> its pretty banging
[11:54] <mborzecki> mvo: you fixed the bug, so I assume ou know something about SNAP_DID_REEEXEC ;)
[11:54] <zyga-solus> ikey: so I heard
[11:54] <ikey> https://plus.google.com/+Solus-Project/posts/LGDbWGGnGs2
[11:54] <zyga-solus> mborzecki: FYI, that test passes on solus
[11:55] <ikey> unfortunately we couldn't do a simple cherry-pick for firefox to get it in early
[11:55] <ikey> depends on new stuff like dbus + xcb + x11 + co
[11:55] <ikey> big chain
[11:55] <ikey> and right now im rebootstrapping the solus toolchain
[11:55] <mborzecki> zyga-solus: thx for checking
[11:55] <popey> Saviq: pycharm-community, mailspring, wavebox, ohmygiraffe, chromium.. good enough to get on with?
[11:59]  * zyga-solus sees one unit test failing on solus, let's fix that
[11:59] <zyga-solus> but while tests run, it's tea time!
[12:15] <Saviq> popey: sure, thanks
[12:27] <zyga-solus> pstolowski: +1
[12:27] <zyga-solus> pstolowski: can you please do a 2.29 backport as well, feel free to rebase+squash this PR for simplicity
[12:27] <zyga-solus> mvo: can you do a 2nd review of 4233 with the extra changes, for sanity please?
[12:28] <zyga-solus> jdstrand: good morning :)
[12:31] <mborzecki> zyga-solus: SnapMountDir must be /snap in solus apparently
[12:31] <zyga-solus> mborzecki: yes, that's right
[12:31] <mborzecki> the test should fail on fedora too then
[12:31] <zyga-solus> mborzecki: perhaps neal patched it, I haven't used fedora actively lately
[12:33] <ikey> SnapMountDir never wasn't /snap in our snapd
[12:33]  * ikey is confused
[12:33]  * ikey also can't english today
[12:33] <zyga-solus> ikey: it's all good
[12:33] <zyga-solus> ikey: just chasing an unit test without mocking that mborzecki found while running arch
[12:33] <ikey> ah
[12:37] <diddledan> ikey: English you good done!
[12:37] <ikey> thanks much they have do
[12:38]  * diddledan looks to see what podcasts he has waiting to be heard
[12:38] <diddledan> ah there we go. a nice shiny new bad voltage
[12:41]  * ikey occupies himself with watching llvm build
[12:41] <diddledan> ooh, that sounds almost like Gentoo :-p
[12:42] <ikey> nah gentoo is for newbs
[12:42] <ikey> :P
[12:42] <ikey> someone else has already done the packaging for you at that point :p
[12:42]  * ikey wouldn't object to someone else doing this for him though.
[12:46] <ikey>  12:46:18 up 13:26,  1 user,  load average: 10.95, 9.48, 6.76
[12:46] <ikey> ow. xD
[12:49] <zyga-solus> ikey: are you on gentoo now? :D
[12:50] <ikey> nah on solus
[12:50] <ikey> the laptop is taking offence to being used as a build machine
[12:51] <zyga-solus> ikey: maybe get one of those $9 chip clusters ;)
[12:51] <ikey> heh
[12:51] <ikey> fwiw ive already built gcc on this thing today as well
[12:52] <ikey> running out of compilers to compile..
[12:52] <zyga-solus> ikey: think about the gcc CI machine
[12:52] <zyga-solus> poor thing :)
[12:52] <ikey> lo, ya
[12:52] <ikey> *lol
[12:53] <ikey> then again they use SVN
[12:53] <ikey> so they kinda bring pain on themselves
[12:53] <zyga-solus> again?!?
[12:53] <zyga-solus> next up: more shards of glass under our fingertips
[12:53] <ikey> yeah i was checking out https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=248032 earlier
[12:54] <jdstrand> zyga-solus: good morning :)
[12:54] <jdstrand> zyga-solus: or rather, good afternoon :)
[12:54] <zyga-solus> jdstrand: we had some drama in the morning, the interface part seems to be addressed now but we are still in the red in lxd
[12:54] <jdstrand> yeah, saw that
[12:55] <Chipaca> is https://forum.snapcraft.io/t/snapd-fails-to-update-lxd/2858 the same lxd issue?
[12:55]  * ikey adds appropriately topical and dramatic musical backdrop to zyga-solus's words
[12:55] <diddledan> emerge glibc binutils gcc && emerge glibc binutils gcc <-- back in the day that was the required encantation to ensure Gentoo consistency (IIRC)
[12:55] <ikey> https://www.youtube.com/watch?v=Wmc8bQoL-J0
[12:55] <diddledan> incantation*
[12:55] <ikey> diddledan, yeah ive done binutils already lol
[12:55] <diddledan> \o/
[12:55] <ikey> 2.29.1
[12:55] <zyga-solus> ikey: just say everything I write with hollywood trailer voice
[12:55] <mvo> mborzecki, I have a look at this reexec in a little bit but strange that it fails on arch and not ubuntu
[12:55] <ikey> lol
[12:55] <mup> PR snapd#4234 opened: snap: use field names when initializing composite literals <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4234>
[12:56] <zyga-solus> Chipaca: not sure, I just saw that
[12:56] <mborzecki> trivial PR ^^ if anyone wants to take a look
[12:56]  * ikey will send off binutils and gcc again once this llvm finishes..
[12:56] <mborzecki> mvo: opening PR in a minute, added some mocks to workaround this
[12:57] <diddledan> I hope your laptop is on a desk rather than your knees :-p *hothothot*
[12:57] <ikey> not sure the battery would last the time it took to move between the desk and the sofa
[12:57] <ikey> nowadays its permanently plugged in
[12:57] <ikey> and hooked up to my 4k monitor
[12:57] <ikey> (keyboard/mouse/everything external)
[12:57] <ikey> its like the most ironic laptop
[12:57] <Chipaca> mborzecki: i thought that was written `snap.R(20)`
[12:58] <pedronis> yes
[12:59] <mborzecki> Chipaca: yes/no/maybe, let me check
[12:59] <pedronis> at least that is what we usually do
[12:59] <pstolowski> zyga-solus, thanks. will do 2.29pr
[13:00] <mborzecki> yup, i'll update the PR
[13:03] <Chipaca> hmm, ho seems stucjk
[13:06] <mup> PR snapd#4235 opened: cmd: pretend we're running on Ubuntu in TestExecInCoreSnapUnsetsDidRe… <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/4235>
[13:30] <mup> PR snapcraft#1650 closed: Release changelog for 2.35 <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1650>
[13:36] <Chipaca> niemeyer: https://www.youtube.com/watch?v=BHTxzn4YL6o
[13:41]  * kalikiana taking a short break
[13:55] <kyrofa> Mornin folks
[14:01] <kyrofa> sergiusens, things finally looking up this morning?
[14:02] <pedronis> mvo: I did mark the things in the roadmap for 2.30 with 2_30
[14:03] <pedronis> Chipaca: is this done https://forum.snapcraft.io/t/expose-a-more-consistent-subset-of-systemds-service-directives/2268 ? considering that we have also this one now https://forum.snapcraft.io/t/support-for-snapctl-stop-start-restart-services/1908
[14:06] <mvo> pedronis: excellent, thank you
[14:07]  * kalikiana waves at kyrofa 
[14:08] <pedronis> mvo: Chipaca: this is done for now:  https://forum.snapcraft.io/t/should-we-use-polkit-for-local-auth/1206  ?
[14:08] <mvo> pedronis: yes, that has landed
[14:08] <mvo> pedronis: iirc 2.28
[14:10] <Chipaca> pedronis: it is not done
[14:10] <Chipaca> pedronis: the first one i mean, not even started
[14:10] <kyrofa> Hey there kalikiana
[14:11] <pedronis> Chipaca: ah, I confused what it was, sorry
[14:11] <Chipaca> =)
[14:11] <Chipaca> pedronis: 2.30 for that one might be too soon though
[14:11] <pedronis> Chipaca: yes
[14:12] <Chipaca> not sure i'm going to get to it (pretty sure i'm going to be elbow-deep in snapshots)
[14:12] <pedronis> Chipaca: are aliases the last bit missing for tab completion for snaps?
[14:12] <pedronis> Chipaca: feel free to put to backlog if that's the case
[14:16] <Chipaca> pedronis: aliases are done
[14:16] <abeato> mvo, jdstrand, hi, I have a question about the emergency repair assertion, does it need to be signed by Canonical? Or not necessarily and it can be created by the brand-id that signed the model assertion?
[14:16] <Chipaca> i don't think there's anything else
[14:16] <pedronis> Chipaca: but not released? so 2.30, right?
[14:16] <Chipaca> pedronis: correct
[14:16] <pedronis> thanks
[14:16] <Chipaca> it even says as much :-)
[14:16] <Chipaca> “Tab completion of aliases is enabled transparently from snapd 2.30 (the completer should only see the dealiased command).”
[14:17] <pedronis> pstolowski: what's the status of this https://forum.snapcraft.io/t/declaratively-defining-environment-variables/175/23 it's marked backlog but worked happened on it
[14:19] <pstolowski> pedronis, right, it's done
[14:19] <pstolowski> pedronis, hold on
[14:20] <pstolowski> pedronis, i need to check entire thread in case there was more than just this bugfix
[14:20] <pedronis> yea, np
[14:21] <pedronis> also there's snapcraft part to it
[14:27] <zyga-solus> Chipaca: I requested your review on two PRs
[14:28] <jdstrand> abeato: I defer to mvo
[14:29] <abeato> ok
[14:31] <zyga-solus> mvo: I replied to brauner on the thread
[14:31] <zyga-solus> mvo: not sure how to understand what we should (or not) do
[14:38] <mvo> abeato: currently it needs to be signed by canonical. phase-2 would allow others to sign it but we are not there yet
[14:38] <mvo> zyga-solus: thank you
[14:43] <abeato> mvo, got it, when is phase-2 planned to happen?
[14:46] <mvo> abeato: we have no firm timeline for this yet unfortunately
[14:46] <pedronis> it also depends how self-service it needs to be
[14:46] <mvo> abeato: indeed, what pedronis said -^
[14:48] <abeato> pedronis, mvo I would expect that the owner of the model (creator of the image) would be able to send emergency fixes as required, from their own store
[14:49] <pedronis> there is no timeline on that, it would also need store work
[14:51] <abeato> got it, thanks
[15:01] <mup> PR snapd#4236 opened: Reject bad plugsslots 229 <Created by stolowski> <https://github.com/snapcore/snapd/pull/4236>
[15:07] <Chipaca> zyga-solus: i'm not seeing the notification for that
[15:07]  * Chipaca pokes
[15:09] <kyrofa> sergiusens, the release notes are missing the "using a remote lxd instance" demo
[15:10] <kyrofa> Ah, I got it
[15:16] <kyrofa> sergiusens, dumb question: is it actually "dotnet" or .NET ?
[15:16] <kyrofa> The plugin name is obvious, but when used in a phrase
[15:16] <kyrofa> I thought it was .NET
[15:17] <zyga-solus> Chipaca: you should be able to on: https://github.com/snapcore/snapd/pulls/review-requested/chipaca
[15:18] <Chipaca> zyga-solus: ! thank you
[15:18] <zyga-solus> it's an useful link :)
[15:24] <zyga-solus> mvo: hey
[15:24] <zyga-solus> mvo: around?
[15:24] <zyga-solus> mvo: I'm playing with containers
[15:26] <om26er> jdstrand: I think that android studio is now good to be allowed 'classic' following Alan's reply.
[15:26] <sergiusens> kyrofa dotnet
[15:27] <sergiusens> kyrofa err, the command is dotnet... the infra is .NET core
[15:27] <sergiusens> kyrofa the release notes are in draft for a reason :-)
[15:27] <sergiusens> kyrofa waiting on kalikiana for that video link (unless I missed it)
[15:28] <kyrofa> sergiusens, I fixed it
[15:28] <kyrofa> sergiusens, I'll fix the .NET ones as well
[15:28] <sergiusens> kyrofa elopio btw, `snap install mailspring` and email problems will be a problem of the past
[15:28] <elopio> sergiusens: so, this was all because we didn't make a lot of noise when we implemented that "snap install core || echo ignoreerror" workaround?
[15:28] <elopio> sergiusens: isn't mailspring just as nylas? They have your emails on their server?
[15:29] <sergiusens> elopio it is local
[15:29] <sergiusens> elopio no, this is different
[15:29] <ikey> and less JS heavy than the old thing
[15:29] <elopio> I will check it out.
[15:30] <sergiusens> elopio it is faster than any other email client I've used and it actually does not lie about unread emails as I have been seeing on other clients using imap
[15:30] <mvo> zyga-solus: back now, I was in a meeting
[15:31] <kalikiana> sergiusens: I sent it in email yesterday
[15:31] <kalikiana> in the gist
[15:31] <ikey> [Package] Creating /home/build/work/llvm-32bit-5.0.0-53-1-x86_64.eopkg ...
[15:31]  * ikey sobs with relief
[15:32] <sergiusens> ikey failed, out of space
[15:32] <ikey> no dont lol
[15:32] <ikey> it failed the first time
[15:32] <sergiusens> cleaning up
[15:32] <sergiusens> lol
[15:32]  * ikey almost cried
[15:33] <kalikiana> sergiusens: wait, I see it in the "is here"...  did you mean another video?
[15:34] <sergiusens> kalikiana I am not following on that last comment
[15:34] <kalikiana> sergiusens: you said "waiting on kalikiana for that video link"
[15:35] <zyga-solus> mvo: thank you for the notice, I wanted to say that the issue with LXD is not so clear cut anymore
[15:35] <sergiusens> kalikiana no, no other video
[15:35] <kalikiana> sergiusens: I see the video on the "snapcraft 2.35 is here" page
[15:36] <mvo> zyga-solus: how do you mean?
[15:36] <Chipaca> mvo: +1! and then suddenly -1
[15:36] <zyga-solus> mvo: I don't think I know what's really going on
[15:36] <Chipaca> mvo: (on #4232)
[15:36] <mup> PR #4232: store: add support for flags in ListRefresh() <Created by mvo5> <https://github.com/snapcore/snapd/pull/4232>
[15:36] <zyga-solus> https://forum.snapcraft.io/t/snapcraft-adt-failures-with-the-new-core-release/2850/33
[15:36] <zyga-solus> mvo: look at the last few posts
[15:37] <zyga-solus> and lxd itself is fun (for unmagic regular software)
[15:37] <mup> PR snapd#4237 opened: debian: add missing udev dependency <Created by mvo5> <https://github.com/snapcore/snapd/pull/4237>
[15:38] <mvo> Chipaca: uh, thank you! I will fix this
[15:38] <Chipaca> :-)
[15:41] <mup> PR snapd#4231 closed: interfaces: add "refresh-schedule" attribute to snapd-control <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4231>
[15:42] <mvo> zyga-solus: just read the backlog, did you see brauners suggestion about the mount-namespace-capture-helper profile?
[15:42] <kalikiana> sergiusens: btw if it was you who made my bits 10 times better, thank you so much for that. Tons better!
[15:43] <zyga-solus> mvo: no, where was that?
[15:43] <kalikiana> sergiusens: are the "empty" sections still to be filled in?
[15:43] <mvo> zyga-solus: just 2min ago, maybe you need to reload
[15:43] <zyga-solus> ah, not here on IRC
[15:43]  * zyga-solus looks at the forum
[15:44] <mvo> Chipaca: thanks for the suggestions in the PR - so you suggest that I use "type RefreshOptions struct {RefreshManaged bool}' instead?
[15:44] <mvo> Chipaca: instead of bit-flags?
[15:45] <Chipaca> mvo: yep
[15:46] <Chipaca> mvo: or if you think the bitfield means a smaller refactor, give it a IsRefreshManaged() bool, that does the check
[15:46] <Chipaca> either is fine, but over time we've moved to structs for flags
[15:46] <Chipaca> (there might be bitfields still somewhere though)
[15:46] <Chipaca> (dunno, haven't hunted)
[15:46] <mvo> Chipaca: I go for the struct, the fact that I messed up the bitfield sounds like a good reason against it
[15:46] <Chipaca> :-)
[15:47] <Chipaca> mvo: memorywise it's the same
[15:48]  * kalikiana needs to hop on a tram, will be back in a bit
[15:50] <mvo> Chipaca: interessting
[15:50] <mvo> Chipaca: anyway, refactoring now, thanks for your input!
[15:53] <jdstrand> om26er: I'll take a look, thanks
[15:53] <zyga-solus> mvo: I'm running out of ideas on LXD
[15:54] <mvo> zyga-solus: what are we using the freezer group for in 2.29? is it allready criticial (I assume yes but want to double check)
[15:55] <zyga-solus> mvo: it's done so that mount changes are atomic
[15:55] <zyga-solus> mvo: and we also use it to detect (but not yet act on) stale namespaces when the base snap changes revision
[15:55] <mvo> zyga-solus: what did we do in 2.28 for mount changes?
[16:00] <zyga-solus> mvo: we didn't do certain kids
[16:00] <zyga-solus> mvo: and they were racy
[16:00] <mvo> zyga-solus: right, mostly asking to see if revert is an option until we have a handle on this. but lets keep digging and hoping that stgraber has an idear
[16:00] <mvo> idea
[16:01] <zyga-solus> mvo: I think it's a jdstrand question
[16:01] <zyga-solus> mvo: the base snap staleness we can ignore for now (it's not live)
[16:01] <zyga-solus> mvo: the race prevention was a direct request from him
[16:01] <mvo> zyga-solus: ok
[16:02] <mvo> zyga-solus: well, I think of course ideally we would make it work under lxd, but the lack of ideas is slightly worrying :)
[16:02] <zyga-solus> mvo: I don't know what's going on really
[16:02] <zyga-solus> mvo: it feels like apparmor but I don't even see the capability dac_read_search denial anymore
[16:05] <mborzecki> this may sound crazy but I tried using this: https://paste.ubuntu.com/25975053/ then on the hose enable trace basically all, and then kill -CONT in the container
[16:06] <mborzecki> zyga-solus: maybe this will give you some ideas
[16:07] <zyga-solus> mborzecki: sorry, I don't understand
[16:08] <mborzecki> that paste is a minimal sample that fails under lxd, extracted from our code
[16:08] <zyga-solus> aha
[16:08] <mborzecki> then in the container i run this process and tell it to create a frezer cgroup, it will stop with SIGSTOP
[16:08] <Chipaca> mvo: you made it a pointer to keep the refactor down?
[16:08] <zyga-solus> and you ran this setuid root?
[16:08] <zyga-solus> as a user
[16:08] <mborzecki> yup
[16:09] <zyga-solus> mborzecki: can you please add that to the thread on the forum where brauner reads this?
[16:09] <mborzecki> then on the host i try trace-cmd -e all -P <pid-translated-to-global-ns>
[16:09] <mvo> Chipaca: yeah, I can change it to by value if you prefer, will make the call sites looks a bit more ugly (or a bit more clear depending on POV)
[16:09] <mborzecki> zyga-solus: ok
[16:09] <mvo> Chipaca: do you prefer the non-pointer approach?
[16:09] <Chipaca> mvo: 's fine
[16:10] <Chipaca> mvo: very marginal preference for passing by value (with a for-convenience default flags object maybe)
[16:10] <Chipaca> mvo: i already +1'ed before asking, that's how much i care about this :-)
[16:10] <mvo> Chipaca: ok, I don't mind either way so lets go with it until someone else objects :)
[16:12] <mvo> pedronis: your input on 4222 would be great
[16:14] <mup> PR snapd#4219 closed: snap/validate: extend socket validation tests <Created by albertodonato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/4219>
[16:35] <stgraber> zyga-solus: what's up?
[16:37] <zyga-solus> stgraber: hello
[16:37] <zyga-solus> stgraber: we're trying to understand an issue we found after 2.29.3 went to stable
[16:38] <zyga-solus> stgraber: it's happening here: https://forum.snapcraft.io/t/snapcraft-adt-failures-with-the-new-core-release/2850/48 -- brauner is helping us
[16:42] <stgraber> yeah, he just sent me that link
[16:48] <zyga-solus> jdstrand: hey, if you have a sec please look at the forum thread linked above
[16:50] <zyga-solus> mvo: I think the issue is understood and we have a solution on our plate
[16:51] <pedronis> mvo: was in  a meeting
[16:54] <mup> PR snapd#4237 closed: debian: add missing udev dependency <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4237>
[17:02] <zyga-solus> jdstrand, mvo, stgraber: I'm running a spread run with g+s, let's see what happens
[17:06] <pedronis> mvo: added some comments
[17:08] <zyga-solus> mvo: the outlook on LXD issue (the more recent one) is that we'll have a patch later today and will need to go through a round of review
[17:08] <zyga-solus> mvo: expect it to be semi-landable tomorrow
[17:09] <Chipaca> mvo: zyga means through a security review there i think
[17:10] <pedronis> mvo: was this fixed:  https://forum.snapcraft.io/t/spread-cron-is-not-running-snapd-vendor-sync/2739 ?
[17:11] <zyga-solus> Chipaca: I think the review will be very detailed as it's not a minor change
[17:11] <zyga-solus> well
[17:12] <zyga-solus> it's a small change with major consequences
[17:13] <kyrofa> sergiusens, can we start landing PRs for 2.36?
[17:17] <mvo> zyga-solus: yay, understood sounds great
[17:17] <zyga-solus> :)
[17:17] <zyga-solus> that single test case passes, I'm running all of main and adjusting for this (some parts need to go)
[17:23] <sergiusens> kyrofa I thought first came elopio's testing one and then we'd all rebase
[17:23] <sergiusens> elopio ETA for that?
[17:24] <kyrofa> sergiusens, sounds lovely
[17:25] <elopio> sergiusens: let me finish the council meeeting, and I'll rebase.
[17:26] <elopio> so, 1 hour. Hopefully the merge is easy
[17:45] <popey> Guys, I have a snap which is doing my head in. Files (executables) are not being copied from stage to prime. They exist in stage just fine, but never end up in prime or the resulting snap.
[17:46] <popey> Is there some rule about what gets copied from stage to prime which will eliminate things?
[17:47] <nacc> popey: i think that would be plugin specific? (/me is not a snap developer)
[17:47] <nacc> popey: do you have the yaml handy?
[17:47] <popey> plugin specific? I dont understand how
[17:48] <nacc> popey: i though the plugins implement the lifecycle, e.g. what actually happens at each point, so stage, prime, snap: https://docs.snapcraft.io/build-snaps/plugins
[17:48] <nacc> (going by docs)
[17:49] <sergiusens> popey things in stage have to come from a part
[17:49] <popey> I'm using autotools plugin but overriding with prepare, build and install
[17:49] <popey> yeah, the part builds the app, it gets to stage just fine
[17:49] <popey> but then gets lost between stage and prime
[17:50] <sergiusens> it should just work then; does it exist in parts/<part-name>/install ?
[17:50] <popey> yes
[17:50] <sergiusens> popey wait, is it a file which would be considered hidden?
[17:50] <sergiusens> starts with dot
[17:50] <popey> no, bunch of executables
[17:51] <kyrofa> popey, any chance this is public?
[17:51] <popey> i haven't investigated all the missing files, but the primary executable is the main one missing and that's a big problem
[17:51] <popey> it can be. it takes ~20+ mins to build on my 64GB i7
[17:51] <kyrofa> even just a peek at the YAML would be interesting
[17:51] <sergiusens> hmm, out of quick ideas and heading out to rehab (knee, don't get ideas); so I'll leave it to kyrofa to continue the "interrogation"
[17:52] <kyrofa> sergiusens hurt his knee doing drugs, FYI
[17:52] <sergiusens> popey teleconsole ftw ;-)
[17:52] <popey> hehe
[17:52] <popey> funnily enough wimpy is teleconsoled in right now watching it
[17:52] <popey> i did cleanbuild though so all thrown away in this build
[17:52] <mcphail> sergiusens: "don't do snaps kids"
[17:53]  * popey seals up the woodwork, less more come out
[17:53] <popey> *lest?
[17:53] <kyrofa> sergiusens, we call that "physical therapy" around here :P
[17:53] <popey> ok, am kicking off another build as a container build so I can keep the artifacts
[17:56] <Chipaca> zyga-solus: jinx!
[17:56] <Chipaca> zyga-solus: except instead of commenting i cherry-picked and pushed
[17:57] <Chipaca> and now I'll kinda-EOD; will check back to merge that if it's green
[17:59] <zyga-solus> Chipaca: :D
[17:59] <zyga-solus> Chipaca: thank you!
[17:59] <zyga-solus> Chipaca: I saw that just a few seconds after I commented
[17:59] <zyga-solus> Chipaca: I'll do that :)
[17:59] <zyga-solus> Chipaca: enjoy your evening
[17:59] <mup> PR snapd#4233 closed: interfaces: remove invalid plugs/slots from SnapInfo on sanitization <Created by stolowski> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4233>
[18:02] <mup> PR snapd#4232 closed: store: add support for flags in ListRefresh() <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4232>
[18:04] <mup> PR snapd#4215 closed: HACKING: fix path in snap install <Created by asalminen> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4215>
[18:08] <zyga-solus> jdstrand: do you have some time for 2nd look on https://github.com/snapcore/snapd/pull/4169 today?
[18:08] <mup> PR #4169: cmd/snap-update-ns: add secureMkfileAll <Created by zyga> <https://github.com/snapcore/snapd/pull/4169>
[18:10] <jdstrand> zyga-solus: I'm trying
[18:12] <jdstrand> zyga-solus: for the setgid. I think the coding changes are that we limit setguid to that own chown. so, as early as possible we temporarily drop, then right before the fchown, we raise, then right after, we temporarily drop. we then let the current code let us drop permanently
[18:12] <jdstrand> s/own chown/one chown/
[18:13] <zyga-solus> jdstrand: ah, interesting, so effectively minimize the changes to the current behaviour
[18:13] <jdstrand> zyga-solus: that happens to be the safest thing to do, but also will have the smallest code impact
[18:13] <jdstrand> exactly
[18:13] <zyga-solus> jdstrand: I was thinking about going all the way in by dropping the chown code entirely
[18:13] <zyga-solus> jdstrand: we can consider that for future improvement
[18:14] <jdstrand> zyga-solus: I was thinking of that too, but its hard to think through setuid, sudo, non-sudo for both inside and outside of lxd
[18:14] <zyga-solus> yes, it certainly needs more time
[18:14] <jdstrand> it would have to be carefully and methodically worked through
[18:15] <zyga-solus> jdstrand: I'll prepare the patch as you suggested initially for tomorrow
[18:15] <zyga-solus> (today I'm just gardening PRs)
[18:15] <jdstrand> zyga-solus: you probably recall that we temp drop uid and reraise in the codebase. you can look at that for inspiration
[18:16] <mvo> pedronis: thanks for your review. I addressed the raised points now
[18:16] <zyga-solus> jdstrand: yes, totally
[18:21] <mvo> zyga-solus: silly question, I commented out the fchown code as a test but that was not enough, but I guess thats known, right?
[18:23] <zyga-solus> mvo: for the cgroup issue?
[18:23] <mvo> zyga-solus: yeah
[18:23] <zyga-solus> mvo: no, that's not enough
[18:24] <zyga-solus> mvo: you also need the packaging changes to make us setgid root
[18:24] <zyga-solus> mvo: and some assorted code that jdstrand described above
[18:25] <mvo> zyga-solus: aha, ok
[18:25] <mvo> zyga-solus: I keep an eye on it (but not now :/
[18:26] <zyga-solus> mvo: are you EOD?
[18:28] <mvo> zyga-solus: well, sort of, I can be around in ~2h again or so
[18:28] <mvo> zyga-solus: or 1.5h
[18:28] <zyga-solus> mvo: no worries, I just beg for code reviews :)
[18:32] <magicaltrout> alright folks, stupid question cause i've not built anything in a while
[18:32] <magicaltrout> if i use a plugin, like ant. Can I run a command to copy a file before running the build?
[18:33] <nacc> magicaltrout: see the prepare scriptlet
[18:33] <magicaltrout> ah thats the word that had escaped me!
[18:44] <mup> PR snapcraft#1741 opened: TESTING: adt on lxc requires squashfuse <Created by kyrofa> <https://github.com/snapcore/snapcraft/pull/1741>
[18:52] <kyrofa> ogra_, you around
[18:52] <kyrofa> ?
[19:10] <elopio> kyrofa: sergiusens: The massive diff looks good to me. You can review while the tests run.
[19:14] <zyga-solus> koza: thank you!
[19:21] <zyga-solus> jdstrand: thank you, I'll address those items immediately
[20:03] <sergiusens> elopio 2.35 is in beta; test away and tell me when to promote to candidate (so you can make the cft)
[20:04] <elopio> sergiusens will start after lunch.
[20:07] <mup> PR snapd#4236 closed: many: reject bad plugs/slots 2.29 <Created by stolowski> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/4236>
[20:31] <mup> PR snapd#4238 opened: interfaces/browser-support: adjust base declaration for auto-connection <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4238>
[21:07]  * kyrofa runs some errands, back later
[21:14] <pedronis> jdstrand: thanks for #4238, I pushed a test there too
[21:14] <mup> PR #4238: interfaces/browser-support: adjust base declaration for auto-connection <Created by jdstrand> <https://github.com/snapcore/snapd/pull/4238>
[21:17] <mup> PR snapd#4234 closed: snap: use field names when initializing composite literals <Created by bboozzoo> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4234>
[21:39] <jdstrand> pedronis: thanks!
[21:43] <jdstrand> roadmr: hi! can you pull in r943 of the review tools. no rush
[21:46] <mwhudson> er does snapcraft's python plugin look at requirements.txt files?
[21:47] <ikey> soo did we figure out some kind of rules to make up to apply to base snaps? :)
[21:47]  * ikey isn't tryna rush stuff but would love to spread social medias :p
[21:48] <nacc> mwhudson: i think so?
[21:48] <nacc> mwhudson: oh wait, you tell it to (requirements: requirements.txt)
[21:48] <mwhudson> nacc: yeah i just found that bit
[21:48] <nacc> mwhudson: the help doesn't indicate it has any default value, so i guess it must be specified to use it
[21:49]  * mwhudson tries that
[21:49] <nacc> mwhudson: i use it to build gbp in my snap
[21:55] <zyga-solus> cachio: you missed one const
[21:55] <zyga-solus> cachio: look at my comments please
[21:56] <cachio> zyga-solus, ouch
[21:56] <zyga-solus> cachio: added one more comment and reading the rest
[21:56] <cachio> zyga-solus, looking
[22:00] <mwhudson> ha no i get two versions of pyudev in my snap
[22:00] <mwhudson> (Well priming fails)
[22:01] <zyga-solus> cachio: done
[22:01] <zyga-solus> cachio: tweak a few things and merge, approved
[22:01] <cachio> zyga-solus, tx
[22:02] <zyga-solus> cachio: thanks :)
[22:05] <sergiusens> elopio something s wrong with snapcraft#1638
[22:05] <mup> PR snapcraft#1638:  tests: reorganize unit and integration suites to make them easier to split for travis <Created by elopio> <https://github.com/snapcore/snapcraft/pull/1638>
[22:06] <mup> PR snapcraft#1741 closed: TESTING: adt on lxc requires squashfuse <Created by kyrofa> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/1741>
[22:07] <roadmr> jdstrand: hi! sorry for the delay. r943 of tools coming up
[22:14] <sergiusens> kyrofa have you reviewed that ^?
[22:15] <jdstrand> roadmr: thanks!
[22:18] <ikey> any answer to my Q?
[22:20] <sergiusens> ikey what Q? rules for base snaps? I guess that would involve jdstrand and other specific folks
[22:21] <ikey> i asked yesterday and got no response, thought id check in and see where we're at
[22:21] <ikey> otherwise its kinda a waste of time for me to be uploading snaps
[22:22] <ikey> i.e. ill save doing the uploads until i know its working
[22:22] <ikey> save triggering the system :p
[22:23] <zyga-solus> ikey: I do think that's jdstrand, just be patient please
[22:23]  * ikey just had to be awkward and use the new shiny
[22:23] <ikey> zyga-solus, im being patient - id just like communication
[22:23] <ikey> and ive asked here for 2 days without being acknowledged
[22:23] <ikey> i dont care how long it takes i just dont like talking into the void
[22:23] <ikey> as i have to juggle my own work and time
[22:23] <zyga-solus> ikey: I think you asked on the forum and there was a response there, no?
[22:24] <nacc> are base snaps that close to existing?
[22:24] <ikey> they exist-ish
[22:24] <ikey> as in i have one
[22:24] <nacc> heh
[22:24] <nacc> right, i have followed what you've been doing, ikey  (here)
[22:24] <ikey> zyga-solus, even if i get told that ill be emailed or something when a decision is made, thats fine
[22:25] <ikey> i just dislike limbo - then i can plan to put off all LSI work for now :P
[22:26] <zyga-solus> ikey: I understand, I'll try to get you a response quickly
[22:26] <mcphail> ikey: we're loving your work, but you need to change that name - https://www.youtube.com/watch?v=Yvpbm37OLiU
[22:26] <ikey> no no - thats not what im tryna accomplish :P im not tryna hurry things up i just wanna know that there is process, and whether i need to check up, or ill be told, etc
[22:27]  * ikey blinks at video
[22:27] <ikey> o.
[22:27] <ikey> tbf i mean thats basically the topic of any FPS discord mcphail
[22:27] <ikey> so it *kinda fits* ? >_>
[22:28] <mcphail> kinda ;)
[22:28]  * ikey renames it boney m just to be ambiguous altogether
[23:03] <mup> PR snapd#4169 closed: cmd/snap-update-ns: add secureMkfileAll <Created by zyga> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4169>
[23:03] <zyga-solus> jdstrand, pedronis: https://travis-ci.org/snapcore/snapd/builds/303226031?utm_source=github_status&utm_medium=notification
[23:24] <mup> PR snapd#4222 closed: tests: add new `fakestore new-snap-{declaration,revision}` helpers <Created by mvo5> <Merged by zyga> <https://github.com/snapcore/snapd/pull/4222>
[23:43] <mwhudson> ah haha you can work around the "cleanbuild always uses xenial" thing by creating a container with the right name ahead of time and then using SNAPCRAFT_CONTAINER_BUILDS=1 :-)
[23:44] <zyga-solus> cachio: one more comment on https://github.com/snapcore/snapd/pull/4171/files
[23:44] <mup> PR #4171: tests: adding test to test physical memory observe interface <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/4171>