/srv/irclogs.ubuntu.com/2017/11/17/#juju-dev.txt

* thumper goes to find lunch00:18
hmlwallyworld: i’m having a brain fart on testing the storageprovisioner panic fix…. what new to add01:34
wallyworldhml: oh i didn't realise you were looking at it01:35
hmlwallyworld: :-) i can leave the test for someone else…01:35
wallyworldhml: you could do that. the test would be to add storage and detach it, but the specifics i cannot say of the top of my head01:36
hmlwallyworld: perhaps I should leave for someone more knowledgable here?01:37
hmlthe unit tests didn’t catch it01:37
wallyworldyeah that would be fine01:37
wallyworldit's EOD for you01:37
hmlokay - good night01:38
wallyworldaxw: for later when you get to it, the 2nd PR is against the first branch https://github.com/wallyworld/juju/pull/4502:45
axwwallyworld: https://github.com/juju/juju/pull/8098 addresses the panic. I've not been able to figure out what caused us to get into this state yet06:13
axwprobably going to have to get more details out of IS06:13
axinohml: pong06:31
=== frankban|afk is now known as frankban
wallyworldaxw: looking08:09
wallyworldaxw: 8081 is proosed against develp and not the feature branhc?10:46
axwwallyworld: doh, thanks11:03
axwwallyworld: it also includes the peergrouper changes, so if you do review, ignore the first two commits11:04
wallyworldwpk: i need to land a small upgrade-juju patch for the rc1 release. can you review for me? https://github.com/juju/juju/pull/810213:22
wpklooking...13:23
wallyworldawesome ty13:23
wallyworldthe code in that area is messy to say the least13:24
wallyworldit might not be obvious what was done and why13:24
wpkI'd change 'uploadVersion' fn name to something less 'this function uploads sth'-suggesting13:32
wpkOther than that - LGTM13:36
wallyworldwpk: tyvm13:40
wallyworldwpk: i changed the func name. i realised i started the merge but you haven't hit approve yet13:47
wpkapproved officially13:49
balloonslast bug eh wallyworld?13:50
wallyworldballoons: yeah. i really wanted to fix upgrades13:50
balloonsthat one was a doozy13:50
wallyworldi *think* it all works much better now13:50
wallyworldthe main thing is you can upgrade to release straight off develop13:51
wpkmerge check failed btw13:51
wallyworldbut you do need to set agent-stream=devel to see the betas etc13:51
wallyworldyeah, repo error13:52
wallyworldactually landing appears to be going13:52
balloonsgodeps failed in the check merge oddly13:53
wpkapparently google is messing with their repos13:53
wpkwpk@minnie:~/dev/src$ go get google.golang.org/api13:54
wpk# cd .; git clone https://code.googlesource.com/google-api-go-client /home/wpk/dev/src/google.golang.org/api13:54
wpkCloning into '/home/wpk/dev/src/google.golang.org/api'...13:54
wpkfatal: remote error: Git repository not found13:54
wpkpackage google.golang.org/api: exit status 12813:54
balloonswallyworld, you want to land axw's 2 pr's as well?13:54
wallyworldballoons: nah, they are for feature branch13:54
=== petevg is now known as petevg_afk
wallyworldwe will land the entire branch after we fork13:55
balloonsahh, i see now13:55
wallyworldballoons: so now we wait on CI. i'm hoping that with these fixes from em and xtian and the official build stuff, things will be a lot better14:06
balloonswallyworld, did the edge snap work out like you expected?14:06
wallyworldballoons: i didn't test the snap - ran out of time :-(14:07
balloonsahh, no worries14:07
wallyworldall my testing has been with local juju builds14:07
wallyworldbut it should all be the same14:07
wallyworldballoons: just tested the edge snap - official version appears to work!14:12
balloonsgood, i just wanted your input that it looks good to you as well :)14:13
balloonsso we'll ship with your patch14:13
balloonserr, your last pr i mean14:13
wallyworldthat would be good14:13
wallyworldfewer upgrade complaints14:14
balloonswell, it's a big deal and needs vetted14:14
balloonswpk, https://github.com/juju/juju/pull/810315:09
balloonscan you ack?15:09
=== frankban is now known as frankban|afk

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!