[00:18]  * thumper goes to find lunch
[01:34] <hml> wallyworld: i’m having a brain fart on testing the storageprovisioner panic fix…. what new to add
[01:35] <wallyworld> hml: oh i didn't realise you were looking at it
[01:35] <hml> wallyworld: :-) i can leave the test for someone else…
[01:36] <wallyworld> hml: you could do that. the test would be to add storage and detach it, but the specifics i cannot say of the top of my head
[01:37] <hml> wallyworld: perhaps I should leave for someone more knowledgable here?
[01:37] <hml> the unit tests didn’t catch it
[01:37] <wallyworld> yeah that would be fine
[01:37] <wallyworld> it's EOD for you
[01:38] <hml> okay - good night
[02:45] <wallyworld> axw: for later when you get to it, the 2nd PR is against the first branch https://github.com/wallyworld/juju/pull/45
[06:13] <axw> wallyworld: https://github.com/juju/juju/pull/8098 addresses the panic. I've not been able to figure out what caused us to get into this state yet
[06:13] <axw> probably going to have to get more details out of IS
[06:31] <axino> hml: pong
[08:09] <wallyworld> axw: looking
[10:46] <wallyworld> axw: 8081 is proosed against develp and not the feature branhc?
[11:03] <axw> wallyworld: doh, thanks
[11:04] <axw> wallyworld: it also includes the peergrouper changes, so if you do review, ignore the first two commits
[13:22] <wallyworld> wpk: i need to land a small upgrade-juju patch for the rc1 release. can you review for me? https://github.com/juju/juju/pull/8102
[13:23] <wpk> looking...
[13:23] <wallyworld> awesome ty
[13:24] <wallyworld> the code in that area is messy to say the least
[13:24] <wallyworld> it might not be obvious what was done and why
[13:32] <wpk> I'd change 'uploadVersion' fn name to something less 'this function uploads sth'-suggesting
[13:36] <wpk> Other than that - LGTM
[13:40] <wallyworld> wpk: tyvm
[13:47] <wallyworld> wpk: i changed the func name. i realised i started the merge but you haven't hit approve yet
[13:49] <wpk> approved officially
[13:50] <balloons> last bug eh wallyworld?
[13:50] <wallyworld> balloons: yeah. i really wanted to fix upgrades
[13:50] <balloons> that one was a doozy
[13:50] <wallyworld> i *think* it all works much better now
[13:51] <wallyworld> the main thing is you can upgrade to release straight off develop
[13:51] <wpk> merge check failed btw
[13:51] <wallyworld> but you do need to set agent-stream=devel to see the betas etc
[13:52] <wallyworld> yeah, repo error
[13:52] <wallyworld> actually landing appears to be going
[13:53] <balloons> godeps failed in the check merge oddly
[13:53] <wpk> apparently google is messing with their repos
[13:54] <wpk> wpk@minnie:~/dev/src$ go get google.golang.org/api
[13:54] <wpk> # cd .; git clone https://code.googlesource.com/google-api-go-client /home/wpk/dev/src/google.golang.org/api
[13:54] <wpk> Cloning into '/home/wpk/dev/src/google.golang.org/api'...
[13:54] <wpk> fatal: remote error: Git repository not found
[13:54] <wpk> package google.golang.org/api: exit status 128
[13:54] <balloons> wallyworld, you want to land axw's 2 pr's as well?
[13:54] <wallyworld> balloons: nah, they are for feature branch
[13:55] <wallyworld> we will land the entire branch after we fork
[13:55] <balloons> ahh, i see now
[14:06] <wallyworld> balloons: so now we wait on CI. i'm hoping that with these fixes from em and xtian and the official build stuff, things will be a lot better
[14:06] <balloons> wallyworld, did the edge snap work out like you expected?
[14:07] <wallyworld> balloons: i didn't test the snap - ran out of time :-(
[14:07] <balloons> ahh, no worries
[14:07] <wallyworld> all my testing has been with local juju builds
[14:07] <wallyworld> but it should all be the same
[14:12] <wallyworld> balloons: just tested the edge snap - official version appears to work!
[14:13] <balloons> good, i just wanted your input that it looks good to you as well :)
[14:13] <balloons> so we'll ship with your patch
[14:13] <balloons> err, your last pr i mean
[14:13] <wallyworld> that would be good
[14:14] <wallyworld> fewer upgrade complaints
[14:14] <balloons> well, it's a big deal and needs vetted
[15:09] <balloons> wpk, https://github.com/juju/juju/pull/8103
[15:09] <balloons> can you ack?