[00:18] * thumper goes to find lunch [01:34] wallyworld: i’m having a brain fart on testing the storageprovisioner panic fix…. what new to add [01:35] hml: oh i didn't realise you were looking at it [01:35] wallyworld: :-) i can leave the test for someone else… [01:36] hml: you could do that. the test would be to add storage and detach it, but the specifics i cannot say of the top of my head [01:37] wallyworld: perhaps I should leave for someone more knowledgable here? [01:37] the unit tests didn’t catch it [01:37] yeah that would be fine [01:37] it's EOD for you [01:38] okay - good night [02:45] axw: for later when you get to it, the 2nd PR is against the first branch https://github.com/wallyworld/juju/pull/45 [06:13] wallyworld: https://github.com/juju/juju/pull/8098 addresses the panic. I've not been able to figure out what caused us to get into this state yet [06:13] probably going to have to get more details out of IS [06:31] hml: pong === frankban|afk is now known as frankban [08:09] axw: looking [10:46] axw: 8081 is proosed against develp and not the feature branhc? [11:03] wallyworld: doh, thanks [11:04] wallyworld: it also includes the peergrouper changes, so if you do review, ignore the first two commits [13:22] wpk: i need to land a small upgrade-juju patch for the rc1 release. can you review for me? https://github.com/juju/juju/pull/8102 [13:23] looking... [13:23] awesome ty [13:24] the code in that area is messy to say the least [13:24] it might not be obvious what was done and why [13:32] I'd change 'uploadVersion' fn name to something less 'this function uploads sth'-suggesting [13:36] Other than that - LGTM [13:40] wpk: tyvm [13:47] wpk: i changed the func name. i realised i started the merge but you haven't hit approve yet [13:49] approved officially [13:50] last bug eh wallyworld? [13:50] balloons: yeah. i really wanted to fix upgrades [13:50] that one was a doozy [13:50] i *think* it all works much better now [13:51] the main thing is you can upgrade to release straight off develop [13:51] merge check failed btw [13:51] but you do need to set agent-stream=devel to see the betas etc [13:52] yeah, repo error [13:52] actually landing appears to be going [13:53] godeps failed in the check merge oddly [13:53] apparently google is messing with their repos [13:54] wpk@minnie:~/dev/src$ go get google.golang.org/api [13:54] # cd .; git clone https://code.googlesource.com/google-api-go-client /home/wpk/dev/src/google.golang.org/api [13:54] Cloning into '/home/wpk/dev/src/google.golang.org/api'... [13:54] fatal: remote error: Git repository not found [13:54] package google.golang.org/api: exit status 128 [13:54] wallyworld, you want to land axw's 2 pr's as well? [13:54] balloons: nah, they are for feature branch === petevg is now known as petevg_afk [13:55] we will land the entire branch after we fork [13:55] ahh, i see now [14:06] balloons: so now we wait on CI. i'm hoping that with these fixes from em and xtian and the official build stuff, things will be a lot better [14:06] wallyworld, did the edge snap work out like you expected? [14:07] balloons: i didn't test the snap - ran out of time :-( [14:07] ahh, no worries [14:07] all my testing has been with local juju builds [14:07] but it should all be the same [14:12] balloons: just tested the edge snap - official version appears to work! [14:13] good, i just wanted your input that it looks good to you as well :) [14:13] so we'll ship with your patch [14:13] err, your last pr i mean [14:13] that would be good [14:14] fewer upgrade complaints [14:14] well, it's a big deal and needs vetted [15:09] wpk, https://github.com/juju/juju/pull/8103 [15:09] can you ack? === frankban is now known as frankban|afk