| cjwatson | tsimonq2: The method implementation in lp.bugs.model.cve needs to have the same name as its corresponding interface declaration in lp.bugs.interfaces.cve. | 10:27 |
|---|---|---|
| cjwatson | tsimonq2: Also have generally the same signature. Actually I'm a bit confused about what method you're trying to add. | 10:28 |
| cjwatson | tsimonq2: If you've added an interface declaration to lp.bugs.interfaces.cve, then the implementation of that method would go in the corresponding class in lp.bugs.model.cve. Its signature should normally be the same as that in interfaces with the addition of an initial "self" argument (it's also permissible for it to have extra private keyword arguments that aren't mentioned in the interface). | 10:33 |
| cjwatson | tsimonq2: Have a think about whether you should just be exporting the existing CveSet.new instead (possibly with different default behaviour for the API) rather than adding a confusingly-similar CveSet.add. | 10:34 |
| cjwatson | tsimonq2: Or perhaps "newPlaceholder" or something like that? | 10:36 |
| tsimonq2 | cjwatson: Sure, I'll think more about it, thanks. | 17:14 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!