=== shardy is now known as shardy_lunch | ||
=== shardy_lunch is now known as shardy | ||
smoser | blackboxsw: i found the artful issue. | 16:54 |
---|---|---|
smoser | smoser error | 16:54 |
smoser | i had made one fix to yours, and i think i must have accidently/ignorantly un-done the merge commit | 16:55 |
blackboxsw | smoser: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/334051 | 16:55 |
smoser | when i added 1a252d46cc6739bc501fc06bde0b5e25e803266b | 16:56 |
blackboxsw | ahh oops | 16:56 |
blackboxsw | looking | 16:56 |
blackboxsw | first rule of cloud-init-club is: "smoser doesn't make errors" | 16:56 |
blackboxsw | wait that's 2nd rule. First rule is "there is no cloud-init-club" | 16:57 |
blackboxsw | smoser: by "undone the merge commit" you mean like a rebase -i HEAD~2 and a 'fixup' which squashed the merge-commit or something? | 16:58 |
smoser | eithe rthat ir o thik i might have just reset --hard HEA^ | 17:03 |
smoser | i'im not sure. | 17:03 |
smoser | upstream now has ubuntu/17.1-27-geb292c18-0ubuntu1_17.10.1 correctly | 17:03 |
smoser | and merge-base shows the same for artful and xenial and zesty | 17:03 |
smoser | blackboxsw: you did not strip the bug numbers from the changelog | 17:04 |
smoser | i guess we have 2 options. | 17:04 |
smoser | a.) megabug route | 17:05 |
smoser | b.) individual bugs | 17:05 |
blackboxsw | oops quick touch one min | 17:05 |
blackboxsw | hrm | 17:05 |
blackboxsw | let's do megabug, I like one bug to point people at | 17:05 |
smoser | either way, we were dropping the non-ubuntu bugs (sles ones are in there) | 17:05 |
blackboxsw | I'll create a bug | 17:05 |
smoser | and gentoo | 17:05 |
blackboxsw | +12 | 17:05 |
blackboxsw | +2 | 17:05 |
yeazelm | I need a little help with the CI for my PR | 17:06 |
yeazelm | https://code.launchpad.net/~yeazelm/cloud-init/+git/cloud-init/+merge/331897 - I'm not sure what to do about FAILED: Ubuntu LTS: Integration | 17:07 |
blackboxsw | https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1733653 filed | 17:09 |
ubot5 | Launchpad bug 1733653 in cloud-init (Ubuntu) "sru cloud-init (17.1-27-geb292c18) update to (17.1-42-gbbe91cdc)" [Undecided,New] | 17:09 |
blackboxsw | yeazelm: looking | 17:10 |
blackboxsw | looks like may have had a slave failure installing the testable deb http://pastebin.ubuntu.com/26013415/ | 17:12 |
blackboxsw | I'll re-run your tests yeazelm | 17:12 |
blackboxsw | if that's not it I'll look locally at the prob | 17:12 |
yeazelm | awesome thanks! | 17:17 |
blackboxsw | np yeazelm thank you | 17:19 |
blackboxsw | smoser: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/334063 for you | 17:19 |
blackboxsw | xenial with just the SRU bug and debian packaging bug | 17:20 |
blackboxsw | smoser, and I pulled in mccabe's should I leave that out | 17:20 |
blackboxsw | ? | 17:20 |
smoser | blackboxsw: you can just leave it out | 17:26 |
blackboxsw | smoser: will leave it out to match bionic | 17:27 |
smoser | new-upstream-snapshot HEAD^ | 17:27 |
smoser | er... | 17:27 |
smoser | you get the point | 17:27 |
smoser | youcan give it anything just give it the commit that went into bionic. then easier. | 17:27 |
blackboxsw | smoser: good deal. repushed zesty https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/334065 | 17:31 |
blackboxsw | using SRU megabug | 17:31 |
blackboxsw | and fixing names, dropping bugs | 17:31 |
blackboxsw | xenial up https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/334066 | 17:37 |
blackboxsw | I thought I saw a CI failure fly by on zesty. | 17:37 |
blackboxsw | checking | 17:37 |
blackboxsw | tox locally wfm | 17:37 |
smoser | blackboxsw: i was wrong about not collecting consoel logs | 17:39 |
smoser | we do get them | 17:39 |
smoser | https://jenkins.ubuntu.com/server/view/cloud-init/job/cloud-init-integration-x/377/artifact/cloud-init/results/lxd/xenial/modules/apt_configure_conf/ | 17:39 |
smoser | i think that i saw them fail in -proposed, which is missing my cleanup commit that added those. | 17:40 |
smoser | blackboxsw: https://jenkins.ubuntu.com/server/job/cloud-init-ci/530/console | 17:53 |
smoser | oh shoot. | 17:53 |
blackboxsw | smoser: so cherry-pick needed me to touch it? | 17:54 |
blackboxsw | to avoid patch fuzz? | 17:54 |
blackboxsw | Reversed (or previously applied) patch detected! Skipping patch. | 17:54 |
smoser | yeah | 17:54 |
smoser | hm.. | 17:54 |
smoser | so ... what happened here. | 17:55 |
blackboxsw | ahh oops | 17:55 |
smoser | hm.. | 17:55 |
smoser | you used 'git cherry-pick 1110f30ee9b4703a3c66fc678c0df3f0862cc7eb' ? | 17:55 |
blackboxsw | ./debian/cherry-pick 1110f30ee9b4703a3c66fc678c0df3f0862cc7eb | 17:55 |
smoser | or './debian/cherry-pick' | 17:55 |
smoser | yeah, you want he former | 17:55 |
smoser | it is confusing. sorry. | 17:55 |
blackboxsw | bummer. | 17:55 |
blackboxsw | ok recreating | 17:56 |
smoser | ./debian/cherry-pick takes an upstream commit and applies it via patches/debian/cpick-XXX-XXX to an ubuntu branch | 17:56 |
blackboxsw | my bad | 17:56 |
smoser | but we manage the ubuntu branches directly with git | 17:56 |
smoser | that difference make sense ? | 17:56 |
smoser | and when you do 'cherry-pick 1110f30ee9b4' use '-x' | 17:57 |
smoser | (which i just nwo learned about). so we have a record in the commit, even though its probably obvious | 17:57 |
blackboxsw | smoser: so why do we want cpick files then? | 17:59 |
blackboxsw | only when we don't manage the branches directly? | 17:59 |
blackboxsw | smoser: also when I git cherry-pick, it doesn't add anything to the changelog. | 18:00 |
blackboxsw | so I should add that back in right? | 18:00 |
smoser | blackboxsw: ...writing something, and then i'll update https://gist.github.com/smoser/6391b854e6a80475aac473bba4ef0310#file-ubuntu-release-process-md | 18:00 |
smoser | https://hackmd.io/IwYwRgzALAZjDsBaEwCsBORUAMA2AHIvsPIWOsNgCb4Cmp+E+QA= | 18:01 |
blackboxsw | smoser I'm working on adding test/skip references for trello for this SRU | 18:12 |
blackboxsw | https://hackmd.io/BwUwrAhgRg7ADFAtMCBOJAWCDHQGwyIBmcAJqiBnhiAExRRA?both | 18:12 |
* smoser feels like he should hit the 'buy us coffee' button for hackio.md | 18:17 | |
blackboxsw | yeah I was thinking the same thing. $5 latte here you come (Thanksgiving and all) | 18:20 |
blackboxsw | ✔thanks hackmd | 18:22 |
smoser | blackboxsw: ^ is updated now. should hopefully make some sense. | 18:34 |
smoser | ugh. going to figure out why https://jenkins.ubuntu.com/server/job/cloud-init-ci/531/console | 18:39 |
blackboxsw | thx smoser | 18:40 |
powersj | I have a hunch it is because the version in the container is newer than the package you are trying to install | 18:55 |
blackboxsw | thanks for the gist update smoser | 18:57 |
shewless | hello there. does anyone know if I can use the phone_home module to call multiple urls? | 18:58 |
blackboxsw | xenial, zesty and artful sru review pushed https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/334072, https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/334071 and https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/334070 | 18:59 |
smoser | blackboxsw: grabbing | 19:01 |
blackboxsw | shewless: doesn't look like the module supports it. I wonder if you could either provide multiple mime type /cloud-config text/cloud-config parts. per http://cloudinit.readthedocs.io/en/latest/topics/format.html?highlight=include | 19:01 |
blackboxsw | but I'm thinking the merge of all those cloud-init parts would actually just give you whatever cc_phone_home section was defined last.. | 19:02 |
shewless | blackboxsw: thanks for confirming | 19:03 |
shewless | maybe you can help a different way | 19:04 |
blackboxsw | hmm shewless shortly we'll have the ability to run "cloud-init status --wait" in scripts and your script your provide could do whatever you want | 19:04 |
shewless | I want to run a command, like in "runcmd" but I want to do it in the cloud_final_modules stage.. any hints? | 19:04 |
blackboxsw | shewless: per https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/333513 (the status subcommand I referenced) | 19:04 |
shewless | blackboxsw: looks cool.. I think I was trying to do too much in the phone_home module perhaps | 19:05 |
blackboxsw | shewless: http://cloudinit.readthedocs.io/en/latest/topics/boot.html?highlight=stages | 19:06 |
blackboxsw | runcmd is run during final cloud-init stage | 19:06 |
blackboxsw | if that helps. it's when every other module has run | 19:06 |
blackboxsw | *has finished running rather | 19:06 |
blackboxsw | same with any provided user-scripts you provide | 19:07 |
blackboxsw | it's run during final cloud-init stage | 19:07 |
shewless | blackboxsw: thanks! | 19:08 |
blackboxsw | np (and another link to continue spamming you :) ) http://cloudinit.readthedocs.io/en/latest/topics/format.html#user-data-script | 19:09 |
shewless | blackboxsw: thank link confused me. The user-data can be code? | 19:10 |
blackboxsw | shewless: yeah you can actually provide any script to cloud init that starts with #! | 19:14 |
blackboxsw | and cloud-init writes that script to a file that is run in final stages | 19:14 |
blackboxsw | write_files: is another alternative that lets you be more explicit about where you want your script written (and how you want to call it using runcmd:) | 19:15 |
blackboxsw | I'm probably providing too many alternatives. sorry to confuse | 19:15 |
shewless | blackboxsw: mind explodes.. but thanks I'm good for now | 19:17 |
blackboxsw | hehe, turkey will help if you are US based | 19:19 |
shewless | nope.. had my thanksgiving in Oct | 19:26 |
shewless | maybe a good black friday deal will help :P | 19:26 |
smoser | shewless: feel free to buy me things too. i like stuff. | 19:29 |
shewless | don't we all | 19:31 |
smoser | blackboxsw or powersj https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/334074 | 19:36 |
powersj | smoser: thx +1'ed | 19:39 |
smoser | ok. i'll wait on ci to happy on nit and then pull | 19:41 |
smoser | blackboxsw: https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/334065 . in your changelog, i think i'd drop the 'cherry-pick 1110f30:' | 19:45 |
smoser | since its not an upstream change that we're cherry-picking. | 19:45 |
smoser | i can fix that here. | 19:45 |
blackboxsw | smoser: ahh ok gotcha smoser | 19:48 |
blackboxsw | smoser: tests/cloud_tests/setup_image.py:63:9: E123 closing bracket does not match indentation of opening bracket's line | 19:49 |
blackboxsw | on your test branch | 19:49 |
smoser | ah. thanks. | 19:50 |
smoser | blackboxsw: uploaded | 20:13 |
smoser | we need a sru template for https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1728186 | 20:13 |
ubot5 | Launchpad bug 1728186 in cloud-init (Ubuntu Artful) "AliYun datasource has wrong case in config" [Medium,In progress] | 20:13 |
smoser | and update to the megabug bug 1733653 | 20:13 |
ubot5 | bug 1733653 in cloud-init (Ubuntu Artful) "sru cloud-init (17.1-27-geb292c18) update to (17.1-42-gbbe91cdc)" [Medium,In progress] https://launchpad.net/bugs/1733653 | 20:13 |
smoser | bugger. | 20:17 |
smoser | that really sucks | 20:23 |
smoser | so the hold and apt-get install works if the package is older than the one available | 20:23 |
smoser | but if it is newer, then it fails like in https://jenkins.ubuntu.com/server/job/cloud-init-ci/536/console | 20:23 |
blackboxsw | Smoser will do | 20:27 |
blackboxsw | Also I'm thinking we need to automatically add nominations for the Ubuntu related bugs for the xenial,zesty and artful | 20:29 |
smoser | blackboxsw: well, we can do that, yes. that ws the extra tracking that we've talked aobut. | 20:31 |
blackboxsw | yeah I'll just take care of it later (when the SRU lands) | 20:43 |
blackboxsw | as an accounting step | 20:43 |
smoser | blackboxsw: unless you object shortly... | 21:26 |
smoser | https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/334074 | 21:26 |
smoser | gonna pull that. | 21:26 |
blackboxsw | nice smoser was that a recommendation from ubuntu-devel? | 21:50 |
blackboxsw | testing the cmdline now | 21:50 |
blackboxsw | though already merged | 21:50 |
blackboxsw | smoser: sru template written https://bugs.launchpad.net/ubuntu/artful/+source/cloud-init/+bug/1733653 | 22:04 |
ubot5 | Launchpad bug 1733653 in cloud-init (Ubuntu Artful) "sru cloud-init (17.1-27-geb292c18) update to (17.1-42-gbbe91cdc)" [Medium,In progress] | 22:04 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!